linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>
To: Rik van Riel <riel@redhat.com>
Cc: Johannes Weiner <hannes@saeurebad.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nick Piggin <npiggin@suse.de>,
	Linux MM Mailing List <linux-mm@kvack.org>
Subject: Re: [patch] mm: more likely reclaim MADV_SEQUENTIAL mappings II
Date: Sat, 25 Oct 2008 03:59:27 +0900	[thread overview]
Message-ID: <2f11576a0810241159i677f67a0x7dce373bee7cd1d6@mail.gmail.com> (raw)
In-Reply-To: <4901DC5E.5040908@redhat.com>

>>> Well, time-wise not sooo much of an improvement.  But given the
>>> massively decreased LRU-rotation [ http://hannes.saeurebad.de/madvseq/ ]
>>
>> My first impression, this result mean the patch is not so useful.
>> But anyway, I mesured it again because I think Nick's opinion is very
>> reasonable and I don't know your mesurement condition so detail.
>
> It may not make much of a difference if the MADV_SEQUENTIAL
> program is the only thing running on the system.
>
> However, the goal of MADV_SEQUENTIAL is to make sure that a
> streaming mapping does not kick the data from other programs
> out of memory.  The patch should take care of that very well.


Well, my second test(following) indicate it IMO.

> 2. MADV_SEQUENTIAL vs dbench
>
>                        mmotm1022   + the patch
>  ==============================================================
>  mm_sync_madv_cp       6:29        6:19           (min:sec)
>  dbench throughput     11.633      14.4045        (MB/s)
>  dbench latency        65628       18565          (ms)


So, I think the code of this patch is good, but I guess his mesurement
way isn't so good.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-10-24 18:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21 10:32 [rfc] mm: more likely reclaim MADV_SEQUENTIAL mappings Johannes Weiner
2008-10-21 10:43 ` Nick Piggin
2008-10-21 11:33   ` [patch] mm: more likely reclaim MADV_SEQUENTIAL mappings II Johannes Weiner
2008-10-21 22:13     ` Andrew Morton
2008-10-22  0:09       ` Johannes Weiner
2008-10-22  0:51         ` Johannes Weiner
2008-10-22  6:39           ` KOSAKI Motohiro
2008-10-22  7:15             ` Johannes Weiner
2008-10-22  7:41               ` Andrew Morton
2008-10-24  0:21     ` Johannes Weiner
2008-10-24 12:55       ` KOSAKI Motohiro
2008-10-24 14:02         ` Johannes Weiner
2008-10-24 14:31         ` Rik van Riel
2008-10-24 16:15           ` Johannes Weiner
2008-10-24 23:48             ` Johannes Weiner
2008-10-24 18:59           ` KOSAKI Motohiro [this message]
2008-10-21 14:40 ` [rfc] mm: more likely reclaim MADV_SEQUENTIAL mappings Rik van Riel
2008-10-21 15:20   ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f11576a0810241159i677f67a0x7dce373bee7cd1d6@mail.gmail.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@saeurebad.de \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox