From: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>
To: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] fix to putback_lru_page()/unevictable page handling rework v3
Date: Wed, 25 Jun 2008 02:35:51 +0900 [thread overview]
Message-ID: <2f11576a0806241035p45a440e1gb798091ef39cffc8@mail.gmail.com> (raw)
In-Reply-To: <1214327987.6563.22.camel@lts-notebook>
> 'lru' was not being set to 'UNEVICTABLE when page was, in fact,
> unevictable [really "nonreclaimable" :-)], so retry would never
> happen, and culled pages never counted.
>
> Also, redundant mem_cgroup_move_lists()--one with incorrect 'lru',
> in the case of unevictable pages--messes up memcontroller tracking [I think].
indeed.
sorry, I forgot to send this fix.
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
but I still happend panic on usex and nishimura-san's cpuset migration test.
-> http://marc.info/?l=linux-mm&m=121375647720110&w=2
I'll investigate it tommorow.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-24 17:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-21 10:00 [RFC][PATCH] " KOSAKI Motohiro
2008-06-24 2:43 ` KOSAKI Motohiro
2008-06-24 17:10 ` Lee Schermerhorn
2008-06-24 17:55 ` Andrew Morton
2008-06-24 19:11 ` Lee Schermerhorn
2008-06-24 19:19 ` Andrew Morton
2008-06-24 17:29 ` [PATCH] fix2 to " Lee Schermerhorn
2008-06-24 17:38 ` KOSAKI Motohiro
2008-06-24 9:49 ` [RFC][PATCH] " KOSAKI Motohiro
2008-06-24 9:59 ` KAMEZAWA Hiroyuki
2008-06-24 17:15 ` Lee Schermerhorn
2008-06-24 17:19 ` [PATCH] fix to " Lee Schermerhorn
2008-06-24 17:35 ` KOSAKI Motohiro [this message]
2008-06-24 17:48 ` Lee Schermerhorn
2008-06-24 18:19 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0806241035p45a440e1gb798091ef39cffc8@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox