From: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>
To: Rik van Riel <riel@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [-mm][PATCH 4/5] core of reclaim throttle
Date: Tue, 6 May 2008 10:01:26 +0900 [thread overview]
Message-ID: <2f11576a0805051801xf144478pb7b04799f148db29@mail.gmail.com> (raw)
In-Reply-To: <20080505204318.3f95c83c@bree.surriel.com>
> > hmmm, AFAIK,
> > on current kernel, sometimes __GFP_IO task wait for non __GFP_IO task
> > by lock_page().
> > Is this wrong?
>
> This is fine.
>
> The problem is adding a code path that causes non __GFP_IO tasks to
> wait on __GFP_IO tasks. Then you can have a deadlock.
Ah, OK.
I'll add __GFP_FS and __GFP_IO check at next post.
Thanks!
> > therefore my patch care only recursive reclaim situation.
> > I don't object to your opinion. but I hope understand exactly your opinion.
>
> I believe not all non __GFP_IO or non __GFP_FS calls are recursive
> reclaim, but there are some other code paths too. For example from
> fs/buffer.c
absolutely.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-06 1:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 12:53 [-mm][PATCH 0/5] mm: page reclaim throttle v6 KOSAKI Motohiro
2008-05-04 12:55 ` [-mm][PATCH 1/5] fix overflow problem of do_try_to_free_page() KOSAKI Motohiro
2008-05-05 8:12 ` Nishanth Aravamudan
2008-05-06 3:29 ` KOSAKI Motohiro
2008-05-04 12:57 ` [-mm][PATCH 2/5] introduce get_vm_event() KOSAKI Motohiro
2008-05-05 21:47 ` Rik van Riel
2008-05-04 12:58 ` [-mm][PATCH 3/5] change function prototype of shrink_zone() KOSAKI Motohiro
2008-05-05 4:42 ` minchan Kim
2008-05-05 8:31 ` KOSAKI Motohiro
2008-05-05 8:37 ` minchan Kim
2008-05-04 12:59 ` [-mm][PATCH 4/5] core of reclaim throttle KOSAKI Motohiro
2008-05-04 13:12 ` KOSAKI Motohiro
2008-05-05 5:21 ` minchan Kim
2008-05-05 8:24 ` KOSAKI Motohiro
2008-05-05 8:32 ` minchan Kim
2008-05-05 21:51 ` Rik van Riel
2008-05-05 22:23 ` KOSAKI Motohiro
2008-05-06 0:43 ` Rik van Riel
2008-05-06 1:01 ` KOSAKI Motohiro [this message]
2008-05-04 13:01 ` [-mm][PATCH 5/5] introduce sysctl parameter of max task of throttle KOSAKI Motohiro
2008-05-04 14:38 ` [-mm][PATCH 0/5] mm: page reclaim throttle v6 KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0805051801xf144478pb7b04799f148db29@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox