From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1B76C433C1 for ; Wed, 24 Mar 2021 22:16:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 34F8261A1B for ; Wed, 24 Mar 2021 22:16:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34F8261A1B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9FD488D0017; Wed, 24 Mar 2021 18:16:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D41D6B032F; Wed, 24 Mar 2021 18:16:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89CE68D0017; Wed, 24 Mar 2021 18:16:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id 7031D6B032E for ; Wed, 24 Mar 2021 18:16:23 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 385FE5010 for ; Wed, 24 Mar 2021 22:16:23 +0000 (UTC) X-FDA: 77956177446.28.E83E33F Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf12.hostedemail.com (Postfix) with ESMTP id E6BBAD5 for ; Wed, 24 Mar 2021 22:16:21 +0000 (UTC) Received: by mail-lf1-f44.google.com with SMTP id q29so34147446lfb.4 for ; Wed, 24 Mar 2021 15:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4D/l2+6KHDLLWR4B5U/x02N6vRyCwEwFRlTNp/wGF4o=; b=hAFDLHj6fjyaz0CpQe/wXAhQdPZckXiCaly/4AYL3Dkx1KVFOPLy4FRdE1mDiYCTpF yfW0W9jRDl2zTI22o9I5dHPuagw96xyQp+zTVWkBTytBNS8TQNXNgUlwQkoceqeQILVR P5ClI8+EZkN5tviNLnEJ4lhm6jQUfYpmKdKEBHQcl//djc6qPej2uFNG+nDsFxYWBW01 2fx5txdgB1E34M2U0XMCIk/Sc7BNqjD8OJXAaxkKlrp7ESUJTxAhgind5phCWk4veEow D3Syzgg0W914P2swEoOaKJ0LQ3DJABKOzBgG6sIXH+3575llrzivPjZTuK4sMTc6afgp XJPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4D/l2+6KHDLLWR4B5U/x02N6vRyCwEwFRlTNp/wGF4o=; b=VprsqjGEey6eHt8bJ7d/zGo/BNM379yh9qVVyEY//21ASF+jbah4NEUjWwET/NDYk7 KImGfoKLd04Q+Db4GbKp9exxrYCzdOfmM1jjfYDrhZ7kFEWb7IO+gsLn1nSUSyBEqTtW gPoSAEOP66oyXSOVaLGpRZ4RfEQmt+1WgHYmwU+KaLv824G6Heo9vT57uYmFi1PRU6Ch WXa8N61gSKvZaUp8W6GM8sbko3dI6bTdg3SmoQ3bOKvrj5ggzyDmIuISgcC9ScrQS+/E NksLGAbQS+0C7lCzmMGa+ZCBskOG9QXiZdIQ1q9WPrKGfjxLKv1Rr0n3kZr81MewP4DQ Q/Aw== X-Gm-Message-State: AOAM532h7nK6qIWk2EdloPKzlIVMdypfmPT9BERTgsqyaSSlavi4G6aA mPhyeVaHnrYanCb54xWrvWA= X-Google-Smtp-Source: ABdhPJyLzK+FeyTdpQAmnRkTno5Ed66uyJHebfewgpXrtWAANvZx9jXP99UStgJ5fgD9ElQQlC36lA== X-Received: by 2002:ac2:4ac1:: with SMTP id m1mr3192377lfp.446.1616624181470; Wed, 24 Mar 2021 15:16:21 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-60.dynamic.spd-mgts.ru. [109.252.193.60]) by smtp.googlemail.com with ESMTPSA id t5sm421099ljc.78.2021.03.24.15.16.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 15:16:21 -0700 (PDT) Subject: Re: [PATCH v7] mm: cma: support sysfs To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , gregkh@linuxfoundation.org, surenb@google.com, joaodias@google.com, jhubbard@nvidia.com, willy@infradead.org, Colin Ian King References: <20210324205503.2132082-1-minchan@kernel.org> <65840bfd-4471-7c8d-ce71-c4705baf3bfe@gmail.com> From: Dmitry Osipenko Message-ID: <2f0ef658-9848-b655-f7c0-fee6aadb9846@gmail.com> Date: Thu, 25 Mar 2021 01:16:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E6BBAD5 X-Stat-Signature: dfiewr7w71uy4cbwwwt5kuysxpn64gwm Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=mail-lf1-f44.google.com; client-ip=209.85.167.44 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616624181-150520 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 25.03.2021 00:55, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> +static ssize_t alloc_pages_success_show(struct kobject *kobj, >>> + struct kobj_attribute *attr, char *buf) >>> +{ >>> + struct cma *cma =3D cma_from_kobj(kobj); >>> + >>> + return sysfs_emit(buf, "%llu\n", >>> + atomic64_read(&cma->nr_pages_succeeded)); >> nit: Algnment isn't right, should be better to write it as single line= , IMO. > Let me make it align rather than single line since I know someone > who keep asking us to not overflow 80 columns unless it's special. >=20 I'm actually one of those guys who complains about 80 chars (where necessary), but in this particular case it only hurts readability of the code, IMO.