From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6912FC7EE2A for ; Wed, 25 Jun 2025 15:22:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DFC06B00CA; Wed, 25 Jun 2025 11:22:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 090476B00CB; Wed, 25 Jun 2025 11:22:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0F626B00CD; Wed, 25 Jun 2025 11:22:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E02EF6B00CA for ; Wed, 25 Jun 2025 11:22:53 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 885A3121643 for ; Wed, 25 Jun 2025 15:22:53 +0000 (UTC) X-FDA: 83594290626.18.8F74E1E Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by imf25.hostedemail.com (Postfix) with ESMTP id C48DBA0006 for ; Wed, 25 Jun 2025 15:22:51 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=hR345H7m; spf=pass (imf25.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.167.177 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750864971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=YJ/Oa+uu2JsEGmaISSGaGZVm+8P6nq5j1FNk2oy/d/k=; b=qIHjdOGe13F07e13P09Mdr8X6TNKMWy5ijQXuTA7kg/m5IRVL6kYGQfusXauUAH17KSfHu 3DF7xGHRxTAA+yePj0PevqTi3jsJe8yXKqz/sKF1OaRvm4UfNzzbhGaOw9VWRtLoMEH5ND pAqQyrqePmb3FsJSni8vk6URr0M60C8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=hR345H7m; spf=pass (imf25.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.167.177 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750864971; a=rsa-sha256; cv=none; b=Jp0GUwd/xKb2G12mVz+du/0RGpi+pXSkkdR6V0hxdb//mlsfrVe91V01HVAws3hFrV5UFa WljfrVMC2sY3q2VgiFxyjbafH9x7GaRz6G9lJkyPx5gnilFaLtWazRmKh4SAQZlnoVuDy3 LF0Y036Vwfzr/SdiKKeFCJm+kpCld8o= Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-40af40aeef6so14535b6e.3 for ; Wed, 25 Jun 2025 08:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750864971; x=1751469771; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=YJ/Oa+uu2JsEGmaISSGaGZVm+8P6nq5j1FNk2oy/d/k=; b=hR345H7mexP0mdLs5zFZRFxudqwrzhY4+juKZyGoBzlaFHeS9MVJj6zlMiFg3WcqHh 3KRzhnCTuWT/vGRCNK2bh4VL8QtwJpzbgNOyW4lGMT5I/rx3DI2OyIIMzGPRkCcdFRvA ek5gdrzl770Up1yMfvBz8/huYBrY/g2u/T/ucgRU6smTUPOqgdFDYHn5VguI9eR+ptHd 8oc0uD8xpx6QoptiAvC+pUoF+5R1Q/6aGfXaieO8+fqDz1+G7QXWbUe795ehRbkR9aS4 mrSbUI/3HLcvv4BlAKD9j9x6UxyWqsfshgVDEH9u8/mrFOXW+Ya+YHAdJnf5vuHpcR8M KQTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750864971; x=1751469771; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YJ/Oa+uu2JsEGmaISSGaGZVm+8P6nq5j1FNk2oy/d/k=; b=D6gyNfshwS/IP2hJntxQoOCn7jrc0renglwwtWkcECHkyRaVg3bkBVgI6TjxKjeiO3 oSqCA2RkLN7JW5itWOBRH2wN2dkZ2aNq35pQy4n7Oq4w+Af77d12po97r5OJZPtM3W0r xkj3tdmrGvZsebpUKiFjXU9W8VzYcADeOpAt0pGiBDLzkSE+RGhFI9ztB24x1ElbUD0w umG5/nWl2FmyxfHaSYQlCMfBd+ZnT5+R66S0EL1Ea7n0Yi9MLWiKmoeihPPDbdjaVeWI K9x7+0MSAInx56rTztgbHxtKXaIw+Rp7jX/63ePcLYuOEA3x5mxlQXIRGiNcX9slRMcd kaig== X-Gm-Message-State: AOJu0Ywr+jIgoluLlTw/uGKkruvMofMNYhcMe2tYvERHMjGu5ZXyme8U rbyrLZvS0A5uIKgR3xlN2rG9+AnmYithJ5YNqhlok/ymSLYFwVX2DDvwtrd3pFvnfUY= X-Gm-Gg: ASbGnctXLn2FcrMFq1Y0sCxFgKflwMPlZ7ZHjLue+IT71U5FfU5JwIZYXJ0ryAjA+4j oWa4yb7bmX1hIZsfY7apiQYRt3kb4YuL3/lFz0qGW2QiCv69ghy407kvCAQbxT8j51m+AKWSoI0 75tu6vQmsTtootidyVspIoJPtranoy6MB2d541wGSvuKfEunv21nUTHG09sOyaPeoETEHDwYKYb ooeHkiS3p1ZWw3sFxNRTUBZQE4zf29x61Vv3IP8u6kmGzekiDh06zuczk+7FghZQ78rZkWLPeZT Tixzh3idopOYFX2j6J2+54CSGpdWoxtBWLIObDEG2h4DoaKjd60aW6X/dCZXJw6IUip8dg== X-Google-Smtp-Source: AGHT+IE+iWtUGVGguip8po1VjXwiwEQs/BKrgwETwVvy1hsun8TaGAng5qgWLXswZnQuxKlLXqW2kw== X-Received: by 2002:a05:6808:10c2:b0:40a:5356:656d with SMTP id 5614622812f47-40b05a2588fmr3392934b6e.7.1750864970825; Wed, 25 Jun 2025 08:22:50 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:1fca:a60b:12ab:43a3]) by smtp.gmail.com with UTF8SMTPSA id 46e09a7af769-73a90b33a43sm2275553a34.29.2025.06.25.08.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 08:22:50 -0700 (PDT) Date: Wed, 25 Jun 2025 10:22:49 -0500 From: Dan Carpenter To: lorenzo.stoakes@oracle.com Cc: linux-mm@kvack.org Subject: [bug report] mm/mremap: complete refactor of move_vma() Message-ID: <2f035b94-ab84-427a-b8a0-5f0274e8b8b9@sabinyo.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C48DBA0006 X-Stat-Signature: axaaj3xikn5a781fwfqjh556dwtd9whg X-HE-Tag: 1750864971-237589 X-HE-Meta: U2FsdGVkX1+COXEdLiOSzrm37Z+KfLj1V0qrU9WNKfGzfuXk+f4nvztTicP+Wmi88/g+/ceCII1I/1waPYedzpWQVEGMH3R+9NmvT8zbQqDZUaN42y78xUqPCXk6aoIXa17Fbs6R0Kj8BwTEEUCNpRZIFBPH+5tcUUA1j1kTV4DO9/q+z9nE2b39OyA8sEVcUsHX62lpmwhXS+6xrnOPGM0/XqX4yPNVRmSPYbyPIIdEfpF1UUD7Qg5sVwPJPb68g8iu5+188hr2L92AYgKKSpScVzQ5nBE8c34Kq/hc0oIOKue2iT1SdxKKq3s4k97UI3s0UzDuhpd649hFoZafnD+LC6Kk4tAjKlKxHeCi6f1BXs1yq+qnx0K4Ap1+SZqTeqRLpbeaM5FqTl9ov7AiYk/Hc4o+ZbIsa9u/IEixRMAYcvEOD9Lgw3bcKwVcx4csmeBsE7dKjGZ2YfA3a3SCtofL6xlIg76OhPPDS1Jo7zLj31TRZqesbnnSSIoBth7f8y7N4Kxt2bFhGVCHG7zFiwDlU89uPWAKMW/DbdKpF1CKnOk2nv0Cb/hL+6/bSo81FcDIS7dB3z75FvTKShbHdNx2O+Y37f8RocwrhmcSS3OENR3gz2aRY+JqDJ0uE/SOlsQ5mr4h1Y7s7C8L7okgXqVAU2zZzPClZ4SszabWby0Sxq71V03prFVZlkGI/ghTvNSm/lKlP+bZeUOZm5FCdCl4CyO7zeVQ39UhcXO9SEj7/e8MnZupdJbi7/LXh5oag2g+tCtYYurpMqC3Icap/ZNIJWSEgVxiyfmkRgX8w0KwPvnKZ0e3y9H0Q2SQ5yzLrq9d+snyw93ZoB4QvOyfKeLvS06CT7+WnbL7U2Fo4IrLejYYOSkvlVxThzRYE0YenoU7ozwyL4EYIvO44DLcHUl2HtyZ0IPv677GNeTVtLoSD24jkX0X+ScUhtWF34kDdHMaj3+Sh6GvLFgjX9J 4QhVIQ1M ZQfHcwriwuja5FZRYGS6sRbvQWTlC9Aury5EeUZ6dhjPX6as+Jngtvp0svefAySBHg+GKyXaF7La+vSEigI99Uicpd7QFldPFc8LNe7FaMn1QBvmenTCsb/zoeYngVjC+R3+ssTdHzkS8tmMYOnxLeMCsEjQbgQJ5dlTN83m/qHMKT/ElfwzXdBg94DQxcT4+IZeFPREu9nh2imxwXEBbQqghglquozzZuNxaac7Q4BAPjqY9Fsl7LbiLeAqeKMh19WYr+AmvmOyHsDO8a9x3wWH2KAfVkhJRAHZDn0tuNkJ9TKAZw5ANk8PGxOVEvSKnSM7xzm0JgvsjlGUICvRKgz5dpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Lorenzo Stoakes, The patch b714ccb02a76: "mm/mremap: complete refactor of move_vma()" from Mar 10, 2025, leads to the following static checker warning: mm/mremap.c:1920 move_vma() error: uninitialized symbol 'new_vma'. mm/mremap.c 1895 static unsigned long move_vma(struct vma_remap_struct *vrm) 1896 { 1897 struct mm_struct *mm = current->mm; 1898 struct vm_area_struct *new_vma; 1899 unsigned long hiwater_vm; 1900 int err; 1901 1902 err = prep_move_vma(vrm); 1903 if (err) 1904 return err; 1905 1906 /* If accounted, charge the number of bytes the operation will use. */ 1907 if (!vrm_charge(vrm)) 1908 return -ENOMEM; 1909 1910 /* We don't want racing faults. */ 1911 vma_start_write(vrm->vma); 1912 1913 /* Perform copy step. */ 1914 err = copy_vma_and_data(vrm, &new_vma); 1915 /* 1916 * If we established the copied-to VMA, we attempt to recover from the 1917 * error by setting the destination VMA to the source VMA and unmapping 1918 * it below. 1919 */ --> 1920 if (err && !new_vma) ^^^^^^^ new_vma isn't set on the first error path in copy_vma_and_data(). 1921 return err; 1922 1923 /* 1924 * If we failed to move page tables we still do total_vm increment 1925 * since do_munmap() will decrement it by old_len == new_len. 1926 * 1927 * Since total_vm is about to be raised artificially high for a regards, dan carpenter