From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9527EC7EE23 for ; Mon, 22 May 2023 05:05:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FA9590000B; Mon, 22 May 2023 01:05:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A7A6900002; Mon, 22 May 2023 01:05:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16FDD90000B; Mon, 22 May 2023 01:05:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 075B4900002 for ; Mon, 22 May 2023 01:05:22 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C1EEC140798 for ; Mon, 22 May 2023 05:05:21 +0000 (UTC) X-FDA: 80816702442.17.01F09F2 Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by imf23.hostedemail.com (Postfix) with ESMTP id 00804140009 for ; Mon, 22 May 2023 05:05:19 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="OKj/gvd6"; spf=pass (imf23.hostedemail.com: domain of hughd@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684731920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q9fqf/aXpqllLgdqCnqVNZO09v0Ag5UU0wZCu2wmsUs=; b=RnlnsNXxJrV0ASknzJM7aHVFKAS7o9ADq7JNYFHSbMHMoTL3aGfk0zWG/c1EvtYgW4SjOa X6knkBpoan0CS6j7WnuP8MpNAAGKzR25iV7GYkOMdt6k9Fq5UWbuki4j41DhTopfMrgt/C ov8Dp+MycMDQmT80SSOmBhvD3q9rJOM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684731920; a=rsa-sha256; cv=none; b=ylQ70lqB7cQF6sgCRU08iHBN3bvK7nxX7agFzt78vdHRYSwD/d2mo3jeNA2IvxaHvlEjEZ cBHXNmIQVFOYgZ2SJBiByNJ7ShnxAgrTllWZ3yTjmcrTDNs9Ju5KAwNPfNE/pgCN+X3u9S T9XUwFLXrJ9vYoy7Ev72ED3T54+IU/g= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="OKj/gvd6"; spf=pass (imf23.hostedemail.com: domain of hughd@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-ba1815e12efso4775384276.3 for ; Sun, 21 May 2023 22:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684731919; x=1687323919; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=Q9fqf/aXpqllLgdqCnqVNZO09v0Ag5UU0wZCu2wmsUs=; b=OKj/gvd6hObldwT6K4phcbvAmhbsjul6iPbLRzKjs71jzjUwd6r3e8xCWCNZVwPENy 0HaWB0qgO/fNnS/Ois67og8DBdTyq3v/IDNkLAR46vDKiCQUR3xPJoyU7eFLCu5OCUxu ene9fgjo5yHZ3AS4/uG54DbEfQUuxcpEJxYx8UgryAp+t99VA5jZFAwJV246EE9mtg1F OZdfnZLlti+W2fNxVTHpJKMKRYyeIyeNsz3sd1gR6zvPQCCVQ9jZz+INsTuvonpNhmYF Bm782lSdhp0xDJA2N1jyxGLFmtKZ57I/CBr/DUG8sWZnMiCyq1l9BTQfv5dwSU+wKfRJ U63g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684731919; x=1687323919; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q9fqf/aXpqllLgdqCnqVNZO09v0Ag5UU0wZCu2wmsUs=; b=i64X65NeO7o9aKMJ1gs7zEeosUYDmTzVrxWHgsyGlDSCIJvjQ0+RVm/xzHziFfLDz8 mtQ94vxJ/fWV7tBkLh57ZaahYFlM6DUYfwheIS2GTf0TyNlcU+LWI+9u1evz2R3JOEK3 63CqOKd5Wlf7efiWnkhLcCGLN33tb/+WvqQEa0EArjNsJa6vuP2JunGlp+Xd+q4TMftw zi7BAtlfkXOEhDVu5FwZk5xsPUjvElPsNm9u4mjZkD5bOOVRoQwlmch6PKtDQ07XcqWy eTKRaUvwItUQdoQWqXxvYnKtro6boStfoKdYylQx+V0LZlitUFLY2vcgz+pqu/fI8Hu8 p/yQ== X-Gm-Message-State: AC+VfDzBGcw7jDNr3baBPo0g1jrUGur2LZg8Fo1rDCgagkWpZHRMal7Y WVsgjLXNh745qXi8xwPJUI0PSg== X-Google-Smtp-Source: ACHHUZ5Raj9TudeXZElbzzsJbxf03YA3/zAVWdObhAbA8Pr6yvbRJfnYmXwklG1UR7VtuXWIGmLBMQ== X-Received: by 2002:a25:fa12:0:b0:ba8:1c9e:c77f with SMTP id b18-20020a25fa12000000b00ba81c9ec77fmr9327198ybe.22.1684731919014; Sun, 21 May 2023 22:05:19 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id a12-20020a25938c000000b00ba87e9b5bf9sm1274482ybm.45.2023.05.21.22.05.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 May 2023 22:05:18 -0700 (PDT) Date: Sun, 21 May 2023 22:05:15 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton cc: Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 13/31] mm/hmm: retry if pte_offset_map() fails In-Reply-To: <68a97fbe-5c1e-7ac6-72c-7b9c6290b370@google.com> Message-ID: <2edc4657-b6ff-3d6e-2342-6b60bfccc5b@google.com> References: <68a97fbe-5c1e-7ac6-72c-7b9c6290b370@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 00804140009 X-Rspam-User: X-Stat-Signature: cm4wt57bkwxx4wjmnip8sz9fhnbokfum X-Rspamd-Server: rspam03 X-HE-Tag: 1684731919-931027 X-HE-Meta: U2FsdGVkX1+vv2H06uqtm2oIe+IhO6hfadC7DTuN4zvzPGi4kICbowlYYpbXsreumuz+jWCQ+LFsVJs1Wbvkbuzj4HrF8aJrROMFk1VpAM+x1of8SaplSthks/0wvB4cMu4amiaq658wN1RQtiaoQsIu0BAUHTJ9Dyh2nSH++ilsgeD6Ke6ZOQ5jWgLmvYXqlI95bsJE6on/i9JoflPAW8c4QB6wQdYibjoR3YjiPT4djgMkquzW4KqjRSSP8KHz0GsJqpOQwRTIT7rxuPFvJLbSDdvYMJwDLq4Hp/w9lHdwBUDkdS/69tu6eZ1OeCmId3hDpw8zHt0ZuBVLDFQCgUETqCQ2Opa/uhI6l8RsbUvZXVvWx55E5mNqJlChDfeoBggQ8XJ3TtdtPpSYL9Qg5OpdVEicj4k+w0p0SbtEdhXPi2XluM9QfPjNuGc9ZUfOnDF4w1IJtF0tRKhS5uLrSWyGiuFowwPHOXqx+UEyq+B2LYs+StvWAanTZdxddAhoTGBXVFFrsv5bOTs/5l1xFEhP14J8ZM2bXd3UXDKNsH3BpqufsvgFkA/8QkdO0FqmMGDrBkQqYYPuIZrTvPxKiGOpzEPri6/5U+fHXRMuhKogdrju4u8SNJjeDfR91wOA4J2S/HZ0OmlbqhrWYqKyYrwvX29DfATCqnIVwJhVD3jLESDZG3AU4vOd4Y+NNFCgtuFSTqsSN4iqizXMHnOQ73D8/FYaROPaLEN9gckeEZPIRdeEALGUR1BhLX+f3cx5MxCt4bmnEEWhh2bcVFMszqLLhK4lMOdD7aVYpVRrlEosBhlJKd20me03vPZIYyGxsUF4CtaOhQ7hz/ACTB1DGj+sTtQL7ScgMdj2Nyqe0nvYPtc81uRufs+kZ8Df7HdJ4Xf6jWGlINO0WQcGk3JBrvu+R8Ad3yLA52n0U+Op850jHr8ZlLepGbgl1vTw7rUV7yNEVZzY/1QNTQ/oea3 cc7GYvOX vLdWt/Dfw4tHLFPk62DmE2tczs8InIiVZ7cdAdtQ76rA/soRAH4ND8jOCXTu5BqofLoYMb+WKtyYyyj6jleZvQJDFPVekb78KgfT8NQ/aQbt6vGD/wvwtO0gJ87JNDQCWfyjEe/m+2M2az0jYWyzn6qs78Z14TK+BrST+PtqM0zCg0nGsM5YNNJ8Dfr2AQyTgkuD9tpEgIeBqRJrnJj0rHAmX2b9vbA8Ib6Y69WZ3CAYYBz+U/U2THc8XTLc8NbOsXIlGu0OPFNhP71yPY1Zhe831cBghjiRqdiDMs49K+f9SjNTptQg3d2se+/Xewrd2GZufpatDWK2GP/RR6iFEl56kispl4UxodCC9XyjdBYR6itK7AqZthBESAH8/E/HdC91OF0LbyKegMIKAb3Yby0w8JRUpmcdDbTllKP6OJ2fxR09u84e/iFFFwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: hmm_vma_walk_pmd() is called through mm_walk, but already has a goto again loop of its own, so take part in that if pte_offset_map() fails. Signed-off-by: Hugh Dickins --- mm/hmm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/hmm.c b/mm/hmm.c index e23043345615..b1a9159d7c92 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -381,6 +381,8 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, } ptep = pte_offset_map(pmdp, addr); + if (!ptep) + goto again; for (; addr < end; addr += PAGE_SIZE, ptep++, hmm_pfns++) { int r; -- 2.35.3