From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CCC5CD4F2B for ; Fri, 22 Sep 2023 07:49:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D53B36B0296; Fri, 22 Sep 2023 03:49:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D03B96B0297; Fri, 22 Sep 2023 03:49:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCC506B0298; Fri, 22 Sep 2023 03:49:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ABFA16B0296 for ; Fri, 22 Sep 2023 03:49:09 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7BEC340BBE for ; Fri, 22 Sep 2023 07:49:09 +0000 (UTC) X-FDA: 81263457618.01.DE7B36D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 539F7A002D for ; Fri, 22 Sep 2023 07:49:07 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FuV+QTa5; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695368947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mUrChINedqPMXcgm7a4g3Fw1rlxjkk+Lujf8OPdqplc=; b=OKnJipizw8iC6XGH//iwKijEyZ7FzrqJ/Y1L9NUhs89YccHcdQCMBzq9wZmecWmAbyaPcV LCOzakeaCLpltKfZlvxr30cyFS1m6VZSyiZQ8OfF3PfotperzjBrst3E+21RT+P0rB+PAv BxaUffr3+HbtftQc+lxuHZCt+KnMvpw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695368947; a=rsa-sha256; cv=none; b=iT68XbkSRjB9eVoOnn2uxJk+N/3ZeKXw/4R+Ss80f32mUhXR2G0g3gq3eLvoHoB5AuY8+F bE9u2nnFbCk9atiOv8Ig8VCR+vGGoKMG6GAevyCHonA0TFK14zJ+LRO75cQqT0z0p3E/0g xUnOdNqgCeWpLeurJ4LGv+7AATgfido= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FuV+QTa5; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695368946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mUrChINedqPMXcgm7a4g3Fw1rlxjkk+Lujf8OPdqplc=; b=FuV+QTa5a8C9yxBWTk/8QssL/KHS5r+HSyAT704UQdsFOGhsJPs8yvO9n27otJ5iDQjXIt WG26Z1Md7d7Wv39QCYoNi/aXQL+d/pto3nWTMMfo7u4UdXy8QtHXDKNUekdrTGvCjYaJcu mfIIAEut72sfVqo1gREstmbx5p5Hds8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-acd6ZTVBMoKgNR7RPO7j4Q-1; Fri, 22 Sep 2023 03:49:02 -0400 X-MC-Unique: acd6ZTVBMoKgNR7RPO7j4Q-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3200942185dso1030422f8f.1 for ; Fri, 22 Sep 2023 00:49:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695368941; x=1695973741; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mUrChINedqPMXcgm7a4g3Fw1rlxjkk+Lujf8OPdqplc=; b=tr0sZcfyWAuaiZClstM2k5I7cCXZZR+BV2S7AXgnz8XkUDCbjthoROwcS7LT94Gpg2 oaP+M9UrS0ZzS1GYJR9/nassc4jz0qhJM4B854kTgZJzFFLu1C2ktprXh+1AjA+8QVjw ngXdbxmTpZdZ2SptDoM91tregut32S1XoRYbfoYOrRd7m8DCg64TIEB3qrpL2yx3vYzk U7VmE8Z3lv7triKAHfgXXt53SGdygOBbFjafGXYOoi0C0x7OzFJHERfNmrg0x6S/RLZK c5XA06aBbuU6agiR97y+qp/Ru0qgTW9xnEHetnODdnMdH4EwqGqoGtdzM+7YyeD7PuAC fSBA== X-Gm-Message-State: AOJu0Yy0mc/BA5Z2xUq0qYT9ShzS5OnT0BRPUVeorxBFbVeOndP+mRwE zXDTGvOBMH806lsQBoyC83rYSNNNIMklUSdNijZfevfy+fUYjdVHHwz2SIR4U7dSHiEkhiCcIik 8vDGZv0TXYgQ= X-Received: by 2002:a5d:5966:0:b0:313:e391:e492 with SMTP id e38-20020a5d5966000000b00313e391e492mr1358468wri.17.1695368941622; Fri, 22 Sep 2023 00:49:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHsL+j01Pw5XaxmoyefOCVvRg5dYpJ8WuCHDVdp80uhbCqWq+8WMVJspNAvm9myjLNXXZO0zA== X-Received: by 2002:a5d:5966:0:b0:313:e391:e492 with SMTP id e38-20020a5d5966000000b00313e391e492mr1358452wri.17.1695368941281; Fri, 22 Sep 2023 00:49:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c71a:7100:dfaf:df8b:54b9:7303? (p200300cbc71a7100dfafdf8b54b97303.dip0.t-ipconnect.de. [2003:cb:c71a:7100:dfaf:df8b:54b9:7303]) by smtp.gmail.com with ESMTPSA id x17-20020a5d6b51000000b0031980294e9fsm3738383wrw.116.2023.09.22.00.49.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Sep 2023 00:49:00 -0700 (PDT) Message-ID: <2ed9a6c5-bd36-9b9b-7022-34e7ae894f3a@redhat.com> Date: Fri, 22 Sep 2023 09:48:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/4] mm: pass set_count and set_reserved to __init_single_page To: Matthew Wilcox , Yajun Deng Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, glider@google.com, elver@google.com, dvyukov@google.com, rppt@kernel.org, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com References: <20230922070923.355656-1-yajun.deng@linux.dev> <20230922070923.355656-2-yajun.deng@linux.dev> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 539F7A002D X-Rspam-User: X-Stat-Signature: imr9nhfcpz4mqyapzijytqapg61uf3x1 X-Rspamd-Server: rspam03 X-HE-Tag: 1695368947-238220 X-HE-Meta: U2FsdGVkX199IwnsMNwgQJI8bhLiLXiTE4WcHEhazI47ETgWptGkZgnrkM8vmEyWvkfJmPy4/Q0dm2NlycTtBUW6uqjV/HEN6o0FKk3tNQBNftjjDuyfmiN5nEEOZ8aSetgmyULJijvLmCMDivM9wiL/dG3j2ht+M393Q62rF70pMu8UMVDRzsYO0UPlhzrsr1BKF3NqKDuKRk1OuPpHcNjCqFEn5pitnQITpvvezDuHksFeFLFbxAFKDHrWrwTuqcNEZ1y0ku4yqD2thirBDQlznUcFDBzrhHtTPAMFR4q0fRLyAo0TSGbVA4CwuBBwzLWT0Pmf+c8zJRk9TxwyIV/xml5yYjYBpWEqZg2EhwE40/cxxwtULEBMqerZeEzqtT7116hLWLu46B+hPKNh8IzVSs7dQ6ilM0RnuXwUxILur4YEfkI8VnE3qZCFxHkjoqimc9DZAZnuS+LzaIAQHA9Bmwy2NXe84w1YxvJ0TnZiWu0SZ2+ECB1uZAn1MA1A3BVt79nOzjGOQhEI3m8KE67zllb5Jtjzf6Fj0kmoXktMAVbUiXI7lMDh9FyhOfr286E+H17QNyBSmOhDK7qN2HOoSKgpY4306ZNOHczMKeOhzWM1wBLtuFPogD07BfuGCuUEufxHQyRlQD4L1BusSSk68w9ZhqP9CyuojMg2b+pGrnIrDiygUEZ8zZkdrrmiZbhVZ7XnzJbu+C3KBHl11dQrstM9tq/KePKO+nbWAEsG4K/OmgRB8lvGoVxDl4H2MAlAwbduUaKkWB7rOAEtA7p9Pc3pOvlpikT7xK0QNG46/DQxniFFmdLYBBbSrzOAmHYqmdO0eCj0kLcTLD+IlNccumfSo57PBrJPU6SicCjMs6ie3dUIcZ78FJgKKgF0Kk5pKWYjN6r5mcsdGRSJXZEfJWciDBDfMvLcmGRiFr8iP/wIPO4oTLA5K7P54L03HoQqIP7ZjTd2qeeHNXV FoaPWagC goQT6oEqsYahAGZr2UV8BGI9C8AIK7gUoHz1Vtdk6kbuVSPgAjUAJnxFzHR9Me+EYGKfl9NLCp6rJcYc9q8r/sf+NmVBZPB7Wz83+xEsdO49xBfYHh7TDA4oldToVoF/k9fow86gGDuDA3QGyiCQIxIb+jOmvwJpHdQz+DPKnPpMHPsBW83Vp/JwSacqbxR0g/+PFzM8eVZoWyNfAeufGMBj5gbrGJRvx8dxT3xelmwFxYeaC9eBh5EngX4py5U1YySfJGL+InTx+6ewXiF0QIZf8vpoe78tNL5S5iK/FWPXad24pzYkSC7Zu8AHjPykxh18Sl77JXZUCZaMf0jNUMZp9qVAugkRV8Ri2dKN6LGGqB3Lqu6+jn6KL3Y0oRtNSE3K2v6r8aveGBAmeE/qFiS1ENcEmlROouynbckMqp9NlQkI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.09.23 09:47, Matthew Wilcox wrote: > On Fri, Sep 22, 2023 at 03:09:20PM +0800, Yajun Deng wrote: >> - __init_single_page(page, pfn, zone, nid); >> + __init_single_page(page, pfn, zone, nid, true, false); > > So Linus has just had a big rant about not doing bool flags to > functions. And in particular _multiple_ bool flags to functions. > > ie this should be: > > #define INIT_PAGE_COUNT (1 << 0) > #define INIT_PAGE_RESERVED (1 << 1) > > __init_single_page(page, pfn, zone, nid, INIT_PAGE_COUNT); > > or something similar. > > I have no judgement on the merits of this patch so far. Do you have > performance numbers for each of these patches? Some of them seem quite > unlikely to actually help, at least on a machine which is constrained > by cacheline fetches. The last patch contains before: node 0 deferred pages initialised in 78ms after: node 0 deferred pages initialised in 72ms Not earth-shattering :D Maybe with much bigger machines relevant? -- Cheers, David / dhildenb