From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E7E8C27C5E for ; Tue, 11 Jun 2024 10:07:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEDED6B009F; Tue, 11 Jun 2024 06:07:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9DF06B00A0; Tue, 11 Jun 2024 06:07:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B17356B00A2; Tue, 11 Jun 2024 06:07:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 953F26B009F for ; Tue, 11 Jun 2024 06:07:06 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 15DFB1C02EC for ; Tue, 11 Jun 2024 10:07:06 +0000 (UTC) X-FDA: 82218179652.24.5EFE53E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id C3557140026 for ; Tue, 11 Jun 2024 10:07:02 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J5bglAl2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718100422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F/H/c4fGsFUdJRDofZpCfuHa+2bAf+RkO1DuZv3WdgI=; b=LUraOzOCGwJeSj0HYmjQYu115hK+zplg5tb16whDqXj0cQiaNvP4mkSJJer8MgdMihJFj7 IPF4ASBZGuFU+j9raMu/MNWzrrzJ7YmAxR6Ko+tPJqWD2R8ia30BUnOmvud910MOHl6OVN jP9P56Di1T7+XKLp3/UNd2mPYdiZzGg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J5bglAl2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718100422; a=rsa-sha256; cv=none; b=Aip2XjWth3ueIIqZvqQ1uGAhsJXXJmu+l5hXImlyMwXQh2+EmEGq0qHHpFoGDc4rsYhLZz GqxgF4FQdFJ9M3b+ZvEqNZoFSQ4TYdltamt8mwFmzfv7Lh5VjYpA70jiJ4il+1uh/1Tz63 xDhq+1feVsPlu34kVG64s3zbIHYKNzI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718100422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=F/H/c4fGsFUdJRDofZpCfuHa+2bAf+RkO1DuZv3WdgI=; b=J5bglAl2hbB6QyihHx/iMZNYmTt9BOqhSfI+fqWpV3xws3ysg0Pe1Ph7nSdR+HbvLfoBCf GSrF+C8pzOS5Ww554eN9YO9HVwDDH2qEmzc3oOztT+LBQotUByMaP96537Nr4F13c0bEyv SRxWoiSXL9N+hoKxBMqYZbolEsRSwA0= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-7EmnlkYQNdqXae4k31sqrw-1; Tue, 11 Jun 2024 06:07:00 -0400 X-MC-Unique: 7EmnlkYQNdqXae4k31sqrw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2ebea9b7822so12824341fa.3 for ; Tue, 11 Jun 2024 03:07:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718100419; x=1718705219; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=F/H/c4fGsFUdJRDofZpCfuHa+2bAf+RkO1DuZv3WdgI=; b=CBr8xKSWhDbkiPS1UwWjElX09z/p4YZoAqdiIOI+Byzc5ga9dCyBvIdRXhpByqoS7r bZkoc5rFxr5QPqlvpTsYtiPCBKZYlQYofpxtPucsCkq2FeSaBUKKO6K2HGZXD1/pGEzp WqOCiJXju3AxyWFeZC6ikRKrCVbPDjcCqcUX5S1rWjgqCMiQESq6L9q5OlbHHGPEGRy8 A58lLfTJtTWHaCmUOs9VxSM1S6QTyLaAJaOcAcouW+KZX6ff9QTWOfyvObraNdBs+17j QbryYI59zuI5ek6RPiUJoMZOF3ktubwcS7ppEs6HYaf4NTRtz8/TGifJT8gdvNaq7jmK IGWg== X-Gm-Message-State: AOJu0Yx164Q7PyuCWew9Hr3T/qOqMs09sxbVGdfZkgYM8ZyaARLZZyuP zZPpZApBZCrrfRolMAynYBJ5Q4NdhQmY7dGY/Rk60dxsxbcpeVlOxvbvjXEYFsMU/dikN1wXYuJ kw72vPgfkVanZ4AW8YEV8fhuHnfHB5B7WoKm9EMTt/y0dnyNO X-Received: by 2002:a2e:908e:0:b0:2eb:ee64:1e19 with SMTP id 38308e7fff4ca-2ebee641fb3mr18566731fa.42.1718100418974; Tue, 11 Jun 2024 03:06:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTPfn39pFW+4UY1ixf2NXkOeipXmnEb8MezD4IOdN3tIhaG3lKM4bAlWBQ/Nnh1BIsuQ/pCw== X-Received: by 2002:a2e:908e:0:b0:2eb:ee64:1e19 with SMTP id 38308e7fff4ca-2ebee641fb3mr18566441fa.42.1718100418548; Tue, 11 Jun 2024 03:06:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c748:ba00:1c00:48ea:7b5a:c12b? (p200300cbc748ba001c0048ea7b5ac12b.dip0.t-ipconnect.de. [2003:cb:c748:ba00:1c00:48ea:7b5a:c12b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-421818907b6sm86762715e9.27.2024.06.11.03.06.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 03:06:57 -0700 (PDT) Message-ID: <2ed64218-7f3b-4302-a5dc-27f060654fe2@redhat.com> Date: Tue, 11 Jun 2024 12:06:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] mm: pass meminit_context to __free_pages_core() To: linux-kernel@vger.kernel.org, Andrew Morton Cc: linux-mm@kvack.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, kasan-dev@googlegroups.com, Mike Rapoport , Oscar Salvador , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Alexander Potapenko , Marco Elver , Dmitry Vyukov References: <20240607090939.89524-1-david@redhat.com> <20240607090939.89524-2-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240607090939.89524-2-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C3557140026 X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: hufn4dac1hk9dypgycjqjueqcw84irf9 X-HE-Tag: 1718100422-226925 X-HE-Meta: U2FsdGVkX19UeOcp2PVJhDu1/UEFx+cj4k/RmvMh5mdV3I7o7VHXXhwwBc97/LydbY+D8Cx2gt99hoJAhMjGG+yMmKj7kiO3VH4f0E0iMSCOaWQjHkqVTCSL+Oegb7N9FHLbhQ4E6RzAUWPar2GetgnDeNeFjIxibMaFcp9Qne6EGMABm84XOh7QGCLxjpGKUQXwQU1Nt4SFeEB/F1IJtVk/DPSeHDOp/l/xwx/Bch00gU9F6tZiFbeeIOd14gLy6DUqoD5Qgm+ig69sbbhf42PO+e8mRz1eTMVm0p64etl2ixO4WbdfVc3ayMm2J0TMaHVfpWYX3WNpbuP8Z0/95wlIQL3ciDGx/4IrUOhBdOzRxUtOjMuXLM37wbTa4o+atQ3B1+zFx3o8JBW6rdsuGH+L+8ChfNmoXmUHlXIuWab4gBmQEzdNb8zQRASdXpDqcjQ7dSXQI/xxZO/AGjEVyKK6dPm8QDE9bkbmE1587b99skm/Vbx41N37H2zP13+NP+aqOWmuyYunGAhuEVVq8fm0ncPk4SCiiqvACBqdzPcJk2pP4zx9ewwAFXteIBHNlM9DYdf+jI0uofEhOG04fEYk0c1mZpjltk5brLznH+CXcYVzhSmwAl/yTPR4i3FABW+5aipvTnXFYuHxZ7aJfknqWdCGtleAM+TFWLAyLWlDhpYIHk+gkKAnHDc6/GsFfcWHLXjBvf/iyJZfgiQo1ocQ8YtLNS1Igd3V2/swrcoQ8kYxJMvedow7VDcMz6wxvwnoQMVWrgreVwCPmBEzRahjJc1VGH2Fcy7yrZCifjWS7+hpJMlfNVyeCShmlIS5Mh009XRNU9fVfMetValtuwjCXR7s/3/JLSvVIibwQU6JGfXHsgE8i1QJkykpI9xGGZ3/Ii5ciflSV24B1FQIrFq61q8WmJbyOvorRp/kXSo/UKCZrJVCnhbnJbuen2YfHMVvKaizH3cIPNYUjg3 OyUjgS4u oB7ShAiRhGbEjTRseuWAKLRJ5k95ckZ1nAQJsVCMZQbh2AjeO4rv0mZ7kV4kFq4wu8jq7gXZct8qig+Vp7Kjqh1IhxeRUdRpPumXfOCYOeBNyWwI54zWXyKgBh36pu25tPnEAoaabJfBTUCqB7i8uswCCsDOOorh91kjSePCMTYofPWiiXM99MCCcSTKjCxXDilyy50d8fAbyyTg5fnF6qWADqdvxrEVjXj2KZu92zTO9tAOEGRzYhDbsNMWRo1r+3nvb30HwxIr7WuLl8t3qTIV1H4pIfmGRKBVzUWOFzn+AJHo7WJZAY/VvLxmV/Ea6FDlkp595unUf113Z+Z18E8pWmQoaF2FKwRWj/9AU+br6JgjvrZR+ah6BlAgNqC4i6t55E+zx+kqbLTRxHSxHULwl7L2O79U7Hkg4VJeK17H6+Ef6z+muW241RwIOE8lwMmnx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.06.24 11:09, David Hildenbrand wrote: > In preparation for further changes, let's teach __free_pages_core() > about the differences of memory hotplug handling. > > Move the memory hotplug specific handling from generic_online_page() to > __free_pages_core(), use adjust_managed_page_count() on the memory > hotplug path, and spell out why memory freed via memblock > cannot currently use adjust_managed_page_count(). > > Signed-off-by: David Hildenbrand > --- @Andrew, can you squash the following? From 0a7921cf21cacf178ca7485da0138fc38a97a28e Mon Sep 17 00:00:00 2001 From: David Hildenbrand Date: Tue, 11 Jun 2024 12:05:09 +0200 Subject: [PATCH] fixup: mm/highmem: make nr_free_highpages() return "unsigned long" Fixup the memblock comment. Signed-off-by: David Hildenbrand --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e0c8a8354be36..fc53f96db58a2 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1245,7 +1245,7 @@ void __free_pages_core(struct page *page, unsigned int order, debug_pagealloc_map_pages(page, nr_pages); adjust_managed_page_count(page, nr_pages); } else { - /* memblock adjusts totalram_pages() ahead of time. */ + /* memblock adjusts totalram_pages() manually. */ atomic_long_add(nr_pages, &page_zone(page)->managed_pages); } -- 2.45.2 -- Cheers, David / dhildenb