From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE866C27C4F for ; Mon, 24 Jun 2024 03:08:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F12B46B00F3; Sun, 23 Jun 2024 23:08:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBDFC6B00F9; Sun, 23 Jun 2024 23:08:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C75996B0448; Sun, 23 Jun 2024 23:08:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9A3306B0447 for ; Sun, 23 Jun 2024 23:08:38 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 17506120A9D for ; Mon, 24 Jun 2024 03:08:38 +0000 (UTC) X-FDA: 82264299516.12.2B3CFED Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf27.hostedemail.com (Postfix) with ESMTP id 8059D4000F for ; Mon, 24 Jun 2024 03:08:35 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719198506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uirVJxlfRE3Sdsr44b8jiMpcgKUWBrskz0Ef05uyM3E=; b=gzxl1cikx65ow7cqMSj5aNIObzC78ot4lVDOoTzcQ08VSM9oZ5Z8WPIqXPcqJ5iNSNdY7d xW7ybWjphCL+PvY1Sinjkaz/2vUC0FbPtxGy8O0PYJH8UDpfc88NhsJcFFHy6ch5/x32EK /CCChOqfJm74wffTV8P+z06mBbz4oLc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719198506; a=rsa-sha256; cv=none; b=P8FDhI1rE+Tgx3tw5NLkb4tCQQ6iMI7MerST1ZrK/ajhiBAcJVHIaLAYmwNnPhM9WXrIrP 26xFL5DELVPo82Z3Jbp91hqK53WveUu43o98QAlyLh0vkuVwpmR11+c2D4kJJ9NDns95pT v4akTSqIUj+FShP0+G+q5zC5xE2fMb8= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4W6tD15ZLWzddQm; Mon, 24 Jun 2024 11:06:57 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 9667418009B; Mon, 24 Jun 2024 11:08:30 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 24 Jun 2024 11:08:29 +0800 Subject: Re: [PATCH v4 1/4] mm/memory-failure: refactor log format in soft offline code To: Jiaqi Yan CC: , , , , , , , , , , , , References: <20240620184856.600717-1-jiaqiyan@google.com> <20240620184856.600717-2-jiaqiyan@google.com> From: Miaohe Lin Message-ID: <2ebeb4bd-d173-2690-cb66-2d3db20c4648@huawei.com> Date: Mon, 24 Jun 2024 11:08:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240620184856.600717-2-jiaqiyan@google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-Stat-Signature: atbwshdzezft6tcoegamiaj7c3eat1b7 X-Rspam-User: X-Rspamd-Queue-Id: 8059D4000F X-Rspamd-Server: rspam02 X-HE-Tag: 1719198515-670282 X-HE-Meta: U2FsdGVkX18HwCKtjmNYYIWkyuaMznFyqx+fps/4A3CfhLAuE/t/w1aNR7RSLHEZNp2I22zldRKUGeAju474ZNHSq3IWgjLhUxpJUSR+CCQs7tnqdwUCMBlZu7ZODICE4gVyKACFs7EVZNZigqnYhrHTFiSm0jM0yoKlx6wxGnoLgaqpNYw3ULerB90H79oQ1wEEulX086hsb73pKb8Yh/y4fxHgT5eVaBrRjnzTHWok+Jpa2uNOQ2fl68P9qRYLvhrdQoQjnlbXCp0BB6W7CwkCeVvjx3vUsvTjn2CBATjBKZOPKhJi0PxZdKr6YQVVcpFTS4FxKmI64JUlp9Iyq5dixQJsNKaZvZGnhQPSb5qAsvlRFmy5Xek7do1mpjgsQYSEg4XMdMDSVoGCWWlUfC1mOWoYzWJo2JPbsgvDRdl6iE/9v0cOjcc7AXwgAIEYI3QrQUrH7bkUD1B8hRotGpKgOUYC+4LlAeVAeVp7j9B8vo16e9p6qAWw5zvInz0Ro7f+HNFXuBb28i6PSPG/aT9SdfjXMOi+Cz8dpAozGVBcEfBvCNLs6vPsCR5LHYQTDyHWPQ8mN4HTYt+nvVwkBSNmY6FbcKEmj/PFajlO1/bkqzwpYazVItkMdKcNcSOOTglCa+Z/iJLvhh14HKEGgd4iH1k9bfg+cx5DcvVe7Tzb8HRXag3eYPuPm4cBRluOcjiTsnMkhw0iG2sMuwERCcXMO6pJfUUcjnajYADSGB/1TKNSw/clQlffoZtQ5zRQV7vNzwhqmKaVJbU9xjPrTKHEF6IM1tSWKZMclfqv4aUpKXq9JZgPRRVsZQ5GetKDAIw2M6gQon/LZa66KJooRbue+WYVTESkwF9OqV59SoA14oEAu0WsNpSKVgaA7ZPd0LimBLneAy/E9TpG+FTF4JSNvEFbVNmBxwmffx6Q5l2LkktPYJgt557M3IKccfR7Ey0wtnU/oRGRPbWP2p4 tSdgWPUY qkHUEtbi0/ujeYX5La4gLKDToxVfQxjqROqRe3dyXTiQ0Zrzbd60mfY0m+ESFo5NPMle7NoPbuHEy7RHdJGs9v64s4WVsKy5hfXVApUj7LyRwVY56MgLTOeiEvamwPOWfb3oq6g90OvGW69ISrv+8UGiAzulWbUoeYWU0yTfIlRWb0mc39cXO6DlHSslb44lx0fRQ58QeaptuIGT+DmTrRkhA6mWOxqeMvQs8owAW3OMvb89BDqz+pq4lq+LLc8KQQaLv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/21 2:48, Jiaqi Yan wrote: > Logs from soft_offline_page and soft_offline_in_use_page have > different formats than majority of the memory failure code: > > "Memory failure: 0x${pfn}: ${lower_case_message}" > > Convert them to the following format: > > "Soft offline: 0x${pfn}: ${lower_case_message}" > > No functional change in this commit. Thanks for your patch. > > Signed-off-by: Jiaqi Yan > --- > mm/memory-failure.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index d3c830e817e3..2a097af7da0e 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2631,6 +2631,9 @@ int unpoison_memory(unsigned long pfn) > } > EXPORT_SYMBOL(unpoison_memory); > > +#undef pr_fmt > +#define pr_fmt(fmt) "Soft offline: " fmt > + > static bool mf_isolate_folio(struct folio *folio, struct list_head *pagelist) > { > bool isolated = false; > @@ -2686,7 +2689,7 @@ static int soft_offline_in_use_page(struct page *page) > > if (!huge && folio_test_large(folio)) { > if (try_to_split_thp_page(page)) { > - pr_info("soft offline: %#lx: thp split failed\n", pfn); > + pr_info("%#lx: thp split failed\n", pfn); > return -EBUSY; > } > folio = page_folio(page); > @@ -2698,7 +2701,7 @@ static int soft_offline_in_use_page(struct page *page) > if (PageHWPoison(page)) { > folio_unlock(folio); > folio_put(folio); > - pr_info("soft offline: %#lx page already poisoned\n", pfn); > + pr_info("%#lx page already poisoned\n", pfn); s/%#lx /%#lx: /g, i.e. ':' is missing. > return 0; > } > Other than above possible one nit, this patch looks good to me. Acked-by: Miaohe Lin Thanks. .