From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BEACED275 for ; Tue, 8 Oct 2024 07:03:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1C646B0083; Tue, 8 Oct 2024 03:03:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACC876B0085; Tue, 8 Oct 2024 03:03:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 993676B0088; Tue, 8 Oct 2024 03:03:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 757F96B0083 for ; Tue, 8 Oct 2024 03:03:30 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 332BB1C6C74 for ; Tue, 8 Oct 2024 07:03:29 +0000 (UTC) X-FDA: 82649544180.24.9F6308F Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 49BE120019 for ; Tue, 8 Oct 2024 07:03:28 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728370898; a=rsa-sha256; cv=none; b=oNg9yfzA19w28IQFRmCTNOnh3CHZNX4LKYZw6AUJeWUEgjkV7UuibWtrONpXrebZA/RPzO 321To0/auEMlWoJvFqdZXJptAlEUY+QYDzeHOmx1CH19zXvSj+VeSzvN/Jgvgds4CMb6ST dAGY02vfgrwQLyZbyYhoe6XojLLe5Uk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728370898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zl37Y91oO+8z1/qTktKLwFztniusr05Po5+KGzWrEPk=; b=TPE2EAcbM3wGZNlxrvwNV8QBrrPKo9RdZ0EHHXGjc6Ex74Q8RFI3IM3Mt2Raq5nXEUUaoF yLNLgoMQBhXY5U8I2WWUMsdGdTVaEkEK0euCxTN2dujNKavKIGX9R0iTvVdHapj7ykIgkj 4nhZtZcNtioR0TnjKaE3SJUyzpq3pBs= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 078F4DA7; Tue, 8 Oct 2024 00:03:57 -0700 (PDT) Received: from [10.163.38.160] (unknown [10.163.38.160]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BCA453F640; Tue, 8 Oct 2024 00:03:22 -0700 (PDT) Message-ID: <2e9e559e-82b3-4ba7-8316-a514abe9dd38@arm.com> Date: Tue, 8 Oct 2024 12:33:18 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 1/2] binfmt_elf: Wire up AT_HWCAP3 at AT_HWCAP4 To: Mark Brown , Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Kees Cook , Catalin Marinas , Will Deacon , Jonathan Corbet Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org References: <20241004-arm64-elf-hwcap3-v2-0-799d1daad8b0@kernel.org> <20241004-arm64-elf-hwcap3-v2-1-799d1daad8b0@kernel.org> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20241004-arm64-elf-hwcap3-v2-1-799d1daad8b0@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 49BE120019 X-Stat-Signature: 4tq7zjo4ch3m5pq1en3huopdteq588qu X-Rspam-User: X-HE-Tag: 1728371008-941832 X-HE-Meta: U2FsdGVkX1/t6iv2KOiG6OqewDkCDq2WEuvWl4eoH87nK8DOn0duw2ZFHLWIwLKBTnzJOXIxPsmv6HUKCJDkfxudkyViSH1jmeUzM3XXl1sJYrdL63hpgbHpquGP7BcxEcCMHTjKpRM5nmHqoRz3kit0AN8UBNoYypw7phq42d5zaER4ZttrCcn+TV57L0AJPV5o220SWOxO0FHQZFH0KU3WRLM4xMb/xdii6+DMeJqDn1qNy0TRxlM42sOkftBsL2lMBmR7ymx6TcXFKg6NbRzkEWNcSgkMR4hUVb/fCndYcIAMsWuDc1XKKM/4F0kcIe897kez74LGXdPHBd+PQWsMk+MLhsf7jW1FcDVv7ef8hKZkojTtB6yZlTxIiOdLQPlOk5WtHkW5Z9xMFTM4KFlyjfH9s5+OjcwkKmuFT2onVe3riWj09Lbdpt1ERkGuUP4iflVvygJeeNTlLkZUh6O5Vjo8GloQbhHoTD73Wm+qQsjOjCyREwirJptgglAw4eY3EAclAFKF5gKqGyPPaCHvfFkOa0PMBjFAvZfoKi6ynHo5VOCYMg07qt90B3EjuKD3s3hY5Kd9dHhAZRyVUwfaOnuSzEc/bH7aMWnpg5tZWLH229mdmS23DM+GZqxF35/y4lLSuJM5oBa0nG0MtO8cHQKzuOstk+O/CJQm8qhJ0zIbPR8VvFgxa6qOTVOHMsDUQIS2brqYbisADrDlH0AtK0urhd1kG+90zquonE29EPlbyUJBgLzpLbOTuMmOgUUv748573zT9KY6JCor31PamuNq4ikRDFaJrPS8Vh2CIEq0wQ0Awb7CLLUdp/Lts7ez8TH8Jd1p+fTnlm8ECuuW6HAvlYhRf53LPtgwGGWhXlW7prwpnR1TTvMvFdRG6nSyQoDW7auNLLe9vEoIhl+u5hExosMHwvDLCY6Cxl/9jYpVO2rKwnGRvoXnYyLAUl1UBInLt61bjiaAHnL twZYpNAN Oqz6GHW0wFfht+g3njvUiC4kwnkjEKOAIpyCswFwNpxo2N3/nlartMYYslpXbiLB/dbLNj5ZvwP4Pv0ekoQ0mfYnJni4UR+fMI1P6vycfUfrcPqF5cLeA2A1atOVRd+URZfE9d3yzaHJNBsD0ESO2B73cALzKLbQt2BrDYnwc2KxjeGPdNA2x/5DwV309pSzrBZ5KgHZySHdjFiB9/dLIYQ3/IgXKmwiycWKP1cJW8FrkHR3XwObpHy8zETXdNaKZ6o+Eu0e2EGhqJHCnGpyvZ+0pmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/5/24 01:56, Mark Brown wrote: > AT_HWCAP3 and AT_HWCAP4 were recently defined for use on PowerPC in commit > 3281366a8e79 ("uapi/auxvec: Define AT_HWCAP3 and AT_HWCAP4 aux vector, > entries"). Since we want to start using AT_HWCAP3 on arm64 add support for > exposing both these new hwcaps via binfmt_elf. > > Signed-off-by: Mark Brown > --- > fs/binfmt_elf.c | 6 ++++++ > fs/binfmt_elf_fdpic.c | 6 ++++++ > fs/compat_binfmt_elf.c | 10 ++++++++++ > 3 files changed, 22 insertions(+) > > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c > index 06dc4a57ba78a7939bbde96bf181eefa950ea13a..3039a6b7aba4bd38f26e21b626b579cc03f3a03e 100644 > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -257,6 +257,12 @@ create_elf_tables(struct linux_binprm *bprm, const struct elfhdr *exec, > NEW_AUX_ENT(AT_RANDOM, (elf_addr_t)(unsigned long)u_rand_bytes); > #ifdef ELF_HWCAP2 > NEW_AUX_ENT(AT_HWCAP2, ELF_HWCAP2); > +#endif > +#ifdef ELF_HWCAP3 > + NEW_AUX_ENT(AT_HWCAP3, ELF_HWCAP3); > +#endif > +#ifdef ELF_HWCAP4 > + NEW_AUX_ENT(AT_HWCAP4, ELF_HWCAP4); > #endif > NEW_AUX_ENT(AT_EXECFN, bprm->exec); > if (k_platform) { > diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c > index 4fe5bb9f1b1f5e0be6e8d1ef5b20492935b90633..31d253bd3961a8679678c600f4346bba23502598 100644 > --- a/fs/binfmt_elf_fdpic.c > +++ b/fs/binfmt_elf_fdpic.c > @@ -623,6 +623,12 @@ static int create_elf_fdpic_tables(struct linux_binprm *bprm, > NEW_AUX_ENT(AT_HWCAP, ELF_HWCAP); > #ifdef ELF_HWCAP2 > NEW_AUX_ENT(AT_HWCAP2, ELF_HWCAP2); > +#endif > +#ifdef ELF_HWCAP3 > + NEW_AUX_ENT(AT_HWCAP3, ELF_HWCAP3); > +#endif > +#ifdef ELF_HWCAP4 > + NEW_AUX_ENT(AT_HWCAP4, ELF_HWCAP4); > #endif > NEW_AUX_ENT(AT_PAGESZ, PAGE_SIZE); > NEW_AUX_ENT(AT_CLKTCK, CLOCKS_PER_SEC); > diff --git a/fs/compat_binfmt_elf.c b/fs/compat_binfmt_elf.c > index 8f0af4f626316ed2e92204ff9bf381cd14103ae9..d5ef5469e4e620f6ee97f40ce9cbbfa48e37e33c 100644 > --- a/fs/compat_binfmt_elf.c > +++ b/fs/compat_binfmt_elf.c > @@ -80,6 +80,16 @@ > #define ELF_HWCAP2 COMPAT_ELF_HWCAP2 > #endif > > +#ifdef COMPAT_ELF_HWCAP3 > +#undef ELF_HWCAP3 > +#define ELF_HWCAP3 COMPAT_ELF_HWCAP3 > +#endif > + > +#ifdef COMPAT_ELF_HWCAP4 > +#undef ELF_HWCAP4 > +#define ELF_HWCAP4 COMPAT_ELF_HWCAP4 > +#endif > + > #ifdef COMPAT_ARCH_DLINFO > #undef ARCH_DLINFO > #define ARCH_DLINFO COMPAT_ARCH_DLINFO > Reviewed-by: Anshuman Khandual