From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A054C30653 for ; Tue, 25 Jun 2024 08:18:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C65D6B0309; Tue, 25 Jun 2024 04:18:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 775A56B030A; Tue, 25 Jun 2024 04:18:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6160B6B030B; Tue, 25 Jun 2024 04:18:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 43E066B0309 for ; Tue, 25 Jun 2024 04:18:43 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BC281C0D24 for ; Tue, 25 Jun 2024 08:18:42 +0000 (UTC) X-FDA: 82268709684.24.927A12E Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf23.hostedemail.com (Postfix) with ESMTP id BEEC614000F for ; Tue, 25 Jun 2024 08:18:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fijsk9ov; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of seakeel@gmail.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719303508; a=rsa-sha256; cv=none; b=ppwfh4PkZf9GTP9EymxIWPbbO+oKidOiPJrTU+Akk831vGYN0+uO72o8PCxE0lPNwY+44H vFEAMiPQ4DPpl9Ox5+ySU1V1iDVOV70zPkmp41+I7pPqqziNQi1BRHOW6VrbCXnquJxo7S QYCzN2fvvSFn/fIRg92v8cNWYe7M6IM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fijsk9ov; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of seakeel@gmail.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719303508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dyV1PLjpvylr46DPQBxqwExK5HpcwEmrJO3AyCumHiw=; b=1HYi5CwcRHt2MbIohdHsVV6nHBlCUitWht77Vjtr709VkJERsFlFt0Q4PdpiLoL8tN5r2H V9ahb4ijPn2Ern883Kp66xp9vOxDzpdLOyaCM51YKAeEcV9L3IoANTQpFWzj2chqAKQezm zolgjjcZYlMrFrBBN5/NBr/SRQ57EQY= Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-6b50a68b0b3so48859936d6.0 for ; Tue, 25 Jun 2024 01:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719303520; x=1719908320; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dyV1PLjpvylr46DPQBxqwExK5HpcwEmrJO3AyCumHiw=; b=fijsk9ov+u6JGi9tAoMUdjteKr8CTJcLMwJAQIbHxXCkoIEgI0NPWDc0AOume/3oK3 pk2Pi8VuhCRpnKLV1L4AOYF4kRfEZw21YtAbDVQiHSDOaLZxsbqHkBO28PUxx/0jjxb9 RjBcSNRCi/mj3W877Op3/L6SPiOBk9WEJBz6+HCfY+8mCw6Dhgl7zsh+Y/9JbXqrge1I 5H1GVub+9w9vqFFZuK5yXlfdKzoMZzHI4Bq/Luq2QcobOvaCPxWh2IPQWbba5WIgQyZT UnwRw7AKqNY9ug5E8SlswdFEUKwXLtJ68iH8BzafGtrO9ytu01s3vXpZjxLVOhwK5K+f BsmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719303520; x=1719908320; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dyV1PLjpvylr46DPQBxqwExK5HpcwEmrJO3AyCumHiw=; b=t1/tNDJRYS0kKhjRxc+6N+BzOnwLGecByIQLzV1TOUNY00SjH5oylsv+YJvZA9FMMK kvwHgwOHqW0Y8gLLmhHtQaZc3WN30d1XB6kDUjFWRNPF/pQHxSdhmCHs25CRW/U3Lw/P kLmhBAIdU3dxrwXvPZylCb7gikYLBxVYvWMTzI4aZVC2EVXy9NzaFIyWCXQY9fgBoRWG wKF5aIBzUK6g5IeemVAVmF8KbxiMsiDla0AQB49sASClgcYMc/ezRiXjeN8sW698puwM GvBROYc6C02Rxt884NSqzKdFhrl5AJHnqCajSoSCarM6xjM/F1Y6Dp/bAuEx/0B/RL9d jItA== X-Forwarded-Encrypted: i=1; AJvYcCUXKOzXCnMRfy65pg/p0sXm589NcTN+AULVnzJLz3MUlTw+cWuJuyt3zNbbLx8tUm7nIYtc0DVYto4sG536+HUo7AM= X-Gm-Message-State: AOJu0YwMnl9ITa8CY/yM5BuBcBDEcw84742sXcYm8RFK3w+qTXO6KRba t4nJuo0JsoFJPBhCK1bwAw9B+u5C3VdYrX1dGx75WMTmo8JQ2dabxyikU0EH3JI= X-Google-Smtp-Source: AGHT+IHe5NrIZJkjGCkdCHb+86lcOYYXgALNf5tDLIhfYrHcwD7+9ye7Vt7UXVyNjTntM1PDitFDdA== X-Received: by 2002:a17:902:f545:b0:1f9:ec87:284e with SMTP id d9443c01a7336-1fa5e698121mr46151945ad.16.1719303114078; Tue, 25 Jun 2024 01:11:54 -0700 (PDT) Received: from [192.168.255.10] ([101.87.0.0]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fa13fed3cbsm53864615ad.269.2024.06.25.01.11.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 01:11:53 -0700 (PDT) Message-ID: <2e9ce344-e25f-41e0-8ca4-b6d80e095735@gmail.com> Date: Tue, 25 Jun 2024 16:11:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/15] add zpdesc memory descriptor for zswap.zpool To: Yosry Ahmed , alexs@kernel.org Cc: Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com References: <20240621054658.1220796-1-alexs@kernel.org> Content-Language: en-US From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BEEC614000F X-Stat-Signature: dwf56p4ni7urujs9isby3em6i16tfpp3 X-Rspam-User: X-HE-Tag: 1719303520-537184 X-HE-Meta: U2FsdGVkX18Z07y2Nm6LAiog3LsEMDdD9juW//Xnr0PohOXi+1LPi/JdDo799nzjeCszcFe0XycQHFaApVOKwuJEer4ZFQ9S8N3Ugu+BxCee2J9VyMJjTnz/polT6lxToMXKXIUrstuHfJmsQtuERO5fTEsVxiupFTjFo4sQbTl784mAAZhq05hZBfMNc0Q0MpmIMIbInCzGbc713TjCogu0SVHlKYEK4FHLYLMGlP2dlPtaY2FY+Dwvu0gQVVp2RVDmKFxtv1D3J7M/ZjMNQ00Vp3dl29IRKOaEWHUJpzOSvoq5I9yLSgAabSUwdLrLMXxUfcmsM0OeN8U3RBZakc3v7um6/mfnqL3gT1KFK5ezkd2ps1wX2LwGGuJcKiAMK6nENlfwBA41dqtQLVZZxjYrt+4Iyh9rKEZVxOWn5UsGazp+wuEb6Vvzs+DA7xOg7No5M98kongE8GRxPuz+nZpgIzVLDOxwl5/IFyKqDcKH/jyYpDDtzPc3OArkJddxH+WGZptqmSqAw0Lc0FvGBA+umx1uDcaw/l5ffAUs/69RNFUG4+z/ZS8eRKn2nOgLqjG2ZSHNkKUpjQ0ul7E+6lSI6rQ+EO5HfQ9Z0xjoq2Nka/FE9yh5CR5yYBfyQmqA8b+4ZPIP+uIJNJ6JSxFRQM5xLOZTPBaCVKUIc0AA8QbbZ8pyHgnv3XAICYN2dhR4Mb3DJcV9u2dgkbw67DLhI56LAYSSCLLY75hNnED85CVKrMrv3oP+4feQo6qvNmKnqD/PWfaSE65Ub+gHjHp2dlYcAHtRT3l31bFrQWNG4NnfOgc9MvyEwG0EzWoOA8l9DNfSzyGUJvnGg+zgP8zZMFITTXEr1kWgirBcRZzsirbWOG4/+YrSL+s6ECX/s8QrUQ9GLYL0YbLyeA/Eq58qrwR0Waji1CLq57m5xzl5zuz278uVPjKxihvLcXjMvvNehHkpNSYC9QO5Rmpl8GG l/vQL7J/ 6cdwzm/aqHSEMFfxTO552pEtejbgn3Os9sGufm8VWiGMvzMCCaQBlN5E1MKXWfqI4pX3VSW0tk2KLFa9Tkcf3X4JWXwdAQtsa+2wLQvxmau2/PzEV0TMOTYkFy+EXOfW0NP+KIvfW21RqbeV5RYI5Qwh6kWDKHOLl3K+lycxaF61MtkbwnlypfzjXuqPEK/EwtGSRutumn+iCdzNs60sWUpp5lee8xuKfBpFYMfteaWLFUv9MOu+GcLxosCrEMUvhIXZ2PcXKx95z3wSWoiGIUj+BTjchUPwSBRFFPc6O0PHN4TaJMENV7uMdIVTR19x8t6UWlhJuymetblDZOkzOrPEP6M85jbaJk0OXitYVSfdNsHb0Rozh68uLbTWjN1ueviWosvZ6CSB6Ry2UfgVg8rZ61+KCnQ57oODdCqjxabAQtne74hVaQ2f2YfxxluV1o09qtFvP9rYcWeI8CNXZC3M6pt13i7l5G8/gX1J6To49+gUQC/+CJ4KrlVtycfTz7jqjxkbnc/iC7D2hN3Iu23tyF8lkxYVPao+N01B5SXjdvhcKwjO5gp+3jh8xRy0X2eybSTXNsWRJ37zGh5z5mchD0K8yqN2yi3QQl5q63bSXn2Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/25/24 5:46 AM, Yosry Ahmed wrote: > On Thu, Jun 20, 2024 at 10:42 PM wrote: >> >> From: Alex Shi >> >> According to Metthew's plan, the page descriptor will be replace by a 8 >> bytes mem_desc on destination purpose. >> https://lore.kernel.org/lkml/YvV1KTyzZ+Jrtj9x@casper.infradead.org/ >> >> Here is a implement on z3fold to replace page descriptor by zpdesc, >> which is still overlay on struct page now. but it's a step move forward >> above destination. >> >> To name the struct zpdesc instead of z3fold_desc, since there are 3 zpool >> usages under zswap, zbud, z3fold, zsmalloc. It looks like we may extend the >> zpdesc to zbud and zsmalloc, combined their usage into one. > > Please do not focus your development efforts on z3fold. We really want > to deprecate/remove it, as well as zbud eventually. See [1]. > > For zsmalloc, there is already an ongoing effort to split zsdesc from > struct page [2]. > > [1]https://lore.kernel.org/lkml/CAJD7tkbRF6od-2x_L8-A1QL3=2Ww13sCj4S3i4bNndqF+3+_Vg@mail.gmail.com/ Hi Yosry, Thanks a lot for the info and comments! It's my stupid w/o checking the email list before work on it. Anyway don't know if z3fold would be removed, jut left this tested patchset here if someone need it. > > [2]https://lore.kernel.org/lkml/20230713042037.980211-1-42.hyeyoo@gmail.com/ David had pointed out this to me few weeks ago too. This patchset hasn't updated nearly a year. If Yoo don't object I'd like to pick up from his left and update it to latest zsmalloc.c. Thanks Alex > >> >> For zpdesc(page), z3fold just uses the 5th member zppage_flag, which >> match with page.private. Potentially uses the first member flags for >> headless PG_locked, list_head lru and page.mapping|PAGE_MAPPING_MOVABLE >> for page migration. >> >> This patachset could save 26Kbyetes z3fold.o size, basely saving come >> from the page to folio conversion. >> >> Thanks a lot! >> Alex >> >> Alex Shi (15): >> mm/z3fold: add zpdesc struct and helper and use them in >> z3fold_page_isolate >> mm/z3fold: use zpdesc in z3fold_page_migrate >> mm/z3fold: use zpdesc in z3fold_page_putback >> mm/z3fold: use zpdesc in get/put_z3fold_header funcs >> mm/z3fold: use zpdesc in init_z3fold_page >> mm/z3fold: use zpdesc in free_z3fold_page >> mm/z3fold: convert page to zpdesc in __release_z3fold_page >> mm/z3fold: use zpdesc free_pages_work >> mm/z3fold: use zpdesc in z3fold_compact_page and do_compact_page >> mm/z3fold: use zpdesc in __z3fold_alloc >> mm/z3fold: use zpdesc in z3fold_alloc >> mm/z3fold: use zpdesc in free_z3fold_page and z3fold_free >> mm/z3fold: use zpdesc in z3fold_map/z3fold_unmap >> mm/z3fold: introduce __zpdesc_set_movable >> mm/z3fold: introduce __zpdesc_clear_movable >> >> mm/z3fold.c | 190 +++++++++++++++++++++++++++------------------------- >> mm/zpdesc.h | 87 ++++++++++++++++++++++++ >> 2 files changed, 184 insertions(+), 93 deletions(-) >> create mode 100644 mm/zpdesc.h >> >> -- >> 2.43.0 >> >>