From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24456C4828F for ; Fri, 9 Feb 2024 22:31:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7ED756B0093; Fri, 9 Feb 2024 17:31:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 798C26B0095; Fri, 9 Feb 2024 17:31:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 612936B0098; Fri, 9 Feb 2024 17:31:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 520286B0093 for ; Fri, 9 Feb 2024 17:31:32 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 32BA8A03F1 for ; Fri, 9 Feb 2024 22:31:32 +0000 (UTC) X-FDA: 81773713224.07.3E63964 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id CF28320013 for ; Fri, 9 Feb 2024 22:31:29 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ILbjPq7T; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707517889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o84G0EeXm0vGHwnJrqDjJuR35i6L4PXjF7UAUJUO5no=; b=7iiEdsoBCIAKstvIqZVtW/Gd6iRkpVR4PjeCL20Eb+Pa6QDa0J3Th3Fl5Y+Ow9X+W5C9nG +sB62b/R4plavPbji8zP90SUBGwCtU/Wm+uDF0IkrWV3i8GJ5aPJ0+5wxHdufe4V6Guhh+ tK5OMy9arWRBks/coGpwq3BQffH5y1A= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ILbjPq7T; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707517889; a=rsa-sha256; cv=none; b=mzNQK/iX0qCGT0KBi2cmz7V8XnE6PTCbu9Sihh2kHpg1OR6tUdK4ymJUYRWGILUTdne8dO TefCrV6/8VEualWh40OAuSzwXu/ozdjpp3BNNiEB7SAdOi9QP8vluntZKYBt+jdT/wLLyM lJuKeWw8SqBrThu0DjO8eBYo3N7lrio= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707517888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=o84G0EeXm0vGHwnJrqDjJuR35i6L4PXjF7UAUJUO5no=; b=ILbjPq7T+ucyqkXwoNGiSqoQ77Yk0obbnxblFhLMJoDE7OVUgYppdEl4i7cBTUcqAUe462 Sx2+7u4lf8zQziNkTVoFoJRkRCLx7CDgeRlcTBXXDkF9FB3Vilbkq+G1zQKxDXbVDWus35 kjEcGLDrKTnw+VIUsrCQru1PUt0nmpM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-xvhS2QDyPBOv_AimI8ErXg-1; Fri, 09 Feb 2024 17:31:27 -0500 X-MC-Unique: xvhS2QDyPBOv_AimI8ErXg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4106ab13a7bso6306355e9.2 for ; Fri, 09 Feb 2024 14:31:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707517886; x=1708122686; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o84G0EeXm0vGHwnJrqDjJuR35i6L4PXjF7UAUJUO5no=; b=vM3udV9L19UV+0O0pco3D3BE5jwXeBp3NYmAIoLyO5FVZqOCDG6X8SP83cxVMS+vPe UeWl1KF0SiGAwa24Lv8eFnlN4KS3mvWCNqjByT9mbS321+GDt9JNFJ+YeGjPh67j5wOc qAI5sqTZRMjZjaC1iv87nfOXcL+175ZrkGTUJurvg42idCe/cZV+ie417A/bg4qfwdQM fZUzY5wh+xNySg2DtuW0GY4HR86WECwIJKV95sgEfsw8xCo7gRNwZ7cfaQnT+93odKnc BpydvQ6FASqyfViFvzEddKB2sRe71Ne5BXUeJcvO31UXHO+dZCxsQT7DhWbRxW3BC9Xr N1Vg== X-Forwarded-Encrypted: i=1; AJvYcCVMrepI+JSg+4/c0r9UZ6l44/lEAxPYeiNRIMh0kxHPkVifqgTjyCiBqt4CF079jT/WUuethBFLXq8k6v7mcDi0yyw= X-Gm-Message-State: AOJu0YyqQnshSd0H7IW2O6t7ls1/iK4ybZiYT/KtMVLIBcbhSSKljCk0 EiT6Jd/lxcDFWesVrbpSkwaaKdDeZUCsH+rIWFOgQXUHRONflMz9EzfWxIauabHJs9XmJkLAIlZ yckbC7GeAAGeOzvn6tSwFo3zCeRntA4tAbxKQLCF/yN+vmdFD8oafDhXc X-Received: by 2002:a05:600c:511e:b0:410:6dfb:6f25 with SMTP id o30-20020a05600c511e00b004106dfb6f25mr403444wms.0.1707517886321; Fri, 09 Feb 2024 14:31:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqvvdbZm3iOppsExvwbOrpna0M6WJoI2+u5jFx2mdU8IlBrJ2UWpAXEPWFdUTY4VYs6r1NEg== X-Received: by 2002:a05:600c:511e:b0:410:6dfb:6f25 with SMTP id o30-20020a05600c511e00b004106dfb6f25mr403438wms.0.1707517885959; Fri, 09 Feb 2024 14:31:25 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXCxASgX/kyQYrW21Vn19V46vPe1WbfO3mvHkEC8NUHRjWNCYjfU1KBM5KSkdzZX/SaVNfh+1pFwPED/WHUzBIoN5xTywOAeC/UqhBqDRCI6zkxYQ5+VV3Q1a7FQQwT1vt5X5/kHVQ2dn4SA5PYUqvU+8dXoGRyN7Wok5wYnvf7 Received: from ?IPV6:2003:cb:c718:6800:9d15:2b60:4f57:7998? (p200300cbc71868009d152b604f577998.dip0.t-ipconnect.de. [2003:cb:c718:6800:9d15:2b60:4f57:7998]) by smtp.gmail.com with ESMTPSA id fc9-20020a05600c524900b00410727c315fsm1779066wmb.16.2024.02.09.14.31.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Feb 2024 14:31:25 -0800 (PST) Message-ID: <2e7496af-0988-49fb-9582-bf6a94f08198@redhat.com> Date: Fri, 9 Feb 2024 23:31:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fs/proc/task_mmu: Add display flag for VM_MAYOVERLAY To: Andrew Morton Cc: Anshuman Khandual , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20240208084805.1252337-1-anshuman.khandual@arm.com> <20240208124035.1c96c256d6e8c65f70b18675@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240208124035.1c96c256d6e8c65f70b18675@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CF28320013 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ednfd9rfkcckfkjau86sjy4ijkxigb77 X-HE-Tag: 1707517889-126251 X-HE-Meta: U2FsdGVkX1+6PoOl2BqlwscbC2IYdvsd+mzi2Kn9mMbQl492rzz7S5U/fqJSM41kQhY07sBX2z/Jmld+45uXLgU4nAb6Nngf4jLJtspPVu6xxmfTPGgasrsBDdEDQMa/tSbXQ/p2A0l4GTlt6H+y1vqtZCCxj0fBfvG1UGZelvbdU4GWHQSWG6UiXBeV6XtB0LM8+90dJ8cQAtBAaCDcGskOV0FELNdI+aQGEoa7oYptGvxnLrWKDEmPj8hG1LlzYqgWZb/XvmVtZeu2/VrctIciX2o3REPeid97zccIEB32T/91hRnbUxvvuWuS5NcEME3U8HyCmLP0L2busIqz92ZxYEUgPz1kXzbiXrCYvrQMfIzjWvUq12+DbG3rpfWalGTLC1f+mRQ20/FwARCHYLjMNqVln8XlFtSrKhw3QNDT2Ry85Z8MQZii2mGafXsK1xpjuaDQ1M9rS2Z/RiW/WqkcvNpkcD8wuKRnYwBznKVcfLT/TvygnydDWLoN8sqTjEUimXvO7+myy+YjkKdmaMxqfK/+uuQ6Ajqp2OcbEysVtlrrJFeDYWfUItsFkXIbmPI0RD2WFbpLuAvoNgCSm70XrArqVtBK+h8qNo9fTM8hO8Dx9GksKtqD5OCWqUZPT3PMHcO127Q1kUtPCbSftmHzdxh7YNgrs8a4Elq+GFM8Jq+ZVywesqcJTrADnIEGpsZZCuOly+uhwyLBMgakKE3dBt04kd6HUBPoOTkpWj43TC0Ikyb6h6SclnXttkJM7o5j5zZlsB+J6eoMd1UTFowTkmJ8CNONOnRmaq+ITt+dEbnP4OPYyuS2TEPWekTMmF/hNzLAVPaYdhJNCZOF9Lv3V4L5UViabUln3CqYKJPxCwALnJSBu42v6Kh7ctR8LPTxker3CCxXUhdEutu/CHqRTAvsNTp1AzoFP5DEOAkKRVnXYwTEEZ61zEpNdRQA+iD1mZH/Cz+D51Kf8Mo f8eRMHoS cPKBtq0MHsBQD1sRP5I3ALT+x5GJTP8nz4vWQ/kzOYEzgOPRjtKLxKJ6DPvPBOrXbDub56AKth+MuzrrsE0rIf6aliR7BtBJYptPubqTwk08zuAiaCZPbFV80Fz8FUjVAj3X0+QbYf1sbH3Lsuos+UB2U8ErDH7ifivyHEt30OmK/DZhsNQwCV1hynhuUUCKYmPTr0D944O4J1gPT9AKly+rH2yFhfzsVNmTssZEULKoBecLMBdVRfiUc/t29PCb8wwUqKWC7tqdqHNMSP2wcFVAgO3RKLKi2x61T2NMS3KFpDJrOxrNgOAnYAsyslguCla7kilxLtoS8l4qccXQBy5anCv8gFL3IgAFVhfIzh2gDTbEJiMPA410HamrllwerbGnRXIuMl1XrtTm+p/u/ma1fkw2/5PC0iAIP9DvygN+VXxCswLzWuSZLxXOPcFzfDfcFMZsYj4TYMVpIuXb24adpz8UzEblTWyn7XWj3fxKbpqpuAz+MecVLC1ND+877M/3C7HjwWRtJW86bNsRPEkg8z0HUfsXTY9QQic0cVAh3e6BECMs9TC5KWeu+duJSD4lPhowy9KNM+zOBk8LJ4B1pQYuuXwvEvOAl9LGJju/zpPy3SJTlr/8vPbfFyYY5/1P76vuW3/getXSHCOzR/sRQDJTsS49Wfbr3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.02.24 21:40, Andrew Morton wrote: > On Thu, 8 Feb 2024 17:48:26 +0100 David Hildenbrand wrote: > >> On 08.02.24 09:48, Anshuman Khandual wrote: >>> VM_UFFD_MISSING flag is mutually exclussive with VM_MAYOVERLAY flag as they >>> both use the same bit position i.e 0x00000200 in the vm_flags. Let's update >>> show_smap_vma_flags() to display the correct flags depending on CONFIG_MMU. >>> >>> Cc: Andrew Morton >>> Cc: David Hildenbrand >>> Cc: linux-kernel@vger.kernel.org >>> Cc: linux-fsdevel@vger.kernel.org >>> Signed-off-by: Anshuman Khandual >>> --- >>> This applies on v6.8-rc3 >>> >>> fs/proc/task_mmu.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c >>> index 3f78ebbb795f..1c4eb25cfc17 100644 >>> --- a/fs/proc/task_mmu.c >>> +++ b/fs/proc/task_mmu.c >>> @@ -681,7 +681,11 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma) >>> [ilog2(VM_HUGEPAGE)] = "hg", >>> [ilog2(VM_NOHUGEPAGE)] = "nh", >>> [ilog2(VM_MERGEABLE)] = "mg", >>> +#ifdef CONFIG_MMU >>> [ilog2(VM_UFFD_MISSING)]= "um", >>> +#else >>> + [ilog2(VM_MAYOVERLAY)] = "ov", >>> +#endif /* CONFIG_MMU */ >>> [ilog2(VM_UFFD_WP)] = "uw", >>> #ifdef CONFIG_ARM64_MTE >>> [ilog2(VM_MTE)] = "mt", >> >> Reviewed-by: David Hildenbrand > > I'm thinking > > Fixes: b6b7a8faf05c ("mm/nommu: don't use VM_MAYSHARE for MAP_PRIVATE mappings") > Cc: I'm having a hard time believing that anybody that runs a !MMU kernel would actually care about this bit being exposed as "ov" instead of "uw". So in my thinking, one could even update Documentation/filesystems/proc.rst to just mention that "uw" on !MMU is only used for internal purposes. But now, I actually read what that structure says: "Don't forget to update Documentation/ on changes." So, let's look there: Documentation/filesystems/proc.rst "Note that there is no guarantee that every flag and associated mnemonic will be present in all further kernel releases. Things get changed, the flags may be vanished or the reverse -- new added. Interpretation of their meaning might change in future as well. So each consumer of these flags has to follow each specific kernel version for the exact semantic. This file is only present if the CONFIG_MMU kernel configuration option is enabled." And in fact $ git grep MMU fs/proc/Makefile fs/proc/Makefile:proc-$(CONFIG_MMU) := task_mmu.o So I rewoke my RB, this patch should be dropped and was never even tested unless I am missing something important. -- Cheers, David / dhildenb