From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C98C9D711D6 for ; Wed, 20 Nov 2024 18:22:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A1CF6B009A; Wed, 20 Nov 2024 13:22:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 551676B00A0; Wed, 20 Nov 2024 13:22:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4671B6B00A1; Wed, 20 Nov 2024 13:22:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 27CE36B009A for ; Wed, 20 Nov 2024 13:22:47 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9F7DE1A0F88 for ; Wed, 20 Nov 2024 18:22:46 +0000 (UTC) X-FDA: 82807292358.25.86E0855 Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf10.hostedemail.com (Postfix) with ESMTP id 081CDC0005 for ; Wed, 20 Nov 2024 18:22:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b="kP6se4X/"; spf=pass (imf10.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732126903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sdW1ywqzef0DiPcYn4D+cJXKXJdd8fJAVTgMxJQcrok=; b=3/GFlTkQ2JybE8ituRWaiPuw0RGIDsibXif97A2x/2vMv5azWVE9Buk9rG2hzG2DV6TOTQ 5s3VlH/ci9int4JbMCOTHzOwAsEawaxyW1EQrdCH8YGBxUoK86204wkE89qy6rrHz9Bvv4 2h1k51hQ/PXDSNw8/wjh//Wz7nsSJb4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732126903; a=rsa-sha256; cv=none; b=ccSRob5zjS1sf0nRNChbCXC9d3HnkBnAj8m4r86wZcnXHelS2Qz30bXc01xxOh7tZW9Wdj VpJCMClWODdsMxOBHYiHON/nTDDAn+4Tu9r7hsNxnjKZXXYlsJxmobb7xurWHEzBQEe6U6 i0BOpYuyZ9aGv0zhWaCn87ZgK8AIiok= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b="kP6se4X/"; spf=pass (imf10.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1732125047; bh=sdW1ywqzef0DiPcYn4D+cJXKXJdd8fJAVTgMxJQcrok=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=kP6se4X/MYCnWvDfI3TBNLuGUC0edJq/nYQAEvTwAxtQOOEXff8ECn4CNZ4tXvSDY 1e9yiTxjsq9nVY4YzrGh46I+1gi/MHw5FrC7LM4ZUxJzDPPX/Xz0q/iLRD844O3jc7 sNfWtNhYjQjhIMmav/JFtu13pDSeya9rbWlRgh2s= Received: by gentwo.org (Postfix, from userid 1003) id 650B1401F3; Wed, 20 Nov 2024 09:50:47 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 62C9C401F0; Wed, 20 Nov 2024 09:50:47 -0800 (PST) Date: Wed, 20 Nov 2024 09:50:47 -0800 (PST) From: "Christoph Lameter (Ampere)" To: Vlastimil Babka cc: Geert Uytterhoeven , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jens Axboe , Pavel Begunkov , Mike Rapoport , Christian Brauner , Guenter Roeck , Kees Cook , Jann Horn , linux-mm@kvack.org, io-uring@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] slab: Fix too strict alignment check in create_cache() In-Reply-To: <4f70f8d3-4ba5-43dc-af1c-f8e207d27e9f@suse.cz> Message-ID: <2e704ffc-2e79-27f7-159e-8fe167d5a450@gentwo.org> References: <80c767a5d5927c099aea5178fbf2c897b459fa90.1732106544.git.geert@linux-m68k.org> <4f70f8d3-4ba5-43dc-af1c-f8e207d27e9f@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: kimycf11w4hyuk8utpbpqe8mh5ggwjoi X-Rspam-User: X-Rspamd-Queue-Id: 081CDC0005 X-Rspamd-Server: rspam02 X-HE-Tag: 1732126941-413319 X-HE-Meta: U2FsdGVkX1+sptbkiF0YPW5iAdYaCXqY7tEApGfTmBhR+uId4t0CP33FMGLsndyKeDF+/bRREq0lY7+lPxe/xKkjZ1Go/uEZLX3ogfMFfr3uWNDXDZh66tvhjBpGH8BhKETh74kOpiJ17jS9Rt66X+EK/qRLPYMuGuJh3U/U53erRNVKXFLN4N3E0HsCpIJpEzeIsjtToBcD+Q8Opnfdvv0rFnRoFQ6bA35DokYMQPPRk1vdqHjo8wF7FMGn6mCeSuf7RtL2161wmvtVJnnIa5ixT7cd6lTZ5WOLSsqNbX56+WHUk1PdgUhyjgEA0GkBtUm5aJSkh70xtHNFEjU6HKFtargx6LL9P24kXWeb2LSCsjHwPzFicBCHZZyWP4RUKN+XfbGyutwIyoSwigWXfcCaC59FFqM/stA90JLzwT1jn3HHw83g3/ynpqNvelGhILdVbsjpsGuaPJgNpMgyUs4XA4X+4KwyFk2jJHhE301SOuj4ZOpbJcRr37ikMKuZyXNBA0D6IlFI4i/3Y4SYGdD/I+4tAIx3JuLwLcMH1KJqDTbAvYF1Cn/ld3Qtne4PiHJZNpSbx+aP8vxebNKRDm5ZcnH3F9Yc6CjGvtqPdinxyA7ZO34lfiiTYMUtx/oQQWYcQYuToO7I2ny8inZQvrlFqSelARVCHXb8e46PVxJ6UEagsRhD8dJb2Gf6vSoN/UWwktsy4gLEIdsYMgbnxYRdwf6+EVvmRUlnE5yrnFD8tsLLDNyWPWVE7+QqhRaUG0mIQkCDzG8qSwAo7BVB1Xo0StonTPl/K75c2IhtYK1AFdSKLgqxWCBX77t8QaZBf8O8Vx3i1K0dLz2LN9i89RFTWY+poZrlJTzdK55prx7QoFI95c/8609QIckYq4+XPaQmdiKR0ifasjXrpEZzbCc/0VNcBupIUrZGI23Yu1fUsT+mkrRqwA/VzCOoS4tDbmABD+MIbHhX25IkUOz Mj89dLCa Sq+RNbuQceuz3eguWAJLY1rWwMIAh3o5P724sduupw872r7K7TxHHz9xn2S5f2JubZ3aGeKgI4Sk8AzrZVF+XyyJ5B+oOpnWuxe2J+0cW3jxatlZMeQWKPHH5+0zRnQxyQ6DcvrHHcFo5u3+tUpUdCjK/8l792N3/i40fnWJFaMBEk6HWy2MD6RjfiKFQaSyORGH3HkwhTORQEgZF4I0lCNXjN/5K79T3x45NUXhSdXJLIzckIe2CRNQhwGbJTpvAxanR3c/W6nTI5ecXVRS9zYHRzpWaNGmxgBqZJXWxyrdcrERDHIXMRmd8+Gp7b9F0jYu7bZcKz/aZnXuFNQTrrHy6aaV17+6mavFA/kuPkkM+1GmU06o7uzKO622gzBeyqxdcCSU10VWnHRuVZzhW/lLLd9l99P7IDeOVbJXvQF1y9O2T6aCHd+nff8lyHybe/skrWDe6+EEJiPo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 20 Nov 2024, Vlastimil Babka wrote: > > > > Fixes: aaa736b186239b7d ("io_uring: specify freeptr usage for SLAB_TYPESAFE_BY_RCU io_kiocb cache") > > Fixes: d345bd2e9834e2da ("mm: add kmem_cache_create_rcu()") > > Reported-by: Guenter Roeck > > Closes: https://lore.kernel.org/37c588d4-2c32-4aad-a19e-642961f200d7@roeck-us.net > > Signed-off-by: Geert Uytterhoeven > > Thanks, will add it to slab pull for 6.13. Note that there are widespread assumptions in kernel code that the alignment of scalars is the "natural alignment". Other portions of the kernel may break. The compiler actually goes along with this?? How do you deal with torn reads/writes in such a scenario? Is this UP only?