From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 087BEC4332F for ; Thu, 14 Dec 2023 11:54:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 688A38D00AB; Thu, 14 Dec 2023 06:54:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 639778D00A2; Thu, 14 Dec 2023 06:54:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 500DC8D00AB; Thu, 14 Dec 2023 06:54:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 39CD78D00A2 for ; Thu, 14 Dec 2023 06:54:00 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D4A88160445 for ; Thu, 14 Dec 2023 11:53:59 +0000 (UTC) X-FDA: 81565264998.22.42416FD Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf19.hostedemail.com (Postfix) with ESMTP id DFAED1A000A for ; Thu, 14 Dec 2023 11:53:57 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702554838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZgIgEGkNoToPX8sQzY6I1Az767/3Ita1HHAYtqLNkAA=; b=rDqD36c4EyvEi9JZ7JoFvFUiwOyQXNUNH4nO04O5qkUC7jhWNzAg5TOgUWopkO2JZv71UW frHkb9u1J7PSyHvJiWkedGddW41LMshJ+OmevbUe/8juSfA/KqsmdYtTwHSUERNgSzZwII p2VgtSB0w61C+3XSRW04wwG7A52CgxU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702554838; a=rsa-sha256; cv=none; b=4YKY5HMiAKnQHb5tGxVhRBXUBTx1Gaoc5HxdvjXgID8PKis+/qIN34bAP6Cj4HcCx1GXxY iGDjwNNIUnyq2ObyZ+2muW6mc0fX8DeFkl6WrIBeecFxKfiV0OBuHiC+8undMJ5hlGs+mc Js6Gh2MfFVbtLdWN8IzHxwpdNz6GPAc= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F719C15; Thu, 14 Dec 2023 03:54:42 -0800 (PST) Received: from [10.1.38.142] (XHFQ2J9959.cambridge.arm.com [10.1.38.142]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 795493F738; Thu, 14 Dec 2023 03:53:53 -0800 (PST) Message-ID: <2e6f06d3-6c8e-4b44-b6f2-e55bd5be83d6@arm.com> Date: Thu, 14 Dec 2023 11:53:52 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/15] arm64/mm: Split __flush_tlb_range() to elide trailing DSB Content-Language: en-GB From: Ryan Roberts To: Will Deacon Cc: Catalin Marinas , Ard Biesheuvel , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Anshuman Khandual , Matthew Wilcox , Yu Zhao , Mark Rutland , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20231204105440.61448-1-ryan.roberts@arm.com> <20231204105440.61448-13-ryan.roberts@arm.com> <20231212113517.GA28857@willie-the-truck> <0969c413-bf40-4c46-9f1e-a92101ff2d2e@arm.com> In-Reply-To: <0969c413-bf40-4c46-9f1e-a92101ff2d2e@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: aawhk74any89iqxdnp1brn8o6uw5rx4d X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DFAED1A000A X-HE-Tag: 1702554837-889279 X-HE-Meta: U2FsdGVkX1+RVPTarVXyP64nOYtAnAne+aYhoo77WWGLGmTRoA00cr+i9BwZrUOB0jO1Ayw0a9H8zvY5kWh4wkRrfRyqdtYEzhuMQq9zMBfriMHMkk4AUsT3AfMAGUiYGaTkq2E8k6AF6kx7T3g0Dl8NAi32Co8BpEinD+mjc9/qI4P5LLEGCfsaZjlw+gJ8cGNvEs3E1T8v7ojmsBkQsJ2ifNUsIXSiG2eQ0EIMA11EzUoAMZOLkHEfxv8ECElB8unMUx7zUvBFbIITMgMWrGYlyTTGY2cQ6NE5xjwCXc3+toP8mY+EmBE4jVKaN4RKvdXIJ1LmroB/Utreg4Khf2P7ehrRqeY50O3mEpm6oWmpbl4NaN3DbBykN9Kb26owlCivCPksddgS1HeJ2Nb9hAkMdmZuhnYVLtJQ5repxTW4y62Sg02nBxfi2aU9OR64Ap8b5hZM/I038jxClKYlPtXF9+x4vunS/XIY6z2fLz7JYqkENm1r3ZEbi884HynqmMyFej+0yA7UkaSUnxyyPbskuXjtb9ynUclVDyUPy8qXmYJrweJ53CmUG1lHdT+J3yQkGUa9v2evkvHf0hHuD5+wOnX+J9ePP/3nj86iebhrdXM2+jgJLOwE2cRsgVNCUr7qtpuCre6lHFnYSTRC/1V6fgRrVkKyAA1zvvNxQIsVaG4SYmOp5MIbCUFSnnvzyW1Zd6ALsQB7+SNpboAYlLb2c4ELjnwoL3JNIaW31CgO5x/1kXIOhkQ6O68lpdQqMHVygLka6zOFMC2FCJdvANu+tisebytKfmm1f7tjDEJRRz3AAStMFKwvCKtzd52CkD6nMNAt7yXwMohkLSJLTt/+UlXAokgLMB5SHLcVP5PSDZgpDbK/5kkrQJL3P+D+WBvcwAlNCOrXmWBZscsG+VJaWxD74SWBLbWyHpsGNOaFG2hgLQoPiZ6N/K+GW9Ro63jAu4cieaXO5XAMmFL aUk2WOo+ GbecmK4O2TTgp8K3a5jhycLQtJtFNISbiwBHIejySApIC3cCcYz6E3zywrMU7YJ+b4tMlz2Q8Pj05913fSikq740Xk0upu6pvyfyFCF7X8NoXhbexQytVXk6uFyRutmtYnB7D3fE0rdZaLCenZJ68Iv3hbCmYmVYQNPna5FRgeGLoUIiV2ZpA+hBE1TWeF9e1WxHAlDw1u1lVwdFBPF5FnRXExxH3P6y1GFBxKrOZ7udhPYwvIBWbsd72nf5T/kyj14+H/15J3PKu/abY+PKAZ+OUxPjR68gcwS5izYcsCnur9uwMaqeZTeYnVVKLqAS2AwCHeG4aGMkn9do= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Will, On 12/12/2023 11:47, Ryan Roberts wrote: > On 12/12/2023 11:35, Will Deacon wrote: >> On Mon, Dec 04, 2023 at 10:54:37AM +0000, Ryan Roberts wrote: >>> Split __flush_tlb_range() into __flush_tlb_range_nosync() + >>> __flush_tlb_range(), in the same way as the existing flush_tlb_page() >>> arrangement. This allows calling __flush_tlb_range_nosync() to elide the >>> trailing DSB. Forthcoming "contpte" code will take advantage of this >>> when clearing the young bit from a contiguous range of ptes. >>> >>> Signed-off-by: Ryan Roberts >>> --- >>> arch/arm64/include/asm/tlbflush.h | 13 +++++++++++-- >>> 1 file changed, 11 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h >>> index bb2c2833a987..925ef3bdf9ed 100644 >>> --- a/arch/arm64/include/asm/tlbflush.h >>> +++ b/arch/arm64/include/asm/tlbflush.h >>> @@ -399,7 +399,7 @@ do { \ >>> #define __flush_s2_tlb_range_op(op, start, pages, stride, tlb_level) \ >>> __flush_tlb_range_op(op, start, pages, stride, 0, tlb_level, false) >>> >>> -static inline void __flush_tlb_range(struct vm_area_struct *vma, >>> +static inline void __flush_tlb_range_nosync(struct vm_area_struct *vma, >>> unsigned long start, unsigned long end, >>> unsigned long stride, bool last_level, >>> int tlb_level) >>> @@ -431,10 +431,19 @@ static inline void __flush_tlb_range(struct vm_area_struct *vma, >>> else >>> __flush_tlb_range_op(vae1is, start, pages, stride, asid, tlb_level, true); >>> >>> - dsb(ish); >>> mmu_notifier_arch_invalidate_secondary_tlbs(vma->vm_mm, start, end); >>> } >>> >>> +static inline void __flush_tlb_range(struct vm_area_struct *vma, >>> + unsigned long start, unsigned long end, >>> + unsigned long stride, bool last_level, >>> + int tlb_level) >>> +{ >>> + __flush_tlb_range_nosync(vma, start, end, stride, >>> + last_level, tlb_level); >>> + dsb(ish); >>> +} >> >> Hmm, are you sure it's safe to defer the DSB until after the secondary TLB >> invalidation? It will have a subtle effect on e.g. an SMMU participating >> in broadcast TLB maintenance, because now the ATC will be invalidated >> before completion of the TLB invalidation and it's not obviously safe to me. > > I'll be honest; I don't know that it's safe. The notifier calls turned up during > a rebase and I stared at it for a while, before eventually concluding that I > should just follow the existing pattern in __flush_tlb_page_nosync(): That one > calls the mmu notifier without the dsb, then flush_tlb_page() does the dsb > after. So I assumed it was safe. > > If you think it's not safe, I guess there is a bug to fix in > __flush_tlb_page_nosync()? Did you have an opinion on this? I'm just putting together a v4 of this series, and I'll remove this optimization if you think it's unsound. But in that case, I guess we have an existing bug to fix too? Thanks, Ryan > > > >> >> Will >