From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F08C5E64A8F for ; Tue, 3 Dec 2024 13:31:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C6416B0089; Tue, 3 Dec 2024 08:31:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 876306B008A; Tue, 3 Dec 2024 08:31:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73DB66B008C; Tue, 3 Dec 2024 08:31:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 554136B0089 for ; Tue, 3 Dec 2024 08:31:10 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 40F16120998 for ; Tue, 3 Dec 2024 13:31:09 +0000 (UTC) X-FDA: 82853733312.13.1D2EF07 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 68F0D40034 for ; Tue, 3 Dec 2024 13:30:51 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733232661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=21Tj0Vtrl++WyZ6wV5+oyun0i/cIREtxJghpq0bEQk0=; b=SMn+BgM13e3/BHAnQ57JZ9kk7FN31YQ/9RiC9wNulRuZJESvXA3pTDvYJ8I6NjbfKBE6DI 3ns1dqUOHFA/WaD77KtbcNwuqrVujNb0tQoSP5T9pT0Qmg+W2+jAsCs/82ADwmSvLXYgvG TUc7L2cgmGBJah4zj5c4scPtCjLnUoI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733232661; a=rsa-sha256; cv=none; b=DYlKxCoLPH/ZZB4ni587gRSrpIYUAQvn8uP6ZB9EF8mJDmN6opZB8bKNU1WN6qHe2CIQGg gh/yT+MgXy4vTrL4N7QLBrH7Vt4SN8LXFCZ6iZd+QcFmU+C4OXalWf96Q9dJrzp8oyD/8r 6BDkN9xP/K0oxSaU8DHF8mgMKlgQojQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 93A0D1F445; Tue, 3 Dec 2024 13:31:03 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 781F513A15; Tue, 3 Dec 2024 13:31:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HGbLHBcIT2cYIQAAD6G6ig (envelope-from ); Tue, 03 Dec 2024 13:31:03 +0000 Message-ID: <2e66a245-30d3-4765-95df-13d300de5d13@suse.cz> Date: Tue, 3 Dec 2024 14:31:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v2 1/6] mm/page_isolation: don't pass gfp flags to isolate_single_pageblock() Content-Language: en-US To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , Oscar Salvador , Zi Yan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan References: <20241203094732.200195-1-david@redhat.com> <20241203094732.200195-2-david@redhat.com> From: Vlastimil Babka In-Reply-To: <20241203094732.200195-2-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Queue-Id: 68F0D40034 X-Stat-Signature: aidzwxr5gmfdz47rdoo5pz116535t1pi X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733232651-272696 X-HE-Meta: U2FsdGVkX19bPlgObbsH95kmojraX8h4sdK/bPYs6/d7HHpHEvwrdaXnwaNiV2fWDZCT/0UfZAVuEuT0PUi6fPfoG0IuSj3p9EYCTF/cZ8a7RgpmrnZo/7qpSpaNXrn55m0fn9XImmejd+QaD1PCFORkoemYUu18WTYWBdRYEsytH5C+NomdQFEdQbfq0aD5UPQ4IASw7SMdSRjyVAQSlJWWHGpMiFNRLdwWIQVpLH8mkPwKoAuZFzV+5lxXsG05gSAHb4Mm7l2HxhiZjscRemxi4p1hkdpZrajeVLEGnvjqlfgmgekhJUjz0t7TXhgBU80ZqK8eEzH88GFdOMVvtkwt/IYr/hZdrQ34UCN2r+bdcY/UrEfYSyMLiY2M0WrVhSLxBHgDU902I74EZ45aOkr0jIz6kFaK1muiRn29CBQ3W9+TaytyEHH4ij28hfFWllCcshKSx1rsucH8k726S4CwhQlDn6aO6/KqkGFgMBvekyFHdlmglFPyXG29M+3aT6M1exESyn47AvURfd2M0nZQSaupwULqGPHHdAbv+6QAGvEMRplXyB49JCDt1YvCEuEvcMwvqHfUJ1OVC/+UZ/DeVSh6mlGLgTvxNc8xBj5KC2Kb+xDqiC6v4efDqty5o700gynXah7N2VS+2RYjHbccaGaKqW1untTvLMkdPg9+OvFj67DtVxksqXoBUjVvqYsBKiYGR38g4kAbCy9SItbHsYQGlxyrHFHYMEhpWlCmEiwrH7heXmJHgn0oSNHKhNMW6aqJKVqQnQg8Xvo93y3PBOdSL7eyOk6nRpbg3m0pW9ZJlwGxpCU7WddUH9zV0vfCVgytV8dgTay90cCVpb673BPCm6367xpaEZnxWh7NTWmUj1x9VLbNcokKRCR/VfxV9GBq54GkAz4o18QbFJjgYh2xpROu0oZrijtJxMu9q7uh3/UbH0px9uudaAg2r2S5Jkr3xGkbBFgxBKA ny9otb+z k+zaSOwoA0UuQgJ35ljLByhPZsmQ7w/WLWZwIIgdSUmGF3N01ZtFOSXyckIbD9ylPUZcvqftp35qdMrH/2atb2QgmuDhiKgs7QQ+vcJjwuTwiUseU6oVNbDnKR06/7XSLAhrzIk7o2jqJcjyjVjih478YjrM4LwbF4XUN7o1RIAJjXJbUfQ/4t3Da021bj96LCh0xtCSl4/os8FduBMxbyX3Gxme4gI5UWBceZn3+CyQz7Cc04a3V9pcXtQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/3/24 10:47, David Hildenbrand wrote: > The flags are no longer used, we can stop passing them to > isolate_single_pageblock(). > > Reviewed-by: Zi Yan > Signed-off-by: David Hildenbrand Reviewed-by: Vlastimil Babka > --- > mm/page_isolation.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 7e04047977cf..e680d40d96de 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -286,7 +286,6 @@ __first_valid_page(unsigned long pfn, unsigned long nr_pages) > * within a free or in-use page. > * @boundary_pfn: pageblock-aligned pfn that a page might cross > * @flags: isolation flags > - * @gfp_flags: GFP flags used for migrating pages > * @isolate_before: isolate the pageblock before the boundary_pfn > * @skip_isolation: the flag to skip the pageblock isolation in second > * isolate_single_pageblock() > @@ -306,8 +305,7 @@ __first_valid_page(unsigned long pfn, unsigned long nr_pages) > * the in-use page then splitting the free page. > */ > static int isolate_single_pageblock(unsigned long boundary_pfn, int flags, > - gfp_t gfp_flags, bool isolate_before, bool skip_isolation, > - int migratetype) > + bool isolate_before, bool skip_isolation, int migratetype) > { > unsigned long start_pfn; > unsigned long isolate_pageblock; > @@ -489,7 +487,7 @@ int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, > bool skip_isolation = false; > > /* isolate [isolate_start, isolate_start + pageblock_nr_pages) pageblock */ > - ret = isolate_single_pageblock(isolate_start, flags, gfp_flags, false, > + ret = isolate_single_pageblock(isolate_start, flags, false, > skip_isolation, migratetype); > if (ret) > return ret; > @@ -498,7 +496,7 @@ int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, > skip_isolation = true; > > /* isolate [isolate_end - pageblock_nr_pages, isolate_end) pageblock */ > - ret = isolate_single_pageblock(isolate_end, flags, gfp_flags, true, > + ret = isolate_single_pageblock(isolate_end, flags, true, > skip_isolation, migratetype); > if (ret) { > unset_migratetype_isolate(pfn_to_page(isolate_start), migratetype);