From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DABBC47258 for ; Fri, 2 Feb 2024 08:13:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 994816B00B8; Fri, 2 Feb 2024 03:13:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 945F76B00B9; Fri, 2 Feb 2024 03:13:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80C346B00BA; Fri, 2 Feb 2024 03:13:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 70C076B00B8 for ; Fri, 2 Feb 2024 03:13:22 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 50FCC1C11F3 for ; Fri, 2 Feb 2024 08:13:22 +0000 (UTC) X-FDA: 81746149044.16.402AB7C Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf06.hostedemail.com (Postfix) with ESMTP id 61CA318000D for ; Fri, 2 Feb 2024 08:13:20 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=ZKXuhu2P; spf=pass (imf06.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706861600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MJTlS+Zx0kwsewgmgXrZQpo393YaXW30zOMs0OgwhUg=; b=OV+uVRLIZY9w1SS3iSpQIFJ4Rhsu2uBZ3PI9pDbDoZqGUZK7tJD5R3u94c+bIrK+2h6FxE lMLV+fPtF1+8LvyjMFc87EuOloU/oESN43ccQUsuGUcvvBjl1tfwQcW5XJzqjHY3EwhLhi S3iXPNZxV44STBPQ0d2CHM5cLlVm4J4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706861600; a=rsa-sha256; cv=none; b=stUUXH7hSpwm1ADgKG+zp4klsLvha4UayJP59jfi7MKU+7DhDN1Vsw3+rCpzHm4v9FP38H W8vU+fgf5Inzigeq+Mj3NKyRU0PTz8+5yooY7ytj6DonOxrWfmJz+6q4P8k8qKRPuRVRft GnpbEUgzIjHKm27aNczSJ9+kjEkah3A= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=ZKXuhu2P; spf=pass (imf06.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1d8e7df6abcso17063635ad.1 for ; Fri, 02 Feb 2024 00:13:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1706861599; x=1707466399; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MJTlS+Zx0kwsewgmgXrZQpo393YaXW30zOMs0OgwhUg=; b=ZKXuhu2PQrWidPkcU1Zn0tmo4gBn+sBeljjb+YABkPF5/3vV8oO1aXZVU7C4X8SpdC pygap+HtO00vOueem2wkYNlWhUfP6Hlfd6LLcazrI3Uv/VtYWevpPEeYBaTYrQE9OsD1 ljzCpTukiljTc51tfAn3t+9jFBuP2mq3YWK6FG1zhg3acsJFKyoEBHC0E0zstdAhmJTY ZhBzf1+tAkvyNpNOs/Tw+MBRoGsVVxUQFCl7nZojnSAgbZaMI15NE+/zY77/siwZj95d ocD6rLa5MdsxQdLt4qDjl+V5JsyIpyXqUBWohZ4J93R8BJiuivtUF41zqXg8GO9RNc5M SamQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706861599; x=1707466399; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MJTlS+Zx0kwsewgmgXrZQpo393YaXW30zOMs0OgwhUg=; b=mpmBkHf+g3n9sxtCxjabU5zDbT2i3U2VYjUkAjJTy+61m/9/wyQ4uk/BeI0MyASOZB TBhrScT7d6diBWjxQebbnG0V1KGzbWf3uTM+rPo7haEauIjMZZawGM01v/wX0sKBLVbN sa+uStDXcvK89mMLcfcdbHfM4YeDrx5c8thXjbFql8H82e4oeJsmit1iJVcpCkMOXQ6e 1g9xPPx2NQHo45uOdP5eJLgC1hWEPd6I+qhvheV+4p35fFZ4s4yckEInc+XXQFrlpZAF pfA8f9aXJ1gEBhI+GXqnDl5CWdb24eQ8z+KQu4KA02q/GP1HAX32esgV5qYV1oMhAu6m bpFQ== X-Gm-Message-State: AOJu0Yy5OvGhyh6shHUonnGf4FI4ZTHshqEZidUzHhIDXNeFGdUKaYA3 2FD+LuZnBKHm5J8sC4s6MCo6vONfj74kItps31xycv27VVOYVAStDo7t2ucNNsy0O3iDFv/x2JQ h X-Google-Smtp-Source: AGHT+IH08/09Sp52XGUFjNivGPPEyv/hiWdujauxR1oqe84/ZQppsHPur7+KvUDNmZvNJzgFOt+V5w== X-Received: by 2002:a05:6358:5bd0:b0:178:756b:6bcb with SMTP id i16-20020a0563585bd000b00178756b6bcbmr1546836rwf.27.1706861578474; Fri, 02 Feb 2024 00:12:58 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWTDogFDZ7mGbhV1qKTMQGCQyeUhQ/bD4WNRszgYLEfg8aXwVdDANZ1/oHSiIXIgcESI809ivm70xcOC5bWQA0ckgEiewI+n57jCLBNhFVwVAHnxNK7x6clqT9/UZdRVPDdclCfaSOzaIHMdcEl/TnaaOm/EIcnFbhDbwwuuZMKrq3HqoVqeSfgMkH4nRPFLA== Received: from [10.84.152.222] ([203.208.167.154]) by smtp.gmail.com with ESMTPSA id k15-20020a63d10f000000b0059b2316be86sm1049563pgg.46.2024.02.02.00.12.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Feb 2024 00:12:58 -0800 (PST) Message-ID: <2e6547c6-1bdd-4e27-a573-b866eb8bb305@bytedance.com> Date: Fri, 2 Feb 2024 16:12:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] mm/zswap: stop lru list shrinking when encounter warm region Content-Language: en-US To: Yosry Ahmed Cc: Nhat Pham , Johannes Weiner , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240201-b4-zswap-invalidate-entry-v1-0-56ed496b6e55@bytedance.com> <20240201-b4-zswap-invalidate-entry-v1-3-56ed496b6e55@bytedance.com> From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 61CA318000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: sr3q4bn5kmxcsors8sfddeb9de5bimxh X-HE-Tag: 1706861600-451801 X-HE-Meta: U2FsdGVkX1+jmOfM6jFrNa7M93oelGJTYCd53RLACpxRUlmv7wzxGJHJI/nTc+SlV/SjRbPvhhqty4ECJTg2r3Nm69GzYHTwh16QMg0TDsMMPmXBCMhgj1KCcw7SmuTtVA4nUW2DCCQ0OBmr06nB303EkZhcr8dBj6iLwuUqVmTxE7qm0KB6F0koaB9D5mJe7EqviBdZ5jEe1BysKOv+ph8GNu/a7OKmuVebZFKGCQH/zmsGDjk1rrSU17/+7ktE2kgpNxaHB+TmQI4Dmehb5KKaaFFlhE7utCbniH0EvXVFHFbQylwQKuSZv6lqgyIY/Y/0myE5a6Mame2SFrKdxQcffvRY74jnNYDgWA427anT+Y0x/R3mfiNfLsr9/8Hli8SwsQikcHmMJ/pfNUgeIqt1MmjBIbmxQS1sJFWsf8T47ne/yxXd8FNjp66WrM0L1V/yAlll0CkppUr/WaZtx65YWDYHpgAbA1VK+odYcms+YmdzK0SljarzNbh8nSq/sMu3+xyJTfNHANHHgsa03RinwmvnTEvWF+mYyGi+98u3aD9L4h/bFdtnbpYjYQgi1WG15/QpIZlK4MrO9Imil7OFjQC11O/KZZb0UmAS/3zgQZdpjd+M5PSq/AWfloDtpNWcXVBgqvsSwst92SUr+/E0SOYq4OO5TyOOIpUKdLueh+9YnCuscx7k3KK3PMPnzU5VwXwr43WoINa1cMCPEY3T3wp6trz8THpwECjMuY9dhf51ijXoGjsMzjTtnZG4el7sL4ktr49FhwqvODtgmSpwcF8STEGoOnqKPBO8qR7SV8gUG7uiLpocs3NdByAoBTOYwG4VG6piWRE5nH6vcQB2oNliS/pW2I70YuPHvtZ6Co7H3tlA3pi54F+pfrAMMvrKOEQQIcKIOeFWfj9lc0PzINop6l6pC6t3GOGRYezLrHMKP8DrGQNZfzX139+DvNCkkWHMwtH5mn70aLX 1j5tS8eo TD5usoIOpSG1gycxHRDFf0zZq6ItAZVQEeRJbRmxaG/HjAlBhKK3d8TZfWKAOTQgcLB2ibgvQso35qvnedDHonFaPMfMBnzEW1ndD0FUGcjilpANk3Y7TeZ5wmGJSqXRpm4ZmIdn0rNHF6GRcY20UD+8eT9HTH8WU6GJKOEqAOxBPSWlxyOrq4AzxRb+5ZMqBZbLKLfR58qXUDe5PEtyeToAIVIN9ifgc95yXXf61OsD4aFStwSZ4Jt65HM4XbGBfJ7KlHJK9tDSK0RSbcDQp8t/Jev6aSM9dkXHEsebdauXZo91FFY+oGfN5awy+Zao7fVarRWpWQXC4WMJNlFidjHCyfFQ7EvBbGil0it3Dsx5xkEilJ2L/JLtqq7CyFcocgf+wQL6upXxXS/hiuUAb1q9W2ohO/ZClNIO5tSJuSxTIqVv7gSwaxcm4tp96ng7Kex38NqZTwky7qmdQkS8E5b1lTFn9ZO5JAvGmWNoTrnfLf7Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/2 08:15, Yosry Ahmed wrote: > On Thu, Feb 01, 2024 at 03:49:03PM +0000, Chengming Zhou wrote: >> When the shrinker encounter an existing folio in swap cache, it means >> we are shrinking into the warmer region. We should terminate shrinking >> if we're in the dynamic shrinker context. >> >> This patch add LRU_STOP to support this, to avoid overshrinking. >> >> Signed-off-by: Chengming Zhou > > LGTM with one comment below. > > Reviewed-by: Yosry Ahmed > >> --- >> include/linux/list_lru.h | 1 + >> mm/list_lru.c | 3 +++ >> mm/zswap.c | 4 +++- >> 3 files changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/list_lru.h b/include/linux/list_lru.h >> index f2882a820690..5633e970144b 100644 >> --- a/include/linux/list_lru.h >> +++ b/include/linux/list_lru.h >> @@ -24,6 +24,7 @@ enum lru_status { >> LRU_SKIP, /* item cannot be locked, skip */ >> LRU_RETRY, /* item not freeable. May drop the lock >> internally, but has to return locked. */ >> + LRU_STOP, /* stop lru list walking */ > > nit: Should we add "May drop the lock internally, but has to return > locked" like LRU_RETRY and LRU_REMOVED_RETRY? Right, will add. Thanks.