From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4738FC71136 for ; Thu, 12 Jun 2025 15:48:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBCA56B0093; Thu, 12 Jun 2025 11:48:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D93E56B0095; Thu, 12 Jun 2025 11:48:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5CAB6B0096; Thu, 12 Jun 2025 11:48:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A5C806B0093 for ; Thu, 12 Jun 2025 11:48:17 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 55FBC1618D2 for ; Thu, 12 Jun 2025 15:48:17 +0000 (UTC) X-FDA: 83547180234.25.F13C3DF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 91F22100009 for ; Thu, 12 Jun 2025 15:48:14 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bZgLQcPc; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749743294; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ei/d28RGKwbGgo0BkY8L/1pu6a5ZV2mA8pg90GSA4I0=; b=M9QpjowNc1fa1HrbhGiAJo8+6bnnZhOvKCSd//0pKiRAAL0T+RGAYCmIYW5+gNmFaPP8yt dv+KJY7HrFkbBygYzM2mMKnpS6YD8mLEMvEnLSk0cYtibn1dPw5Nfqdqm6e097TSylF+/k oZTe/p0wDK36zkZd3rMTr4wBslgceK0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bZgLQcPc; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749743294; a=rsa-sha256; cv=none; b=Poi/OoIfHaf4wKHFtVGMspPByWLyZwY26e+C9fLmTVam+VdvDfBLBtaFiozzkHPpCPJOF0 AqnMHGN3LTYYYeCYlIJcpSfN00X8KFTSWv9WGJvh/sY/I6pSLX0T2VJGsF/uPFlk6oqRh2 xzov5NagvM1xjrG8bm/cJOAR4slM4/Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749743293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ei/d28RGKwbGgo0BkY8L/1pu6a5ZV2mA8pg90GSA4I0=; b=bZgLQcPc55trnVrGKdzc11fEwCmqDPe2OvndNQ+vYEaeUcqZRsAvr4el+JwJT0v9tgj4EV dLFApZx8+PTIDR1BOhGZv91uHwTYv3AoKH4vDxGYXaOR/8TlqkX08W5Mcy34rmnBBupmkR QeOX01hdaD/GNMLq1xryiq3CHGOwFsg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-231-YrGgdRHJNAeoVwEkHOLxoQ-1; Thu, 12 Jun 2025 11:48:12 -0400 X-MC-Unique: YrGgdRHJNAeoVwEkHOLxoQ-1 X-Mimecast-MFC-AGG-ID: YrGgdRHJNAeoVwEkHOLxoQ_1749743291 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4530623eb8fso7407095e9.0 for ; Thu, 12 Jun 2025 08:48:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749743291; x=1750348091; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ei/d28RGKwbGgo0BkY8L/1pu6a5ZV2mA8pg90GSA4I0=; b=uK3/ksh2OifFId6/Pybn1TXbMcTo78WPdduk6HeGWq69XZvoVWNjLrcpoY0rL6Hr0d JkpINQivIZXYSJezRrAMSOhcpke8gQZR94+5g+xfSqwidfS/kzFByxNbWi1eIaMzAFGX 5ZIr6JVNAT0/C5UL03iRe7zkG/zNQp0Jp47DljanYseBNoBhq+JUYa323t40DoTOyRyU HKh+OcPGznUl933Wq/QZhjyHJCFXamMn93N+SB+P4NUmP9mRZhJAenAETqyNqTkKAIxh +5+9zzKkvkLtPemeqPQlaizBSxBbcb+Sdcn8GdBvFgVOzlWZcRYGNFN8jA/zkPBhtn8G LX0g== X-Forwarded-Encrypted: i=1; AJvYcCWR+85PcdlmVid0js1mfRrvLK9ab73ZFy59WnbmAMiz1ROjTAAdoASHRMRoDqMlBHwPrr1vXzGv0w==@kvack.org X-Gm-Message-State: AOJu0YwwwBCFxGeFG4+oBkXTS62johT9EXKI9EbQHnVaWEVFPPRSwhvt 6Xg/lJyHIJnt1J3FnI+DqrgxvW3zDSSm7Gxsv25twM1CXccxVCujgbo/26di1uLXDefI8qZxWsj eAWo87ptSVv15rXip3/5TLaZT+CBjKvZVpO7RmShYnd1VD4uZOflH X-Gm-Gg: ASbGncubGEBB0hFxuprTQvl8jg9nRjY4nrZb79pZGoCDq/QYuEqFT7eoW1/iNtLALxW FLZcVwNuat/cHn3R1phrcOUS3KXhmit4W+i95dzBRA5LRbyycDntaTJJsRyWqDrSbZhXU3AwPDm l/yAJhoUHU063jsoFUtXRSr73M+DoXJuhGRffE0kH9bg7/MfDvfsd0rjEVb/+B53lUTJgNaeSsG yMMUaWwEC+cyWOaqzBwGIZwN7NqcF6y/ARl8T6RS5MFX/CD4dQ3ZAFYqb1ckzfE60Dc/+h2j8Ma R68WWe5+eNVhOLHdQn1kJH7XnheSSApkSztkXmjl2SIsom13HqEcVzeWuHatCM/Yn4nIRFggyAY Rc5LWgQEZYUogIaFygshNI4aYaV3i1MZXwTrKl/jzXM+0ozfLgg== X-Received: by 2002:a05:600c:3489:b0:441:d4e8:76c6 with SMTP id 5b1f17b1804b1-453248dc848mr86660335e9.30.1749743291250; Thu, 12 Jun 2025 08:48:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGKJbzhqucCYFF6L45cVov1+4dJDmjC/GWZqYfL6Yk/ZiNCgc95grP7byUyLps7/+rUkN1TbQ== X-Received: by 2002:a05:600c:3489:b0:441:d4e8:76c6 with SMTP id 5b1f17b1804b1-453248dc848mr86660005e9.30.1749743290856; Thu, 12 Jun 2025 08:48:10 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:1e00:1e1e:7a32:e798:6457? (p200300d82f2c1e001e1e7a32e7986457.dip0.t-ipconnect.de. [2003:d8:2f2c:1e00:1e1e:7a32:e798:6457]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e16e550sm24134635e9.35.2025.06.12.08.48.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jun 2025 08:48:10 -0700 (PDT) Message-ID: <2e5eda85-f1b3-4fc7-a378-346cfb3840e9@redhat.com> Date: Thu, 12 Jun 2025 17:48:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] selftests: khugepaged: fix the shmem collapse failure To: Zi Yan , Baolin Wang Cc: akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kYoRdjwR_m1r4FeHkdBF3sllFJnznlhLDFCPi-hkh0M_1749743291 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 91F22100009 X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: wpxho15gf9i4cnczg5kfghwk6t5y3xhy X-HE-Tag: 1749743294-70277 X-HE-Meta: U2FsdGVkX1+LZsZ+LLDLqAtLoOkv1dgRFg+eFaTAhKWMegHv5O9ciXIvhU5EHdtR9BU18vTEqTtxhRf47xul731K6IU3KnfkCGZ0HABlyO5rJEhmY9+JF7RrHS3NO8xBD4kCqI2FQkSKuH9R8rK/JWjDB7WZgjLQfoJb5Af2ajd5YpSblmYTmfCk3xQMM/KSjQdgG4z/CSzwP9gN093VjtZSn073nqFFm2CT9fB0E0Afdk2zEsyFchArlxVgqnX/xBfdOLmvrEVQe94RdfgZmSOcuE0NAOmSXvdf0EHhGrp6ZIvc4+4DSQzRnDN2YbYbEcSNkh1hpA5URCS0PSJogJqdm01MA3cNOJVxwnd8Z9f3geNCb4FekSmzyKKPye2WOnpibcxBtEJPxo7ahX0XiCqPBixvaW5atqnQRnEqep/mSReiIgubVJOcjbr/mo46uZYOkZR1gwGTFt9j4T5gmULkoRh87z0JzqoSAQlnFQeTjQrDPDgmQrluSP/wQJNA2XomGFHIIz/4SQUT1gmq6pG7bcavVtW39gq6d9FPCY/htLv96FWWr0Ts3c67K1/uNZ9alZzXxQoCIwgvPKsa2q4GR/efZcn45+3VwJh43EpGRKtOMybdSLkl1QMzlK8dR+nM/UTd6sBiu/4rX4FeUKlDs46TBxKMDOpDkM6PPaMGeni7NHu+rLvutAAujR7hHVyLUakemUiMNWRKfTiHOtAknJsdYjoOvItNCwyXSLvcHF3Rap7wUnnGEvdqwXS48fmSPZLVkwogJWg6blAy9ZKFUXMJHj9pnkNYAGXg5ZfBQUGiiRubQfHGvR+l4wlf+F9+Dr6VAeQAB5jn0NOjVIqCxOMAyY8bOEBQcmGUGBf/75Vru3bq1axVBPNunIhQRQY2Nt7a1sNX+g1tlMDlNGQLiBMaO1kUWldzlk7zlu4rSfw7g9abE1MeNQBzGsGe5Va7R2v11XgjBiL+W8l +ZyU+4W6 mYg0caYNzYWGMbNKLMhxUHqdYf7UdN9oFITtQ0UVTffzYXG4ofgrZ7cu6JBWc0ucNFWJc2/q35H/QB2QBfNVF2Mrfwg9yiTxdSD4HXYD7YRYC9Hyz64yNapug2at2DdzOSZC2EAw0ZDKlsJ4jdokZkMg9j8I0oNyiJXp3wDlxq3ykNBk3BrP7ALwBy/m8JuEoW7OXtfLYcwBzMc5dtRjcIqaN9vYI4L5wyZ6EUEHNU2Qkh2f3XvlWXhpY+HT0IzVa6D9WoMNuxQ231ohDQgxZEC2TuoM+dfsGzD2Ur0woeu9Y72MywguFicApqg4PLhqHnoyG+K8B4kFRWwJjhhSzotm9NFMbJRDZnPM+ctEiWVlcTXyxAlB7H6d9jUX7H9VESCNRRtXgikpWNjV341W90D31HQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.06.25 17:46, Zi Yan wrote: > On 11 Jun 2025, at 23:54, Baolin Wang wrote: > >> When running the khugepaged selftest for shmem (./khugepaged all:shmem), >> I encountered the following test failures: >> " >> Run test: collapse_full (khugepaged:shmem) >> Collapse multiple fully populated PTE table.... Fail >> ... >> Run test: collapse_single_pte_entry (khugepaged:shmem) >> Collapse PTE table with single PTE entry present.... Fail >> ... >> Run test: collapse_full_of_compound (khugepaged:shmem) >> Allocate huge page... OK >> Split huge page leaving single PTE page table full of compound pages... OK >> Collapse PTE table full of compound pages.... Fail >> " >> >> The reason for the failure is that, it will set MADV_NOHUGEPAGE to prevent >> khugepaged from continuing to scan shmem VMA after khugepaged finishes >> scanning in the wait_for_scan() function. Moreover, shmem requires a refault >> to establish PMD mappings. >> >> However, after commit 2b0f922323cc, PMD mappings are prevented if the VMA is > > Can you add the title of the commit? It is easier to understand the context. > > 2b0f922323cc ("mm: don't install PMD mappings when THPs are disabled by the hw/process/vma") > Probably checkpatch.pl would point out the same :) -- Cheers, David / dhildenb