From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 631ECC5B543 for ; Sat, 7 Jun 2025 12:29:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD26C6B0088; Sat, 7 Jun 2025 08:29:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C82FC6B0089; Sat, 7 Jun 2025 08:29:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4AA56B008A; Sat, 7 Jun 2025 08:29:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 902756B0088 for ; Sat, 7 Jun 2025 08:29:13 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0B7CE1D6C42 for ; Sat, 7 Jun 2025 12:29:13 +0000 (UTC) X-FDA: 83528534586.13.968D015 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf13.hostedemail.com (Postfix) with ESMTP id 36F2320004 for ; Sat, 7 Jun 2025 12:29:08 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=OhzyX3m4; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=OTkE5s3t; spf=pass (imf13.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749299349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EBc9d0IdqKrQ2wHegIXLBwYKKA1s+nUrEDRGKspT56c=; b=NgfCtBsTbHOTzAR5deKO9qbnhSMhDztlv8uYwCnIe73S8XIAiPXTUDzaCt+rH6HNpvZssi OKeVn+6APUjcw9Ku1s79r3b0TMc2LeA33MBePemgnXlP2KewscVn8OeMnE4HhcfqAF6al9 JGn6JmdVO1f2kVCUfHiT+w8Bkq33jVs= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=OhzyX3m4; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=OTkE5s3t; spf=pass (imf13.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1749299349; a=rsa-sha256; cv=pass; b=FTeJvz8Wwu7S9QFtHac0ex9gMXtaVlZAmIizlQTo6oUlljLuQAww7e1Pm8mPaaowpmE1r8 PYskeQguasFSkrzOp+PMj0b4JxkiKCTPytFtNuTDTUqFZHtnRGLmviNF2AQuwOerVTAyAL EpGPgwBAuUYNTNg3vxfkFWO9cLAWzQ8= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 557AU5oR005918; Sat, 7 Jun 2025 12:29:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=EBc9d0IdqKrQ2wHegI XLBwYKKA1s+nUrEDRGKspT56c=; b=OhzyX3m4W75k53Xkqsx8HPEr/x1erkBMY2 tMtH31cbK47hjV7LXCwOKBWRUv1225ENlCvi18SLbW3HMbpdyvGJc5B40duhkqcY vYBQ8/lxAjTPEsJgd136Nb8cykMlrze1tjCfUuKIMOMNvxLCt2+W/IAihaYqcywY PQICR+KX3AVJwLixBFYwjpV1DO8a9LPm3StN22+wLPA+HcfK9ImxmrKYfxPUm0Y8 mjnaPzc9lb8qJ6ht4fHNDVwH93FW/qpxz7dh54DoPQoRyCcavoPkIJkERmIYGGKI JZSGEVPApM4r6CEQamlXXIuZzYQFVuhwQIyJyjeF9cWFcy3Od3vA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 474c14890q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 07 Jun 2025 12:29:02 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 557CE3Qe020668; Sat, 7 Jun 2025 12:29:01 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12on2045.outbound.protection.outlook.com [40.107.243.45]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 474bv6ru1h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 07 Jun 2025 12:29:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DgS1XbkqItyhL4ml+dfoYUgN8CWfseFCqJc019aju1tvJU4lTtds6ETKCf2I13zKxRRziDVOsPQwCZ4kxHdbh3h7ET6Mf2y78Si/FY1Xk5ywmHezPG1wBlnCM+cDjwmwqEKW2Rz1/QlUq/mT9szzwNucmHc5QW/r5hWbAplnKNAcOgJRAWSSSE1LCg5dqd25Bbvdqp9P0XBARc1nilUy1J2NGH6eBDFGvf93Lw0AevmEbEU2lbx1U7YIfR95i3Mg0bUyPK2unvNMpKobwboGtSdnOazCXOGYJQnvh9Sxvi6/9fPEZAmrNe3YsHbWTcamvHkCYhxfgEu06Snxa2YbYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EBc9d0IdqKrQ2wHegIXLBwYKKA1s+nUrEDRGKspT56c=; b=yEzBeuFGH0tCe5qWT7RVClOcHJf4aD7OxObSXVz1iuFEyAoCUxpMZ+A0H2upDwZPNPYhqUV7QhAwe7mLBKX5knOPSKQ3iQCGMDGev81uxUmlGkkf7ZxsGW9g2/dt8qdbARA7DQr+dJM4xIr5g41eowMf6ZbxYbEw7NUeNYpEEaMsI+zQDsP1TcDfb1obc6ovgliqH3g2bSE9mv+6Nadsj/sG2W60QdMI3bHUVxjjFSCMiIeBxeo/WnMD3P/yqoaKDBJByqrj5fgsEbQeACnOybCKG3yF20Mbzo2MLnFALtXO5JvDYxcZc2XgiRk/Oyj1qUBPcbhFxHcwu5UHV4rkfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EBc9d0IdqKrQ2wHegIXLBwYKKA1s+nUrEDRGKspT56c=; b=OTkE5s3tUpMiii/00/zDrN3J4Gl6hWYTfgZ1WsA5XJGQQcqrrmh/nJN54j4TkIIJyvS4Bxj+/nYHqVfG5+sKa2AoTNdM9sATXv7kGUa/jCJXRL46Ph5dFo9WA092oRb7uLQffTOIy6jZW8jE0x2dtopERAauk0PLhhG19U44ySc= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by SJ0PR10MB5600.namprd10.prod.outlook.com (2603:10b6:a03:3dc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8792.34; Sat, 7 Jun 2025 12:28:58 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%6]) with mapi id 15.20.8813.022; Sat, 7 Jun 2025 12:28:58 +0000 Date: Sat, 7 Jun 2025 13:28:56 +0100 From: Lorenzo Stoakes To: Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] fix MADV_COLLAPSE issue if THP settings are disabled Message-ID: <2e30bffd-bda5-4f83-b88d-c51940651a49@lucifer.local> References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P123CA0006.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::18) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|SJ0PR10MB5600:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d7369b5-615d-4360-b50f-08dda5bee03c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?VLDnMrH+T+l80Pdf9OE/RtiJQKvCnaie8a/utkk/8xtrAd19DcJYvr3r9sBy?= =?us-ascii?Q?m/kzpPDxO75HOkSI4wNPUb8xU2wToxfKsmGIVHgDNQ4K2Mhfd07xN8fHfzxh?= =?us-ascii?Q?oC4r0MFDsuA7YbOR/SnfebiFZRs7tL5A6BS/oenafguFGF1t9Xc5DuDb3mk3?= =?us-ascii?Q?AhaIwkBzlbT8msyTKS96D2ewffmgR9CZ2gAOF4boDmCvSc4oAPvszfnKzygw?= =?us-ascii?Q?7+rgPDnHNasMktRHFL30oaLqE5/BnTbQxhqbc2jvnX7oKsiNN4TYfBYeNnHa?= =?us-ascii?Q?IU2A/dOyKAGQWTHQY+t2OJ/fmqqMFK9lE4n2xsDR+c/6+lHnUyWC3jG1Ro5l?= =?us-ascii?Q?ohWUBr8gW4863aSN2yMfmxJwpQbKVBc0UVYMymzgjHAPGCXZOV59CPHyPcCd?= =?us-ascii?Q?HTyjEb4XCbAW8a1MzHfhSB12jU6pSZRMK8fx2NH+Kt84EebGZtSXirpnA124?= =?us-ascii?Q?MUnl+hRAfgCEI9zXRNfVfYhY4EedHMYoQAz7KOLLZKwoBwaUXJ4Kc9xCq+21?= =?us-ascii?Q?fLWX8NN2mEvmauPFihLBLSmbFTBm4jJGXvhYHYVbGZvFVqUEVvChfKuX4xP5?= =?us-ascii?Q?xCMhAGOCmvEi7AsCYxGT+ypUWgNtLGcRY9SqiVgx83K1/SzsK0sN/3oY3giK?= =?us-ascii?Q?g5InOFg9jKazPR829kqYXvbDnNS/KpS/vXTtmaXSF++JEOG7HltwiVczLYwz?= =?us-ascii?Q?yLJ5XYDaeZey5Q3gEGAjEW1DncrRBAWvjYCx4/ho1uhkpCAfRZ1BY+D2hke6?= =?us-ascii?Q?79g9st+YeIcBBE5sCe+8IIsjIU1IR5cQRCfefFhYi4MK1PK6GBv1H9zDxpPS?= =?us-ascii?Q?gDKMByv3XOQrJAuDTJw9OJfniJFzYrT2OwTVbBI1ww4DH7qhirs042RVey6c?= =?us-ascii?Q?LVdy7gfSzZzFM7hTvER40sK0o5X9YEGvRRwdDo9kUlOZSRip/PxxOgks6MjQ?= =?us-ascii?Q?ObM8lduqEFKWBPz70x7Bq6tVhCd/QY9Iezrdp8oSVTp+mRFdR2V/AsiFZp6F?= =?us-ascii?Q?cw/3F6Q8Mp2g3UgoSgJAFccSsfdguJbVNjsVWXtVadaTTUAqZ/ELq6zq7/Sk?= =?us-ascii?Q?WVRMP/Af56ahVbAIsmXZEIEVAVr1ET5kvFKemabWjlsHKYHzVezsvKp56JvU?= =?us-ascii?Q?o60ofhjwq/xsDVRA72rGRC1o2SgwI6nlO1c6eqaMLJfRlnVUCe8et8aIiv8J?= =?us-ascii?Q?DMx48ocO3DXguUQxlXl2gy/Yz0cpV3FNunMoEew0MhXjcJ8UMHF/HvEDJbMf?= =?us-ascii?Q?kkHyq4Kvlxjtb5g9lVsnSRvFZLSgP56PGdBrcvHHeQvubXTdKvqffe91C9L2?= =?us-ascii?Q?BPdV6zpGS4XAt5Gvb5cimTUvYrLD9BlAR986PosDWBvE/YIGdaLDlh1fBhzs?= =?us-ascii?Q?6JnbMiqqMXpiITbUmOL+NNhvBF8Mm0Slt/HhekLOHZDDQVgFqcVfhkio+c6f?= =?us-ascii?Q?GfdiBvTImOA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fdYpfjwFpyH3R2bReF/L0F3aWJYI1zBF7NNVEt0YJKSLDNDFQr2tcx0kd9GN?= =?us-ascii?Q?277H9d9OOSU5KWZG8CZaI8NhteGdqbOJqNBEHQT2QY7/D1Q39U4AOVr79YnE?= =?us-ascii?Q?L/4F9CSwJQDmC0WWSPE1nqX5tYx6wlBByvT+6rknZBMOOXIV3JgIMbnehKWO?= =?us-ascii?Q?eGo6RgL9ctSgs+wCY7f9tVZhH6ZI3TJ5uhq+iCdSCY6D7gGstIuv4eLJ5kG3?= =?us-ascii?Q?JPXJ3IM2T3sb79ar78WDniRbbHWPfrHlQBsaLDNv1Pvu1DikH6vnrHIRCZux?= =?us-ascii?Q?zygCPFHZ8AL9obN6naItaPki7AQqj1aeP6iaGR2azLNYGQPe2pvP0kk+x8s7?= =?us-ascii?Q?sezkUfEDayi1bUVuhPhPkuyGA6xfFz9T/66eV6hPp1UlotoFw2hl6MTxvT3X?= =?us-ascii?Q?YMfo4WL6QbJq6ltxoglGI5bGrQa2mXcR3rWr8OOX2af2Ber7OCBMx5PNEzW3?= =?us-ascii?Q?BHi43G7+oZI5V82DHyvkWqe+Zj2LTho+0vk+5RHdTtmE3n9jXL+LKiU38FSO?= =?us-ascii?Q?P1qCcwtfATyuR+QhLDE5b99jMQF1/yDSj9X0ecs03BZ71Gyko/qPtmkRdXr7?= =?us-ascii?Q?7VpgyKZ2t2NsylbAl6sIZ5szSqZKbLgicr5WpkMaqWyv39kdRfrdJR+N/+Mz?= =?us-ascii?Q?zeZkQyl4aK0DmiLNJv1ePh8zlaQjyzcyVKx91CM1dn8EiS9Y77wl13EcMyAU?= =?us-ascii?Q?2dxar55sEpQoYtfRosrH+Re0cfAJ2X0U98ZFTCOhZS55myV+nQieBTfAXwIo?= =?us-ascii?Q?+DndO5IaCd90Q32Y2T2wuHewLrsOBf5MovI7RrWYusZQsO8Iicii/T498mGa?= =?us-ascii?Q?NGd4D7R3pGcqmEWblqZ7O064A7+D5qcGwXqgWxBvp+VX76PpjJp27A8B8omQ?= =?us-ascii?Q?OVnr0rYDadTHRq5zkouGCRH6ZKLVhCRqwGZ4HGtucEJjhfN6PaEPyAcoNiEJ?= =?us-ascii?Q?r3pfX1vxf+pkbW8jwNbRw/F2e5wUoFkQZvnUmsHz+XFOnbm+93NFLMvTOPtH?= =?us-ascii?Q?lwoc1yL4QZJyVGJ8W54aJLAVV94NAxszaS2UC5SNpI5j7BmgKcyvz69d4OO8?= =?us-ascii?Q?+LijU24UGp3g9b7ooihA2360YRviKnVwdvmKaFQ3rdkt8OaIpIaofJ6o0gfR?= =?us-ascii?Q?pEqml//j7p2nw9CHzROsVS4T+5WzlSYpMciZlIK69C85Kgi/ahBqV+FFerue?= =?us-ascii?Q?6Fq68t+eM9jRPHLyhy7/nEV1M5BjOSAJX5RLQ70cuqZsGBgmHOOxE21ln06N?= =?us-ascii?Q?6k+xFMgpUPIk4eZQ4uUHaiUexsZMOdUQ61WyVXTU4fQhWUs2PlOCE8Q4QuIN?= =?us-ascii?Q?DGbrU5PAY1DqKo+xkqmJPGCGIG/upbQCwbb8jLhT0/SwliDuIRW/RPoGre4Y?= =?us-ascii?Q?bNKDzkFpFzoXSofiQmFbeX8qkdNb1UK3xW1OMQCz5GCAiYgMWL/oc7fSA0WX?= =?us-ascii?Q?QA88bDsGoS9Ws3ll+mhJnYyNg6yC53TEo9sllC0Ume0bEB2W06/QeS9RYBMz?= =?us-ascii?Q?mfBAvMUjI4gWv/wQX+SrVtcHOxoLKuStRhP7cyWQ53s/u97kax6Xj4OUNjrc?= =?us-ascii?Q?+yVB6H/q8ctzlex4eon+q5L0P4xEc3/rdKKf645hYT4UWO4y9C+5Z+F/5x2I?= =?us-ascii?Q?FQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6nQ9SzWJOcO5usTd24PFPYNzWjEQzWI5jtmJawGo3UYJJU0ZwsiuyUtt3IgZoCSFyn81yR9lysLSaA2xdMD6IHd3DS3w9m4kVG72Dxz7soRCYfOBlivBbJI48eBwwi6NefTg3zA9tRBXdI1uLlv77aAh0Q96HoASJwOfZ1RYHDEYlnT6f+FimLqViqksEReWpXwP20op3kSb/J+y9CNY9znSSNsF9dHB9leMvVcQVFG6tBUa1yytipIkA5pWIn82y9qyu+tQlHhENBbece7LXOeDQL9tiAbkHcy5usNHdNEhBt+qvHgQDo+5n/6rb/Yt2763mL4/08jvK1fWuW8MKsZung8Iu/cdjXr7C1k4VfzAb/dbQYdB0/PYdIsY2c5bAe10BDf0lKrMuSJWsO8g9BCOZ82AwgQKLL/sryQGyoPPWr/nMw8B8ZmYtO/3tYXTHiQuo2+MSTAuOLHKYLainR3HIJbliryzK+iG+EuZKhAB/LCwCMHNTDhpSCryvrqKyZyFsb3LLxgACQe6U5nkHKjHPpM9JrmLuNrTQUEIUWGWKzgHX2/80a8jqTuDbze0Og8D0l9vD2BCoYgTW0HgxE4n6Y8hKmdlZqi9PC+oefA= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d7369b5-615d-4360-b50f-08dda5bee03c X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2025 12:28:58.2001 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KBxmhDM5mUhbCurztCyG2994ejSIUiSh5v8hXHpf57oOZy5uYgCaoQd/vZ2Fy2V6UObWOukPcYig9g5u9t++b8RdQKBNYKPD62sBfft0+Qs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5600 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-07_05,2025-06-05_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506070089 X-Proofpoint-GUID: 6B7JEeqqjpjzhCHe2r-6ECk4cix2Zkrk X-Authority-Analysis: v=2.4 cv=GcEXnRXL c=1 sm=1 tr=0 ts=6844308e b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=SRrdq9N9AAAA:8 a=tCvvFVPAsNhtnAX8jeoA:9 a=CjuIK1q_8ugA:10 cc=ntf awl=host:13206 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA3MDA4OSBTYWx0ZWRfX4bKAHLMjmS9d A7imL4nrHXaHMInK1WOCEDuyjMN9CJLkUP0ol+mTG+oDWVApW6a0wgpiyRkX6B7A8ZFOef3TnE0 J5HmgDl7SaVBc9S9BvxfahNElQn+Ahe5q8uaCUls1T0pTjDmtysI8OKnBbm5m+S9LkkNqiSSzPy fUBAkmkn0xVXEDC2Cvz804BrfkRAWt9WnmqieTnbYpk+f0RrwxeEMOzpx77USq4HqOfsmBbtxj8 dKxc+xTTpISglOpxKsa9G1CfYwvBw92WHzw7UodXlrKARH/t1bkR0C1b9BLWVIV0mTTu3u3VUQe 5lK65ctAq6bSwcShY7tzQlLJb0ZJCxBvuiQmwIsz33ndblWcE54parBp1ArggYbSgrVYi2VMwBD 2hd8DIa3Fipy3+1tYorY8uAh7Nvj/PyFbRhjTy+mNRdSsTMmo0H96Xq120CiSsDyngYEXB7e X-Proofpoint-ORIG-GUID: 6B7JEeqqjpjzhCHe2r-6ECk4cix2Zkrk X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 36F2320004 X-Stat-Signature: 5i7jmnq9h87cqp4wfz6hneag1azty4dq X-Rspam-User: X-HE-Tag: 1749299348-647290 X-HE-Meta: U2FsdGVkX1+1rwaovYMpsW+Oqrc5uekDq2W2y4PSkSNNWoIclova90o9rObKTCHeZfWkMT6kSjiYLJv3a/xXhc2/DwcikD+5CX03I9qCcd5Y4TU8Lx9/D0zAWSEEOONRDsTqaG30FobUZVBXIJzg4V1dzQ1dmiWct7QqHasH5Ca56Fn88/Qir9O/eI9vYO86dX6gPyqY2eFR7JkrSU7rOwnPGIdRz8k9DRChTEJme2fTr8dB7jo5pAUsb/xhyAwNanUCuR3cyorrYQE8O4ZLQNeXuQwGb2KbFS5MCUomiCT2paDgHZj365ZuRvmWSpRLYUjdeovMQJpAFq+rGSrTWn2EpKVuo4JLZKeSypHkNFqrf4Dhz43fofqSaObteJtp6JAyob0iyx+FkSMtrO/9ie3L2wHyfTXry8AhpCt0l8ae/ipN6ubEQbUTS9hupnBG54ZEpNPrfMTYT7MVp8g2KTJSjxfAdNfqbeaDu57XdQsJbeAEMne2368I0q7jSL4yzlkIBM564ylQSVLWIbIWULgyEFJcuhVQS6psvHKgHmrKOD2+qXOpGYHFiGCbkYBrZVqX+lp5WspIrPADAm0pGlqbRVRWOjadlvjJHS/VEuYio76WvdrAluTKmusmaVLhZav/fR7WEYP4EeTP9WlaY2rEzSelkBnKxkugGZzjVBh7vRpKAZ2YrFd8jCkUkwteKpg/zu2n0HmyvYRM9WZpuxND8YoSUPMHUjP033a6B+WkiDj8N8kHSbbDy4cWKmwqUfCLIqSBvHN06Hzio4ms5CJM62eXZkITr9YyNoZKLIHmlLUdBvnqHUH9Xkl/BCuhf35z7P/ki+4FrrBzcivG0FuztSSDsvjHhoqCFP5KwpNOQPUeFWq0ZSKv4ZdIKoEpQWkAnXkNcJM1czjtmPSIUE2InKMV5NsOcEyNBhYqelSBRlhRqF00M2BoFuz3UooxmcOaov2xE5ztuuyAmt7 gmaF9mhI c32eZ3ASYNqZTZFyGrjDuPnBNm2VFAAjUYd9RjytmiRKEnhmMxBHNZIwUT4yDuWzyqcC3htdMYT9000I6eL0nr9Yy65iXi0NBZnEhIJuEZMRtmJQn96BjO0oPq4u9kEavtV3XtT4eKo6c/DWNBcci8Ilxb0ZMvxZ1zRDttqMXsYmCe+3V0ikSySTelhAmZ6SpbIkFw0HrEm7yuO9QNqdJFgAHx7CtYgwduCF6WPRxH9z5q72BcU5zuUdXO91uWw001IiEpCI/EPbfglDBN3mUVBVB8i4rbj/slqAmS+tL/nyn1qJ1rNjIf7Uo07Nw16wPE/SEsHbbxT7MJA2CFDAMkYOnLJDkZNFQmhJaWcDPqPkcYyT1rELi2gZGLEaG16piMt/dTkrQ1rR64eJMO42we80LoVMHS3ZAeJIQw1x12W+FEZYffFxDzo+hcasF5Vpr6RaaQjiZxwj5j/8m/afX3h6sFYMg3krnbzI7SUy41GmeiV6mNqPO8YNgTWa5DaMp8bSpAhtxviIeOBhDWrUSZDHxpk4k3XXb2HIunA9VB1OKWe6DzbLBil4uB4GiW0A4jHd2dbKragJ6/CyX32YciM4d9CoVIyMboEffpp2XAgt+HO2GPRcbUvvYKuwq0EvMQov++4sqXoOouJQUXajjzZQ/X6RorEsUqc0vHtcIMNbxuhgBIKtYtWjukMFBsGlkrWQZxW64OsfE730YdG2+dmYIizD/fn5vXHGbIaMiN0ASJX5JJ3ss+ilB/8xVg+3FebbW1WLXXwW+ta4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Before I get into technical criticism, to be clear - thank you very much for doing this :) I'm just getting into details as to the implementation, but am a fan of this change and consider it important. On Thu, Jun 05, 2025 at 04:00:57PM +0800, Baolin Wang wrote: > As we discussed in the previous thread [1], the MADV_COLLAPSE will ignore > the system-wide anon/shmem THP sysfs settings, which means that even though > we have disabled the anon/shmem THP configuration, MADV_COLLAPSE will still > attempt to collapse into a anon/shmem THP. This violates the rule we have > agreed upon: never means never. This patch set will address this issue. Hm this cover letter could be expanded upon quite a bit - you are doing a lot here and it's not only MADV_COLLAPSE, more a general change. I'd mention that, even when TVA_ENFORCE_SYSFS is not set, callers checking THP order validity will not be able to specify THP orders that are either specifically marked as 'never' or set to 'inherit' and the global hugepage mode is 'never'. Then say something like 'importantly, this changes alters the madvise(..., MADV_COLLAPSE) call, which previously would collapse ranges into huge pages even if THP was set to never. This corrects this behaviour'. I suspect you are unable to write sensible tests here given the need to manipulate sysfs (though perhaps worth quickly looking at tools/testing/selftests/mm/khugepaged.c, transhuge-stress.c, run_vmtests.sh to see), but it'd be at least useful for you to give details here of how you have tested this and ensured it functions correctly. It might also be worth giving a quick justification, i.e. 'system administrators who disabled THP everywhere must indeed very much not want THP to be used for whatever reason - having individual programs being able to quietly override this is very surprising and likely to cause headaches for those who desire this not to happen on their systems'. > > [1] https://lore.kernel.org/all/1f00fdc3-a3a3-464b-8565-4c1b23d34f8d@linux.alibaba.com/ > > Changes from v1: > - Update the commit message, per Zi. > - Add Zi's reviewed tag. Thanks. > - Update the shmem logic. > > Baolin Wang (2): > mm: huge_memory: disallow hugepages if the system-wide THP sysfs > settings are disabled > mm: shmem: disallow hugepages if the system-wide shmem THP sysfs > settings are disabled > > include/linux/huge_mm.h | 23 +++++++++++++++++++---- > mm/huge_memory.c | 2 +- > mm/shmem.c | 6 +++--- > 3 files changed, 23 insertions(+), 8 deletions(-) > > -- > 2.43.5 > Thanks, Lorenzo