From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 045C1C4332F for ; Tue, 12 Dec 2023 18:08:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82B8F6B01FB; Tue, 12 Dec 2023 13:08:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DB946B0321; Tue, 12 Dec 2023 13:08:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67C7F6B0322; Tue, 12 Dec 2023 13:08:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 574C36B01FB for ; Tue, 12 Dec 2023 13:08:00 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 226D0A1F40 for ; Tue, 12 Dec 2023 18:08:00 +0000 (UTC) X-FDA: 81558949920.27.E20B9BA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id AA8D21C0029 for ; Tue, 12 Dec 2023 18:07:57 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S+tXut/3"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702404477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vrF6cApjPp7IqSr9Fgr6kbcQE0WU2mTbHV/9Qb1eeoM=; b=ilLVcsFCXUbN0W7KAHnCSEHiOjpXU76Bm6gzqIYvE6pdOKICZofHl3kkNkoIoW4Zo8KiWG +yCBW7c8PfSv8QwxAAJS0hrP2AkNJZxKVCv0UQjUgB2sKQZBxiXhqc77qf++5WW1c3SSJ7 VG8mOA/4oLKdWJlLhzmyiwbPeu96Kug= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S+tXut/3"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702404477; a=rsa-sha256; cv=none; b=stOPTmzHQ76aSuJudCAammMV9fxSo7ieZqlsvq6LNSHsBSypu28wX+4DaCgWiy1n6lNNwS wyfXRaNgpg8fRDT28JGj69MXHEQnIiQWP4zZjvkw2JYTIASQZ3hSx1s45eSgK1n/3FVNoS kiv+c0PIRNBnP3vcrAyUmOgwTex/Xh4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702404477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vrF6cApjPp7IqSr9Fgr6kbcQE0WU2mTbHV/9Qb1eeoM=; b=S+tXut/3XngvO+Wk2YZCS/GWbmRhHLR0PUoTb9Qll11m6mpYVey5M+9BX1TiRw22+4FT6L GWcHW86gxmoTH1nliQMz05VO3RVWu4ggACNq2fZv1UdfIa5EIb7LL0YT8IgsXNvKPfR8YC mmLBrNHPObp5k6bZFdRGkmwIwVw19OE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-WicFHWXBMB-XVkVcQ1LWUw-1; Tue, 12 Dec 2023 13:07:55 -0500 X-MC-Unique: WicFHWXBMB-XVkVcQ1LWUw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3334e7d1951so5163139f8f.3 for ; Tue, 12 Dec 2023 10:07:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702404474; x=1703009274; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vrF6cApjPp7IqSr9Fgr6kbcQE0WU2mTbHV/9Qb1eeoM=; b=g6higyVanMkCyYwUQKW22ahgyN+PsTdiUDmf9CN4bP0G3WbpkUAgB0geMV+SoD+3jH FRH1FEBK22guWwZsglE8qXaQcrNLq45vMPlyJDxl48F6uHh48JXaYOqNnnNwZr+ueYdU e8WfEsApB3sZRADionUhyIxXpkPWrARhjGVW2WtZifP+Q/pnWCIAF9yO0t8Nu+dy0aAN lPfebwC5AybiKppnIf4SQbNtr7KMgAoE/uR+A/tT6m+uuGWyByOWHNaQyJMz+GYApit1 50Em3a1wyPU7O6liSI01HVFuC5W46cIxRDle9sHldEO/gtutBA5VWxekkrkQW0gXUgpZ a8IQ== X-Gm-Message-State: AOJu0YxIZunCsCcj9wnX89xMhGWToEMlmmNJdViYYBkN6A2/iRtxQIs7 jtey+M5GX0kOWZFx8FiAsd0xr1wDbrBZvoca+5ysjZ6+d0uIzIkZMqk4MJ1WJ+3ptDMxl0Enya8 s4o6wPlFD/pI= X-Received: by 2002:a5d:4f0e:0:b0:336:348d:e78a with SMTP id c14-20020a5d4f0e000000b00336348de78amr304259wru.161.1702404474351; Tue, 12 Dec 2023 10:07:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IH9PSI1OJ5SYwzuvucvRwmxBYR+m/Iq8uC0uFMpnQkpr6RV3qjNf7e5PGGMtH7DaTFwzeETyA== X-Received: by 2002:a5d:4f0e:0:b0:336:348d:e78a with SMTP id c14-20020a5d4f0e000000b00336348de78amr304252wru.161.1702404473962; Tue, 12 Dec 2023 10:07:53 -0800 (PST) Received: from ?IPV6:2003:cb:c74b:ca00:4ca2:ff2c:9092:f070? (p200300cbc74bca004ca2ff2c9092f070.dip0.t-ipconnect.de. [2003:cb:c74b:ca00:4ca2:ff2c:9092:f070]) by smtp.gmail.com with ESMTPSA id o1-20020adfe801000000b003333c06fa79sm11437505wrm.71.2023.12.12.10.07.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 10:07:53 -0800 (PST) Message-ID: <2e22fe80-2280-4003-923d-8749fe85b81a@redhat.com> Date: Tue, 12 Dec 2023 19:07:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] mm/ksm: add sysfs knobs for advisor To: Stefan Roesch , kernel-team@fb.com Cc: Andrew Morton , hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20231204234906.1237478-1-shr@devkernel.io> <20231204234906.1237478-3-shr@devkernel.io> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AA8D21C0029 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: eqyqjpd9epb6ptpggt9ty3ntd48pr3uo X-HE-Tag: 1702404477-391368 X-HE-Meta: U2FsdGVkX18741bylK1H1vu3yfb76oZejf4GH3o7ho8vzPU4KYphzP/8VDkODKIcCEAiZFP0ReAnBd7LavD0PCJBx4Hqhar0vHSttTkzdwrZYpg73DRXL9P3F0x8UmZs5kTqpxDWW5bZaaLgELGGKklYWOQ5rNs4iQ6vReqhciHyyVBFnESOw0O+b+NNMLwqh9CYS3vS9F6OKWE4oh43hnd8VfoJkT6QN1HK7Df9voW9WMUzu0Pjlq/dgcxvsJnSjZOPDgOVue8j8PGjtqi6AhY1yRNWMwE0FDR0lMJ5ENasSeXMtIVGKhQLd7l3CMz5KGSn0981UjEOgWNyc68XunOymwlUjxVWyy7hGf9ylS7LvYVUpkVSaH2agcHj1kAraR1jY7OX4PHWczXxtS+qPh66HqUyqGR1pgag7MTo1kr59CKQX1TrabQ+ruhEBwdV67KiTqVfoUUpZn9EXm0JFYZQpu3SB/o1iSkaliPBL4Y9PjDXsHx+P0D3Gt4GIPWdxBPsfAcej6yB6nL1V6bCUsUOB6pKRaazWmdXhDzkOqf9jh8OTEpTvlOWT2koVECMfP53dBkfkArFQeNuWxW9kU6AdMSNz/cYbrgJNtGY8WV1BUATPUfpzeVpxwYpt/rqGs0/GzT3DXz8O7g4LAdmuW8/Lt9pEdtNX8Bs87TscGYOniZhwrfzU1RbN/pLdTmr3whUCpWgCPJqgSNDxtIK0txnDmGiiwHzVqzzy4281MOQxbgqJkD4uE7SBVZrt0LQf9DZM0eeyBMQWtKz68vbnkSBh/mKSHN4OwA2HXPURDQ71dWV8oKY2x0JpfrJyyMLb6nyGea0S5k6XbSCdxnXi8H3l0n0W6l4uQoe2O3ek9HrWfYnQ9cjKnVYjoHaaVPLlRBVMU0wvBlk074mHSGWQChrUVpFFsLFrcYbWRIr0pMYq8/xiv8LoemJ8JjuMudGBy2tiobrpq23Hs2W7Uc qyrX0LBH gIFRfewtO/uOYUi5BpAjLRhOOpCGY1CYe6zuTjLzcFjSUe6NybRBnAvID7KQolT0SpptGEWmcAshblyq/8SXV3tV50oJk6GP0Q64BZ7SyE9NN/1SpZVzikbgBCiN0OCC8fLPWcwiz12UysAZFlyY0kNhsojqAPkByua6KFtVriUjqqtjPufHlrybTjROIHHE7rdIYUI31w6xjdvuVOyCx0RmOUTd9568YeIaePMYlQ7gWPl8SumpVunn4B3NkcrximXHBKIuerk2+dkzduxnrX9FhcnmQgsD+egpUW8wFBOewEgX/rBN/dMaA2P0BOl33JOqI5VJJwt7FzinArErRT3t5JRDS/aQ+iFc9+2kzQAGTMZXjd0jqXhEW+lee3qwzM+mmICB7TfTKhDIzM5ePTp4tGgf/xh6L2TSI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.12.23 19:02, Stefan Roesch wrote: > > > On Tue, Dec 12, 2023, at 5:45 AM, David Hildenbrand wrote: >> On 05.12.23 00:49, Stefan Roesch wrote: >>> This adds four new knobs for the KSM advisor to influence its behaviour. >>> >>> The knobs are: >>> - advisor_mode: >>> none: no advisor (default) >>> scan-time: scan time advisor >>> - advisor_max_cpu: 70 (default, cpu usage percent) >>> - advisor_min_pages: 500 (default) >>> - advisor_max_pages: 30000 (default) >>> - advisor_target_scan_time: 200 (default in seconds) >>> >>> The new values will take effect on the next scan round. >>> >>> Signed-off-by: Stefan Roesch >>> --- >>> mm/ksm.c | 127 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 127 insertions(+) >>> >>> diff --git a/mm/ksm.c b/mm/ksm.c >>> index b27010fa2e946..18b7185bbc65b 100644 >>> --- a/mm/ksm.c >>> +++ b/mm/ksm.c >>> @@ -3735,6 +3735,128 @@ static ssize_t smart_scan_store(struct kobject *kobj, >>> } >>> KSM_ATTR(smart_scan); >>> >>> +static ssize_t advisor_mode_show(struct kobject *kobj, >>> + struct kobj_attribute *attr, char *buf) >>> +{ >>> + const char *output; >>> + >>> + if (ksm_advisor == KSM_ADVISOR_NONE) >>> + output = "[none] scan-time"; >>> + else if (ksm_advisor == KSM_ADVISOR_SCAN_TIME) >>> + output = "none [scan-time]"; >>> + >>> + return sysfs_emit(buf, "%s\n", output); >>> +} >>> + >>> +static ssize_t advisor_mode_store(struct kobject *kobj, >>> + struct kobj_attribute *attr, const char *buf, >>> + size_t count) >>> +{ >>> + if (sysfs_streq("scan-time", buf)) >>> + ksm_advisor = KSM_ADVISOR_SCAN_TIME; >>> + else if (sysfs_streq("none", buf)) >>> + ksm_advisor = KSM_ADVISOR_NONE; >>> + else >>> + return -EINVAL; >>> + >>> + /* Set advisor default values */ >>> + init_advisor(); >> >> Is the "init_advisor()" really required? >> > > The init_advisor is required for the following scenario: > - advisor is used > - advisor is turned off > - pages_to_scan is used and run for some time > - advisor is turned on again > ==> Advisor would start with two high values for the first calculation Can't set_advisor_defaults() handle that? -- Cheers, David / dhildenb