From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EB75C6FD1F for ; Tue, 26 Mar 2024 13:30:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCA9C6B0089; Tue, 26 Mar 2024 09:30:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7AE26B008A; Tue, 26 Mar 2024 09:30:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1A226B0092; Tue, 26 Mar 2024 09:30:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9030E6B0089 for ; Tue, 26 Mar 2024 09:30:31 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5F178160B98 for ; Tue, 26 Mar 2024 13:30:31 +0000 (UTC) X-FDA: 81939274662.05.B20AF3B Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by imf02.hostedemail.com (Postfix) with ESMTP id 0196280023 for ; Tue, 26 Mar 2024 13:30:26 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711459827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uJd1/8iCFzjZxOfnwPLJ6P9UHKR1DwBw2yqpIj4Z9L8=; b=qqohWdlb6XP6TtWYOgE+2c4W/t4eDHbatSjlTNWnLVn2ag91nmF6QhUktvs6rHODtVAK6V EXhQAi5cmONLm/nTC9+RIvg7J75ANjV7BUPzrI6NI1oZ71s6H+qIqQ0Wum9ZFCCRxi5x3k V3WKe6JVSKiMptoPIqsDAaMvs39w0Rk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711459827; a=rsa-sha256; cv=none; b=3Q0mdLZbvDIHFAXXdpnkZWUmcnN1+9vwEDsctbF2OehtqZr7HAU/NzSmEsirJJSymLpwql wv+hWbxcr0jgWSQ45pPVs1xHGuCOypIzUlRpCFKVg11qRwbyu96m6KDhHPJpJTQ1KwURC5 e+dTIruhQ0k3lTbBS445l1BwJ3XXD+4= Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4V3rJk1kd0z4f3jMV for ; Tue, 26 Mar 2024 21:30:14 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id 6DF611A0FCB for ; Tue, 26 Mar 2024 21:30:20 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP2 (Coremail) with SMTP id Syh0CgAnlQjpzQJmxEQ+IQ--.31963S2; Tue, 26 Mar 2024 21:30:18 +0800 (CST) Subject: Re: [PATCH 6/6] writeback: remove unneeded GDTC_INIT_NO_WB To: Jan Kara Cc: akpm@linux-foundation.org, tj@kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, peterz@infradead.org References: <20240320110222.6564-1-shikemeng@huaweicloud.com> <20240320110222.6564-7-shikemeng@huaweicloud.com> <20240326123503.kxyxg75xr7wk3ux3@quack3> From: Kemeng Shi Message-ID: <2e1ac568-1883-700c-ba41-575f5db339c2@huaweicloud.com> Date: Tue, 26 Mar 2024 21:30:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20240326123503.kxyxg75xr7wk3ux3@quack3> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:Syh0CgAnlQjpzQJmxEQ+IQ--.31963S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Aw4rKr1xCw45Kr4xWr15Arb_yoW8KF4kpF sxGa1UKF45Ars29rnxCas7WrnIqrZ7tFZrKwsrCw4ayF4xGF1rGFyj9w1Iyr1UAr93Kry7 Arsrta4fZayjyrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvFb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lFIxGxcIEc7CjxVA2Y2ka0xkIwI1lc7I2V7IY0VAS 07AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c 02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_ GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7 CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6Fyj6rWUJwCI42IY6I8E87Iv67AK xVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvj xUrcTmDUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspamd-Queue-Id: 0196280023 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: obsiqgib6p7fw73d8cgck5rfrrigq47u X-HE-Tag: 1711459826-700774 X-HE-Meta: U2FsdGVkX1+K7nZtnU0MRgOMmhfrtRI/tXT9eaz4xWS6jLIknx5gGFJvgtrjdqiedWxLf4Csj70yrGwthP0+Mce+5/E9DXbKTGwCViGqF7jGfCcqF9RsWL3EFBmmWqsJofygG3evp5uBlOyPBBO3Y/2w9UadIC1IZzec55HMVnruBcar2uAdeQdW1WKSIEXixjEkgpJTiVlJeh4RoY64F3fJZzviNVCvjgLvjFekflENBVHkTuh7Ku4zB2sKoFsWPrCTHmtmeaw8oR/BLOXVx8k37Gdjt6TonG1asSzNGW6g5UowQf5yDKpVoDnears0MkdTivcWr/d/xqkX6c2Curc4GIIIJmR+hbm/+c43s4Rv3739dRxduToZzMXLebthQczuzCyeqifN+8ZKZkl2nQ321bjXV5Ps2YbvvPEiJPWciKHSeA4mYWHO4/JGlLxGulCUQWGt3GAVHjTE2FDX7VijSXihr3A9Qztv5KAJetw9x9KCXAZidudA4bff88v2w+HlL1pElkoILngjIz/C0aL92tCSE4FQObGUoUV9WLASn5EuTdxdKSVyTm7zk4WXmnxdu0aQv8KXQy2L+E8OupYpDTcv40OAOTtNU0JYquNJkgd+H/Ebo1zo9UOwLquF6o+pOYRmAczM7hmuPvJwmQf3yQdyIgxh1IsNorepFihVPb0mJpSTo8pqlDnD4/YGw7GTiWkwggn3HSKoUF4XL19MzTEimJ3VT4OvLVg9MXaj3K8zCwoxSJyJl1HkHjOHjxqOCj6OD+PBqfsQBZCIsejsbxndTdBX3Dx/DP/AAN3yrqNor145syh7hl2YQfGUdsKDdTeAABINDwb7D+TeGkJMdWlQF/5Aqqq6XIviEcijTQ43YLkiGk40C2OMMDdt3z1erEBUOL4lpw4j99QcCbdKE2ETK1pe1YvGtQNabhlvJ5lCNDIEJZaPouacoJptLEudFeNdqTQBCSBC3Jg 5SzdYIHY K3HfBE/+32/MxqbawGgUCpfirfBJdUvMOXwgNUd/Dg4LgyXgSLUPEoHpdLdMs/lQsHm+UA0BUHs9MvZAu21p3hc3nBe3CMqAZSQHcLZN/9nN2+VwRNcA+DXNgBEHGl5qsiJu0LvHOGzZX2EJYnF9ymD05kOzlPoCXFabPraLqSc0qCxi40out2ACcQd05U2o2eaWIyP3f6pI8lRAQKT/sAxxHrxJWBK66xSdZuMfzo8bDdgKAx3bFeSp2hm4ayc2JuzV63DP0/yft4p1ewKq6NSUi+oQ4LH2/TTrr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 3/26/2024 8:35 PM, Jan Kara wrote: > On Wed 20-03-24 19:02:22, Kemeng Shi wrote: >> We never use gdtc->dom set with GDTC_INIT_NO_WB, just remove unneeded >> GDTC_INIT_NO_WB >> >> Signed-off-by: Kemeng Shi > > Please no, this leaves a trap for the future. If anything, I'd teach > GDTC_INIT() that 'wb' can be NULL and replace GDTC_INIT_NO_WB with > GDTC_INIT(NULL). Would it be acceptable to define GDTC_INIT_NO_WB to null for now as discussed in [1]. [1] https://lore.kernel.org/lkml/becdb16b-a318-ec05-61d2-d190541ae997@huaweicloud.com/ Thanks, Kemeng > > Honza > >> --- >> mm/page-writeback.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/mm/page-writeback.c b/mm/page-writeback.c >> index 481b6bf34c21..09b2b0754cc5 100644 >> --- a/mm/page-writeback.c >> +++ b/mm/page-writeback.c >> @@ -154,8 +154,6 @@ struct dirty_throttle_control { >> .dom = &global_wb_domain, \ >> .wb_completions = &(__wb)->completions >> >> -#define GDTC_INIT_NO_WB .dom = &global_wb_domain >> - >> #define MDTC_INIT(__wb, __gdtc) .wb = (__wb), \ >> .dom = mem_cgroup_wb_domain(__wb), \ >> .wb_completions = &(__wb)->memcg_completions, \ >> @@ -210,7 +208,6 @@ static void wb_min_max_ratio(struct bdi_writeback *wb, >> >> #define GDTC_INIT(__wb) .wb = (__wb), \ >> .wb_completions = &(__wb)->completions >> -#define GDTC_INIT_NO_WB >> #define MDTC_INIT(__wb, __gdtc) >> >> static bool mdtc_valid(struct dirty_throttle_control *dtc) >> @@ -438,7 +435,7 @@ static void domain_dirty_limits(struct dirty_throttle_control *dtc) >> */ >> void global_dirty_limits(unsigned long *pbackground, unsigned long *pdirty) >> { >> - struct dirty_throttle_control gdtc = { GDTC_INIT_NO_WB }; >> + struct dirty_throttle_control gdtc = { }; >> >> gdtc.avail = global_dirtyable_memory(); >> domain_dirty_limits(&gdtc); >> @@ -895,7 +892,7 @@ unsigned long wb_calc_thresh(struct bdi_writeback *wb, unsigned long thresh) >> >> unsigned long wb_calc_cg_thresh(struct bdi_writeback *wb) >> { >> - struct dirty_throttle_control gdtc = { GDTC_INIT_NO_WB }; >> + struct dirty_throttle_control gdtc = { }; >> struct dirty_throttle_control mdtc = { MDTC_INIT(wb, &gdtc) }; >> unsigned long filepages, headroom, writeback; >> >> -- >> 2.30.0 >>