From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38172C02193 for ; Wed, 5 Feb 2025 02:52:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB055280007; Tue, 4 Feb 2025 21:52:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6018280004; Tue, 4 Feb 2025 21:52:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FFC4280007; Tue, 4 Feb 2025 21:52:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7D887280004 for ; Tue, 4 Feb 2025 21:52:13 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2CFFB47F40 for ; Wed, 5 Feb 2025 02:52:13 +0000 (UTC) X-FDA: 83084366946.26.8A91C38 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 06EFF140004 for ; Wed, 5 Feb 2025 02:52:10 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf23.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738723931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h+q2I+o2pIqkZ67hPtcNM7vfqWV0yzJJt2K9tkglYvs=; b=sYuHukyzijASsW8sKBT5F4vDT0Lfm7e1l6OfGXuy2N1HdtqrkBz0KL9mRA/wr2eps7GiGf 3z0hzKLJt5M/mXn6GKdppp4QacmQgB48jEkLyBXXQgcBf66BVxB9nsrO9B6FKC0niek7if wVkEZO8ALI/VSvUQ9g0L/tPSg8br85o= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf23.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738723931; a=rsa-sha256; cv=none; b=QOdEPUwiaKqJ5oVW1RTKPx+YN80yRGz2bKAU6t+DZ2jU0OV2R6yjISOcRpRbuCqUCsInNq lgQbTilu3p4SWX8wKBMi3I1A1b9z9C+oydJyVkmk68McV2f42F57gWCTfqi/OMsoq/Pmvm 6oiD/11L36EjQuqy6OcqcAq+Y4Dl9zg= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B963011FB; Tue, 4 Feb 2025 18:52:33 -0800 (PST) Received: from [10.162.16.89] (unknown [10.162.16.89]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8F6A73F5A1; Tue, 4 Feb 2025 18:52:07 -0800 (PST) Message-ID: <2e160343-8420-4f55-86b1-128676cf75d3@arm.com> Date: Wed, 5 Feb 2025 08:22:04 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Fix thuge-gen test name uniqueness To: Mark Brown , Andrew Morton , Shuah Khan , Muhammad Usama Anjum Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250204-kselftest-mm-fix-dups-v1-1-6afe417ef4bb@kernel.org> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250204-kselftest-mm-fix-dups-v1-1-6afe417ef4bb@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 06EFF140004 X-Stat-Signature: qb6it1ymo4oyesyzmnc98wk5oydaaypx X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1738723930-203374 X-HE-Meta: U2FsdGVkX1+p1tnsCxbB4guP9pv4Wpt7UVcs/AnA26ofcXuKgNxamyMySeq3F18QknJKFq2NvhrX3Del8rA1KLuBB4Oqb4mqY2TwLQlz9Khy4Z0Jr4yFzI297wksYKm1WW0hkanFqd6CesYZCVpNBKo6SmnB71duhGdCbxwWTvF7ny/IjIt6No0auFipZfGRA+QHj56e/KJEpio19TEN7a82rtuYI4ce3lbl2UnYfS/+Dv3q5VUZFITj3nmbc4fXvwQB08Z5qNYU1UUDbbdtHjGXPWzwjRPNbtaQmWUrKRKNTTYMo/WDSjf1gg6TuqAJ3uuDPiLanwL52pf/cOyjiqiTm71SGu7ZTMY+pTQuuV+BFejsy9Qpv0hLay/LxPjx63tOedfNPb+G5YsZA6hshHW5wmaDjaepOe/XTbwpYBGmZFFFjLnqB3WaNOA4gm59qvZmEuugOwmDt0IYY/0dRp2smCEiZecuCRnEhscJFtLvl1A7/JSRjiWOLyk4qmNwWf88xt8b4ylB20aDZpMj3Hnimrkpvr9ZNG46weNo6ghOz6EHOvv0XNNFbWOVbUXVGiiTdfz/C4WTPzrb2sr0S5bQgfm5lMRxnAHvFfJuk6UEjS7xym4kkZmJYY8quh2uildFJsKdyIMALpTsxbeVDZw98bCDnELHmuRqg+qYJMXNEQOao5hc1m7hi8idS7GdqxBts7Vt5SK6q5EOZuDMcqnV7cRKGjFTR5JqmIpTl4rsMowL9xDYluBvDP60gZ459ib2bfimKaRIMqw8bAeh+jq+VguqbMscel9NjX98FldbuSqrcd0CJumJGdUVikLuR5Eaur3OHyL8yt/r398hTfHtnzOO8BX1RSlBRb7hJkMJPyAcBC9mYBiUuKpFLz8qJkrza7y//TnfW8SCRMy+JhUyFgaaea/3Ub0p5o+Qe13J69AofyPgNB08ExSOHgrmXhGwZUrgPEs7mX23+a2 UdRpVquq Bm95cHyTPAdf1E4/qUPMjdK4y27C8TYISY9CXx0kNlwBmTx/trzgOzdelFGMgir5bqkioFwoiKsw8sWbw146UlXdGkpTHtHg7vAGzcosgU94vI60Lr/C9F3EyJRV4Odeqt0CIDoao+k/CGCHWzocVGuNbt+IBRjRQ64GF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/5/25 04:23, Mark Brown wrote: > The thuge-gen test_mmap() and test_shmget() tests are repeatedly run for a > variety of sizes but always report the result of their test with the same > name, meaning that automated sysetms running the tests are unable to s/sysetms/system ^^^^^^ > distinguish between the various tests. Add the supplied sizes to the logged > test names to distinguish between runs. This makes sense given that the size parameter is available right away. > > Fixes: b38bd9b2c448 ("selftests/mm: thuge-gen: conform to TAP format output") Just wondering how this fixes anything ? This seems like an improvement to the current behaviour. > Signed-off-by: Mark Brown > --- > tools/testing/selftests/mm/thuge-gen.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftests/mm/thuge-gen.c > index e4370b79b62ffb133056eb843cdd1eaeba6503df..cd5174d735be405220d99ae796a3768f53df6ea4 100644 > --- a/tools/testing/selftests/mm/thuge-gen.c > +++ b/tools/testing/selftests/mm/thuge-gen.c > @@ -127,7 +127,7 @@ void test_mmap(unsigned long size, unsigned flags) > > show(size); > ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES, > - "%s mmap\n", __func__); > + "%s mmap %lu\n", __func__, size); > > if (munmap(map, size * NUM_PAGES)) > ksft_exit_fail_msg("%s: unmap %s\n", __func__, strerror(errno)); > @@ -165,7 +165,7 @@ void test_shmget(unsigned long size, unsigned flags) > > show(size); > ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES, > - "%s: mmap\n", __func__); > + "%s: mmap %lu\n", __func__, size); > if (shmdt(map)) > ksft_exit_fail_msg("%s: shmdt: %s\n", __func__, strerror(errno)); > } > Otherwise LGTM.