From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33132C52D7B for ; Tue, 13 Aug 2024 20:37:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A93316B0082; Tue, 13 Aug 2024 16:37:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A43386B0083; Tue, 13 Aug 2024 16:37:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BCD16B0085; Tue, 13 Aug 2024 16:37:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6D2F16B0082 for ; Tue, 13 Aug 2024 16:37:33 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1DCA1A0AA4 for ; Tue, 13 Aug 2024 20:37:33 +0000 (UTC) X-FDA: 82448382786.15.191FC1B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id D14E7100009 for ; Tue, 13 Aug 2024 20:37:30 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FCu2CNIx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723581398; a=rsa-sha256; cv=none; b=oDY6OHMPcuRjH+BACLR2vDv6PZlfVrfxd87xOq73I0CofFbZbZv5x5v8w2D1gAIolnTiIP IlOssqtzHvPXs3d1VMlU85itVBshBaaOmZtllkD29RRpWqbSF2RdaXNJW7DwRkbjU0iUm5 fnpjJd2tbXAwzGAWe24eN1H2RhXFMnI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FCu2CNIx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723581398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=De9NMJzxGYMXCFYYNuYNKYWMOUUelr8gYoH0sgIr7zY=; b=L5nw20tUEgzsfbgrJU/bOQPU+c/fCJIog+234dHN+DSoTVB+3hjIxjZF1ZHPaQOayG6a+T 04/4uxaSj3F/Amhx88jDf+A9OTkC8HQ7Xh8cYYFJ68hNbdFJ2TnpBS9K5He1UoEcCYPTLu LTBBvvWS8NkIKgCMu5RfhMcpf3rwRpg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723581450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=De9NMJzxGYMXCFYYNuYNKYWMOUUelr8gYoH0sgIr7zY=; b=FCu2CNIxwbMtOAv5+EQReAe5SVWnO3Vm8RD+qslc+VhPzxbHfIn5xwBqx6LUW0HI75k+9s Dgwb+kh5IoLfGiR7QkwBpXrsKaXDC+WN2KgDIabs+EKf7FXbTFLhr4e94po0vfCIGhW6Wt OJOb89hAVuhpUq3fDD7J1wNKnqTzAIc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-NTtpF3jDNgqOhmtE890pQw-1; Tue, 13 Aug 2024 16:37:28 -0400 X-MC-Unique: NTtpF3jDNgqOhmtE890pQw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4280645e3e0so42566945e9.1 for ; Tue, 13 Aug 2024 13:37:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723581447; x=1724186247; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=De9NMJzxGYMXCFYYNuYNKYWMOUUelr8gYoH0sgIr7zY=; b=S7hkprbPxktLXsCeVnRWa/+cPQsueviLEMXza7QVHWid38glqskF0TzevVYhNfN7md IT5R/ek82C7OtwiLAsPX9p2Nw+NdM3mHHGe5ZVTXtLNSo/d2b4O3Qf+RYDWEKeYeIgmj RCE8Iu1f+dH7gpnK+AYF+inM8vpUNVGYuEf9tswyTP2U2ivjnpA+Lnkzy6uswppSeDog yM6Dt+vUxW/UBQd6IirReqKDuHaUiDx5TQ2yqmLU9rt+FlGy+QFvsRDq22ptHGQ673HO 0Fk9t2n6exopIG0ciCMbx3LHpeuui/+j1dUX57TFVI7yfbkUkHYpR6Xf4TgLbqlsbbpk dKGQ== X-Gm-Message-State: AOJu0Yx0G/XlD1iysfKcn+ZGUlcjcaiyJHQwkuzSte4H2+YyLA59+Iaf E7Nhs0hTEuX2dNI0hLGU5QLJs76TOwZhwPeJOPXBhMU4QZ6qxOdLmFRfOWGPuOnXkHGehYb0zCS k0cZUph80Jxcmq+U4R4+7mrwKAa5/uGW9mWcn2A3avD2JAdgJ X-Received: by 2002:a5d:6284:0:b0:368:74c0:6721 with SMTP id ffacd0b85a97d-3717780facbmr453744f8f.38.1723581446890; Tue, 13 Aug 2024 13:37:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcugufgzUZYf2EvsRoYFlOyZPm5fd34FmAlCTu8To2eSYdt0fLONv0y0UWPb/BR0XnGBGBJw== X-Received: by 2002:a5d:6284:0:b0:368:74c0:6721 with SMTP id ffacd0b85a97d-3717780facbmr453719f8f.38.1723581446384; Tue, 13 Aug 2024 13:37:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f09:3f00:d228:bd67:7baa:d604? (p200300d82f093f00d228bd677baad604.dip0.t-ipconnect.de. [2003:d8:2f09:3f00:d228:bd67:7baa:d604]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4ebd30f5sm11201902f8f.92.2024.08.13.13.37.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Aug 2024 13:37:26 -0700 (PDT) Message-ID: <2e14537b-cf91-479d-a665-c3e174cf2c66@redhat.com> Date: Tue, 13 Aug 2024 22:37:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] userfaultfd: Fix checks for huge PMDs To: Jann Horn , Andrew Morton , Pavel Emelianov , Andrea Arcangeli , Hugh Dickins Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qi Zheng , stable@vger.kernel.org References: <20240813-uffd-thp-flip-fix-v2-0-5efa61078a41@google.com> <20240813-uffd-thp-flip-fix-v2-1-5efa61078a41@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240813-uffd-thp-flip-fix-v2-1-5efa61078a41@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D14E7100009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 8ed69ck51mr6z4gfqbnnx6choicx78sn X-HE-Tag: 1723581450-378466 X-HE-Meta: U2FsdGVkX1+m3QkXYu63uE+rTKyw7fAjr/JqnEpsl1f3fuHkTy29LUB3mtMpv4K2F5QN0DZcrq3OlCV3x7uvRlo6GbWy3qkKWrfsI6JUHYZvvkW0J/yeMuehJftgOFnmjYl7WdACTVQrbU64c2EuaUlsu+zCSttGvubg+8t6VtM7iLjty4N0JbkXHCu1/LqJJp4/XlAedfwoAmBnN9J8YYUoGePd5O0wjvaUjE8tGRNjuR9M8OcwyKc9/Kp5q29NpV8eoAzN0/Oh/mHMxPl4on6dHxeUHgIVIo5tCtdQQZQibxfpy1+uFzPvxKgPXI2ANwULjsoVovQFk+JlaM9C+Z0eMGNJ8ILgaqQbv05hku9YY9UX9NQPMfj5anQX4ZoE36DkNGSngz+QJDJjd9pU2/O5AB2Ue4pPv0SSaYql/kEwWNdGnGgnOUMMEd2UYH/V8MeJNcAlZju1YRVpz2iMYAu59o7CQ30jYf04YrM4IO6bXINfN50jAgiodKCBj6OnLNit7cga6fmCrZ4Q7ta0QwXhpPMf7g97ZRkj2ktNBf4ZvnZC3qQaWqa7Tam8J8i8aYJQxb+zZN6xOskL9XeHVhIvgXD08el/ahKRU4S7xxvGciO+nk0FDWg00BR7JLHepbitUM1HLuKhzKG5CRf4Cv1N9yZzZ+gk5Udfz83JxZrsMSpXBxNrBderf+DVkrLCL+e4wAP95Ogo5PUdIPz0J79CFUIAvmHU0fwlSDlC+iWs9kaUiZksvk8N3GJiKJGm7rFTYbJt/SxtUm6kF6I64Hf+S2wrz59ROVUEMwmxwJ/a4eUzMN76rFOHNn9G8quMaLfK4M3Ahfl2er7BQ0R7e2tKTkg5uzohsrVSdQ38TottxNOhNmLqGhKq95FtsuAATMyKKCACkQosT0l5p3PnBdQLyhUkQ65yLO74jiSuNEUf5zI3+3RU2pG+27BVOxcCTVU+iNJ1KjwQ/7noGuy jKOZ90HX qeFYEUuxkl9N+8ytZCuEyi9l+QdOBVtXe1eMYL5jIc3aeeN9XO1ADMZH3+hde6DvZl+jSPjj6clnIaO4CfWVQiZr76mFmiUhwxuAF9p5PfGJK1gv2Z3rqYJTn10FIW7IyoA0uJqGQ+ovfenEppkNaNsjAO4UK14MuGkCBT2wxkrYWR3co5O+gndEzFaGRameQXF26WVCdeoGRUgyJFRu3UnyBisQEn/cHA+HU3jtOPTC23jAjm1cvE4gt/bM68XymqkZjYZFexyE83tVzU6PioWVEJoAzJijSNgQOVqL4mXmognufjidsJCQEXYTLmqlVmJiV1/PQSwcfNhHvUkJg8CSQ54mjow/1l8iMjQSWRAfG0umF3+hehZDb1Nc5w8aFdCLNgGJaF6bX3CY2935PVf83OjVEUx1/PNLh+lOHVi7UjXgVAwvlj/EASWRHlSMrQDTRls1j0XunBQMcsvgPrXLwGErM1NZigpnmfwwtFQQGhtZHE9Q3/ptebUphL+zDoUOrA/QhVoTpJN9lwdydIxQ5J/I9R3Z69SNOT6JnIDrGr2Fb7/YGPngTuq72gIdQlwoMwuyrIW8SmRpl4uRYb61Hz/BXKiWWC0Nze+kgnzhriXjvjp4k/wLjQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.08.24 22:25, Jann Horn wrote: > This fixes two issues. > > I discovered that the following race can occur: > > mfill_atomic other thread > ============ ============ > > pmdp_get_lockless() [reads none pmd] > > > > __pte_alloc [no-op] > > > BUG_ON(pmd_none(*dst_pmd)) > > I have experimentally verified this in a kernel with extra mdelay() calls; > the BUG_ON(pmd_none(*dst_pmd)) triggers. > > On kernels newer than commit 0d940a9b270b ("mm/pgtable: allow > pte_offset_map[_lock]() to fail"), this can't lead to anything worse than > a BUG_ON(), since the page table access helpers are actually designed to > deal with page tables concurrently disappearing; but on older kernels > (<=6.4), I think we could probably theoretically race past the two BUG_ON() > checks and end up treating a hugepage as a page table. > > The second issue is that, as Qi Zheng pointed out, there are other types of > huge PMDs that pmd_trans_huge() can't catch: devmap PMDs and swap PMDs > (in particular, migration PMDs). > On <=6.4, this is worse than the first issue: If mfill_atomic() runs on a > PMD that contains a migration entry (which just requires winning a single, > fairly wide race), it will pass the PMD to pte_offset_map_lock(), which > assumes that the PMD points to a page table. > Breakage follows: First, the kernel tries to take the PTE lock (which will > crash or maybe worse if there is no "struct page" for the address bits in > the migration entry PMD - I think at least on X86 there usually is no > corresponding "struct page" thanks to the PTE inversion mitigation, amd64 > looks different). > If that didn't crash, the kernel would next try to write a PTE into what it > wrongly thinks is a page table. > > As part of fixing these issues, get rid of the check for pmd_trans_huge() > before __pte_alloc() - that's redundant, we're going to have to check for > that after the __pte_alloc() anyway. > > Backport note: pmdp_get_lockless() is pmd_read_atomic() in older > kernels. > > Reported-by: Qi Zheng > Closes: https://lore.kernel.org/r/59bf3c2e-d58b-41af-ab10-3e631d802229@bytedance.com > Cc: stable@vger.kernel.org > Fixes: c1a4de99fada ("userfaultfd: mcopy_atomic|mfill_zeropage: UFFDIO_COPY|UFFDIO_ZEROPAGE preparation") > Signed-off-by: Jann Horn > --- > mm/userfaultfd.c | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c > index e54e5c8907fa..290b2a0d84ac 100644 > --- a/mm/userfaultfd.c > +++ b/mm/userfaultfd.c > @@ -787,21 +787,23 @@ static __always_inline ssize_t mfill_atomic(struct userfaultfd_ctx *ctx, > } > > dst_pmdval = pmdp_get_lockless(dst_pmd); > - /* > - * If the dst_pmd is mapped as THP don't > - * override it and just be strict. > - */ > - if (unlikely(pmd_trans_huge(dst_pmdval))) { > - err = -EEXIST; > - break; > - } > if (unlikely(pmd_none(dst_pmdval)) && > unlikely(__pte_alloc(dst_mm, dst_pmd))) { > err = -ENOMEM; > break; > } > - /* If an huge pmd materialized from under us fail */ > - if (unlikely(pmd_trans_huge(*dst_pmd))) { > + dst_pmdval = pmdp_get_lockless(dst_pmd); > + /* > + * If the dst_pmd is THP don't override it and just be strict. > + * (This includes the case where the PMD used to be THP and > + * changed back to none after __pte_alloc().) > + */ > + if (unlikely(!pmd_present(dst_pmdval) || pmd_trans_huge(dst_pmdval) || > + pmd_devmap(dst_pmdval))) { Likely in the future we should turn the latter part into a "pmd_leaf()" check. > + err = -EEXIST; > + break; > + } > + if (unlikely(pmd_bad(dst_pmdval))) { > err = -EFAULT; > break; > } > Acked-by: David Hildenbrand -- Cheers, David / dhildenb