From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F2FEB64D9 for ; Wed, 12 Jul 2023 09:04:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4EC66B0071; Wed, 12 Jul 2023 05:04:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFF326B0072; Wed, 12 Jul 2023 05:04:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C74F6B0075; Wed, 12 Jul 2023 05:04:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8E9916B0071 for ; Wed, 12 Jul 2023 05:04:03 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 603991A01D8 for ; Wed, 12 Jul 2023 09:04:03 +0000 (UTC) X-FDA: 81002372766.24.E8DDC73 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf02.hostedemail.com (Postfix) with ESMTP id 792CE8001C for ; Wed, 12 Jul 2023 09:04:01 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=YsTuUc1j; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.42 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689152641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1nuWks/h7+PLBflf1v26FbRi70eISolCyE8GT50y1mU=; b=BuH8lHEPDEGCHh9RBNYJA+HNK/UTq3ag6k315FLmCw4mdH7EiVpCRv4BpvX3vlVeVR9Riq 8ElzFWMPzHKmUJWAu7GXf88tVcxW/3+stEa5RmzmoY+rmjYb9SBiXDDjhbF2+Y8S1eW2D0 V78Bie3++8q3PIGBcptRNR1oJwDBxNg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689152641; a=rsa-sha256; cv=none; b=gPd9FEuqC/Ky7sDTnBc0f8O/o+8wkPRDFkAwwgviWz4fAVR552tuA9JAVwol7bwlZ5rOF8 rFli9NWnPZTvVjY5yyQn7+OLKozo5PqQGqIft8qPmTDazzW9+PRTaf1UxRNjtNbbPTEOEs YoTKPKsV8jhHB5GvhZwZYZ+IPqlJgS0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=YsTuUc1j; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.42 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-3fb4146e8ceso69419215e9.0 for ; Wed, 12 Jul 2023 02:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689152640; x=1691744640; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1nuWks/h7+PLBflf1v26FbRi70eISolCyE8GT50y1mU=; b=YsTuUc1j+RJXAfWRHqdirI8pWfJDO1wGUMOIPQKCWQrgt8J0O1lCYf8u5uSYkraAE9 iQAhnIZLRsSvVSGYIUoCK1BUDcN9oxAJPKk+/lmegk5unzpK0VYr6guaTxwYBBEKT1J+ giOaww7NWjq+bDw291bfs7yymqfVVUC6lx7a8dTtA4NHraOvN5IrjAVUruEUXOazKvdT n48MmMTD9r8N0++JUkfyeZjnLQpGBxpJvm8+jK3rkG+eqzJYEMyivehuLA/abYdDYDGn Yb/f3qBvrOrpZD9BLcXJLPONwY+Y6SpSPkHuLS9cNXqegTkX0Wjhh2PuIdZKdqwHqnTu +sTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689152640; x=1691744640; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1nuWks/h7+PLBflf1v26FbRi70eISolCyE8GT50y1mU=; b=g+Y7MQsKBYDxoJWknJ3XQ+NENVWPuPu6SAPUtgMfwJBOMkNLFQKeOzKh0ahDmzd6/d 6B1rZVnxtoTaljOY3Om+lFqzonoWQ7HzqbkoB6Cy6KmRLyQX0xQGFBsV2vyJPgwTr3qn 15ZfBqpZ4hHfYtrVUjHnsagb6/CW+62D5BDQ1MW25VlyvxAluCvTKl8ONy2p+dS4snBi jLBkUwUk77MONT2EVTIa+JM7w2sHPgir03bk8Z/3cg+jZVRrcuVIB7z2BBryB777RsBH 7kDD4nFB8oeI31ASZCwq5UJdCLyxBSQPzxNjU82+wEuRySb5iwoXMvMZvlHsf5wRPmUX e/xw== X-Gm-Message-State: ABy/qLYtrEYgR4oKt5MxBogPRF/q+n+N1zEQJOIa3rTnVkWpISs1Yv4C VtJQ7P4pxc2dWSWLrlqSaS3VOA== X-Google-Smtp-Source: APBJJlF+CNeA+L2/Un4arddKohn7hEb/z2BzeYIY4X/CNXjX7bxqK2gLPkB0ZPqQUaSpVlVvRX2yMg== X-Received: by 2002:a1c:4c09:0:b0:3f8:f1db:d206 with SMTP id z9-20020a1c4c09000000b003f8f1dbd206mr16183478wmf.25.1689152640043; Wed, 12 Jul 2023 02:04:00 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id t22-20020a7bc3d6000000b003fc02218d6csm12761633wmj.25.2023.07.12.02.03.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 02:03:58 -0700 (PDT) Date: Wed, 12 Jul 2023 09:50:25 +0300 From: Dan Carpenter To: Hugh Dickins Cc: Andrew Morton , Axel Rasmussen , Peter Xu , linux-mm@kvack.org Subject: Re: [bug report] mm/pgtable: allow pte_offset_map[_lock]() to fail Message-ID: <2e10ca45-fa3e-4383-9565-ee143a50e341@kadam.mountain> References: <3ac58297-c3b4-4ef3-9743-d96a477ac53c@moroto.mountain> <7d4486c5-679d-67f8-dee4-f33d2b73517@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d4486c5-679d-67f8-dee4-f33d2b73517@google.com> X-Rspamd-Queue-Id: 792CE8001C X-Rspam-User: X-Stat-Signature: 96ytknaf7pndsiny5tqf6ihqwmdgtpac X-Rspamd-Server: rspam03 X-HE-Tag: 1689152641-451472 X-HE-Meta: U2FsdGVkX182eKGxJEC7fq9jVpysTwD1u6uiDEdgwoAxAMrBcFny+G3m7sDw++FMkpsUe2Nmc46EJHkgDPsOca0VHzay6UlEc6D9bm6YPE0FhmzG6Hq+ZuzQbsp+Petb/oJa6KBgnKbEE0qnN+13/wsBt6JDzxjNhIIw8ujw75N2ds4ZclpVYYruFfIecun2TX08dVoiXNYnT0BY9QbCZgaklhQ3FR59q8fDRbxREU2UOcVZObfLNzZWIL9X+inj2st9AXB2YDOHKqP4k7xsEJdp5ruObuarmPg8o9/zz7QOHwSp42XoUFycZP5RZ4LH/4johYvVUpSxieTen+omvDnGXYMmOAKnCXcrBUu4Gbk5yad7YJj2QKoCWn9B92SypmmzVz736BUC4DO+xYs3uJ7tvBtsqdlKcTzHyY5sLtD6zgOtwP0zwgdB4WWjF+Vz1FFZrt/ufThLhoBPDEjk1vnKO1ecn3eCOdUJnfvPMfFlZ1n5BduPkYRNwGSXBzwva8qFIweaZdmaUL5Y76y/g0UTbGLF0bhNN3SfmsD6qU/xx3ycCSje2XjbhAHpWEGRFa+5k71dDz6j4kNL9iD2CGaO32ov66+4otn4zDSfxlyBkPQi3oi6RchaLYINmSilU9EqB5MU1O37/f6ES2bwoSF6l8IfwZ1XrwkWJvLtSGkfjjZ8iWJ6mPFOMRFfWeN0GLqsqCAnhJ03Hgdzo5jvTSPaQSPCESIzTdRLmFsyTqJX8Rprfd0Gi7W7qL0n55tmaO6/00xUCH7ZZXjn4OxWiKUof/aKtsUPiXHcFNhnPCHDASvQHzjJHiqfEt/LNb/d/n2LeLrwvGJDx3aquQ6Wfxof3LKwHlmUd9ZbmYkASuJEFK5P8lYqloY2bmzfci3jlcZON95PwlhTemq4ELmmj2Iuz5vFAqMA9ycdQMUAAYrdk618yzIAuEzgKi1KcqUHTcK3KKaNCNHK4s6a31t YrEuSe8J WQr5wvMw5JlLiA6qu87dpzrTLAT56GQEZ3n0Xgv1mKJpXWpAdXPpmXOH14OhrZJ3I2C3TgPsklFGrjcHqL8WBW5KjvUy0/5yCr886wD9BTetq81BBgZd5DsJvs+CuuHhIwSHaSGcVEHC/R63uDZ8PQjk8lSDfJrVgqIV6lXUafa3kmnoTdAgm0UbjE1DR4C/hTslGRU0Cwq/QT+cq3Ax3gSnQHeV0EkGz4DQxbbUSbKJcMmE5duWUauQBYG2nWPLXuOmR9ShBGwYkb1S7iHXFETFe37wWFKNJDEuBLRKr0yrVJ73J+6rBz2GLqOSuPOBTwj+oYaOOoD4p5KF7GtLupO3InX8YJFhJ2G27 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 11, 2023 at 06:23:07PM -0700, Hugh Dickins wrote: > On Tue, 11 Jul 2023, Dan Carpenter wrote: > > > Hello Hugh Dickins, > > > > The patch 0d940a9b270b: "mm/pgtable: allow pte_offset_map[_lock]() to > > fail" from Jun 8, 2023, leads to the following Smatch static checker > > warning: > > > > mm/userfaultfd.c:321 mfill_atomic_pte_poison() > > error: uninitialized symbol 'ptl'. > > In mm-unstable or linux-next: not a problem in 6.5-rc. > Thanks, Dan: yes. > > A little unfair to blame my patch for code that went in later Sorry, Hugh! I just saw your name in the git log and knew that you were a person who knows how to get things done so I didn't bother looking further than that! I will add that it's on linux-next to my bug report template. regards, dan carpenter