From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 869E8C433E0 for ; Mon, 25 Jan 2021 06:28:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CFEA7206B7 for ; Mon, 25 Jan 2021 06:28:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFEA7206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 06FA28D0002; Mon, 25 Jan 2021 01:28:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 01FA28D0001; Mon, 25 Jan 2021 01:28:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E77AE8D0002; Mon, 25 Jan 2021 01:28:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id CFACA8D0001 for ; Mon, 25 Jan 2021 01:28:14 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8D7BD824999B for ; Mon, 25 Jan 2021 06:28:14 +0000 (UTC) X-FDA: 77743317708.24.key67_390908c27583 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 675E31A4A0 for ; Mon, 25 Jan 2021 06:28:14 +0000 (UTC) X-HE-Tag: key67_390908c27583 X-Filterd-Recvd-Size: 2196 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Jan 2021 06:28:12 +0000 (UTC) Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4DPKdl029jz7ZgK; Mon, 25 Jan 2021 14:26:51 +0800 (CST) Received: from [10.174.179.117] (10.174.179.117) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Mon, 25 Jan 2021 14:27:58 +0800 Subject: Re: [PATCH] mm/filemap: Remove redundant variable's assignment To: Baolin Wang CC: , , Andrew Morton References: <08dc7237b44b9455ab095b44dc6969a1607b08db.1611544316.git.baolin.wang@linux.alibaba.com> From: Miaohe Lin Message-ID: <2dfe7c46-f8a3-a28b-021b-7c6f4d2843f9@huawei.com> Date: Mon, 25 Jan 2021 14:27:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <08dc7237b44b9455ab095b44dc6969a1607b08db.1611544316.git.baolin.wang@linux.alibaba.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.117] X-CFilter-Loop: Reflected X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/1/25 11:20, Baolin Wang wrote: > We've already set the variable 'i' 's initial value before using it, > thus remove redundant previous assignment of variable 'i'. > > Signed-off-by: Baolin Wang > --- > mm/filemap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index e4906f5..07b02f3 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -2472,7 +2472,6 @@ ssize_t generic_file_buffered_read(struct kiocb *iocb, > if ((iocb->ki_flags & IOCB_WAITQ) && written) > iocb->ki_flags |= IOCB_NOWAIT; > > - i = 0; > pg_nr = generic_file_buffered_read_get_pages(iocb, iter, > pages, nr_pages); > if (pg_nr < 0) { > Reviewed-by: Miaohe Lin