From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3AC4C433E7 for ; Mon, 19 Oct 2020 11:54:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3272B22276 for ; Mon, 19 Oct 2020 11:54:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NKc+eQg4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3272B22276 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7529D6B005D; Mon, 19 Oct 2020 07:54:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 702B76B0062; Mon, 19 Oct 2020 07:54:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F10F6B0068; Mon, 19 Oct 2020 07:54:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 2F0716B005D for ; Mon, 19 Oct 2020 07:54:57 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C57B98298A3C for ; Mon, 19 Oct 2020 11:54:56 +0000 (UTC) X-FDA: 77388518592.10.lift48_500085627236 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id A054D169F9A for ; Mon, 19 Oct 2020 11:54:56 +0000 (UTC) X-HE-Tag: lift48_500085627236 X-Filterd-Recvd-Size: 2978 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Mon, 19 Oct 2020 11:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603108495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=syJyp0LZAACFoq8I2v22ukFUQBSHrf8TktVNFyazXaM=; b=NKc+eQg40hb5VyDZ0jACx6jOtv/LayqfyqvFHXpIGF/9GY0LvjpmcH2r/9Iz+tZ6h1CUb6 zl1KuxGWVBgdkw1FS5xoPCOOhYgH2EKBQtaPDDC4/mY6w1sD9n0dWWKR6oUiwmCIZiljfp czWj0mUoT/jy/F0xUNe+jp8lQFcLeWA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-264-PE9Of15rPs6GGKWQecEMog-1; Mon, 19 Oct 2020 07:54:51 -0400 X-MC-Unique: PE9Of15rPs6GGKWQecEMog-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 30F3418A8220; Mon, 19 Oct 2020 11:54:50 +0000 (UTC) Received: from [10.36.115.26] (ovpn-115-26.ams2.redhat.com [10.36.115.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 185AD6EF41; Mon, 19 Oct 2020 11:54:46 +0000 (UTC) Subject: Re: [PATCH v3] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone() To: yanfei.xu@windriver.com, akpm@linux-foundation.org, vbabka@suse.cz, pankaj.gupta.linux@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20201019115044.1571-1-yanfei.xu@windriver.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <2dfd5820-ca92-8a73-6dcb-00b6ce6c735a@redhat.com> Date: Mon, 19 Oct 2020 13:54:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201019115044.1571-1-yanfei.xu@windriver.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.10.20 13:50, yanfei.xu@windriver.com wrote: > From: Yanfei Xu > > There are two 'start_pfn' declared in compact_zone() which have > different meaning. Rename the second one to 'iteration_start_pfn' > to prevent confusion. > > BTW, remove an useless semicolon. > > Signed-off-by: Yanfei Xu > Acked-by: David Hildenbrand ^ huh, where does that come from? (you should only add acks in case they were explicitly spelled out) Anyhow, now you can keep it :) Acked-by: David Hildenbrand -- Thanks, David / dhildenb