Re: [akpm-mm:mm-unstable 175/198] {standard input}:63: Error: symbol `__export_symbol___totalhigh_pages' is already defined

[David Hildenbrand <david@redhat.com>]

On 11.06.24 16:55, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
> head:   2e3df1a7bef9c2814b80049345f2a53706f82001
> commit: dae48e2d159fa9b7d6956b72cf3ebff6cd5e0de4 [175/198] mm-highmem-reimplement-totalhigh_pages-by-walking-zones-fix
> config: csky-defconfig (https://download.01.org/0day-ci/archive/20240611/202406112233.GT7V4e9f-lkp@intel.com/config)
> compiler: csky-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240611/202406112233.GT7V4e9f-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202406112233.GT7V4e9f-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>     {standard input}: Assembler messages:
>>> {standard input}:63: Error: symbol `__export_symbol___totalhigh_pages' is already defined
> 


   AR      drivers/media/platform/nxp/built-in.a
   AR      drivers/media/usb/siano/built-in.a
{standard input}: Assembler messages:
{standard input}:63: Error: symbol `__export_symbol___totalhigh_pages' is already defined
   CC      net/ipv4/tcp_rate.o
   CC      drivers/input/touchscreen.o
   AR      drivers/media/pci/mantis/built-in.a
   CC      kernel/sched/core.o


The placement of EXPORT_SYMBOL(__totalhigh_pages); is clearly wrong.

Seems like Andrew inserted it at a different place than planned [1]


 From 7d3c3e8efd1ccf9ba4a8fb8571bfdeb21fc5ee86 Mon Sep 17 00:00:00 2001
From: David Hildenbrand <david@redhat.com>
Date: Tue, 11 Jun 2024 17:24:19 +0200
Subject: [PATCH] fixup:
  mm-highmem-reimplement-totalhigh_pages-by-walking-zones-fi

Signed-off-by: David Hildenbrand <david@redhat.com>
---
  mm/highmem.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/highmem.c b/mm/highmem.c
index 3e89639cec1a4..ef3189b36cadb 100644
--- a/mm/highmem.c
+++ b/mm/highmem.c
@@ -133,10 +133,10 @@ unsigned long __totalhigh_pages(void)
  		if (is_highmem(zone))
  			pages += zone_managed_pages(zone);
  	}
-EXPORT_SYMBOL(__totalhigh_pages);
  
  	return pages;
  }
+EXPORT_SYMBOL(__totalhigh_pages);
  
  static int pkmap_count[LAST_PKMAP];
  static  __cacheline_aligned_in_smp DEFINE_SPINLOCK(kmap_lock);
-- 
2.45.2



[1] https://lkml.kernel.org/r/b57e5bc4-eb72-40e3-add4-57dfa6e03df6@redhat.com

-- 
Cheers,

David / dhildenb