From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEBB5E77188 for ; Fri, 20 Dec 2024 15:20:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DF956B0083; Fri, 20 Dec 2024 10:20:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 38DF56B0088; Fri, 20 Dec 2024 10:20:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E2566B0089; Fri, 20 Dec 2024 10:20:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EFD486B0083 for ; Fri, 20 Dec 2024 10:20:09 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 95FEDAFA99 for ; Fri, 20 Dec 2024 15:20:09 +0000 (UTC) X-FDA: 82915697844.29.1AE834B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id D2E6440011 for ; Fri, 20 Dec 2024 15:19:39 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Vq4XQT8E; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734707991; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GSLhLAF27Dus1djWbXuEQF2P4ueNwx/IWO+wl4w6Zb0=; b=rtkIRNEq6pD6IfHLFlYNTaJWFV59euds+irUbPu1FmYQogrDa5LU727GLMzYc0O2eLYJbD lHL5MfFxoQ3f5yEOqnp2uQenZxdvIJ1SZ2HT0aBQN6W+fy2EQBqzzRko12PFrTWnh8JF/R p86UAmv4wm6gvciIR5wuLTEqUk9bV0I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734707991; a=rsa-sha256; cv=none; b=BX5vSF8D63B7m/OICWrCBNTBHLlQDumyPiXFlg2ygCl3cX9BGQtnK437K47riUqbV33bh3 wrgyXnCGjf7P4SN5nZxvFNrLEHL7opI6fB8n8RpRN4c8YW7I8KT2kUuwcr8iiCQaQ9WqfB ejLu4eB86BsFVd2uf35hip52USzwm6M= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Vq4XQT8E; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734708005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GSLhLAF27Dus1djWbXuEQF2P4ueNwx/IWO+wl4w6Zb0=; b=Vq4XQT8Etal4YtTTHfMk3r0aZNjSqU3Om4Y/dcqkCOKyMewLcdAT1PBub//zOErh2W4Qjt QFe2xD5MllZgHfoRi+9QGI6EBJY2Q6La4i+6zQ5uco9aefem/I6dlEa7es/vA34B3UK8Xu dKUNAOET/v4b7awl6AKeaQT6Lo2SS3g= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458-0mx2hdaCPui6VHn9QGjr2A-1; Fri, 20 Dec 2024 10:20:03 -0500 X-MC-Unique: 0mx2hdaCPui6VHn9QGjr2A-1 X-Mimecast-MFC-AGG-ID: 0mx2hdaCPui6VHn9QGjr2A Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4361c040ba8so11916045e9.1 for ; Fri, 20 Dec 2024 07:20:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734708002; x=1735312802; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GSLhLAF27Dus1djWbXuEQF2P4ueNwx/IWO+wl4w6Zb0=; b=a0Zea5jJmdPO96izoqPX3VdKy2vcB/ZfaeOc+CqytoMretRX2VOdRDW8GKKQw4l7E2 HhA5U6gFOoLBuiVzvDINC6UmSIvJwZWm0i7Yw/ibgHgUhJwgcWUojrHsZr0Xw8xu0bc9 OnlivU2nJc2Y2esWr4ifAnBer3mGUcVMonn/OadLinkAqTgd8Y8/gh7qjktgyd4v3eDz oBC00CUUC2N+s2v2e3nmN137dE4rZLMjcC1cecBNmnHd5jgHVyPgMdnZ2n0owCDQ8inb abAfmWvdgwmst40CKsq02NM3LSLWlTBzR4pgENHEOlu5Gdy5qobR12qp3OMvE0gHdPi3 /Uug== X-Forwarded-Encrypted: i=1; AJvYcCUGcPVEP8ehGhXi3GK4YvZCRiDGIyTYlElH3lcP+FQBhTQrpI9WvPO20tTCT2+xDkjxiRQz5BNqPQ==@kvack.org X-Gm-Message-State: AOJu0YxBQNWk/amA4vNCSHX39Rlv0HOub3++AuoMy/qN5O74/jjgAH1i cebwxsD5BEDTizoqMk21r6Ek1yqGE5FdNNODG0iZP11HLbn1g5VSY77lKtF79aJNN0ixmUDKxCi vunK6E17p1LeirefYPXFf6WNniC2pSdD3KC1zp+JXgkeFDre0 X-Gm-Gg: ASbGncvo3iYUj6BVcdEMHsdSC9NM6JHCBX1bKNjzIvd6WDUmGUXuBqhUtRgejt8Z9Xu 55rFBuMAIjqg9wLY7P+MluTSLqCeiQvsBhy90gVA/RXv2pCrczkhFtEPRo7TkOYE9JI1UcrC6IL YMPcA2tEUC0x56nfUPqHj3BkGMdNA3ql9cxL0AIERbjDAoI+glqMosPzq2Mh9SPcLwZHcuaIe29 nrZou7z3mlwZKpjG3QyyjJ2c98c5lGV9UVmBcOeYKevuK1kzALpcjabdS7iXxpYDaG9AbE0bF1V iH26h2hkAoQoCnI/pAITP6DuEoPm6dXgZM5SuVcTK+uyWjqKqTPgoViOtFUVCyorDiTjhDnRLca cNB5tP1kV X-Received: by 2002:a05:600c:5488:b0:436:5165:f21f with SMTP id 5b1f17b1804b1-43668b498ddmr26296535e9.26.1734708002600; Fri, 20 Dec 2024 07:20:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IEW1Oqhfdpc6oK9Vd1HWU9G3K1S0GmvUViZlC6eqIxnVLitf33vN/LN4J02Qp4R9fzoO9abEw== X-Received: by 2002:a05:600c:5488:b0:436:5165:f21f with SMTP id 5b1f17b1804b1-43668b498ddmr26296315e9.26.1734708002277; Fri, 20 Dec 2024 07:20:02 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c832e53sm4265574f8f.27.2024.12.20.07.20.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 07:20:01 -0800 (PST) Message-ID: <2dde1a51-f4c2-4e0b-8ac6-b9859e194304@redhat.com> Date: Fri, 20 Dec 2024 16:20:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/11] mm: add PG_dropbehind folio flag To: "Kirill A. Shutemov" Cc: Jens Axboe , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com, Vlastimil Babka References: <20241213155557.105419-1-axboe@kernel.dk> <20241213155557.105419-5-axboe@kernel.dk> <042d3631-e3ab-437a-b628-4004ca3ddb45@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XAZtMSVAJrviiYF1DUJ0rzuv845FSlP6mK6apu7AvmI_1734708003 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D2E6440011 X-Stat-Signature: 4mr5ekczo81qsud1f1iidityc8ap6ace X-Rspam-User: X-HE-Tag: 1734707979-331667 X-HE-Meta: U2FsdGVkX19qlNPyFdkQAg5D/kVBrZg2ymYe8xgiR64pJCuUds6YfbMwcD+6FQgT3VbnP6+kwrozwtAZlrDl1uFtiSylsfBfPLMIGyjgTFHZxTZ+ejszuPKwY+2pNyMUfquoWHFDU3X8rjzVatCVBWC6fThTW0tflCSfpRp7sbfHNGMX6wbLOfn6mej0m1ELCT6DASe9LxJxXFgDQWoBOi3OiIQX9uRk6VufeRBf8guyWBEnvo3AKZX+inyU5u+TyGdp9lff8gTatCcduoYp92uLVpThVGGdR/fPpeBS1C/ol4xbK++0zXYT5lSOyUiHOlNqfREcNNhSmbNKJ5KaJwVuvLfgM3kMLb3kcgKWNrTp6zxBVPFtdi4EDr/QCMGh/QqMQ5CFOWu78nV5pp+biXB4NczMaKoBp7OksGG9wQAokZ52a6JSh22MAXePmuW+dE19BxLFw8G5+U05yp0g/esr4N9VvkCRnZWoTuY9c96xmk6iih5bYfFnzuiK+T5VL5Ws14bwDDtexqKdNuORa41Gu2vfRWZ13UZ70pgzGdOqgcoMqmbZdf4XI4Cb6uK6qgncC28lf16rg/bHz1OUeBb/1J+UI+CQeCZRzQR2ix84H/RbZ+ylC6OkxT5HVmx8TbdS1/pcog2BbrCK09ds5Ss5n6lCxgm1OGNlfPyCQsUOJZNJf6KDDwI3Hzf+s+lBryBuU5MdBfElG3KlvtlxFdzUinmt9yhL/0gjj1QRa+Phq7YI7QhPLE5R8TH6rIMw+fK5tPAhc9JGlaOrlWM+2Wts6iFATm0VMIwwyCoUJdHdkzCFeK+7I66a697gElhRsEwdwCuzr50ANnmSlJQu5vnePaHFD4H1db55PQqEPHQneLejfmjhOrSgNzLnrQZTLtinH6gBbvIFdB3e3fR8OKT/5Pq8K4dxdZr1Lt2haFlexYy1K00jU5htz14eMIE8xNCWBV1j8IanJ1qp9QR kBuHZsH3 KSmCPex8my8t92XbiqbtEU+I7qNrTnWlaWS6hoS4g3ijDSzvjxTTqhyl8ncw2ZA+cSGvCF58/0DvGCqgvrnTmmeoRL1teUxq0aO1L8NZ6s+nMZWmQAk9skOvgu7CfUapdLI0rsQ1u5lvi+ukbFGdoujY9CnSN5JHmKCslyY/esChfrBAgaydVla9X0F2rJgLyWFVFwO4UW65kIsGEEAYzA+cbC7DxazCGvsTRnWOoyS41evTUhDoPoS9+PLA1edV0lr8j6ayja4UyQIaYtqCbtmoQKyIypojsX/PYRnsBgCDX2vFwx5BmovOgMo9Bpw1JptmZ/r2ozisDBUNB+WKbHmoioM72euogJQGXDPSX+MIv7UOV/BdaTobR5wg4PFyD+HSNTq6Vt6CDQgTk1F66rrMeNLjl+LfRKeIwdHYfjupnY8e2hrqYl/1r2rh8+sQNmSqE88+Sc4wQn0/JVngUkL8WKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.013960, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.12.24 16:12, Kirill A. Shutemov wrote: > On Fri, Dec 20, 2024 at 04:03:44PM +0100, David Hildenbrand wrote: >> On 20.12.24 12:08, Kirill A. Shutemov wrote: >>> On Fri, Dec 13, 2024 at 08:55:18AM -0700, Jens Axboe wrote: >>>> Add a folio flag that file IO can use to indicate that the cached IO >>>> being done should be dropped from the page cache upon completion. >>>> >>>> Signed-off-by: Jens Axboe >>> >>> Reviewed-by: Kirill A. Shutemov >>> >>> + David, Vlastimil. >>> >>> I think we should consider converting existing folio_set_reclaim() / >>> SetPageReclaim() users to the new flag. From a quick scan, all of them >>> would benefit from dropping the page after writeback is complete instead >>> of leaving the folio on the LRU. >> >> I wonder of there are some use cases where we write a lot of data to then >> only consume it read-only from that point on (databases? fancy AI stuff? no >> idea :) ). > > Do we use PG_reclaim for such cases? Good point, I looked at the pageout() case, but there we really want to pageout that thing and not just write it back, so makes sense to me. -- Cheers, David / dhildenb