From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02760C02183 for ; Tue, 14 Jan 2025 12:05:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 781C86B007B; Tue, 14 Jan 2025 07:05:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 730D66B0083; Tue, 14 Jan 2025 07:05:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5835F6B0085; Tue, 14 Jan 2025 07:05:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 39EA96B007B for ; Tue, 14 Jan 2025 07:05:48 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E470F16091E for ; Tue, 14 Jan 2025 12:05:47 +0000 (UTC) X-FDA: 83005928334.07.8201840 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf29.hostedemail.com (Postfix) with ESMTP id 60E1F120008 for ; Tue, 14 Jan 2025 12:05:44 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="Olmf/9+q"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=aAI07yxq; spf=pass (imf29.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736856344; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OVDiF31FVOfBP5PM90kLUV3lqzMx2V368T4ehzfSBLE=; b=300k0rkzEMqYYRtdNAE3ppLe1ahQocUxE3jnLahO2b5mrr/mBVw0rMsjiq3n5DnRRM/GHW nKqKqfaSACDmdtmYDtXFz8XnBYkB0xycEpit4BUYE9XAFV9Vtm0nfXXCneFIAv+trd0Tpj lnM3Op/vmxdqSa5U1V6VnN7J9VSp9e8= ARC-Authentication-Results: i=2; imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="Olmf/9+q"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=aAI07yxq; spf=pass (imf29.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736856344; a=rsa-sha256; cv=pass; b=DmEzF2K3U4flU7+UIYr2fM1E/X+SZ9bDnSJ4i4dwtBMRfgrQ9W76PgcSdntrQXXgku33y9 dUeD4N7vLwgnmdN6aafnqglpfQc/GcBxgEPZsNkOWE3N9qmn9CaBids0RcOaIhGJY5Twy8 P//WcmVqRCfF4JRLWauv3kNtoWXq9HI= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50EC0mFW012481; Tue, 14 Jan 2025 12:05:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=OVDiF31FVOfBP5PM90 kLUV3lqzMx2V368T4ehzfSBLE=; b=Olmf/9+qndG0Zz8wTlS6aPPITljxT8FzqS 0lbW1AEfpavKorDsFMbRheU6E4dWEJfnP38sJFDOjd/ecLdIY4BGvzPOS/5DckPc bmXi/KNxWw5SUU+mhL4enYfmwG34pdJRjnQeAuCKKDxbsi0wIRKe+CnTqLKPbpWi kJFp5U70/ljYRK7HrNDKlhb+qfxT6Z0Hge/D4wDao7wJpq5rtwliPOYAAzstNzOk BRctvwaWpMBNniBcXluycbisFzk1MonEq0f7LSsTnxHtJ2pmYLlhERFq/92Edfub VBNJXmEn0stQxvvs2y/Gee4UCDBlbDxwf1AvJVDB70xYkWqBEELg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 443fe2dp59-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Jan 2025 12:05:30 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50E9ADdd036286; Tue, 14 Jan 2025 12:05:29 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2176.outbound.protection.outlook.com [104.47.59.176]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 443f38k9bg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Jan 2025 12:05:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Jaq2NvmieA8fQDTTerLG3RIdbcvxZfyiKjYu+QS1NNYBEpfYUuaO9Jh3oy4STCYfbu6f3QcM7SmkIBTAdBa8pqmoygXO1exvUytiIgXR/3LyNoMzzaqtwDpKI3Ot4Pw7eec8JZtPpmaLNEPNzWOQwkgj0p9ku0G4KL6LRfOrkJxsPFN+GXK6+3emxFWXgJJQSszN5Bs+3i6r5i24YxGRKhyh9e1ROhkO7PdUKYeuib9K9AZJk/B4LGqmBkcIoIFhu4SisKhnhW/eDhbqJzXP5KQUtCV1Ad+11L3o6tU0cqYemz7YorxSIdrNd7oC5jOK8WdgJU/No2Swt4jG+dg0OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OVDiF31FVOfBP5PM90kLUV3lqzMx2V368T4ehzfSBLE=; b=iMs7MNWn2ab5GwFFWQDVF48n1MR48Ew57U8XdQfCdK5Tagoo7UxDxpdfLiI0PmjhKXAsA4L5KDR0xtu8Zwfa3H2Rt1TrC1KAE93C4gQWvv7mRxbEBppcjEi4KNHXFPFAe3nWIqjZX3N0zPn31egiuG1r/OE7JBhxeMA/UNx0j131S5dYw1qlFu5INqdDmmYZ/TGcJbLn9MkW0yGPNp+8OiGlLZjl9tEvBlLD7FoCZ3mWM3NPbsEXIv1F1/CqAJRr9L/Nwsn8TNsFqePNGouLA7cpXb+fvkRxZkL1FiipeTNqm+GcJmIYYd1dZJjBA3PHAlEiIDN3JxOmbPYVzKIyug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OVDiF31FVOfBP5PM90kLUV3lqzMx2V368T4ehzfSBLE=; b=aAI07yxq3+ACDqMZgxlT5hAQNBi/qtG3e53nrWjLtMdzxAkoYyZQreGv0csnn6f2WZAoCnP/N3c1jNDLK5ORLLRow0Ih7itus5/ydchyNXbsILsjQhE1TlYV5YGOCaomZMIQXAWRmLdWLqx262DnUqUNvd0YxwiPa3viGVXPGLU= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by MW4PR10MB5750.namprd10.prod.outlook.com (2603:10b6:303:18e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.18; Tue, 14 Jan 2025 12:05:27 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%4]) with mapi id 15.20.8335.017; Tue, 14 Jan 2025 12:05:27 +0000 Date: Tue, 14 Jan 2025 12:05:23 +0000 From: Lorenzo Stoakes To: Yang Shi Cc: arnd@arndb.de, gregkh@linuxfoundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, willy@infradead.org, liushixin2@huawei.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] /dev/zero: make private mapping full anonymous mapping Message-ID: <2dda50aa-e4a1-4664-b8fa-56ba975db329@lucifer.local> References: <20250113223033.4054534-1-yang@os.amperecomputing.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250113223033.4054534-1-yang@os.amperecomputing.com> X-ClientProxiedBy: LO4P123CA0279.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::14) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|MW4PR10MB5750:EE_ X-MS-Office365-Filtering-Correlation-Id: b2492f51-09f6-4e27-fed7-08dd3493bbab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5B1wOv4jllVdZs6ad2mL7sHj/Sa42YXC68CT16pntJgSPfisYhcN/NbGObSZ?= =?us-ascii?Q?HEfHWMC4XfxbeaVbR0SCaSTJDZwGygAgsoHZ2saVnr5OzODP3ygD87DUL3SH?= =?us-ascii?Q?Qn6xEO5dP5rONbCpCHrEAC1yhGklp7bEgfrmVf9a8XrhNINKD372vEs4rvFz?= =?us-ascii?Q?ZYb47SVeKcN0CARMtghG+0WIqkdYUht3m8Vm9+3lTH4DlDthT/7GmuFeN1Bi?= =?us-ascii?Q?togSKvl4N/q1DljmTnTZaFxzfgymuw9a7S67LHW2sRK0n5pNqOvtpOFB44rh?= =?us-ascii?Q?1UwXDxJT6a3guIoM8nHTsrMBLXMCkpiupBgnooc1YkDrOWPs/iHmofnep+WT?= =?us-ascii?Q?a82pi3pqRT75YwF86k+N4OMmZ3iFmr3IVZOMebH6jOiesDv6e4YSoJ6KwErx?= =?us-ascii?Q?NlrogfxZERRxGtBj41e78z5lkIIHjkvhe8fvFsMMwYKirADe4QbXpOIUcNaw?= =?us-ascii?Q?aaOcRVBy3eHwT4WPboZagJUZdOoGd5+1HmlNZpSrATpi+gFE9dAk5ta1/pGq?= =?us-ascii?Q?/dZhzluOpD7Cv0iXdS1FhmHiSBcCzdVtKQ/bZGk5y93d6PMp3OvpEDQwDbS8?= =?us-ascii?Q?N+S16mW7czpwmczFRaB+38UgMvBBHDR8BwqAmwFZgvR+6n8MXHLqAyWFXqjE?= =?us-ascii?Q?A6KXaZuTsO/Lix22F3cq21CksJMJzkye85XfVXimXmtRbBd235ql914fW2Nb?= =?us-ascii?Q?yCIrq/VgoNtHQGVnMKmRIkjBCDZeetp1myjKCHYn977VK2/g/Y1I9LJpY+ne?= =?us-ascii?Q?n5YHFJaGl9GZ0aqtoGaY5UcV/jnpGN7hkk1SAQZ230BWGgxVJG0MKihoEeQJ?= =?us-ascii?Q?KfIKs2S/thGaw8guopKjRdBIIv+kOG5DPJ75vsjfxyfOosvi+CLdgw77HQhw?= =?us-ascii?Q?nx0LciyZ6IcpOAN7J9P+u3b4aHS9W/V13sGSv7knV6psI5IwLsgm/6uB4Zw3?= =?us-ascii?Q?PfOD7jNR6/Yk/pvvaAEi/2nRUYwA5BslhMWaY+ymtWX9OQzBkt45indoOfVw?= =?us-ascii?Q?7wCfspNI0RgoERkba9Xhc1JgpDArEiKx3+cnIWOeb2psPZPbPlomCWG/E/UP?= =?us-ascii?Q?88Rwvu7jwrmUIR7APZr2EKcb8iT1gWcZeV0SntjP2eS84HOw/SnWYmI+11Ac?= =?us-ascii?Q?e4RCuALkr8eHHsS6+tUvOEq/zGF/MUDzjZJV5AMJyo8cIJTXOALsTV3SlQki?= =?us-ascii?Q?WDa/gP5eVXwL60uRLTLFB9HI49fkiUJELPIhce8/mUBVqcBshWhUWkr3+6ps?= =?us-ascii?Q?4ULoIt5QHeNrzry16nx3SpjmlHvSjuqvT6qbuRuuZjksP95zOUm/n5EbLgcG?= =?us-ascii?Q?H11KgJORx9rSVTWCVsaDhUGyp9mmUkowRuEUmVAdaQhoBFZJT4OmTET3Gs4X?= =?us-ascii?Q?aN2oHxpY2n4fmpV+XARZrOomOGwl?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oXUdCYehMP8I4fOkq1VQi/JjrTB/2VbmUPGKAih1PBikpyDKMPLdI4aJJFKh?= =?us-ascii?Q?3ILAqYZjcOIz4mBBUGuGsh20EjiXD7rFj22yHBm6U1zgZOUvzcMSgzY9rHxQ?= =?us-ascii?Q?eEWdKaFCZE+dRVSrne6lkZWtWGeWa5G/NMl62oZrLa7YSDpf54zJ9PtOayqq?= =?us-ascii?Q?2EM9irzI4EI8COCsOj8l1OR82Mun+ET+ibOMbqsyWzTyesMAApvaXqNgeCmw?= =?us-ascii?Q?mDBor7jrIqvPYj7hK4LtFtVSrXJ7ewhceEs6jnc3rmk68nwwZeTFTgYq66PT?= =?us-ascii?Q?OnT3pm0N7yrzspnLHbwq4r8f8l1SaObB6eeqACePAePMyyWWYQP2AN4WlHLi?= =?us-ascii?Q?MHskR6hRGuhRHg9UdnJhpnNiplTPs7FMykIHJGaLLqyEiLgMyyZCOr2OcYYV?= =?us-ascii?Q?7cOilI1Y/bWvj2kYVxWuxV89rTONHTxKMd2JnirIhsdlXUOqfstcDE3U/qWC?= =?us-ascii?Q?srtyo9YQQBDlejFJK9TbPaatyjej1v6QxmAnRJIfbn3/MT5QPxSNzWyYPyOI?= =?us-ascii?Q?etZ0UbZg/aQn5soMXAyEiVt19yG0urEmkNLFjd+CF0eFoGx0h5FPQdsaGf74?= =?us-ascii?Q?VWxZdd5qCMDYIjwk0LVeRHLbvciv3xocPrOGotwXve3tG1/5475cQwVz1e/J?= =?us-ascii?Q?ytRW8JSwsS0y66hOJHEn7g7Z/FPOFB3K4LeObqdckbWnX4+8Fm7XKt4TA1dV?= =?us-ascii?Q?hRXUTJPj2GN0BrdyD2uRf6fwjsiIihIv3hsEDTevjMVEGVCc1MQDqATUxNXe?= =?us-ascii?Q?QTKWri4vDBpJueVAqtafVWtA0MljQ42hgpIPqg05w7oHVhivAkGveyeRUFDB?= =?us-ascii?Q?orT/lh/MtuxtGn8ptIC/7rJ5Zud524qtpMgT6lIiVTLv7S4o7qB+V0NAXeYj?= =?us-ascii?Q?Bk57QZ2Yoi7DSR7IS7ndwnxg4d9WYvMbTmuc2TeEh6B6x/0fYfIfpQOcoMCx?= =?us-ascii?Q?FOyzgzhw2quiB58Ss/pfjGPYEtM45mtvH//JoiGJnCuG2EDhIqt2v29iUAy7?= =?us-ascii?Q?LWE1mhxyRDmAlhHrXQb+2We7VT09OsUyRxmSL25wE7i0dQO7ZfCJPmaDHwxj?= =?us-ascii?Q?Tc3o7M+T1fYx/yBdtzxXRoO7w706Oyh+/xN+Bnfaif/NOA0FyAot9JRUhGF3?= =?us-ascii?Q?vtOlJDT0K1lZ+yWCZw+sdwQ/hp3epJB6DoSp5h80pdApJ+TqvBzu/3EDWF4m?= =?us-ascii?Q?LqwugNC016vEZpX2nkmceYllnNyshTSAaIi3lBK1y45yIogLOh9WGuY99yV9?= =?us-ascii?Q?3oiD0pL5ANXWpHblM9oirQHxlWq3XL1ylQwEkVUZdedlo9EjpNpp7dzC0jIb?= =?us-ascii?Q?DIPfAoUVKZnG1nWXjS/HedpzSRxszBNAzZ2yuQ3sCWWbHYyQmamuCk/fYAaw?= =?us-ascii?Q?avOq/3s5qXcnOsIMlY8KUeARa6vocQ7Ymdw+5Wjr2kRkCsr+kbwY5UkNX/qw?= =?us-ascii?Q?/qBI/gt1kQW02pdsfTptbhB6CSBN3CNbAqqzskbDmSDCv2RGNTH3uYPlWw3I?= =?us-ascii?Q?rmw+QxuYa5MkutaKUVcf0EGc+bMIRHK3GX/RU3uQrDOAQvs/gHC6Y+UToe8f?= =?us-ascii?Q?U8Yj6BzB5/0zLoPNodQ7m63/N8mdFVE6NU8cYielxLDykq0qVvkL4esP/bEs?= =?us-ascii?Q?+w=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: iMrZP8mIwFyrfjFm7rbxaweFjpQMPpoe1j9bNaJykFTx+mgrDOgBqiINhloXKYpGy/hjwyvTH7/mIWEzkXh1/bydF9WkSqn9nj2vARxvCvpwFOLsOFcRJAb95AgyizD6PVP7a/FrChJXPYusfTIMYkdLeJBXP/o26LkXsymCtvbk5driTUy53Dw/qoMK84LHoGcP9eb3pwDfNaalahIsu4qQg4Lu8B75GP+RwFmm0Qrmruy1SoySzDv8LqF0u98MXHRZ8aj8CmLDrYg27rjCAUFrC8hmlQUCNj9CT628i63eHbdBixubzdFdIVT7yTmT8h1pJ7uWbHPdYWZ2eqXAYaEqUeMTzbQIF00HHc/Efxy488Mu96lRWzHFUHjU2Ci0Lmk1XCxsoM9ok+vUUZZ5w+hnLvCy9NC8gIuJzrIYv7MGzaXBvAR8a5kd0yiin0tCP74yiSZCNte+uUu1Up/iY3eybM9F2xpODK3n4ETvGKg6DrDUYKjKF6BTS2QVf/tF6cJy7Z8Sy0YRBnMpJIoTnNoHyLeBPPmsSW+QMTl8sHFMNlSZE+pX4np0g92KLYPACnZDK40vDRPlwNcVY0brDo4gqsJGBc71a/RoN3GALak= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2492f51-09f6-4e27-fed7-08dd3493bbab X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2025 12:05:27.1647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ycTX8jfpdgFMr36Yfs8tdHwp6sxQ1zyul2cGjjFRbHoWW47nFdN5djqppPgsljfiSPCPuiiFMlmhByzYymV1/xMu8pv1o3AFHi/TzR/RDn8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5750 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-14_03,2025-01-13_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501140101 X-Proofpoint-ORIG-GUID: yJZSgRhOKhYphseK4X_p3I-mjKDwVsiS X-Proofpoint-GUID: yJZSgRhOKhYphseK4X_p3I-mjKDwVsiS X-Rspamd-Queue-Id: 60E1F120008 X-Stat-Signature: th7xwo9wbnpo9ri6txhh7wxwq6qmtjc5 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736856344-415041 X-HE-Meta: U2FsdGVkX18FOKnZI6+HdNIfB056Jam3gP/R2bsmWjmWHwmnx2zXeb94OfSnhvZM0KqA5DdtTb+wdhuQcvWe0el+GoMPc9fl/j+pPRXITH1Kv0IUft4x6ZB0iNj0wRGs9v+fK67Dw/L33YUKAG4WZE+pzUnIet6Vlp5AD3OoULGJPBeVw0NeqkpCQHFTi4DYBs6zil7x+zxMV+oFnBwNXfPI1aD3R2BAXpRKzQYm6oEBRCtE9FH6eT2Xi/WLZfSIS+DygHcnajv7x73eucC3oU6ZgZaJg/hKCRaZN+/BADtSo04U8NMnqakg5o5/BBaQybPCNdyHb+c8Ao+VhYbTAcnm1U4BLuZae21DmD2FxRK4dikn7KDKyx0oa6+tKhPLjqLwVz2MTR+BG3KVB8hgJdHwXda2DB20TpAGQoVcPTBrmO9tw3Q34Dq42gFgMn/0QYgAS0XKQlbcujzaqtx8GWZ9iDXODgsDq02sN5Gxw6FWgL/ghf2VRELUdYe4/yhBz2/8iVccdWVWoIkljV+ZjjpU2zCKRydJJDtXGE6lWbAQohZBVCxq4RSv/noseCKW7res+EJlQEjNiOHTO4ChY0K8BH2enwgLjoL8QQkM7PrC0yceG2hcEE829VwuQjCa3uNL/XzSLX6WNsnsFrPC1jT7qrt8vYdgX5XyQupFQZfzkg0SLe/isAy9kbOZ+PVIKId/jqOTSB9e7s8hngtY2Y8Uo1HKS+s+WpBz/kbITn711jtE0YLyC8+u+m1wP1LoAYF9iTZS5zpcsFr26L/2VjaFFtlGumRM/tQrxwbcCbdeyAJpdzMFiL+VLrHszOxoEJirnzb9BHfBP52bBcvchWUT96XJR2mynNkuHSlvLDdyYm729kfBadT1a1AAvtNJAFt7SQo5GAILh112ZV18BZrRotGbipJiMGsJeV9mIwo5eDnUOQiAeckiDlOMfzRluczjJF4TxssHBj25N84 UHW41S7i Lraumf44kpOfW8V5SdtXUGtFvdUXNIr3lpW6S7QfELbALQlV2mVZt7PeRBHenr14rVXf7vxxLOMgVylFRJF4awUt8rE5uWMFlCwGwHHFnPKbKfkQSwqYtaDhdyVlC5ywAqPjPJuqvFxqjm/s7aOJfhkeDLzEwzVmeOj2pRsW9AruEsuUlcDORAMn3gNT/CvgvzEllb2gIOpzrLqFyvYVZ6cXLIDlCL9KX7e2vQVWMwRWv+9VgtKurtQiecr30PpeeKE7ojg4xpP5FSyvWo1xp3XoQWhz2qYhroKlwIF3Im7IOOV3sU3lU1e/lkoZLKnrCJK7K/Z17tXvLhJ3gI+VnHVzrWHlsR65NnSQBBjd2UfaIVf5VIYX5VQiaVPRNQC+bN2sIf9YkFQA2f9bQEVZcIJQIXO/Tn3+SC7ymsJlKCQlxsedvazOTCfjXZxmuzvoHSaivH8cHQQ5g32XNHy5Bld2b+ZjDypt/OuY3raabYtkqIFMQZ5IYkYX13Pa/P03fZV7llr16snXut8X3svS9bvAX5A7zcYe5TkORPjCtZdO6ST/hFjWYqlYOszmM1il/FWx8TXzqH1g7f2u0oy15G59vEK3uqwZVJDJDZgSjDtLMROiQJeeRuATw0l/noZAGb1l2dZu1mubsAm3+aak5iI1EsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: + Willy for the fs/weirdness elements of this. On Mon, Jan 13, 2025 at 02:30:33PM -0800, Yang Shi wrote: > When creating private mapping for /dev/zero, the driver makes it an > anonymous mapping by calling set_vma_anonymous(). But it just sets > vm_ops to NULL, vm_file is still valid and vm_pgoff is also file offset. Hm yikes. > > This is a special case and the VMA doesn't look like either anonymous VMA > or file VMA. It confused other kernel subsystem, for example, khugepaged [1]. > > It seems pointless to keep such special case. Making private /dev/zero > mapping a full anonymous mapping doesn't change the semantic of > /dev/zero either. My concern is that ostensibly there _is_ a file right? Are we certain that by not setting this we are not breaking something somewhere else? Are we not creating a sort of other type of 'non-such-beast' here? I mean already setting it anon and setting vm_file non-NULL is really strange. > > The user visible effect is the mapping entry shown in /proc//smaps > and /proc//maps. > > Before the change: > ffffb7190000-ffffb7590000 rw-p 00001000 00:06 8 /dev/zero > > After the change: > ffffb6130000-ffffb6530000 rw-p 00000000 00:00 0 > Yeah this seems like it might break somebody to be honest, it's really really really strange to map a file then for it not to be mapped. But it's possibly EVEN WEIRDER to map a file and for it to seem mapped as a file but for it to be marked anonymous. God what a mess. > [1]: https://lore.kernel.org/linux-mm/20250111034511.2223353-1-liushixin2@huawei.com/ I kind of hate that we have to mitigate like this for a case that should never ever happen so I'm inclined towards your solution but a lot more inclined towards us totally rethinking this. Do we _have_ to make this anonymous?? Why can't we just reference the zero page as if it were in the page cache (Willy - feel free to correct naive misapprehension here). > > Signed-off-by: Yang Shi > --- > drivers/char/mem.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/char/mem.c b/drivers/char/mem.c > index 169eed162a7f..dae113f7fc1b 100644 > --- a/drivers/char/mem.c > +++ b/drivers/char/mem.c > @@ -527,6 +527,10 @@ static int mmap_zero(struct file *file, struct vm_area_struct *vma) > if (vma->vm_flags & VM_SHARED) > return shmem_zero_setup(vma); > vma_set_anonymous(vma); > + fput(vma->vm_file); > + vma->vm_file = NULL; > + vma->vm_pgoff = vma->vm_start >> PAGE_SHIFT; Hmm, this might have been mremap()'d _potentially_ though? And then now this will be wrong? But then we'd have no way of tracking it correctly... I've not checked the function but do we mark this as a special mapping of some kind? > + > return 0; > } > > -- > 2.47.0 >