From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 310E7C0015E for ; Sat, 12 Aug 2023 05:09:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F2486B0074; Sat, 12 Aug 2023 01:09:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A2276B0078; Sat, 12 Aug 2023 01:09:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 769A16B007B; Sat, 12 Aug 2023 01:09:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 657796B0074 for ; Sat, 12 Aug 2023 01:09:31 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0983DA0541 for ; Sat, 12 Aug 2023 05:09:31 +0000 (UTC) X-FDA: 81114274542.21.0922D30 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf17.hostedemail.com (Postfix) with ESMTP id B6AA34000E for ; Sat, 12 Aug 2023 05:09:28 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="ejQ/KB0x"; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf17.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691816969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=86mtJloUHa2cU6xz1krwxTUYHHYWBvUKL/iATDB/E+k=; b=POx9vBsY41whJqD+KA9CsjGlHNxAArtF8buT0GeEmqFZQF7Ds2lCPcOnfSbYmy+XXdBjNb 2lwhZmvZmgT8OlSlLLnj59QBWJBkmU+wYV1R5vHowLdeqZ58KxsgsJ/FaMuPjHGuMcWd38 2XfWMf/V08fc8wblaDrPl6eYFe2lOXo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="ejQ/KB0x"; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf17.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691816969; a=rsa-sha256; cv=none; b=gDjnVsFe7NY3lGcTtOYYpCA3TXUBUkHH1nvSFoNwCuf5eCOwklHLYRQIpU25l8NiazBFWN A7tFWzPja0RSpYcmjJMnArlns0dM0toEAztSDFaj09GWHRNLJBCdIc0lpXnK4CbArDTzCA qY2Zb4UKor+/U9J6F9GUb4lT2iA87Rk= Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37C59Kpg030312; Sat, 12 Aug 2023 05:09:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=86mtJloUHa2cU6xz1krwxTUYHHYWBvUKL/iATDB/E+k=; b=ejQ/KB0xxNzhvQQMMu3fDEEMOHkBHkZyZ2+Wj78XLZQihQ8aUzFweazNT9NJo92w01EC uzZ6+WaQfXq/kemj/hkdcoy7nubvof8DObdYaTt87/V+FroieN9AAAA1miFgUXkBF8HW QYPJd19L+hkJwfP+ys74Vp0joG/+ejKbbQgKyvazKsmlWW7tYGqSiyxLuNsc4EsyW19A 6dCuxdXkq0isczaeHwOTvpATe+uIdOjRRU6z1JwiZzmvnZe50xd9m+9VZr1vl7Mv/U4k sHZSh49b+qF3i8jbsaCLn1Ine50wYa3zidUcj2WKIqLnsUi9fdR5Hkk+3SLE6Qf3xqf2 dQ== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3se3hsr0bm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 12 Aug 2023 05:09:20 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 37C59Jfc032040 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 12 Aug 2023 05:09:19 GMT Received: from [10.216.41.189] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 11 Aug 2023 22:09:16 -0700 Message-ID: <2dce810b-3fa8-0ae3-1f74-b0c447c1ed71@quicinc.com> Date: Sat, 12 Aug 2023 10:39:13 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] Multi-gen LRU: skip CMA pages when they are not eligible To: Yu Zhao CC: David Hildenbrand , , , , , , Kalesh Singh References: <1691568344-13475-1-git-send-email-quic_charante@quicinc.com> <9d109a43-78a3-dee4-5aaa-385bdfe4bcb3@redhat.com> Content-Language: en-US From: Charan Teja Kalla In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: GeKOCoDcCB0OB0bzUFKTHUlYkcGMTb3v X-Proofpoint-ORIG-GUID: GeKOCoDcCB0OB0bzUFKTHUlYkcGMTb3v X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-12_03,2023-08-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=687 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308120047 X-Rspamd-Queue-Id: B6AA34000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ugatbjnpfipma8bfpthxdmje7xkssay5 X-HE-Tag: 1691816968-410527 X-HE-Meta: U2FsdGVkX19BHGq18kaxhHtrK2R3oGcAwBtH9fRe4PXwzzbEswnBWuO/t2SdyFgkcgxzy+RrHDUV1WOTZcOlqd1DkPzRyPNO8zc9Pzl5G/xIDSGJDamLEzy6foVf9QmUUddttUdCrgiF88r2gVDJQ0vy5yyr4oyLTYcJbhfD0zYpmEa6OTpRl304R/ChI2dd15QV3ZqIn8jKYUHtOxEN6ZdwJ+BUkvK+3Cr0tZTM3aF0T68aO+3yOAwnc6g5xcGMKNayi/Bg7NCBwmyURTClPeeoFAtLItL8nfbOWht4eWBBaOformWmAwZdXeKlpWyiPGvnJVBVhuWg6LDimjLnoaTl4wrUuZHqeCUs/+tb/5Shspposrsa541Ys08y+xooyXhN2rNxETgxr8y0rVdYr01IYMtG+Rm2hipfZaeqN9TEooYu7C/mbtGbMaJyZLvWcxsqs5psb3xH24lOw8MBPDQkPlMMXXQ9Qc9NQJGNoKZi+NJohU7ac/a9yv69yWDQEglgP+wA+5YEgi3VZT9BWL4dWW+15VI5zMCGrkv2SSLDjVCaSx+7zwImrsILQSOuKDjTnWtt5Ir6aAOCFWUAvILJcsMO5f8UzZfAaOawC66oN1PJybsHy019glgf+Bf+09gSR9QbbYqXA23T1H2AJwr1gjq8KfpNeUIOQymspEk0T33lpzUtq61BgGUChE+LmQKruL/qfwBeChVLCiVSnvhYsMyNvLl/I6XuYENZRW/3R0PdbUmsQaX/nU3+vs5cJnFO0alw99dNpi/B9Wg7k+twpDJ+WehOJcwKGhOgryRmJo/eV+dmZQLPnaEMYvq9HKHxRkdNqtUoaRl90eAp7l8vESidrC/MciynI/vOamLBRvo8uOVUEmdvjnh452iWvegzKyqd6J+nAFnw+Y6pyTlSrUxCincyZbFQeU2DiaelF6pHGEdGlvyLUTbIL8gXgObuoYsP2k3TKHhMBQe Dar95kut 6w5dzUby7UEnFF8PPyet/r5hd84Gg11HBIYCmklvhpsfpASg9H73AoxYCqpqRLUdGLhirT7LZAOWnPKKWklTWhtCAOJCcbTIwbM9KZfAXDja/NxFS/IXG5BNGKVB0fVisGeXjanwnIl3TgXrarcaXsxHK7YYs96rV59Lvo/fdMr3BK5NyjA4MRQbPW5eXdKsAAi2oUxUi3Lr7uYvDJuL0/g3aLGtIyiRMnII3VsNyBojodotBV/E3uTb8zZCzffk1h3sB/e6+Sd/OafdKW4YZBTOWcPViy0fH1hY7LrIcXOEhiS0TBtlFvsUu1D8pxZfPTT0p8Mo4TjMo05UI3JfAhNAMjw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.011273, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/9/2023 10:39 PM, Yu Zhao wrote: >> On Wed, Aug 9, 2023 at 7:00 AM David Hildenbrand wrote: >>> On 09.08.23 10:05, Charan Teja Kalla wrote: >>>> This patch is based on the commit 5da226dbfce3("mm: skip CMA pages when >>>> they are not available") which skips cma pages reclaim when they are not >>>> eligible for the current allocation context. In mglru, such pages are >>>> added to the tail of the immediate generation to maintain better LRU >>>> order, which is unlike the case of conventional LRU where such pages are >>>> directly added to the head of the LRU list(akin to adding to head of the >>>> youngest generation in mglru). >>>> >>>> No observable issue without this patch on MGLRU, but logically it make >>>> sense to skip the CMA page reclaim when those pages can't be satisfied >>>> for the current allocation context. >>>> >>>> Signed-off-by: Charan Teja Kalla >> Reviewed-by: Kalesh Singh > Thanks, Charan! Do we need a "Fixes" tag? I think the below tag matches. Fixes: ac35a4902374 ("mm: multi-gen LRU: minimal implementation") >