From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B41AAC3DA7A for ; Fri, 6 Jan 2023 15:22:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F5248E0002; Fri, 6 Jan 2023 10:22:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A56E8E0001; Fri, 6 Jan 2023 10:22:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 147858E0002; Fri, 6 Jan 2023 10:22:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 018FE8E0001 for ; Fri, 6 Jan 2023 10:22:24 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 91204140AF0 for ; Fri, 6 Jan 2023 15:22:24 +0000 (UTC) X-FDA: 80324740608.12.2F97C6E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 92C5510000D for ; Fri, 6 Jan 2023 15:22:22 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V1KQCwvk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673018542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vkMlgudnEw9cYCp+n6zfUM112uSc+tuDo/FfsaWzwqc=; b=SabyD9n0Popb2r4lhLyUs3U+zjyKzdbqLBIUrx5tUpSKFL/A02YomHjVeDYrleIjfvj2yN z4HH9SmoqmoKx2q6BOVwM/WAM/jD+uuIzCSZ49oGvygDWwO5Tttrmpz1kVbVlzzy5fK2Ht 6azcEPNTfdAo5zAbnhLwLF1ocBluC9c= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V1KQCwvk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673018542; a=rsa-sha256; cv=none; b=PyGbqDTNWqz/ipWLlU1N4EbC851M6t7a4tu1gvS2fnIqXOqPe6NsBciKHrCgUQLpKhpDfa rVWGSNQclT8n6c3iu4zjezj6etNKbIF+Hk1HSkmytrHztdi//kYNjhC+3a+z2z5xJSVwN4 SoEg2dxa1R4QIGFT3035GcdPN7yMoqc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673018541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vkMlgudnEw9cYCp+n6zfUM112uSc+tuDo/FfsaWzwqc=; b=V1KQCwvkQ7ALPQNcVyGBVUrlrxKJmr2C1tuZM7dmrNWGqLJ4T5YbmCa7M3+qs4lmgxeMUE 4/VlgX5F2QKGx8d+xPcEVi6uT+3KwfFQ60IXcXx6G8ZIzEb/apigSyYnwlFVkNQD8wB9Js tVWE16noFlVFFpDUNzVucYwxIxWE2Qs= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-494-Gj6S4H6DMMai_ix-Np5Wnw-1; Fri, 06 Jan 2023 10:22:20 -0500 X-MC-Unique: Gj6S4H6DMMai_ix-Np5Wnw-1 Received: by mail-ed1-f70.google.com with SMTP id e6-20020a056402190600b0048ee2e45daaso1426456edz.4 for ; Fri, 06 Jan 2023 07:22:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vkMlgudnEw9cYCp+n6zfUM112uSc+tuDo/FfsaWzwqc=; b=m5eNFWe/Ex+qBDoNefGeA+Edyj/LyUL0X8oxeuNNJ467H/fU0tzMPK+Sw6fRMcRSbY WT4nfl2zQNBqtMnuSewDdzF8vUaav/kSEswD50oSPF/L1Ig/8dsUdtOhWCu4VRlZR4uC AU4yOvMMu5OTbsYGP+s/QfxWMJvs5tWHVSW6lzFe2o85ouI4pH4Rg8EGGz5BRDfgzvgy xwQhFf52FkxOjL4Z4RzewxNfk8FqejII9iiAOoG5R79g0opYuGo5skcP8HL51np25xZF OPqbAPwHkQ+WRs5YUdCtD+gQIonKN7Psp6oXbfJrL1GP7U8oBo/k4OJ/lu/7NCjRE9c+ ooJw== X-Gm-Message-State: AFqh2kpR0eAu4cFa3BvveQZy9lNWayAyLshZjWhJaMxtdl/MYW9gAI02 NjYI8fQRGviB9bs/gmk9UWsVmcS9IL09iJCBGoxrmEoJEQKFH1XhZzIgOAPdWlUuNyXg+E1hviC iP6UvByAs9lk= X-Received: by 2002:a17:906:2b16:b0:81b:f931:cb08 with SMTP id a22-20020a1709062b1600b0081bf931cb08mr53830179ejg.47.1673018539419; Fri, 06 Jan 2023 07:22:19 -0800 (PST) X-Google-Smtp-Source: AMrXdXskB1uFKW7sCrySt3QwJTexCkq+KHK25MYr8JlE4mYtzsho/RGqB4+BwR1dK/+DDvQtlwcBXQ== X-Received: by 2002:a17:906:2b16:b0:81b:f931:cb08 with SMTP id a22-20020a1709062b1600b0081bf931cb08mr53830160ejg.47.1673018539203; Fri, 06 Jan 2023 07:22:19 -0800 (PST) Received: from [192.168.42.222] (nat-cgn9-185-107-15-52.static.kviknet.net. [185.107.15.52]) by smtp.gmail.com with ESMTPSA id l10-20020a1709063d2a00b0078db18d7972sm497026ejf.117.2023.01.06.07.22.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 07:22:18 -0800 (PST) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: <2dc46e55-6d16-d8d5-b70c-02c283970d4a@redhat.com> Date: Fri, 6 Jan 2023 16:22:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Cc: brouer@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH v2 11/24] page_pool: Convert page_pool_empty_ring() to use netmem To: "Matthew Wilcox (Oracle)" , Jesper Dangaard Brouer , Ilias Apalodimas References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-12-willy@infradead.org> In-Reply-To: <20230105214631.3939268-12-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 92C5510000D X-Stat-Signature: 8ud1h9dwx3x9ns9rts5bmjjfe6w3fsfe X-HE-Tag: 1673018542-123494 X-HE-Meta: U2FsdGVkX19v9Y/uO3Rbrm37poq07cgKpkMMNA9lsSqjVUoNV4jH8rF1coYf2nv3daO80tkx/IaYg1lO0xCvljCzIIOrTBMe/D1p8apnZDKxT6uM+GXMxyWeaRpbbN7m4IYEdF3Ao18bmyeTugg3wmQiLmC76k5NF8yNvIES6qHJcAKewxFjvsjmqlp2K/FnR4M96VWYBY/BcU/ZuhzH+W4vSiFrjXWF55HMazsZFeCB92LQ0E94X8LFC1dgoICeG4VTRH2whSXjTgCbQSqglLy48NGZ7V4dwiVvJ7U9iwiXQpyaeYFsqQIbLMSbEUwAmmFCHslFNDYv9p1K0b/sFK4tLXpxWGoikHwrbelS+LBbzcJZjuaxsTsa6WbM4fSwjUoiFC4KCXkuInYTbEXSVFvOEdnTJql/mmT3U3q8syzPEGhEZunD4frZbddujGnLr8k93sjFDbb00tBFY6dv78rE9jzYTmi97asKo6k1VJjNIpKukJOfw0qcMvbmW/83xMnUfRZE7bwl5xxpejUdzhHeq1334lm/2VLymnDvttACwS7ZSI9S1ntoU2K/S3SoJVS/rmiSSYswpJns2dpl0DoqTGq9XeMdi+49pQbDusx75a8YUCiOdgLYL4TKmxai06jssJTI2A9AvvVuxVqTI7LgT5+ghfSDrzZk9MSaNEw+9H1guDlfdDvyuwEgpwde6NIIntcU7WU0gJVX+4BZ+WkjyCvaNy55gMf4qNUCzRm/n58HitGcsGDWhoUltWNA90NhtHY9XH2JhXs467WxaguhIp0JOl4KmgZgdNLsY0EFU/sKdtePNV7q7Kvv7djmi5QpWHmC6xeXQLLc6Xg0CGVwKDmtdnrCrHPoSl8Hg6+VpEBczqr4D8Q6rhlaFLO4BDHq9z82c/HZ6CkHR9tknzXlw9JBdCjjn2RY3Gx5/V95caMKy8bzX1aYvzPSVDQOwM3N6FDoC8kWeGoNb1n wnMyk0L7 7h9fsMxcO0eXc0aDCBjZsvNjnoja16HqYDRuGCVqyGN1IAeYgOUH30EL1j8m4zAgvyDzNU3bIywrSa3UY60QmqlyelSNYwZRGUGMKwjFhFJEWj51UHvtgQQdFBclLGvta4N98drH2fCnDSxuziWc6cclN7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/01/2023 22.46, Matthew Wilcox (Oracle) wrote: > Retrieve a netmem from the ptr_ring instead of a page. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > net/core/page_pool.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index e727a74504c2..0212244e07e7 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -755,16 +755,16 @@ EXPORT_SYMBOL(page_pool_alloc_frag); > > static void page_pool_empty_ring(struct page_pool *pool) > { > - struct page *page; > + struct netmem *nmem; > > /* Empty recycle ring */ > - while ((page = ptr_ring_consume_bh(&pool->ring))) { > + while ((nmem = ptr_ring_consume_bh(&pool->ring)) != NULL) { > /* Verify the refcnt invariant of cached pages */ > - if (!(page_ref_count(page) == 1)) > + if (netmem_ref_count(nmem) != 1) > pr_crit("%s() page_pool refcnt %d violation\n", > - __func__, page_ref_count(page)); > + __func__, netmem_ref_count(nmem)); > > - page_pool_return_page(pool, page); > + page_pool_return_netmem(pool, nmem); > } > I like the changes as it makes code more human readable :-) Acked-by: Jesper Dangaard Brouer