From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 598F6C77B7C for ; Mon, 8 May 2023 00:45:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C3FA6B0078; Sun, 7 May 2023 20:45:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 873A46B007D; Sun, 7 May 2023 20:45:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7441D6B007E; Sun, 7 May 2023 20:45:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 609AB6B0078 for ; Sun, 7 May 2023 20:45:21 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2BC9A1A0522 for ; Mon, 8 May 2023 00:45:21 +0000 (UTC) X-FDA: 80765244042.29.DCCD81F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 9C2C914000A for ; Mon, 8 May 2023 00:45:16 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AeThqeNh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683506718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=okFAsHxyJchjNrk0KoWMUmCZd1ga74s7ApU5O8osyqA=; b=fTbxAQveF0TL4lLozJ3ak701+7UiITuTOhWg8LezDzYZQcVWvXffgnGjDfTMXQRXQpJ7Nm lFLO/q6+qHrsLuqVn2lVKo5h9SyXEdlvl3qilxzHtj7r2+1RrgSGUh6DnndSL2th5MXTra tHo24BlJ5rCCrAd78voMz4QFfFu8z+Y= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AeThqeNh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683506718; a=rsa-sha256; cv=none; b=WuWjnqHsnp/R4i2mr7dfsOMiww859R1i0X6Au0MrzSu+zIhWBQY2vZKSUSkR3jDDuBsKDp V8cLYcQV18EC5SkxNPSpUMZDC+vskpx1fP4+oCa1HmkgDZ2FFd3EnJ5+azXE1hYfEqXIoR uzsFB1NClCLKeBBIFChJL16BX7ktkzw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683506715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=okFAsHxyJchjNrk0KoWMUmCZd1ga74s7ApU5O8osyqA=; b=AeThqeNhrcjAX/ZV9lIPOEhiM7Ito4dID2et/6PfchJKqn8G8vvKeTEaIrDxGSW8s9mgvI 4a0IRLMW1dXZtLCKVgrFVtigou2Dvp3eOvxE/cfaVTXDFTNCZVv5zXuMEXlvUOGubUkQE9 7WKyCC2BoNy2EMowPAGQOMt7ZzFPRq4= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-79-_Q3oshEzOo6aEFIFzUZ8_w-1; Sun, 07 May 2023 20:45:14 -0400 X-MC-Unique: _Q3oshEzOo6aEFIFzUZ8_w-1 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-5287c9b01fdso3392081a12.2 for ; Sun, 07 May 2023 17:45:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683506713; x=1686098713; h=content-transfer-encoding:in-reply-to:subject:organization:from :content-language:references:cc:to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=okFAsHxyJchjNrk0KoWMUmCZd1ga74s7ApU5O8osyqA=; b=Tf0jEnPxcetApk4sPzo/Xkorp8oMQd7CUypemRuIcScLvCWuQmxzVy2EUII/mjNAKp LlEVvCUEpNik4qesN+8v8eLvBwOvMmWL+innd3oiSxDdPh+BAckD3XD7Ut5osLKHd8m5 2qo+4jxF42A+CefwsZ9RfhAhyYqQa2qezSkdrkXzh8WyhjLakFvCld5niH1UN9XXzvXS O0Endbm7YSyB+0Xh9V0Bviiysy1Ecy0BdVZmwSvwE6t01uahKM29TuvhckrFgdYaSAcJ Hno2qbHUb5rvTnp1q1G8vAFUgeuVRk1/WPyNn8FTq5nIh6ouXVQZXuAK6HcMbAEzOqMb QspQ== X-Gm-Message-State: AC+VfDwgKD6fXeG8vJgWKyr7O2DINKCRYcfl+3O3iwc1ljwkUHPUHdyp NLp0KKo1du9JFNPOkzkK5NtEGJImhKZZsIOP8qWtKJCkSz5xMGVo4tcsga7lGAibsaT4c+ZwsZD saIjbbzpEtLs= X-Received: by 2002:a17:902:e881:b0:1ac:83d1:9269 with SMTP id w1-20020a170902e88100b001ac83d19269mr173379plg.16.1683506713406; Sun, 07 May 2023 17:45:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ilOeSF24ChjvijrcWynnSsR3umEj3DjlM86i7bewgAZM9hCT70b/UXz1MUwFbUTzSHnnrIg== X-Received: by 2002:a17:902:e881:b0:1ac:83d1:9269 with SMTP id w1-20020a170902e88100b001ac83d19269mr173361plg.16.1683506712996; Sun, 07 May 2023 17:45:12 -0700 (PDT) Received: from [192.168.35.160] ([64.114.255.114]) by smtp.gmail.com with ESMTPSA id e9-20020a17090301c900b001ac7af57fd4sm567699plh.86.2023.05.07.17.45.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 May 2023 17:45:12 -0700 (PDT) Message-ID: <2dbc82e9-30dc-5187-cdd6-166fa53213c4@redhat.com> Date: Mon, 8 May 2023 02:45:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Andrew Morton , Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230507173022.96c9d24cb1aa6f57ed50f5fa@linux-foundation.org> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH] mm/gup: add missing gup_must_unshare() check to gup_huge_pgd() In-Reply-To: <20230507173022.96c9d24cb1aa6f57ed50f5fa@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: req6nymjbue7ejrr8rcfbnp57sio3f8t X-Rspam-User: X-Rspamd-Queue-Id: 9C2C914000A X-Rspamd-Server: rspam07 X-HE-Tag: 1683506716-869819 X-HE-Meta: U2FsdGVkX1/uYCOWZ0qKz/VQGIQiJQRM+Ee35+XyFoBlH2chqZ46i61E5PYkFB68nVvnwwi2lyh212mWqXLlT+WIrOcGct/i+ee92RmyUuhLI+3PVs4DF+n262jvpXye2u6DUMG+mZb9ROXf4ro2DsbXcTl6Wm2yBfmKeWcnxqK8YSYSIf5JvghDzsy26xtfXLbhF7xR6m9Jt4PVdYhSapTyqPAH5NT5uBDeKw67GUphreNvTaTpGY6Kif0oaliZFUxzdxN/a8JvKOE9057z1P9qQ1FNmGbAEIMdZmY2YX2q6Ot/edK3nAxSH/qdUOVbDnUI2aUKnQEAVCgePwstk9SbGFBJrIUSjEnHNMRN0v/pt8B0IIezSJaQNk39YRIkQdbZuQM5Cb2CiVfFrU4qllgOqFsIdcSRW/ADMFg+DM3BSf5gwGMeEV9I7gEYLfuZXAP7VU+lCgLwxnZtOL0qOJkJA2blfyTs5l2+G70NgjVXXYqCT5T+PA6mD0cuTozTfLLWCy9uuxJVTFESHhjcJm9Oqru5npaUPIN4nwUvQfotUUXi3bLfGt4/6qDQE5qcxIUPhWvDD15Zn5mdps7bwix8nW1jBFFH79WcSBiv1dRhSFlesv0m0Skcjpzy9rGw/8arEp22z9ffUY5/7kHVxVf5dGJwSbxSSpLMRIa4obxSNSaW1p84ADXK57lG8qoVHjDZeKNV57yq+AZotENMA2816dJulJ3fK4fasOkZJTAGzU/4hxuYflwa9x0BmzU7Dvo8Fzha5cD+EQWVrJjym6/EZfhdpShjt39TQ9vKVI8I2TBpMj9mKH/GvWtEqSjIakuF/PbpszfJuhdrTN9FFTAcOz1WZ6LER5anoqO91ZqqA3OjHsrOgQsxKEpap9ghEHaGeMmal1G5Ry6U/g7HdhsmiBKbwpB0ot2Umo6q3K8xVCvsZG/u5D2uQdXX0nc0Nr/AOxFXfN2I57r2GNy PIZpQZLu 3UNfXXFdDlviWlTSmIGcsi4YGj/lumFjtF4aTzMkU3RcOLgC5XLpkxG69+ZFk5t+4lkVvm1QqFdqn7JKuoIrkGF30hEEWe7fNCwu2f25REJOCeF0Q+IfUl3NZMZiAB+2sWPHjzDXe6Bcys+Bc6l8xT8Eo3S+K3A8fVIA/1JbDILYx9M8+nuoyTHkBdPXKtHPJfCwwyyK6/PQiARRZ7psoF5/TfMm4V75ymm5FyRs3lBFCcjeOvaOdafAN9pbWj4lXKWqNR6qWD/4s5Rb8IfXMqULCoFMYSXgAigQwDktI4G+MSnquA9qnUvEy/ZlUOsqiVX84cVVDsSEDJojBGk6lXQ9ONvO3w0BbNhyfXrjpZqP+ei4rhaDHJlj3IsM33S+BY56hn4PcEtaodKy8uMsS1AfmZFfGIXzVhVvrXTJwKghTMeQbeuqekWe45KB8EoWzajj/smw103Ksz4rLBmmJ5vKYpIseOXR4v/sSBZDJ5Jb4R8KmZ+4QoywCRQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.05.23 02:30, Andrew Morton wrote: > On Sat, 6 May 2023 15:05:25 +0100 Lorenzo Stoakes wrote: > >> All other instances of gup_huge_pXd() perform the unshare check, so update >> the PGD-specific function to do so as well. >> >> While checking pgd_write() might seem unusual, this function already >> performs such a check via pgd_access_permitted() so this is in line with >> the existing implementation. > > Rationale seems strange. "Other sites do it so this should also". Why > is this a desirable change? Maybe the "other instances" shouldn't be > performing this check either? This change makes unshare handling across all GUP-fast variants consistent, which is desirable as GUP-fast is complicated enough already even when consistent :) This function was the only one I seemed to have missed (or left out and forgot why -- maybe because it's really dead code for now). The COW selftest would identify the problem, so far there was no report. Either the selftest wasn't run on corresponding architectures with that hugetlb size, or that code is still dead code and unused by architectures. I suspect the latter. It might be worth to add a reference to the original commit(s) that added unsharing, because they also explain why we care about these checks: commit a7f226604170acd6b142b76472c1a49c12ebb83d Author: David Hildenbrand Date: Mon May 9 18:20:45 2022 -0700 mm/gup: trigger FAULT_FLAG_UNSHARE when R/O-pinning a possibly shared anonymous page commit 84209e87c6963f928194a890399e24e8ad299db1 Author: David Hildenbrand Date: Wed Nov 16 11:26:48 2022 +0100 mm/gup: reliable R/O long-term pinning in COW mappings Acked-by: David Hildenbrand -- Thanks, David / dhildenb