From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC75C433F5 for ; Wed, 2 Mar 2022 06:35:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 358FD8D0002; Wed, 2 Mar 2022 01:35:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 309088D0001; Wed, 2 Mar 2022 01:35:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F72D8D0002; Wed, 2 Mar 2022 01:35:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id 100468D0001 for ; Wed, 2 Mar 2022 01:35:48 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B5BA18249980 for ; Wed, 2 Mar 2022 06:35:47 +0000 (UTC) X-FDA: 79198485534.22.A054C01 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf02.hostedemail.com (Postfix) with ESMTP id 9C5EB8000E for ; Wed, 2 Mar 2022 06:35:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646202946; x=1677738946; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=QDBresT4kLR1cCfGWTt3ps8fR9YuwZAWE6RflB2ZJZ0=; b=UOoLIWhXKlreXBD4Hh9ynkJk2vawE1WKgN0e31TlitMiAF29BfV/ylpy cNCDBWR8uI1eXGcHKVVpzY7Ht5USC2G+byD6ERI8vG01BUpXMwxzP7gGu d0mCfuHHKhIwdED2WMZlEIqJmthyaV48LuMl0T0uSn0ZGfh4D3EypQHSk eUNReu50saOQUKi8hV9ig6AcD8WJG3C/UHg0w/RmlvJ7KiQF2sCsn3zOm HqsG+fzp90FbBcY7+v+KdprsT+KsW9lc3LzsbjRbyf67iJvcFesyPghaV r8JYjKiFB71mtAbDpw60H5WBNkGHy4CJrXaD4UNlSV7QxBtsXc7i83EWi A==; X-IronPort-AV: E=McAfee;i="6200,9189,10273"; a="240736566" X-IronPort-AV: E=Sophos;i="5.90,148,1643702400"; d="scan'208";a="240736566" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2022 22:35:45 -0800 X-IronPort-AV: E=Sophos;i="5.90,148,1643702400"; d="scan'208";a="535260489" Received: from rongch2-mobl.ccr.corp.intel.com (HELO [10.249.171.245]) ([10.249.171.245]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2022 22:35:43 -0800 Subject: Re: [linux-next:master 4044/9592] arch/arm/kernel/ftrace.c:229:6: warning: no previous prototype for function 'prepare_ftrace_return' To: Ard Biesheuvel , kernel test robot Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , "Steven Rostedt (Google)" References: <202203020913.I6LbmH7l-lkp@intel.com> From: "Chen, Rong A" Message-ID: <2db6ea89-846a-8d4e-a5c3-954411332029@intel.com> Date: Wed, 2 Mar 2022 14:35:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9C5EB8000E X-Stat-Signature: 9tmh5snep1c1ttgwecrwt785irgnniuc Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UOoLIWhX; spf=none (imf02.hostedemail.com: domain of rong.a.chen@intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=rong.a.chen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-HE-Tag: 1646202946-621046 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/2/2022 2:15 PM, Ard Biesheuvel wrote: > (cc Rong Chen) > > On Wed, 2 Mar 2022 at 03:52, kernel test robot wrote: >> >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >> head: e6ada6df471f847da3b09b357e246c62335bc0bb >> commit: 41918ec82eb6f80c8b401422f27ca76c85aa0cb7 [4044/9592] ARM: ftrace: enable the graph tracer with the EABI unwinder >> config: arm-bcm2835_defconfig (https://download.01.org/0day-ci/archive/20220302/202203020913.I6LbmH7l-lkp@intel.com/config) >> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e) >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # install arm cross compiling tool for clang build >> # apt-get install binutils-arm-linux-gnueabi >> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=41918ec82eb6f80c8b401422f27ca76c85aa0cb7 >> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >> git fetch --no-tags linux-next master >> git checkout 41918ec82eb6f80c8b401422f27ca76c85aa0cb7 >> # save the config file to linux build tree >> mkdir build_dir >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash arch/arm/kernel/ >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All warnings (new ones prefixed by >>): >> >>>> arch/arm/kernel/ftrace.c:229:6: warning: no previous prototype for function 'prepare_ftrace_return' [-Wmissing-prototypes] >> void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr, >> ^ >> arch/arm/kernel/ftrace.c:229:1: note: declare 'static' if the function is not intended to be used outside of this translation unit >> void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr, >> ^ >> static >> 1 warning generated. >> > > This function is asmlinkage so why is this still being reported? Hi Ard, Thanks for the information, we only checked 'asmlinkage' from warning messages: >>>> arch/arm/kernel/ftrace.c:229:6: warning: no previous prototype for function 'prepare_ftrace_return' [-Wmissing-prototypes] >> void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr, but actually 'asmlinkage' is in another line: asmlinkage void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr, we missed this kind of problem, I'll take a look at it. Best Regards, Rong Chen