From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A5DC021A0 for ; Mon, 17 Feb 2025 09:30:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B6976B0101; Mon, 17 Feb 2025 04:30:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 265BA280029; Mon, 17 Feb 2025 04:30:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DF1D280024; Mon, 17 Feb 2025 04:30:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E08056B0101 for ; Mon, 17 Feb 2025 04:30:45 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9073A1A1DDD for ; Mon, 17 Feb 2025 09:30:45 +0000 (UTC) X-FDA: 83128916850.22.F64A178 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 253A540007 for ; Mon, 17 Feb 2025 09:30:42 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V65RbTl1; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739784643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DQMR/fADtVbSBPPwd01Xw99f5NYlXC5yZS7SkQWeIc4=; b=h+bB7fiSmAQ7il94crbnGn/vXwovgCk6dITgJKJs9pEV7BC7VdhnHYMRZXZGsNdjWLvwaM tvi9ZgImmtWAOsrrIyyblFtAeIgDFfLCm7aqx+NeA2KzxhQP+c+0G4TgZECeCA2k5zvBTq Bx56l8ztSex9MvuYQUMcHT3Dhqe7Dic= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V65RbTl1; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739784643; a=rsa-sha256; cv=none; b=UF6qzHW37DLNFq+WCGTDLWZS3Ji7UUiqF5rlimRYKGYpPnZZS/BfvZP5kuQIq6jwh4HZgE BFIADiD6CQab2lbj4EyVdq+1XQQ8EHKnlUpzlYrIPAxCooj2I1GD2ZRfQfm6xpkdkOYnSF dL0sMv7VnrJXTGSmYCyA0ptCHDYlCE8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739784642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DQMR/fADtVbSBPPwd01Xw99f5NYlXC5yZS7SkQWeIc4=; b=V65RbTl1soP2Yuxf53VlmOBdzBIBsPBWSWce7FABuAmWIm7pf/foulJxzlIfQa/2xKdBdw jJtK3OQwe+Zn4u0Z/Kixm5f3ZjsN8quCXjGrZmQjOdi29dZNMQmFzGGvVlcO4rJyTfGGmS qwhrkGPVTEE1MvHgn1aa5T5XK/apaJ8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-MWm1oq5SNZGjOxmiHEH9ew-1; Mon, 17 Feb 2025 04:30:40 -0500 X-MC-Unique: MWm1oq5SNZGjOxmiHEH9ew-1 X-Mimecast-MFC-AGG-ID: MWm1oq5SNZGjOxmiHEH9ew_1739784639 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38dfede57feso2302724f8f.2 for ; Mon, 17 Feb 2025 01:30:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739784639; x=1740389439; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DQMR/fADtVbSBPPwd01Xw99f5NYlXC5yZS7SkQWeIc4=; b=R6zLbc+vs3RjX8H7ML65OjjuqNwOFH6crqM4F0mj/Q3WL25oNvjMjtkAAfS0CxN2F8 EjekDI1K+tk49pd5/GdtvSemOo6RdbjrFSelBPpt8piKXOim2JJ18N+earNK8tDVabIo J9lYRkhd943ZKkkANZnnWezxtz+wCVvdnkof4Yon/E/EmlNvUnpYKGGZFUIvbDqYTeNo fxg/1r7fyc6h4xPIoH2s0ONRKgdpO7SOHAUZ4ThMohAP7TIn0Cl1cjEIuBjUa3UBwr+P AL43VKoRtGEWqi24DzpnbYPCi86G2iIjyV1ozYIdcwTTjXzymQnPkaD7Umqf0sWrzM7B G3Ig== X-Gm-Message-State: AOJu0YyKYcKU3OaYP+Is35yJoHyKk5w1cNd8NIo3kVzhCFlzKtB1Trs4 0C5jSzdTKuLBTPF3iGUZ+xenUJKYsK+XqMbOAqH40n4PJs22MVM2f4hTLc3gKwsQqM6SSsyM1Uc zxGz6q38/Cba6bRGF2xXQX9i9hREQzxDaEBWBma8lrWPl9/Lb X-Gm-Gg: ASbGncvR4MHlz5SpZy8BKmMOtiz17NhUt8V0GNcjJl4g/L6B/d6TIOZSZO4cudq32gQ f3NeeJ7V5DX/B37MiD+HyhRVXWuULd1S6TAH+i5kFDLS77jShxOs/dRYOkCtcjxICsfZZLUlLrm A4tvGQlFmdajtolHLtGbzdJzxiMw666uPtvdHT2GYE2PTlf4HvOgeiz9CYspDU7tyBlr/2QjWD7 EnS3IYpkaDK+REOuLtpeKaJpGejt2IyIzkwWpg5xLKtlc08nXjtrQKEPvQivEGnLp5iJAAs7/rd XiTHreHUblQHGV5rCH/trNS0DgZngt0Pu7Ma8sLznRKp4P0GkXUFGcObcVFNK1+ehO0zeVfGUwG Fn+x0zaRSe9M+PvmFEjFyjhOk6ySL X-Received: by 2002:a5d:6d86:0:b0:38d:da11:df22 with SMTP id ffacd0b85a97d-38f33f43709mr6921301f8f.37.1739784639480; Mon, 17 Feb 2025 01:30:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzQem8SDfS/ZvSrlOTLgwy6hXjdD72EYQbeWLdcuIX9+g88j62/tG8U2ja9LR9xp+cV1i4RQ== X-Received: by 2002:a5d:6d86:0:b0:38d:da11:df22 with SMTP id ffacd0b85a97d-38f33f43709mr6921274f8f.37.1739784639117; Mon, 17 Feb 2025 01:30:39 -0800 (PST) Received: from ?IPV6:2003:cb:c739:900:900f:3c9e:2f7b:5d0a? (p200300cbc7390900900f3c9e2f7b5d0a.dip0.t-ipconnect.de. [2003:cb:c739:900:900f:3c9e:2f7b:5d0a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f259f85c2sm12124991f8f.91.2025.02.17.01.30.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Feb 2025 01:30:38 -0800 (PST) Message-ID: <2db40a7f-9463-49af-8600-73d735fd78bd@redhat.com> Date: Mon, 17 Feb 2025 10:30:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] mm: memory-hotplug: check folio ref count first in do_migrate_range To: Wupeng Ma , akpm@linux-foundation.org, osalvador@suse.de, nao.horiguchi@gmail.com, linmiaohe@huawei.com, mhocko@suse.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250217014329.3610326-1-mawupeng1@huawei.com> <20250217014329.3610326-3-mawupeng1@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250217014329.3610326-3-mawupeng1@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NWxYBsCInKhGQld-ij-6bdbmXJQeeJ3jXYqcNKqfg10_1739784639 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 253A540007 X-Stat-Signature: fg33ic4bxfj3i4hs6e6g1xcrkwkfrozp X-HE-Tag: 1739784642-282850 X-HE-Meta: U2FsdGVkX18V7sUzhmsevlnX1YtnLIZVsIkljX/45odl7HQYyXjkFE7jsdtMvdKwZKQwt4GA9YzpquYYoEVnuLPYQOR0axz0ianqvBLHLeKJzFDKLtxtl48BJ17gDWEkKq/EnPLHV3UbphD0lLUcOo0b+Xxo5um+BgysTkxWJAPd6JOZXX8lwOHfAvLeAXDL2bmif5ca/LCynmGKNmgdhg1Vz01XWUNdphV+O4Gn1dU4McGkHLt0ZceFDgofi3fFKXtpCN1wgF178IQ/yjVCjlNIial5SI27PcLRbqXJeogl2DsfyjLCirOzMFZl44GcSeG75VPV1Es7TOZ4vEB3G11k0S/WDzJxKKNFTKcwEj0PaGz8Sb5NULN6mVm+EoELzHMRyXeaSszmHILswMCKqg8i05xqEUFaRXvT2z4vYDtRn+chLpjoNeRzWY/ynqSsPto0/21fuaxg9Iy/M10aYnRFceyjhzl+1B8kWo4+1M7JW+cIYhtXrmt8BCc9qcJgddO23F2DldyOQCl/R6ZcxRFpi4Rvj8H63M27xbQb8c52ZGB8lvGeV4NZjN/h393Y/qJoleLGjxJL+L0xQAZa8HJIDqV1maZggLG8l5cL7F02ChQEBOwOxFtFfoyCW5Hols9gRelrl2oTiRcI8Ofq1eFwh7XckVW8KNPY8qZ/kl8J1653C3Wje9AW+/LvTywuU+CqD0d1EP6LAIBFCWmWRUwLKtnUv3rHLeVL1JBRMdZ/YhXcszBYhvmXJKPbY963ShWu0hCieB/UKDiXzVXgXkXGjqYRySpsZR/6XtnpULZqda3zJwqmelvQVVvepsqFM9udC+jI6uPoQCy3HQioydcr8KAZqSA8lM1OpOHTJEEXya29F3HMfAl/zT6lp/d/wEZ1J4DSRaeM/3vTldS/12rr5ECnOxrwLDkWEq7IM7NJjkT8W0g11KMdGfRks3MTUdnc8J1X+XCoOzy3ySn 6bzJub7K pQylT7yvoK/6KNsyWAixxhAmPsD1c3sW/vuVYARXLutlC3tEzUwpLXHHOtQCWsujw+82PoMpmdm6rK0a5/bwuzpPIkT44fG6r9Xb8dbpfVCOtpfWrREdHb8euZ97d3rSKtlNkFGGPDduvYD9jXJZcTsuvipnwbUkWRTVV9/IQhoeOVTRT9g0XVOtel+8PfAtI+2lRrdwpjVgMlXhryU29ohAwVuWANqlvYRcmThHr4hyZE4W//ODylzA+EkLSHbvO/8kkzBU3D1wDDwB1TAwkybI63pVJB+V3Z6ZpAueyOuT4DAXHktopF0nm9ZgGmuPngRKcqjosWgQIkn5rikXTTYFNNpMv0XjVuHYe+CYBXumXzzWmc4Ui/eQptfputTr55VnB09sRj7E6p9O/ITOFb+2TI6PKAU8FD934z+gK6SuXDOgBCWYLHhzeGUevfEeIMGmqLQztPtZMmfdcz/rfFu8xEW0tXkPdCnU7ZzBJRdVluBPyJFNZqymqEjvUCMXe4sKEVMVEwl2ehiugvUptf+DdOH0wQ+ZHs/M8unIrk1sMj7FpyL+nOP+A1BuLzqI2RKjgTt5T+PLEv1M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.02.25 02:43, Wupeng Ma wrote: > From: Ma Wupeng > > If a folio has an increased reference count, folio_try_get() will acquire > it, perform necessary operations, and then release it. In the case of a > poisoned folio without an elevated reference count (which is unlikely for > memory-failure), folio_try_get() will simply bypass it. > > Therefore, relocate the folio_try_get() function, responsible for checking > and acquiring this reference count at first. > > Signed-off-by: Ma Wupeng > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb