From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BF44C5478C for ; Tue, 5 Mar 2024 06:26:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E90116B0089; Tue, 5 Mar 2024 01:26:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E19636B008A; Tue, 5 Mar 2024 01:26:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C94676B008C; Tue, 5 Mar 2024 01:26:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B4F136B0089 for ; Tue, 5 Mar 2024 01:26:51 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9788DA0E25 for ; Tue, 5 Mar 2024 06:26:51 +0000 (UTC) X-FDA: 81862002222.15.4A21541 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf26.hostedemail.com (Postfix) with ESMTP id BB95814001C for ; Tue, 5 Mar 2024 06:26:49 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="Q9W/PLYL"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf26.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709620009; a=rsa-sha256; cv=none; b=z6S4F8NHFkt7mHDRrcuS3nB1h0nP9LhaHX3OI0KqKbMF02AIRzGrPlehTZuexBaMmYRsn7 Rv9raBp8kKWf7bkeCQZuB1bCWLGrFBylAfToBTItvNTvImbBHL6DEwaX4wJiEHll2swxKt MaZTbKcRECH5ZvtuzOTU0csVG3lINoc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="Q9W/PLYL"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf26.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709620009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s2w88aP0w0l2XM2FEGGnYLLZzGTri3r+uTrIgue2qs4=; b=VWT6Cg8jlSRjCj6/FiFMAMpY4DhqmH2IYlcoUu1MYndANljCnzGR5VUOAZ9vL8UsXH1i9v /Audrz6XVVCBSlKs81yXQuoCXxPYV7q5Jw1Cbjm3h6oBKxwBhs1XT8+rmJwYnQxUzvTo0z PQJvuNshJY4GbRHIYC3L0PkAq9WA8iI= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6e56da425b5so326217b3a.0 for ; Mon, 04 Mar 2024 22:26:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1709620008; x=1710224808; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s2w88aP0w0l2XM2FEGGnYLLZzGTri3r+uTrIgue2qs4=; b=Q9W/PLYL0jPMekFKq6FSaeH3r3OVWZHkkAhjmQEL2G8LSPfVlgMuFtZ/EmUk0laWMU 2uY8FtZPoVPij1d7eHNUCAmYZMB00AZbSQFFsi48+Tfyj0lTOYn8AR+PkFP2Pc8OAm6y VVWX4F10QlCIynOzCGHnJd+/R7zBH4sMCBim5tA/KetgalOdh9XDOkKZCiSdVLtKIrRN BqZAjKA6PuJpJDjuWuiMGazY7h/cFbPi4Vf5eRV/T/b/URcTtgF1o3tvpaCqfU67yhBT oYGYWlL1/jjlgH0sb44o1EC75QevnqBQYu9bQ12cwg61cXoStMOpB3XcN67DvIX6+c25 OaJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709620008; x=1710224808; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s2w88aP0w0l2XM2FEGGnYLLZzGTri3r+uTrIgue2qs4=; b=E13jqpZSBH+WWjzUC+fLWI6zMMwSFPMw1jczK/f7FI9T5f8SU1quTF10mw+dbInrHj BNWcO4kFx5KXmTInN2DdFr0oyMHskUVphidE99JXDpv8qbGd4xdJu4V9bCw2C0HeYsCX /6iov30RPMdau/fOGOFN615M6J+q99PCCpThWKO9ijCT1cbdIk/IaA/NG9ImkKcwbNyx +S6pwZz5MDYhcmhoNRM/rJ6FPSuLOPwYCS9A8Mzx6STEcQ/cnV8fPCbFDJjT6KMd+bWv kHHWxrymMQrTJGE6Vq3rUPWuKyfTEh6ZYkxmxJaGNWyvh71AJzPrWKssPR2vpBG4ndo+ wy+A== X-Forwarded-Encrypted: i=1; AJvYcCUkpKR2dujBiQfoUqx9BS5nzX0+na8jUlSx2K1T3i22ElwPZjWgDTJ+fxYga8jYId6D0972O7iHVHuOzEr+OXuhmGU= X-Gm-Message-State: AOJu0Yx/uv6e1S2gko4Ky3nNfNWHAik6cMNIzZbxcFaQSSsAH3Mxy5/G A5atqwyP37lCYYr6MKgEfn2P4tY+PpzFLuSQvsj1Zyo7ifC84lvMqdv9FdivrbY= X-Google-Smtp-Source: AGHT+IFjrJQ9ghS+9AJ4azPUvBka2eHedp4SB5zrkZ15ZtPebDeqsNbsGisGu+WWcgnZkOeCqVYqgQ== X-Received: by 2002:a05:6a00:2315:b0:6e4:fa4b:b6e0 with SMTP id h21-20020a056a00231500b006e4fa4bb6e0mr12965155pfh.15.1709620008404; Mon, 04 Mar 2024 22:26:48 -0800 (PST) Received: from [10.254.206.221] ([139.177.225.234]) by smtp.gmail.com with ESMTPSA id jw37-20020a056a0092a500b006e621e75cffsm2750121pfb.83.2024.03.04.22.26.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Mar 2024 22:26:48 -0800 (PST) Message-ID: <2db1ec36-c227-4bed-b3d5-a0dc4834a193@bytedance.com> Date: Tue, 5 Mar 2024 14:26:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master] [mm/zswap] 18ce3c9e4c: BUG:spinlock_bad_magic_on_CPU Content-Language: en-US To: kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Yosry Ahmed , Johannes Weiner , Nhat Pham References: <202403051008.a8cf8a94-lkp@intel.com> From: Chengming Zhou In-Reply-To: <202403051008.a8cf8a94-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BB95814001C X-Stat-Signature: t5kt98haudzqqfsf51bj14s7tokhxe4r X-HE-Tag: 1709620009-12513 X-HE-Meta: U2FsdGVkX18Qfm6gTDEnwUaUH0t5uKhODzHTMGDG40SnJoUca90VLyIGng8S1EiuqTY26Asonh3TapQ22/iswft/lhk1mwY9WvxzXfoca0zkFRt+IZkXlsF2nIP6x4E1U49zFjn6RMHqxaD/4VUbW0ZElWFmJBQI0ysZrnrS8f8fh7zkisnlZe8bXFOCg/VXy9eLh+uYRioZFkzuNpXpYEx4snaAtyWk+y5stFoPl/BPipZEPzZSjjZdByA0YtlteeaCEZeXMmijNqbW6VDOPs6GEhJV1+h12VeXDQfGNZexSODvGjW0O/Hk43Gr/dmTzlmDvbbhybqqW6p5g7FBHJlHZryZ0DePf/TIPd/W6fWNpp1WlRQRSOvtnt+j1UmE7eN+7Gwd8h7b3tbvaXH4GBxCMbnkpBP5MPckCwHxVnZb7FeyTC3OYnySIykrtcFVrmhGP03MaZ+Lu/PYfmZ26dgU6QzxJKIw9n7pAq9QRgNsqI1Yi4pV/vQi1WNNN97Q9qXgHGf0b2d55u2S9p10fqVzDpZFAqqru8vzKGoks2Coxty/M8FIyj3102aFkJ5KH0RgzDfWteKXmo1Z/MKrQgt1ShvHADqjnoF9j/HJY6CzAo3LRGYJ2IU4XqjjW/wYuhaDoAGWR528zUTA4F8wviWa9KwXvDQ+/f+ATmjyXjyOuBEfnBUmrRafufHMoFidUT+o/HLFL8w3Hfeb+nqStctBiYsuiyaeN6WM3gEBkk/4gWPKDRHvZwH8x9yU8GytsNn4WejLAzQ2YWTtiLaFDoOk+0+kf3x0SDmJha+8/dqqQxSHLQk1OYVvUY5MzBW27BOnp6o9+i1SzdKxrE/Wqx9J6ULvH9VSPBnPrBgfMCaZ6JcxaE7ihlrFwK1a8SYdBbgVly/9SPGW5DkUUf3ECD4LnaLJm2cwYC00ljYj0uJ2oluSLEBcX7yiv/Uo1GlJgjj5JtyL7djnw3QKjdJ xN3rYpNl Uyv1w+aQX4UQifMpHKNTprSXiYwt3zHm7d4CR2h0j+5yN8j+4y9+IFFcE9bCnebewk/E5xk0jg1SC1zuaPyzbmDRmdy6i4g9RJveJs0LJg2dkjropusvkVX2IL/7Susa+P99ng+wiB9aOr/Ar1D/v2vekaZD3qk2AhAlcQDqFEdzOMEgWaQ8e9kXwaA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/5 14:02, kernel test robot wrote: > > > Hello, > > kernel test robot noticed "BUG:spinlock_bad_magic_on_CPU" on: > > commit: 18ce3c9e4c2d7cc1b7eaf1e8cc95be8e34209dac ("mm/zswap: global lru and shrinker shared by all zswap_pools") > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > [test failed on linux-next/master 67908bf6954b7635d33760ff6dfc189fc26ccc89] > > in testcase: boot > > compiler: clang-17 > test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G > > (please refer to attached dmesg/kmsg for entire log/backtrace) > > > +----------------------------------------------------+------------+------------+ > | | acc2918c08 | 18ce3c9e4c | > +----------------------------------------------------+------------+------------+ > | BUG:spinlock_bad_magic_on_CPU | 0 | 12 | > +----------------------------------------------------+------------+------------+ > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-lkp/202403051008.a8cf8a94-lkp@intel.com > > > > [ 88.645344][ T8] BUG: spinlock bad magic on CPU#0, kworker/0:1/8 > [ 88.645699][ T8] lock: zswap+0xd0/0x110, .magic: 00000000, .owner: /-1, .owner_cpu: 0 > [ 88.646351][ T8] CPU: 0 PID: 8 Comm: kworker/0:1 Tainted: G W TN 6.8.0-rc5-00353-g18ce3c9e4c2d #1 > [ 88.646922][ T8] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 > [ 88.647458][ T8] Workqueue: cgroup_destroy css_killed_work_fn > [ 88.647785][ T8] Call Trace: > [ 88.648049][ T8] > [ 88.648308][ T8] dump_stack_lvl (lib/dump_stack.c:107) > [ 88.648557][ T8] do_raw_spin_lock (kernel/locking/spinlock_debug.c:?) > [ 88.648807][ T8] zswap_memcg_offline_cleanup (mm/zswap.c:784) Hmm, zswap is not enabled so this new spinlock is not initialized at all... Maybe it's better to take Nhat's suggestion to change static struct zswap {} to multiple static variables, to keep in consistent with other global variables in zswap. I will fix it and sent out a hotfix after testing. Thanks.