From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD504C7EE2A for ; Wed, 25 Jun 2025 15:24:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D52C6B00D2; Wed, 25 Jun 2025 11:24:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 685DC6B00D3; Wed, 25 Jun 2025 11:24:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5756D8D0001; Wed, 25 Jun 2025 11:24:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 470B76B00D2 for ; Wed, 25 Jun 2025 11:24:10 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DB100160547 for ; Wed, 25 Jun 2025 15:24:09 +0000 (UTC) X-FDA: 83594293818.30.B1E32A2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 570834000C for ; Wed, 25 Jun 2025 15:24:07 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Oo1nLmhu; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750865047; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j9zzTIzKhG7VUl5IjQWUl80M1deKwcxBPVTbGm/9TuY=; b=r74jY8YERLLxcgjtr8WNsMDga+EV7VDgPFhlaZ8BU+eKAyQmRRUsVzosCqm0NkeqscBhUR 7pwbcQVbKRSggQ2DNWHRlGwj6E7ei+ac1aiOGu32bpEvYmsPPQH+a902zXQNg+Z0BHwDt0 CSQiRbuMEPZV3pe7mkcJU8W5mHKQhfQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750865047; a=rsa-sha256; cv=none; b=OZ+GB57PboVazQEpZiH/9HbOAl5GCiKf+KAzDeRtur46yaSKXB1ouirN2OEnhbclFAhvF6 yrCPlqHJL3Od9emyer0WwNkq/+7WXmoqy0NeIHTxl3H1cnCoe0kdex8MS/kbTYsoqjgaMw A0mwJAJVIZ/szwPLyU5wK3BVDQuxyjg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Oo1nLmhu; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750865046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=j9zzTIzKhG7VUl5IjQWUl80M1deKwcxBPVTbGm/9TuY=; b=Oo1nLmhux/UWB5Oh/m3aXyC5wf2gXdKv3tJyC2eN1FUIG0ESUaBi6GM7bs7AKBBJKUtSuu Blo48g6/lKwVcRKpD9xRXxo+qfpF7LMrWtGfWXQpf+DmUSPPvZOpXYUhPogMP5cPGevS89 pQyjdBwSRdowRtFbETElsqwvpQSeFa8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-547-3KBs8i67Nc2FH3OoW6CNIg-1; Wed, 25 Jun 2025 11:24:05 -0400 X-MC-Unique: 3KBs8i67Nc2FH3OoW6CNIg-1 X-Mimecast-MFC-AGG-ID: 3KBs8i67Nc2FH3OoW6CNIg_1750865044 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45311704d1fso43397285e9.1 for ; Wed, 25 Jun 2025 08:24:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750865044; x=1751469844; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=j9zzTIzKhG7VUl5IjQWUl80M1deKwcxBPVTbGm/9TuY=; b=REGcNX9z7450BoLOw4g45IkHdAgGt/IQiDNHHlrehtvVE3JDH8SQwfgjhtgmA4/JrR /pgUoj95pmXUYhp7/ZvAIYhiUTaRRS5Z/thUvGekvzw+qhhs/pN3tjQEusFeDf29jQJn XBpMMxESAjiwSWQbqJyW7ENKAhBokb/pI1qfSVDwl9esfERX7vOiTCHZrUqEPSXlBsKp 3g7nynp0nmkj3gDw2ORTydHPw/g32eN9Fe2JNZ95hyMQm28r1BqRP2MGljRkAUHwarBc tq8BfqGLYJfNUuNMPLn/4IrdhzsVtS12g1YwjTDX/2K0yMy/DmBsPlXXQUN4j6CwNAnb Sm3Q== X-Forwarded-Encrypted: i=1; AJvYcCVVTb7Tt9nvbx+YWq1DwGz+kkZt0Ro0nyNOBa4DPYPkwI9BN7AR9/airS/3dXMcJ5NuyEHnGIfnYg==@kvack.org X-Gm-Message-State: AOJu0YySxHxV98rH/6FJPE9colisDIi8wMendFBx+DBhGAa5T1DLisAh w7owI5LoOIoMloCdsXiz0sELgcDKCrLoX5ZUIq9d0rn5MMjVNQBi2fKB0hrBhLHxFEWvLZFCe5d VdN8BuxUdnnhoXRtD1vI94ow1cwHGpPmPo0lu9spmDpx//aQkuUKL X-Gm-Gg: ASbGncuqX3uJkLYpVfowv0nz17eiFxC8zEg7TvFf2FYXnmw4GyFNEp+oHmsjRcQ/HpQ nd6h+uOC4ZlIIeZjgXsGPF9ZDHh7I7JGnm2o0xKP0QfLGEXm8TV4Act3b7s94TxYyeTKi5CBQzD xuClEnEcmmNx5Cfyqv/djP6q1aYPz5uwiY2JjumAJMM9u6froRb9j1A38I7RefbsjXD2xWxnYEg gjv/M+cGtfRNhINivhcSL6BOs7wFFpgfJHjNb48F/oq4tSlYiX+s3MeS6SqAKSpPu1kCO00RFz/ tFppp2bPK08/d086Kd4Hc0ZD2Z9xV+UvNEl766BZTlo9x06pwH3yrxVIq0Dpwqo3nUxjXBfKasS IV3lvy+eeFJYKhg6xJU3NGcn5gRQpudBEaHPYJXqc6cGD X-Received: by 2002:a05:600c:a31b:b0:450:d07e:ee14 with SMTP id 5b1f17b1804b1-45382830ademr26473475e9.17.1750865044007; Wed, 25 Jun 2025 08:24:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGK5Wspjs/KgJM3ipOlt6CRZQ41vK3S8wKqPJvNzw8lA5JimIHK7x0qy7jz6uvnDpM8gRbr0Q== X-Received: by 2002:a05:600c:a31b:b0:450:d07e:ee14 with SMTP id 5b1f17b1804b1-45382830ademr26473165e9.17.1750865043578; Wed, 25 Jun 2025 08:24:03 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:1b00:5d6b:db26:e2b7:12? (p200300d82f121b005d6bdb26e2b70012.dip0.t-ipconnect.de. [2003:d8:2f12:1b00:5d6b:db26:e2b7:12]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e810977esm4860550f8f.83.2025.06.25.08.24.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 08:24:03 -0700 (PDT) Message-ID: <2db18566-f864-44f4-bd0b-baa7cc4bebea@redhat.com> Date: Wed, 25 Jun 2025 17:24:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm,memory_hotplug: set failure reason in offline_pages() To: Dan Carpenter Cc: Oscar Salvador , Andrew Morton , Harry Yoo , Jonathan Cameron , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <685c1428.050a0220.346d5e.eafa@mx.google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <685c1428.050a0220.346d5e.eafa@mx.google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7_8ordzt3Pdh-bAaS5PGIO8yv59sv5fYa9fh8O0-cu8_1750865044 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 570834000C X-Stat-Signature: x5x84skkutsb3ig3rnzc4jnmpb1yc9q6 X-Rspam-User: X-HE-Tag: 1750865047-213550 X-HE-Meta: U2FsdGVkX1/SZDB9yAj74pfm8NLPGBpwI3WDSzHkV3r/mNRqVx/hIWGmSRHCm/tHcQ1uhXqmfOcFNp0GxEooHJtkmfcj+tT4kdvnaFABtSL5zyhMOeAtJudtBA8MHRTNXkL+w3yGZ7HhCKgQqQo5ykBLcrKb5fw2MHs/SSdM/c1K3h2Uup1QaKchhgPcpHHA7fBx7duTaN0uiW3saKRuCVNJX/fPRbELUGRVkd5O2e96JPBAN2nONBZbDDASJKpJR2sIjPyicN2nTl50nPAWaa/cWwBEr3LgJTHtjkbPRnJJn7wiwpk9Gs8ks5U0zSxkZHJwLtiDKeogq8xfdfh7GmEmd9W3EsEz/5rGeW1J8PT9PiV+++nFdE3CpsuH3+b1wPuFuhPgFA/UZlnhD1aRaMJbnECirJxKIO506CJvgyUxhV8FO6UmBvECE5mgyVLg3gF34HHCCkGBDYKNf3Lk7wY3ycUlIbJZ7SoJ0ACq25zr6iUy4rjMnDwYFZdj/6og01IWv2ifEVWpeAk4xSwQxrjCFDHZqqUHKi9/9xtUqe9eXDrcTHh7t14ReGA1KlDtN0L114/rjWKPkNYjcFkCb8TpcKUWFGEy0vdSKtfRi3MHlTAAaboJfrmbY5uqIATKwHgOanvsHSvDmcqeWCKY8i6lJ7G9H7k+7MwSM1BCV3OET/Ca4nQaBWHqayeIdWniJ0THFaUCZ3AcO/gdd1cK+fl0Z6LTnkf4lnmORJHxrGPPw5ZX3gOYMMUC6jY5oSdwOXwVvzHyudVqXK5/wsCDOP2NCLqnTf+uRe5hoIGYxbf3ARnSQHfE3thig5yWZU9mzf4IrAjm3D6r9PaG0D95SgeITH43UfG5ZcMW5j2l9NRFz8aDtHLfhdYaWAeOdByBRDCHtlzLYjZ2n5V3y7yHAtIZgP4jGbOFtYdlpBYBbfUJp2kupJEjlEla+JVpwJgzsGALcwY3qkIQqnic3pd krOfG+XF bo/4AIjoKeZqR1npWPompBQ0pFoXvFIfUZ9JhYcoGxuH7k5etnJqc0Gqvz+LVydDEPrIcxKz2oS4trVs/mBtmieXGJCo0jbmr4j07tB9ID1ZAau7hZfysdtC4kFEGTfHAjJoIw55NLnNmqdRGISLEH0NwVvJSfXE9VPLscMN9so8lw33Cee7tjpxfwXkhwiZX3bpcbSlnwRdFxXAx2U+VwjJNo3bhYjBI0ShbYKWUNbTVH/EGXxPiJNtjOFtUmPD2H186VAI53bERCR5lhtk0Yt8WZV19eqbst/tqXHLkGo1t//9/3jvtSrBjgZZaEoJmVK6AugNf7gWeOKU9HIQoDr6UlMMS4UTJ3buCoJLPxLSPmC44Lte7Uo/mcMa56SLGP9ghVMuXWC7xLxKzeBw8HhsvmomndHjOoZzABRQLUMHFAXn10dVzFc0oh0MdqcAszSfJsvps/7oiFoCzyhcU/qUbZftTUu5dmytViCjCM0pOAIYZQtaEBOCpjuWKyGQ2pPFfk0jA5kaSbaxb14CYPyb2pz2dtZL3nBj84dPgDcas7Yk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.06.25 17:22, Dan Carpenter wrote: > The "reason" variable is uninitialized on this error path. It's supposed > to explain why the function failed. > > Fixes: e4e2806b639c ("mm,memory_hotplug: implement numa node notifier") > Signed-off-by: Dan Carpenter > --- > mm/memory_hotplug.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 4d864b4fb891..e954f81b55a0 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1977,8 +1977,10 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages, > node_arg.nid = node; > ret = node_notify(NODE_REMOVING_LAST_MEMORY, &node_arg); > ret = notifier_to_errno(ret); > - if (ret) > + if (ret) { > + reason = "nr_pages more than present_pages"; "node notifier failure" With that Acked-by: David Hildenbrand (likely should be squashed because the commit it might not be stable yet) -- Cheers, David / dhildenb