From: zuoze <zuoze1@huawei.com>
To: Uladzislau Rezki <urezki@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <gustavoars@kernel.org>, <akpm@linux-foundation.org>,
<linux-hardening@vger.kernel.org>, <linux-mm@kvack.org>,
<keescook@chromium.org>
Subject: Re: [PATCH -next] mm: usercopy: add a debugfs interface to bypass the vmalloc check.
Date: Wed, 4 Dec 2024 17:21:12 +0800 [thread overview]
Message-ID: <2dae287b-c645-3773-4f99-fd44902ae589@huawei.com> (raw)
In-Reply-To: <Z1ALDmybeJfpIqge@pc636>
在 2024/12/4 15:55, Uladzislau Rezki 写道:
> On Tue, Dec 03, 2024 at 07:56:34PM +0000, Matthew Wilcox wrote:
>> On Tue, Dec 03, 2024 at 08:02:26PM +0100, Uladzislau Rezki wrote:
>>
>> I think there are a few other things we can try here.
>>
>> First, if the copy is small (and I still don't have an answer to that
>> ...), we can skip the vmalloc lookup if the copy doesn't cross a page
>> boundary.
>>
>> Second, we could try storing this in a maple tree rather than an rbtree.
>> That gives us RCU protected lookups rather than under a spinlock.
>>
>> It might even be worth going to a rwlock first, in case the problem is
>> that there's severe lock contention.
>>
>> But I've asked for data on spinlock contention and not received an
>> answer on that either, so I don't know what to suggest.
>>
> I think, it is not about contention. It is about the extra "attached
> load" when a data is heavily copied force and back. On each copy path
> you need to do a scan. Maple tree is not that something can help here :)
>
> Indeed, no contention data. Zuoze, please share this if you can.
We have enabled perf lock contention and are currently debugging the
environment. We will share the results as soon as we have them.
>
> --
> Uladzislau Rezki
next prev parent reply other threads:[~2024-12-04 9:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 2:31 Ze Zuo
2024-12-03 4:11 ` Matthew Wilcox
2024-12-03 11:23 ` zuoze
2024-12-03 12:39 ` Uladzislau Rezki
2024-12-03 13:10 ` zuoze
2024-12-03 13:25 ` Uladzislau Rezki
2024-12-03 13:30 ` Kefeng Wang
2024-12-03 13:39 ` Uladzislau Rezki
2024-12-03 13:45 ` Kefeng Wang
2024-12-03 13:51 ` Uladzislau Rezki
2024-12-03 14:10 ` Kefeng Wang
2024-12-03 14:20 ` Uladzislau Rezki
2024-12-03 19:02 ` Uladzislau Rezki
2024-12-03 19:56 ` Matthew Wilcox
2024-12-04 1:38 ` zuoze
2024-12-04 4:43 ` Kees Cook
2024-12-04 7:55 ` Uladzislau Rezki
2024-12-04 9:21 ` zuoze [this message]
2024-12-04 9:27 ` Uladzislau Rezki
2024-12-04 8:51 ` Uladzislau Rezki
2024-12-16 4:24 ` Matthew Wilcox
2024-12-16 19:18 ` Uladzislau Rezki
2024-12-04 1:21 ` zuoze
2024-12-03 6:12 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dae287b-c645-3773-4f99-fd44902ae589@huawei.com \
--to=zuoze1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=urezki@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox