From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Paul Lawrence <paullawrence@google.com>
Cc: Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
linux-mm@kvack.org, linux-kbuild@vger.kernel.org,
Matthias Kaehlcke <mka@chromium.org>,
Michael Davidson <md@google.com>,
Greg Hackmann <ghackmann@google.com>
Subject: Re: [PATCH v3 2/5] kasan/Makefile: Support LLVM style asan parameters.
Date: Mon, 4 Dec 2017 19:55:15 +0300 [thread overview]
Message-ID: <2da6480e-08ff-2444-7abf-2964de53e7ff@virtuozzo.com> (raw)
In-Reply-To: <CAL=UVf7LO5BDWVEeLXLkrLDBxwV0aO2sLv_htkpcL_Gp7sT07Q@mail.gmail.com>
On 12/04/2017 07:20 PM, Paul Lawrence wrote:
>
> > +A A # -fasan-shadow-offset fails without -fsanitize
> > +A A CFLAGS_KASAN_SHADOW := $(call cc-option, -fsanitize=kernel-address \
> > +A A A A A A A A A A A -fasan-shadow-offset=$(KASAN_SHADOW_OFFSET), \
> > +A A A A A A A A A A A $(call cc-option, -fsanitize=kernel-address \
> > +A A A A A A A A A A A -mllvm -asan-mapping-offset=$(KASAN_SHADOW_OFFSET)))
> > +
> > +A A ifeq ("$(CFLAGS_KASAN_SHADOW)"," ")
>
> This not how it was in my original patch. Why you changed this?
> Condition is always false now, so it breaks kasan with 4.9.x gcc.
>
>
> a??I had the opposite problem - CFLAGS_KASAN_SHADOW is always at least a space, and the
> original condition would always be false, which is why I changed it.a?? On investigation, I foundA
> that if the line was split it would always be a space - $(false,whatever,empty-string) would be
> truly empty, but if the line was split after the second comma it would be one space. Is this a
> difference in our make systems?
I dunno, but it could be.
Anyways, does the fixup bellow works for you?
---
scripts/Makefile.kasan | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/Makefile.kasan b/scripts/Makefile.kasan
index 7c00be9216f4..d5a1a4b6d079 100644
--- a/scripts/Makefile.kasan
+++ b/scripts/Makefile.kasan
@@ -24,7 +24,7 @@ else
$(call cc-option, -fsanitize=kernel-address \
-mllvm -asan-mapping-offset=$(KASAN_SHADOW_OFFSET)))
- ifeq ("$(CFLAGS_KASAN_SHADOW)"," ")
+ ifeq ($(strip $(CFLAGS_KASAN_SHADOW)),)
CFLAGS_KASAN := $(CFLAGS_KASAN_MINIMAL)
else
# Now add all the compiler specific options that are valid standalone
--
2.13.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-12-04 16:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 21:36 [PATCH v3 0/5] kasan: support alloca, LLVM Paul Lawrence
2017-12-01 21:36 ` [PATCH v3 1/5] kasan: add compiler support for clang Paul Lawrence
2017-12-01 21:36 ` [PATCH v3 2/5] kasan/Makefile: Support LLVM style asan parameters Paul Lawrence
2017-12-04 16:14 ` Andrey Ryabinin
2017-12-04 16:20 ` Paul Lawrence
2017-12-04 16:55 ` Andrey Ryabinin [this message]
2017-12-01 21:36 ` [PATCH v3 3/5] kasan: support alloca() poisoning Paul Lawrence
2017-12-03 12:23 ` Dmitry Vyukov
2017-12-04 16:42 ` Christoph Hellwig
2017-12-04 16:55 ` Andrey Ryabinin
2017-12-04 17:09 ` Andrey Ryabinin
2017-12-01 21:36 ` [PATCH v3 4/5] kasan: Add tests for alloca poisonong Paul Lawrence
2017-12-01 21:36 ` [PATCH v3 5/5] kasan: added functions for unpoisoning stack variables Paul Lawrence
2017-12-03 12:24 ` [PATCH v3 0/5] kasan: support alloca, LLVM Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2da6480e-08ff-2444-7abf-2964de53e7ff@virtuozzo.com \
--to=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=ghackmann@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=md@google.com \
--cc=mka@chromium.org \
--cc=paullawrence@google.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox