From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 665D4C3DA7F for ; Mon, 12 Aug 2024 20:12:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B29FE6B00B6; Mon, 12 Aug 2024 16:12:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB2B26B00B7; Mon, 12 Aug 2024 16:12:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 905056B00BA; Mon, 12 Aug 2024 16:12:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 715586B00B6 for ; Mon, 12 Aug 2024 16:12:11 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 19EF91203B8 for ; Mon, 12 Aug 2024 20:12:11 +0000 (UTC) X-FDA: 82444690062.04.0D0931C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id AD08AC0016 for ; Mon, 12 Aug 2024 20:12:08 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mk8Dkbxx; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723493458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4pxPhrlq8M3bwqSfpv7S5gTFvgao+jQlKr8jDIOLaPw=; b=IJIvLyBrA6bZu8kak/QIQfxg41S2MeiiP9VhI0aHRWLca3xxh6bE7sxjCQSO5IVmSVgvak ruRmLkjASba8Nmyt4fUEIXmkTQacd7Y5w/T/oibWFihqO1osodDuvWLrNUJZsij30ae9ic 0QXGeR8oS0lH7nxPVPevDqUmHgKHkWY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723493458; a=rsa-sha256; cv=none; b=px3/SHc5QT3qxrH5xpS3oijProikwE6PZvTthr39gkWq7akIXkSG2xg7a//k9o88Bdb6NF OiOXpWqCPMrcrdNM7sMKdYD64+2TIzh2Hw43IAMVgdZKToF9fHMWsSIsmRtlP16MTqAwUU 1sIrfZY4YfIKUrQ2a5tQnbv2JP3cyKQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mk8Dkbxx; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723493527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4pxPhrlq8M3bwqSfpv7S5gTFvgao+jQlKr8jDIOLaPw=; b=Mk8Dkbxx73QVWL68K0dhoEbar1ESOGu3TtbxXEjWDBAz1k8oX3CkZpYPWja3fwja4AXzjJ GD38SW3A3m4xf9R7bK3yFU/bqqiegGZF5VISahCc5WMR91PriFc/JRxrbwJM19ZtJ7JISI tJZG5c0hY8t0UdE+anIhq3glK+2Kp8U= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-6A1L8K0JM2OGxXhyJobFzA-1; Mon, 12 Aug 2024 16:12:06 -0400 X-MC-Unique: 6A1L8K0JM2OGxXhyJobFzA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3687e6d7a3aso2537285f8f.2 for ; Mon, 12 Aug 2024 13:12:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723493525; x=1724098325; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4pxPhrlq8M3bwqSfpv7S5gTFvgao+jQlKr8jDIOLaPw=; b=TWhIEQvfTNlyUmwagLUbzmtUcZqeaI8z4xZSJKxdgYx7Q9XJHTBFleVgPZDCpeXryl RrLNmtAEEkHdOjS334laN8qT7zWZGWcvJSAtrHyWakHPJd072g1RcwKyWuq8wPGyDghA UhY3DXXr+oq6fCj+Dl0bgqcGwhSmjcq0XoK/91ItKUD08K2c7PIazi0Y63NQA1jbYVIx uWkYu/VOVWQ3EAjWkCBm+Vp7AXHoIiWighCTpG4O5OGPs5UTD4KBoF11NSCXgksx8pbf rtgAngylioKg88RCQShnSHU+xsSeqO9JmfgPR+IWshYez3sKTYpKEw3fyNpf2pNytB0W SMsw== X-Forwarded-Encrypted: i=1; AJvYcCUI+Yt28BFbIi9yc7rlScBg3kcRrvr0ccdOxws6mb7HFe/K9yF08t+OGPnoGdJMDJbg5am0KJ/+j3zUUoXi0t5IwmU= X-Gm-Message-State: AOJu0Yx0stIZGIS4s8dQBGUCxLl1mwUC3FainrxeIgKugwMAlA1nnLy2 tgZ6mEji5E8r8iIYssnD6wQJdQvq6NaNZrrfTvZz0Zxc3Gu3uxj3PAlPjfN6lV53z8hk7qq5py2 DP+MvVtzebxgXWSjAWHhoMWwJr7hORmvewgGYPeonfPswrYl8 X-Received: by 2002:adf:eaca:0:b0:368:79c6:8845 with SMTP id ffacd0b85a97d-3716cd2aa5amr1098011f8f.56.1723493525280; Mon, 12 Aug 2024 13:12:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzEjoSJxu62SrF6kS7QmEKpfeqlP4QeF/rvgAdIXqlEfED0lrpAX3R4zrVGI3zqHlAw3mzaw== X-Received: by 2002:adf:eaca:0:b0:368:79c6:8845 with SMTP id ffacd0b85a97d-3716cd2aa5amr1097990f8f.56.1723493524761; Mon, 12 Aug 2024 13:12:04 -0700 (PDT) Received: from ?IPV6:2003:d8:2f09:3f00:d228:bd67:7baa:d604? (p200300d82f093f00d228bd677baad604.dip0.t-ipconnect.de. [2003:d8:2f09:3f00:d228:bd67:7baa:d604]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4cfefa29sm8348294f8f.61.2024.08.12.13.12.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Aug 2024 13:12:04 -0700 (PDT) Message-ID: <2da47dad-46ff-4e04-b697-c85f30a4341a@redhat.com> Date: Mon, 12 Aug 2024 22:12:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] mm/swap: take folio refcount after testing the LRU flag To: Yu Zhao , yangge1116@126.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn References: <1723461718-5503-1-git-send-email-yangge1116@126.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 35ee37njudnbusmxser4imfeo6z7f9c7 X-Rspamd-Queue-Id: AD08AC0016 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723493528-206682 X-HE-Meta: U2FsdGVkX19qrNXAQLpt+qfcWIkO50gnGT15zstBr4hwWcHx9Eib+DnyXnC9OfDalx4SW/Qojb9rNPS+opny/Oz0+Swir1t6CJFNSe9AgVda+bA5eWM3wYYbarL13btqPe2tii9PjTID91TG1GxE93bLLwm6gt1WfYzr2cR9RDFouJgvmDtr5iqDfd2CWoCsHIH2TVFIJ6dQnG41iW68n5pSxTEL5LpRGTLp3Ef1yTx1bGpZXlg8ASPfooQ42tCObWzjoIt0Ql91wo/uSfj3oxcHOLDExzD4GLWZll4n66ztcPI+2VVTLD5oh4BrG+cZ1DY6IkaKlZ+QrVZdlo9/xO88GWM91DPwizs14dT2uBz74ry4otdP0HZtzUD2Z+sF6nflhf6D0jqmMTAxsZb8Pmzyn5NSnRhVNpH9aG9jHclTJHfQwmqMjUXb/76C6Tyf0Rwrz7357Zha3Eyjs25QWXBtWjDIYm+W82zVoyS+qFQ8vkE4QUS6d9K3vTYPdzw24Jx9MVdJ4a2jaOuGEnHEqqhSFewi9NgB+Q/TobFyhb6OYZbqGjuZmQmgt0RmK0GrutavqSmdgMFyF5NBBDKY46aNSCqifJc39i4n9bNJKQr486jo8t8rh6WzLzI46q3ga//C3EstNDw1i99FRbofh4KOjfIxLqAYXttDzArzczRV18Uj3iD5RPxCe+NaZDfPOlFUSREKApJx9Axxf8AXy8dK9e8ume+gICGYstv+eXsDr0RvT383Wn4j+0S8xZmZnhLRor8pPiA9fDTuPDrMV52ze5ltaNi693EGX+hAg3y8XKu5R+2oBL3DPFpkns3KLfG7AGju+RBTahPeys+rQDlFt3V+KTrh0nT5eFbmtqasLb3I/lx0simEhK+Yc7ooYUkTTbNHNY1cJ36jHnfo2Rb6h3PMcZQ5Ds3RxRIAQ2+vhKr360KsTl8eltjxHX3/osGmZk4rSRqpS5XjDX5 AEH+7Zmh 2c0U0OI6MPsGIxL5Q2ZTUuAr2bolCGWPcHV1cvz4/0+uJ/+naztFcvxZ1Nf4QgvujH2FinToE7Z+Jw0kWXQg4vK0H4prvmJQP4WEkBtF7ztGlNVE2WcfPef1cLOSO/ue+SnSCtMQ1fbHH8LdQ8mUQ3AnvTA5YcSw9m20Yn1RfDP818yBbiW1deKjK0tj7tjsiirFNFbfX5XYuvoBb7b2wQKZXl0Bbi0uZ9uafyFUPslO/h63uf/lG0+EDcXb86t94AwEdtPKyRU3lUM+ps+aOnb7refvJxDRJUVIyiKL4L1oPDggr8R22cyhdEt+ho91ptCTpWXBjext6GA2DeCsi3dEyiKs8sPsEpLEgh/4OBjsSmGigvPZUB3UePePm/KXcCE655jVPGYX4dFyT0b7zlNuk7B4SsZtufhycOIHkGVvKhjxVpECVtwWnUAW1fDA3OK7P25jjqQOWkSs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.08.24 21:06, Yu Zhao wrote: > On Mon, Aug 12, 2024 at 5:22 AM wrote: >> >> From: yangge >> >> Whoever passes a folio to __folio_batch_add_and_move() must hold >> a reference, otherwise something else would already be messed up. >> If the folio is referenced, it will not be freed elsewhere, so we >> can safely clear the folio's lru flag. As discussed with David >> in [1], we should take the reference after testing the LRU flag, >> not before. >> >> Link: https://lore.kernel.org/lkml/d41865b4-d6fa-49ba-890a-921eefad27dd@redhat.com/ [1] >> Signed-off-by: yangge >> Acked-by: David Hildenbrand >> --- >> mm/swap.c | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> V2: >> Add sanity check suggested by David >> >> diff --git a/mm/swap.c b/mm/swap.c >> index 67a2467..c048659 100644 >> --- a/mm/swap.c >> +++ b/mm/swap.c >> @@ -226,12 +226,11 @@ static void __folio_batch_add_and_move(struct folio_batch __percpu *fbatch, >> { >> unsigned long flags; >> >> - folio_get(folio); >> - >> - if (on_lru && !folio_test_clear_lru(folio)) { >> - folio_put(folio); >> + if (on_lru && !folio_test_clear_lru(folio)) >> return; >> - } >> + >> + VM_WARN_ON_ONCE(!folio_ref_count(folio)); >> + folio_get(folio); > > No need to check folio_ref_count() here, because folio_get() already > does it with a better check folio_ref_zero_or_close_to_overflow(). > Ah, good point, thanks! -- Cheers, David / dhildenb