From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC35AC6379F for ; Mon, 13 Feb 2023 18:07:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75DFB6B0073; Mon, 13 Feb 2023 13:07:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E5D36B0074; Mon, 13 Feb 2023 13:07:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AEA76B0075; Mon, 13 Feb 2023 13:07:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4A6426B0073 for ; Mon, 13 Feb 2023 13:07:39 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0D8ADAB208 for ; Mon, 13 Feb 2023 18:07:39 +0000 (UTC) X-FDA: 80463051438.30.7428140 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf28.hostedemail.com (Postfix) with ESMTP id A95D4C001E for ; Mon, 13 Feb 2023 18:07:36 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="T/dj3msZ"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf28.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676311656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gTmAaxsJs38uXAuirdsWiXUOoLVF2n96THxM690X7TQ=; b=KxjaTVTc5qTiwRSHIhLG82stDvY26fv7bhJLfsEKrPaLJYjNxFz+EEV8rMpOCCiGqmMcZQ Sn29ePNoaNAivhBUDMoZ+WdMvz3R8Wb2rLxFeLx/IxWLWuMak2Ydp3a5aPituzYcFpzw1f h5RASeELirbVwYQ2viYvG32lO/lM1z8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="T/dj3msZ"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf28.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676311656; a=rsa-sha256; cv=none; b=xMjK3kwMNmaxBlGXelkpeApJ/vCDuCdmqew6OjnWrH2ifC0KTwzszz9iGSOpowBaNdzkjy rNtQf8IKSC88HePWu/PSkZTqgt+FIrXOtv9r6yeSuOLDGqh545k/c/7pS+MJUDojlSDMBw EPWEXFdUpoMKfnVM1D4ydw59CRpQTBI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676311656; x=1707847656; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=G5AV2pkXDQoTS6YCv9ce9+5JFgN9La2hpC0dnMFOo9o=; b=T/dj3msZl2lS3SWFRVeqRsSSQqd0I3FM6h229YoynMFRJIvdh9gawAtH fOO00TviTRMhxOv/AeQKBdPaR92+XvojtDhSkZ2HEJ35koz3yTOHHCgjc +UMV0nHCJpuQDZGbNkVTyLz56Oh1SDiO6GtlucmA4fzqzkMK7bolQqqdX 0bjWLRgefBu5CSPnwokSTGcoZZPmPae56uMG5aJ/VlBJRopV3nixj8Cus /nbpbkvhQL9c6FtZ0n0WGNNAFmb5fFBuQkQIxYSIqYKCJhsGs1Ztvum4A q1B0oViTlq9fzjc263naxo8ThpDStHGyN+vOGeudIXw3XmbYwsxj7cf/T g==; X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="395567982" X-IronPort-AV: E=Sophos;i="5.97,294,1669104000"; d="scan'208";a="395567982" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 10:07:32 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="842854085" X-IronPort-AV: E=Sophos;i="5.97,294,1669104000"; d="scan'208";a="842854085" Received: from mlswanso-mobl.amr.corp.intel.com (HELO [10.251.26.232]) ([10.251.26.232]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 10:07:30 -0800 Message-ID: <2d9172c5-e1e7-bf94-c52b-0e9bc5b5b319@intel.com> Date: Mon, 13 Feb 2023 10:07:30 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v9 07/18] x86/virt/tdx: Do TDX module per-cpu initialization Content-Language: en-US To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, david@redhat.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: <557c526a1190903d11d67c4e2c76e01f67f6eb15.1676286526.git.kai.huang@intel.com> From: Dave Hansen In-Reply-To: <557c526a1190903d11d67c4e2c76e01f67f6eb15.1676286526.git.kai.huang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A95D4C001E X-Stat-Signature: xghhoao4ggofqfka5edocdg8i9w1hbce X-HE-Tag: 1676311656-534429 X-HE-Meta: U2FsdGVkX1+2uw9ohG/mzmAF3Xyyi7Tc5Qg2ztxqGZaoCJ6sd6Vo8e7FCaod+44+iMii0836wolOL2UbltBoF02fALnpMMSfNMD/fxq4wUgJ6R1FbTc0FYiCdM0j7En5dmLf3rXOUYVbVShz7zV0eedOmVNlKnZqokJxVNmT5xurZ4Abcu/Nliah6qSjkY/y/B3Fli1FvOHpPahtmerCIGHXS/V87sDV/L4v65FLFhtQvf6t5kKKtnucVf8SW1r2NFpIuWXmjLeB7T8TM6Re6ygWHDD59uZMYKgA9gXYKXTGDGIeDRYzTWRTMow/3IrIDUYFCjUydb9UGDck2IcnUoSO+1U8XnNGzuTrgPrdgGeJNVbRcFW+EtVDauAE/SgD6ILdW7V/Tjm66CCDNRyJprLaFEjmcPhwTCCHqZGWr9pwUTw14fUK8zVQX9IEt41ZdP1+IdlA1efgrrR+HaJqYpKJnUs5G6xwPLBk5HbTv40UQvuwPgAl7o8d/wyv9Bi4x+lAPWM1bi5Vug4d0ht+1I274dlLn9FoQoAh91H9PYOWUTSgLLbwn88mD1a1UZ0gmFBWqEGROtveTN4tEsfHfb7z4n87CG/rBOeYlsCqQaOzKdwtPVjozJFUhPCoMh6Gold8FX7mdhcz8Gpp1H1pfijZoogxTpyWAy4PCiXDRuKolutGRN5z/cvy7k6GTbQhS0SlC2TpAcwG3alTvIONZijBEMr2kUv7VEa4NdhHf8wdhjHEqKr85uNIAmwQdjEKMM2cIUfpqwS6tV9RrglHjPHICL0U7dHHy8djSk6wUgGlEN6+D00b+/P9OgePz6P4vgrN8/ZGxUF7J1QAXGYGs4Jzhhtv2T/Q+WRQ7bjaMwl7I9PZ5Yx6oKqHvqvxi42RBAfCEZKW93oF3mwgpuKNsq1hvFmepBQjeF8OmbSlPDj7Li7fzdGVrd6Z2W4vwyDnRJ9UjJYhCjtL9bUl2Ky gmVqiiDv uXXZ0bpak9mlYwvPvL0mhWjK3QtSl7bEJ2wRRsZx+Ls7YJQDXFVmEeCeh4HVw/EMkCdou+bb4BxnWN1Lk1NyUI40jpH5D15ZgjQtxt2tHiUNhVrUGA0MOKsNpdG98Ga2URSbojse+Hxfejg+b4prrrw151vtqF5+n/jio X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/13/23 03:59, Kai Huang wrote: > @@ -247,8 +395,17 @@ int tdx_enable(void) > ret = __tdx_enable(); > break; > case TDX_MODULE_INITIALIZED: > - /* Already initialized, great, tell the caller. */ > - ret = 0; > + /* > + * The previous call of __tdx_enable() may only have > + * initialized part of present cpus during module > + * initialization, and new cpus may have become online > + * since then. > + * > + * To make sure all online cpus are TDX-runnable, always > + * do per-cpu initialization for all online cpus here > + * even the module has been initialized. > + */ > + ret = __tdx_enable_online_cpus(); I'm missing something here. CPUs get initialized through either: 1. __tdx_enable(), for the CPUs around at the time 2. tdx_cpu_online(), for hotplugged CPUs after __tdx_enable() But, this is a third class. CPUs that came online after #1, but which got missed by #2. How can that happen?