From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71321C001E0 for ; Wed, 2 Aug 2023 17:38:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0E662801CF; Wed, 2 Aug 2023 13:38:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBF412801AA; Wed, 2 Aug 2023 13:38:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C85CA2801CF; Wed, 2 Aug 2023 13:38:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B68052801AA for ; Wed, 2 Aug 2023 13:38:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5741F140F8A for ; Wed, 2 Aug 2023 17:38:17 +0000 (UTC) X-FDA: 81079873434.17.84E2358 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by imf05.hostedemail.com (Postfix) with ESMTP id 8ACFF10001E for ; Wed, 2 Aug 2023 17:38:12 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of glaubitz@zedat.fu-berlin.de designates 130.133.4.66 as permitted sender) smtp.mailfrom=glaubitz@zedat.fu-berlin.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690997894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5HUkNf6WA/GdG2gu94NnQMOuKbPwTYeYPW9JgTKZ2TQ=; b=E+yuXhrelcGy67cuk2pStPaNhFaq58ohTdEKOhpW3RCuy2Z09XYjWQrQmT/pQFG7vQaQy/ O+lvtPLu845Jy0kxLF1UsPUOMdSETGY3MAgsDyY7nNnumdSNq9zlzd4MdIvKbZjni110yZ U74po71hvEYISsAOZH1uXPxPmGELrnw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of glaubitz@zedat.fu-berlin.de designates 130.133.4.66 as permitted sender) smtp.mailfrom=glaubitz@zedat.fu-berlin.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690997894; a=rsa-sha256; cv=none; b=1VRARQOB8IB7288ZFSp9i92VhOpqkPb/EWSS06+RrfNrSQgdbkyjIfNPOpbnix5IQhAtK0 cYAUUTJI0phbFfBlTrIfPlaEJqWDbydNqYwfuIXyjNW6BAJgFWNb/Wwz4ix7GsXxboMasm JjmumlWPhhTbEm1Jn40P/dpnjDTWJOI= Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1qRFe6-002TUY-K1; Wed, 02 Aug 2023 19:28:26 +0200 Received: from p5b13a085.dip0.t-ipconnect.de ([91.19.160.133] helo=suse-laptop.fritz.box) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1qRFe6-000eVY-Bd; Wed, 02 Aug 2023 19:28:26 +0200 Message-ID: <2d82e0312f7d667e36238938a3cb13c95903033e.camel@physik.fu-berlin.de> Subject: Re: [PATCH v8 11/19] sh: add including From: John Paul Adrian Glaubitz To: Arnd Bergmann , Geert Uytterhoeven , Baoquan He Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, Christoph Hellwig , Christophe Leroy , Mike Rapoport , Matthew Wilcox , Alexander Gordeev , Kefeng Wang , Niklas Schnelle , Stafford Horne , David Laight , Helge Deller , Nathan Chancellor , Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org, Guenter Roeck Date: Wed, 02 Aug 2023 19:28:24 +0200 In-Reply-To: <39c79971-12fc-41fc-8cae-b2a0089ed034@app.fastmail.com> References: <20230706154520.11257-1-bhe@redhat.com> <20230706154520.11257-12-bhe@redhat.com> <0f771b11539d5a3871691af901315ee2034b577c.camel@physik.fu-berlin.de> <09094baf-dadf-4bce-9f63-f2a1f255f9a8@app.fastmail.com> <39c79971-12fc-41fc-8cae-b2a0089ed034@app.fastmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 91.19.160.133 X-ZEDAT-Hint: PO X-Rspamd-Queue-Id: 8ACFF10001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: s7eu5thpntcsrwxdxcz1cmnpprktwopn X-HE-Tag: 1690997892-371170 X-HE-Meta: U2FsdGVkX18eS/ziXi0cclZyWuSxhFfg3w1d7iy4NpJZozyyxkmX5wencx/2sYb5DgF1VtBifQIEFWW0PQFxQQxw+Kc5t+oUHI91GnAE8qq6kS1oHxmwphQJ0ctrfJTVHNkq9i7j2uS//SYbbS8fglY7Azw68od36QQwzHft0r+kkoEI5vqYcXcnIqHizxlNKSVMCuug13FKVvYt3fDROA6xWQj0nAAUV3Q8OVeLTaSymZtTF/s8+caHnPr8HM6N/DFWujHJL6Nz7AXY5UNwGX2AaQ9jCwa8Ha0r4pVDXERIX85gpg78/AMYUuoyjJ5nv3Hs7aGZfnT/kkJvVrjmwsSGTR4g7yuwuSJzT/HNNpdn2Q1lPtsLatPMloyAIKm8oqmPhjdVztgQA7p0ZcNjkAv8DYaWvsg/YpeEIBmGI14lAgFdQV/esRRb0sH8lc1OqT5Z1bt41cmbSRH0HkRuG/KSFQPfcFydEbjUUns4j4KgsGl/2SiKfxNqraTTCgZNAU9B3RxG5d/tL1otTwctaKDjr7wIdfjZlPY7tltjc+iExvBNPSOKL7hl6nUEQrLnqVUFEApPuKNQ8Wy5F8mfLg6IWrFt4UCGG1Bh86AhUbnOtC+tPoqLsrs0wYEMCT+ELGTqzR4F2vneLQc2dodkHMHmIjwXWwn4PHsJ/IdFb8la8sqBnKBXN2wnIK8vRNKiXIrvTaiCOpWlUUh7G+BkRzEefGCA88fQRQUkyk5kPIQi37o39Nz50dYRDE3WJtxbrRIJCKQIo5shcoGWl65E+WBD8lVv/0gCDLPvHZaAO5Et4vzFNZiGAb60pf1g9ycz13IoCGMBzSz+K6fI8DYqcCK1pgxUmm6tNw1cPcg5P4mJ2Dur0a1NbyaCsY2SN0RRmwnGfq6qfawDZKx3A2TcdHAupBAmZUHxfTed4UwdD+poPPcigvEEU6T1A4vj7AH+N/NUdZR1LVRS2JocojF mVbXMx3c rSO1TeaPOAYGwvGzZ9VCWTOcAnBxH7zQY5Wmv4oZP2XYNZjBlqWPL9beuxMKf2jSeC0e+ZbfXKLBKpjfDDqI0EzVktqzUHV7VSgoN086yx+ExCvGMIO9MCnN4gK1beTF5UAyHpxY1hYUo24ekVolTjxzlMymGcbN1L7d1YoR/Vw7LJb0lNAEbRCXCz+FvgbTRB0fO5UMJ75XtC3A0PAbvj4EKzS4q8NXmhobWywy/aurlhOkZTPCFmsE6eVpOMSUGOsrxS/W3tOU3MmLhrnwMeyvAQDgyu54Mmwqi82uSxurMku4i/4LPgQMuIsm8+PDeU8+QK3RtgRReMsk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Arnd! On Wed, 2023-08-02 at 16:19 +0200, Arnd Bergmann wrote: > On Tue, Aug 1, 2023, at 21:21, John Paul Adrian Glaubitz wrote: >=20 > > > I think ideally all the I/O port stuff in arch/sh/ could just be > > > removed after the conversion to asm-generic/io.h, but the > > > microdev_ioport_map() function oddity gets in the way of that, > > > unless someone wants to clean up that platform. As far as I > > > can tell, the ethernet, display, USB and PCI devices on it already > > > broke at some point (afbb9d8d5266b, 46bc85872040a), so it might > > > be easier to remove it entirely. > >=20 > > I don't have this particular hardware, so I cannot comment on this. >=20 > Sure, as I explained, I'm pretty sure that nobody has > tried to boot this hardware in a long time, so I did not > expect you to have one. >=20 > I'll try to follow up with a patch to remove the platform > later on, based on the explations above. There is no need to remove any platforms now as we're working on converting arch/sh to device trees anyway and will eventually get rid of all the board= - specific code during that step. > > > Having the series go into linux-next sounds appropriate like this, > > > the entire purpose of that is to find such bugs and Andrew can jus > > > fold the fixup into the broken patch.=20 > > >=20 > > > Let me know if you prefer the simple version with the extra > > > #defines or if we should just use the generic inb/outb implementation > > > immediately and drop microdev in a separate patch. > >=20 > > Please go ahead with the simple version. >=20 > Done, Thanks, Adrian --=20 .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913