From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EB15EE57DF for ; Mon, 11 Sep 2023 17:50:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A02916B02CB; Mon, 11 Sep 2023 13:50:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B2756B02CC; Mon, 11 Sep 2023 13:50:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 853096B02CD; Mon, 11 Sep 2023 13:50:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 702E86B02CB for ; Mon, 11 Sep 2023 13:50:11 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 41C98140A49 for ; Mon, 11 Sep 2023 17:50:11 +0000 (UTC) X-FDA: 81225055422.04.C1DA612 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id E882D40010 for ; Mon, 11 Sep 2023 17:50:08 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HQTH1v0H; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694454609; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LH9SgwlPGuC8Jzb1EeRGGbzpWVfq/nZCCXYeCFnaw2g=; b=Gg/Ka52uVt5t2IcTKoZyj/7SOEmNV9JuY0raZI5l1+abDFDRzNnPEGns7oUUpL12a31U7T o0+vWH+cpOzYfzsboePpHeVgYYcW8QumGmMTWoH5/2cMfz8SLtc4kbJ/VvplxEZhsDIIWt JRSQ34Yk7372dFnkYMeSuEDBkN/uZck= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HQTH1v0H; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694454609; a=rsa-sha256; cv=none; b=XxS0cgzRJ5/84ixhUrxp5IYQOJx+szXiukne0XBczhuSmBXFdRCOlkyWm0EKA6CZB5upaX YwBcIMSjXjoiYbYOnA5ZU1dZQg7pGB9I0BFWdw4G6bVQtLJNpaLZLt4ERtPrmxvz2hYhrL Ldqvi50KICUcORfhpNXKF3pdQIKiqP4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694454608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LH9SgwlPGuC8Jzb1EeRGGbzpWVfq/nZCCXYeCFnaw2g=; b=HQTH1v0H2yHTfMrsbK/sI83E51J/WVGV+NaZd/fV9bH1yERz1ZNUc9m1I9sD14K3/MS3J7 D1xrWwFX0MUd/OiCeku7Kkrc6mTSYgc2siHtFBVP5/Fe37BCUdD4VODsqAJsxkaaq4DvUR 46SAqEdt5wc69f2KH/qNpg/iMWhN/9I= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-l-_-4QWwMniEmdaCjtxF-g-1; Mon, 11 Sep 2023 13:50:06 -0400 X-MC-Unique: l-_-4QWwMniEmdaCjtxF-g-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-31f3cfe7269so3054543f8f.2 for ; Mon, 11 Sep 2023 10:50:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694454605; x=1695059405; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LH9SgwlPGuC8Jzb1EeRGGbzpWVfq/nZCCXYeCFnaw2g=; b=dweU14J+QM6xqvn5F/Gcz+1niEaYcDiEFKxGWcwL2/TbPBB/4nHIHXpZHuB/DvanOi fTxOenG5t5nS0pNJC/IY1q2Jcc7xV8egN09WXT82+eMljM46eHI1UhX+NlSknCAfDj1X KhfBpSU+SXzKZbyyE+rhOAn6lBir+8r4nQ1jTVL+1QJM6j7wre1YxfOkMysvBx3Sntgg YQWYuvxNjiurRLRyNuV4CmVRN9FLj+Fn9B3wY9T3DMWbBkXcMXU6e9DPbvprM04ltXcK RX06hsu5NOg1Nfh97sNsKtZIGHcu5/IRC+LVdN5cPdjFC+9DkyoV8tpadyHa2UFrIvhb Sg7w== X-Gm-Message-State: AOJu0YyHZGg/9K53JDaTJhMYPa2lolAbuZBLErfUUAVqJq15f5daVYoQ WStOmyHU3iXOodHC1xE3l8OpLhvMJ+2Wtx003VTgnJUnN17m9o1sVg7lguOS3VbIOAMY5xlDGMt 7JSC6peKAWyk= X-Received: by 2002:adf:ee8b:0:b0:314:34dd:aaec with SMTP id b11-20020adfee8b000000b0031434ddaaecmr9223433wro.8.1694454605288; Mon, 11 Sep 2023 10:50:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGzZ48EI/2tgK/zda2AhhDYR7h2n2d281WwBuVGgWZKJdUSKanksMi/FMb2K/VHeeezM8OZ6w== X-Received: by 2002:adf:ee8b:0:b0:314:34dd:aaec with SMTP id b11-20020adfee8b000000b0031434ddaaecmr9223419wro.8.1694454604950; Mon, 11 Sep 2023 10:50:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c743:5500:a9bd:94ab:74e9:782f? (p200300cbc7435500a9bd94ab74e9782f.dip0.t-ipconnect.de. [2003:cb:c743:5500:a9bd:94ab:74e9:782f]) by smtp.gmail.com with ESMTPSA id r15-20020a5d694f000000b003143c6e09ccsm10604803wrw.16.2023.09.11.10.50.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Sep 2023 10:50:04 -0700 (PDT) Message-ID: <2d760884-051a-372c-a33d-a4bfe2f25675@redhat.com> Date: Mon, 11 Sep 2023 19:50:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [willy@infradead.org: Re: [syzbot] [mm?] BUG: Bad page map (7)] To: Matthew Wilcox , Sean Christopherson , Andi Kleen , Thomas Gleixner , Josh Poimboeuf , Michal Hocko , Vlastimil Babka , Dave Hansen Cc: linux-mm@kvack.org, x86@kernel.org References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E882D40010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qgfefrpjczxm8ep16j7jii8x4ctkzfio X-HE-Tag: 1694454608-694080 X-HE-Meta: U2FsdGVkX1/UUMzWxS9KVLaHxA1Gh60o1nTx2V0hNoCrC61mdHFw7HPiwWN9l64Mz/VfB6sVyr0d+sxefQmoW9NdlNazZKMPNR6so3ZfVHgztqrYj59yYUoLAsZmN9ViGu0iua4DXxAmKE9r9L8LdppLMOi6fVxbmMoLYreQKxb/1C9zy1lNuWRWe5hSq+zFxCHjfEJltmDrOkkP5Isqjyh6UKBjfGizMdzLBmi0/oHF93VlQpUrG4R++qTudoj0FGYjetOUcxxa0pgogzR0MJCjrHgd6YfIrd7dBMP/8a0rEAiWAW7wNqe6BfuE0d989lsVvpufF8gkZz6ZYUKj9yT19OB6S2+Qeqdypebny5OwpVt2VffLMfQpknP7IDMGszlCFmPT8FAymkoep+6Dy+lPHTz0yn2p7aDS3j2fW+3WkRqiHz55QY/LOzIc7AnUHJ4U0UGcPv9WDKNJBcKrKGTOBz4UDz7E1PbNM9WExocVjSy6m8Jxb4EgwCDoWkYfR8V7POclrMjLrs4Ff45RpJcOgL4WEsdXZEgp/9Z2bPWW5zpshzDZIyItjZ4Z3f9PxLPfCvfvh9IelVj0ETGVT3kINAWYVjwRzX6BWfYJUW8M1gEm/Wxhz9Z8l3+gL8BKb62rgdicChwcsuz7GXbo7HP2xHVq7P+GZyDHkAURYZ7ggeupnFUweDPBL7r4C0/R4kc1pxmhBVv4Xa8MWe1T9XPMAMzyn0c9HkKl1xHUgBKAgWwNKUOMydfnXl02Gt6RklgHoL5aZp2EjLo2RtSDFZnJ5OmdvFLvYyIjOwaz03FBhu6Cjq9mrH+gDC05A/Knh+BcaG1AU2AS+O+jXyzXskZ3Qv9jN3walE5HqqeFqDs4xGea57Igjqn2kwEzuRmLBbX+Xia3Mv+YjbQoqTOAlz8aosgTlUypafh7IJPAMW90wr8OdT6X8xZ1PcdRLQ7pM/0DUhTsKptuqcniC1H 9EAgDEUe DPmZkXgn9rx6sAhPTWxZkfk8i+pQXWaUuW+43QQGMeyATpm30s+c5zB482Yq3COZKUavV+pCcBDu9Gyj6Rdhw2Yw/AFMJANLq8P+f/42BG85gU1608mfUJU6B+zWTl2LfrIxgHjYoXDNaxxPIte4Ak/mtOvolDQx72oCdp+Gx6DuDRsfbtl8OHSkPoFjrnMvBxsq/LOmxGv2D4EIZEyYvyMxPhlO6U9mxydX6cKHwEULcMMpvjX7+aAAGp7nT4FgIppKxs8pgIUWwCFfWfhnz2xXa5WO92bzjxlCOifrjcJE/M/33VPlRc14ZXJjYGOfQ7+szXQ7rji3xc4kC1HjlUCGHmgExkCZemj1B3axITDBhLuuVmUYAVIFbiTzcBm0oOoARCKd7DsrWBl+oIxt7al1NTy0f7p6YxfgOyBUGc0EvL+arXcS0z2geMcu4ZQVsHjE2CW/37kkCw1lfviis48hwgdn6BPzfWvB5FMo3mdvQD1OlHYO0ABZtLxfoYeh3F+mr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > #ifndef set_ptes > /** > * set_ptes - Map consecutive pages to a contiguous range of addresses. > @@ -231,7 +235,10 @@ static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > if (--nr == 0) > break; > ptep++; > - pte = __pte(pte_val(pte) + (1UL << PFN_PTE_SHIFT)); > + if (__pte_needs_invert(pte_val(pte))) > + pte = __pte(pte_val(pte) - (1UL << PFN_PTE_SHIFT)); > + else > + pte = __pte(pte_val(pte) + (1UL << PFN_PTE_SHIFT)); > } Maybe we want some pte_advance() [or similar, you get the spirit] instead? Leaking this inverted-pte logic into common code really does look nasty. -- Cheers, David / dhildenb