From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F70BC4828D for ; Mon, 5 Feb 2024 08:23:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE4A86B007B; Mon, 5 Feb 2024 03:23:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B952A6B007D; Mon, 5 Feb 2024 03:23:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A848D6B007E; Mon, 5 Feb 2024 03:23:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 99B636B007B for ; Mon, 5 Feb 2024 03:23:37 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3EF42120523 for ; Mon, 5 Feb 2024 08:23:37 +0000 (UTC) X-FDA: 81757061274.30.D4F8DDC Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by imf22.hostedemail.com (Postfix) with ESMTP id A92AFC0002 for ; Mon, 5 Feb 2024 08:23:34 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ezjz7fwX; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf22.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707121415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YKZXLXscoo6WspId5ZWXzvGxFuSp7LUnE6//QnlzEM4=; b=4+XDQwOJ834AbQY4O0VT7D8GP6nCWCPUvu5KLZr+kGrBpxTjYD8dQeVPrCzeKj3pvIOAuo p3dUjgJ7Ylto+P0rcVxK4SLLgvK2gBNVBdsTBit4Jy5uwpXILhx1xAhaVnfkh+kACekdr0 D3pAmy+PlRSqZijcnip6Z4IZlXDm2Zk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ezjz7fwX; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf22.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707121415; a=rsa-sha256; cv=none; b=lqdXRVcJiHAu6y2ZpjGSQJQEz81+HICS3YRTtWMYz2XTLfeYbB1dvivZncdOSJkKOtmeEN 3QBLk2EKjFABe+H4rpvTiUGhk69StbS+Qg/puVe4Y9qp6jI741/hT5F+pZ9LFh7nVUXmFF 4XC9uNzbAi17ZUxB+8YOvgWUCWcwGkE= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1707121411; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=YKZXLXscoo6WspId5ZWXzvGxFuSp7LUnE6//QnlzEM4=; b=ezjz7fwXZYAlxUjF7f+A55OD0HLm4KgD8ToHj/Xkdyuza8kcfvbpG2Z7DugqMOu0hUYduI4Fe00cZVySaLFlnxVVxPWEsXtXAEADm84+YfMNP5g+OrKgu3PpvqRCbtMyRTqF7qFcto+tdLHakU7ARtBk1gmkZr95FS1PSKE2UY4= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0W064Cfa_1707121409; Received: from 30.97.56.40(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W064Cfa_1707121409) by smtp.aliyun-inc.com; Mon, 05 Feb 2024 16:23:30 +0800 Message-ID: <2d6fa6b6-db90-4ba8-9205-437593bc2f9b@linux.alibaba.com> Date: Mon, 5 Feb 2024 16:23:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: hugetlb: fix hugetlb allocation failure when handling freed or in-use hugetlb To: Muchun Song Cc: Andrew Morton , Oscar Salvador , David Hildenbrand , Michal Hocko , Linux-MM , linux-kernel@vger.kernel.org References: From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A92AFC0002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: if1q6ez5yjf7rcsdkshxoj4sw75js6fa X-HE-Tag: 1707121414-790163 X-HE-Meta: U2FsdGVkX19OU/zBDvADsa4uItMRDRGTaRPK89xQDoSjY7BmtGaM+YcJ1EeKNl9YVOgQJ2ukTgtB7K0mCu0jO/j+9gCOS3rzW76NTNawZfyKmUQnI2Me2dEQMftdAeQgPoy0FJfLyvBGMVp63xtlkQJOLcUREqwaJ5mL+MqF5MTNZjL0YMqVOZCAwtPkKFwWUyU05B66L9x9GuRgNzER1ylxBkW66msTLk/Pe12/kbOl/amiiqX0Qeg4Rtst3TaFMc6o6nsVAVpZB2FsUFqGUavkDOrE3RQPct2fkNjGUVgFH2nDA4EtJ4hiUsfASc3UIz1SncnITGY2HyRLikU1KmCERBsT2am9kQzhpr2LVEXXReLtS8qpG7gotFT3ObiVtsCXbwjYIcE8tKhr7QAxZN8u2UEnVCBdhqrO/CmCEQJeNQS6odjRDzvpXdbLgn7yM+ZlpHOTMSfh5QAuAKgEkG5uJS1pQf4nHbHKFS3X/FdWB2L4/BppNVH1l0ycwq1aPXayAtdYjgrfkUtVY/uYxRxkvOvCKq/qxxusPEG5qdNK0NOf1KlJMjdX80S5X4x1z1UMNpehLdvZEeGwudoZJnlv/HV4FzhvBUXKESlVO4gaH+UBs6z5cbUsDPA2fW14nANa/ePCZRu7mxVQQL+qo0UC+kD4Q9CwCWrJkvU5I4SI4ib2ikAka48FbIdk26zAePew33OQ5Oo+4x+A9Fd4VLkTOE4wd5iPoOIa7hj9EjdX2eC24N0etMXeIGFWGH0l78ZUeHq7ftxZQ5/Ag2mjoOakBTn1Lcu1M0fLP3UUqBh+9hbwX/cmtmy2QjGvrKSO5hj8G7snylC1yWIaF1C9SOwPFwYnbYuNz1ztK2EFRGm4Yh87qU9mqKeEx9XhN84ZPCHv0m8gzSsqwGqzlYKS7CZ2CpIxhrZofOOVoyQ404W5ryo7q7CyKtsofMumKL2k82drdzueTqLkUjK16ZJ GbKeqJbr gr91su03GQDPgqwpV1rFEQz9pcEfUhuaNJLWxEz4cXlcgpbhugrY/ny3RZYqUSKMZgkdf+bwz/Y54esAwC3kipnY/YTNI2Cs/tLKUHXbMP+8hGJwN2qXypn0sNpyWR8A27pyLuwL83Qv44wMoDBIHD5mj2PJNFB6ZVkuQww7Hnf8M57/dGwCY9G8r4ddF/l+X1Bk3t6pg8WTbo90IYZFWSVV24WUUoef96opaU0cdBPMIkOmtKUyGiuvP672jtc9yvzt7C5T9jTFPwpGkvLdnDR5GHUl/rGtGun5yTpHb8OqYHQJOBihWrTOe5+KsSd0aA7Le7dPwier0Ih0xsKl3IRmpHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/5/2024 2:56 PM, Muchun Song wrote: > > >> On Feb 5, 2024, at 11:54, Baolin Wang wrote: >> >> When handling the freed hugetlb or in-use hugetlb, we should ignore the >> failure of alloc_buddy_hugetlb_folio() to dissolve the old hugetlb successfully, >> since we did not use the new allocated hugetlb in this 2 cases. >> >> Signed-off-by: Baolin Wang > > OK. It is not a fix (I see a fix keyword in subject) but an > optimization for unnecessary-allocation cases. Thanks. Yes, better to change the subject to 'mm: hugetlb: improve the handling of hugetlb allocation failure for freed or in-use hugetlb' Andrew, could you help to change the subject line when you apply it? (or you want a new version, please let me know) Thanks. > Reviewed-by: Muchun Song Thanks for reviewing.