From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Muchun Song <muchun.song@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Oscar Salvador <osalvador@suse.de>,
David Hildenbrand <david@redhat.com>,
Michal Hocko <mhocko@kernel.org>, Linux-MM <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: hugetlb: fix hugetlb allocation failure when handling freed or in-use hugetlb
Date: Mon, 5 Feb 2024 16:23:46 +0800 [thread overview]
Message-ID: <2d6fa6b6-db90-4ba8-9205-437593bc2f9b@linux.alibaba.com> (raw)
In-Reply-To: <E549C993-A900-40AF-9D0E-F14109237487@linux.dev>
On 2/5/2024 2:56 PM, Muchun Song wrote:
>
>
>> On Feb 5, 2024, at 11:54, Baolin Wang <baolin.wang@linux.alibaba.com> wrote:
>>
>> When handling the freed hugetlb or in-use hugetlb, we should ignore the
>> failure of alloc_buddy_hugetlb_folio() to dissolve the old hugetlb successfully,
>> since we did not use the new allocated hugetlb in this 2 cases.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>
> OK. It is not a fix (I see a fix keyword in subject) but an
> optimization for unnecessary-allocation cases. Thanks.
Yes, better to change the subject to 'mm: hugetlb: improve the handling
of hugetlb allocation failure for freed or in-use hugetlb'
Andrew, could you help to change the subject line when you apply it? (or
you want a new version, please let me know) Thanks.
> Reviewed-by: Muchun Song <muchun.song@linux.dev>
Thanks for reviewing.
next prev parent reply other threads:[~2024-02-05 8:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 3:54 Baolin Wang
2024-02-05 6:56 ` Muchun Song
2024-02-05 8:23 ` Baolin Wang [this message]
2024-02-05 9:31 ` Michal Hocko
2024-02-05 12:38 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d6fa6b6-db90-4ba8-9205-437593bc2f9b@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox