linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 7728/11071] kernel/rcu/rcuscale.c:301:27: error: 'get_rcu_tasks_gp_kthread' undeclared here (not in a function); did you mean 'get_rcu_tasks_trace_gp_kthread'?
@ 2023-06-20 23:28 kernel test robot
  2023-06-20 23:33 ` Paul E. McKenney
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2023-06-20 23:28 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: oe-kbuild-all, Linux Memory Management List

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   9dbf40840551df336c95ce2a3adbdd25ed53c0ef
commit: df8fa2f1fc4c20cd300855a11b31ba5565f45ac6 [7728/11071] rcuscale: Measure RCU Tasks Trace grace-period kthread CPU time
config: microblaze-randconfig-r003-20230620 (https://download.01.org/0day-ci/archive/20230621/202306210727.vqY7wkdG-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230621/202306210727.vqY7wkdG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306210727.vqY7wkdG-lkp@intel.com/

Note: the linux-next/master HEAD 9dbf40840551df336c95ce2a3adbdd25ed53c0ef builds fine.
      It may have been fixed somewhere.

All errors (new ones prefixed by >>):

>> kernel/rcu/rcuscale.c:301:27: error: 'get_rcu_tasks_gp_kthread' undeclared here (not in a function); did you mean 'get_rcu_tasks_trace_gp_kthread'?
     301 |         .rso_gp_kthread = get_rcu_tasks_gp_kthread,
         |                           ^~~~~~~~~~~~~~~~~~~~~~~~
         |                           get_rcu_tasks_trace_gp_kthread


vim +301 kernel/rcu/rcuscale.c

   289	
   290	static struct rcu_scale_ops tasks_ops = {
   291		.ptype		= RCU_TASKS_FLAVOR,
   292		.init		= rcu_sync_scale_init,
   293		.readlock	= tasks_scale_read_lock,
   294		.readunlock	= tasks_scale_read_unlock,
   295		.get_gp_seq	= rcu_no_completed,
   296		.gp_diff	= rcu_seq_diff,
   297		.async		= call_rcu_tasks,
   298		.gp_barrier	= rcu_barrier_tasks,
   299		.sync		= synchronize_rcu_tasks,
   300		.exp_sync	= synchronize_rcu_tasks,
 > 301		.rso_gp_kthread	= get_rcu_tasks_gp_kthread,
   302		.name		= "tasks"
   303	};
   304	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [linux-next:master 7728/11071] kernel/rcu/rcuscale.c:301:27: error: 'get_rcu_tasks_gp_kthread' undeclared here (not in a function); did you mean 'get_rcu_tasks_trace_gp_kthread'?
  2023-06-20 23:28 [linux-next:master 7728/11071] kernel/rcu/rcuscale.c:301:27: error: 'get_rcu_tasks_gp_kthread' undeclared here (not in a function); did you mean 'get_rcu_tasks_trace_gp_kthread'? kernel test robot
@ 2023-06-20 23:33 ` Paul E. McKenney
  0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2023-06-20 23:33 UTC (permalink / raw)
  To: kernel test robot; +Cc: oe-kbuild-all, Linux Memory Management List

On Wed, Jun 21, 2023 at 07:28:01AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   9dbf40840551df336c95ce2a3adbdd25ed53c0ef
> commit: df8fa2f1fc4c20cd300855a11b31ba5565f45ac6 [7728/11071] rcuscale: Measure RCU Tasks Trace grace-period kthread CPU time
> config: microblaze-randconfig-r003-20230620 (https://download.01.org/0day-ci/archive/20230621/202306210727.vqY7wkdG-lkp@intel.com/config)
> compiler: microblaze-linux-gcc (GCC) 12.3.0
> reproduce: (https://download.01.org/0day-ci/archive/20230621/202306210727.vqY7wkdG-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202306210727.vqY7wkdG-lkp@intel.com/
> 
> Note: the linux-next/master HEAD 9dbf40840551df336c95ce2a3adbdd25ed53c0ef builds fine.
>       It may have been fixed somewhere.
> 
> All errors (new ones prefixed by >>):
> 
> >> kernel/rcu/rcuscale.c:301:27: error: 'get_rcu_tasks_gp_kthread' undeclared here (not in a function); did you mean 'get_rcu_tasks_trace_gp_kthread'?
>      301 |         .rso_gp_kthread = get_rcu_tasks_gp_kthread,
>          |                           ^~~~~~~~~~~~~~~~~~~~~~~~
>          |                           get_rcu_tasks_trace_gp_kthread

This should be fixed by Arnd's commit in -rcu:

d22c97e39866 ("rcuscale: fix building with RCU_TINY")

Please let me know if this one does not do the trick.

							Thanx, Paul

> vim +301 kernel/rcu/rcuscale.c
> 
>    289	
>    290	static struct rcu_scale_ops tasks_ops = {
>    291		.ptype		= RCU_TASKS_FLAVOR,
>    292		.init		= rcu_sync_scale_init,
>    293		.readlock	= tasks_scale_read_lock,
>    294		.readunlock	= tasks_scale_read_unlock,
>    295		.get_gp_seq	= rcu_no_completed,
>    296		.gp_diff	= rcu_seq_diff,
>    297		.async		= call_rcu_tasks,
>    298		.gp_barrier	= rcu_barrier_tasks,
>    299		.sync		= synchronize_rcu_tasks,
>    300		.exp_sync	= synchronize_rcu_tasks,
>  > 301		.rso_gp_kthread	= get_rcu_tasks_gp_kthread,
>    302		.name		= "tasks"
>    303	};
>    304	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-20 23:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-20 23:28 [linux-next:master 7728/11071] kernel/rcu/rcuscale.c:301:27: error: 'get_rcu_tasks_gp_kthread' undeclared here (not in a function); did you mean 'get_rcu_tasks_trace_gp_kthread'? kernel test robot
2023-06-20 23:33 ` Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox