From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 938F1C433EF for ; Thu, 23 Jun 2022 02:36:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26B278E0110; Wed, 22 Jun 2022 22:36:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21B028E00FA; Wed, 22 Jun 2022 22:36:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BCE88E0110; Wed, 22 Jun 2022 22:36:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EAF848E00FA for ; Wed, 22 Jun 2022 22:36:25 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B1BBF613E7 for ; Thu, 23 Jun 2022 02:36:25 +0000 (UTC) X-FDA: 79607936730.10.E3B3777 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf02.hostedemail.com (Postfix) with ESMTP id 2979E80002 for ; Thu, 23 Jun 2022 02:36:24 +0000 (UTC) Received: by mail-pj1-f50.google.com with SMTP id i8-20020a17090aee8800b001ecc929d14dso2742685pjz.0 for ; Wed, 22 Jun 2022 19:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ap/l5/DtRvj53V2CP02OCV8Y9yv6B47W9rFtmSDPxls=; b=FpOyHo8x4jGy05YG6pNB+UTP0d2tDbI8uK8nVnAfyLYHadT0jVXhh164JY6S+Y4Ets StuLbjcpbIXgQfPPKNHjHdrFuZxp/1vsrAwNf+MIRPoxcw2kOtZI+0qyHYG4PtWf4EGZ 4YX3AIDmZ0EnsgevwSnayUEl1nJyIOGwjXbMlMLWZ8+We04oQ2oKyh0YzlwFBT2uW/5m sW28f3aZPh+rREYYdhaXmB1yj66IS6Pe9Nx5ez8jz2nMgKIo8SrdNIPH5bvcUB5LURHZ klTqDnqyx8w+fAKTMzbI11ocnkMFpG+Hji/l7D7R1aVizV0BooQ27c5D+vlP5GNpleON NAIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ap/l5/DtRvj53V2CP02OCV8Y9yv6B47W9rFtmSDPxls=; b=1GcaS9F14vW5X0lyGo+rCUWxO8lUh7eNWOBwboYkaQCNWEidD8iDZ9t5CvHZ8/WZiB xlv3z173yIu8mV302BMhE05VoGKMcxRgjC3ANzhqRXmwtcFZHsYWzsbvtPG2b807rHmf RoYhK00iAm6kcW7KEPYpjOcqoiIADkBqdV5QN7iberfy1w9WXQDVM/OKHay2dT1DAd7+ it8n2xXr7s61pZ9MaYkGbRm0mTlbMYBV8o49IYIhWeMvFYhS/dzRCY4sSglEB/iKl+G5 XUBrcG3FV0v8esz25HG6/Bzw7bt3Yl93Z4+HqJAc6FmiF20IkwcdUo7p+JKcHFNz5y8Z Ykew== X-Gm-Message-State: AJIora9CU6DYwrJhwQtwBHgerXs7cnZeyDhURl7mmEIClvezPm62eGca ka+GazAkBtai4w8teXsZ0PnDsA== X-Google-Smtp-Source: AGRyM1vpifYz050GyEzWzRjhQy8/6B2veXLZvJ6SBiX5HXPWJbx+e9VN+j5wuu1AX6XUoLZCOJnVtA== X-Received: by 2002:a17:902:f60d:b0:16a:1a7f:a22f with SMTP id n13-20020a170902f60d00b0016a1a7fa22fmr21280279plg.13.1655951784244; Wed, 22 Jun 2022 19:36:24 -0700 (PDT) Received: from [10.4.214.173] ([139.177.225.237]) by smtp.gmail.com with ESMTPSA id a13-20020a1709027e4d00b0015e8d4eb26csm13583831pln.182.2022.06.22.19.36.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jun 2022 19:36:23 -0700 (PDT) Message-ID: <2d607f47-71fa-9505-b355-7203eb327bab@bytedance.com> Date: Thu, 23 Jun 2022 10:36:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v12 12/14] mm: multi-gen LRU: debugfs interface Content-Language: en-US To: Yu Zhao Cc: Andrew Morton , Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Peter Zijlstra , Tejun Heo , Vlastimil Babka , Will Deacon , Linux ARM , "open list:DOCUMENTATION" , linux-kernel , Linux-MM , the arch/x86 maintainers , Kernel Page Reclaim v2 , Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain References: <20220614071650.206064-1-yuzhao@google.com> <20220614071650.206064-13-yuzhao@google.com> <214db251-827c-715c-54cf-9c0e9bb5fe30@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655951785; a=rsa-sha256; cv=none; b=mLkkNAsUTVDJXNw/HkMOhV09DrSjGBzEVzSrafk+1hwxZSlCNWbwL6LBxGMAVO8u9anlhL z+d7l0uRhUZqPimuCtPXlv85rP01i+iR1nCJF02hl8euvudN4HcJdyDo1/JuN6e+2CJio/ xunVKnzWFgQsGNV8EPrqMjOeP9ZwWi4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=FpOyHo8x; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf02.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655951785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ap/l5/DtRvj53V2CP02OCV8Y9yv6B47W9rFtmSDPxls=; b=F65wxmcq9shr1jSK6yrxXIPay+Fw7vK0lDhvoLCCNC6a6llonV8ffI02u+uqs/nlpajUv+ mZuc+CPqm0aQhO7oK39wwjuEvZcC2ZhQnYz8JN8yIBm8ZKUSkm/EBSbwqdlE5vgEo6mg/I Me090Z/KzypC0zX3J4zqYa1SB1rPyZM= X-Rspamd-Queue-Id: 2979E80002 X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=FpOyHo8x; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf02.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com X-Rspamd-Server: rspam03 X-Stat-Signature: qk3fa6h3z7i1fqa889dyyqxcie6y894w X-HE-Tag: 1655951784-118916 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/23 03:13, Yu Zhao wrote: > On Wed, Jun 22, 2022 at 3:16 AM Qi Zheng wrote: > >>> +static ssize_t lru_gen_seq_write(struct file *file, const char __user *src, >>> + size_t len, loff_t *pos) >>> +{ >>> + void *buf; >>> + char *cur, *next; >>> + unsigned int flags; >>> + struct blk_plug plug; >>> + int err = -EINVAL; >>> + struct scan_control sc = { >>> + .may_writepage = true, >>> + .may_unmap = true, >>> + .may_swap = true, >>> + .reclaim_idx = MAX_NR_ZONES - 1, >>> + .gfp_mask = GFP_KERNEL, >>> + }; >>> + >>> + buf = kvmalloc(len + 1, GFP_KERNEL); >>> + if (!buf) >>> + return -ENOMEM; >>> + >>> + if (copy_from_user(buf, src, len)) { >>> + kvfree(buf); >>> + return -EFAULT; >>> + } >>> + >>> + if (!set_mm_walk(NULL)) { >> >> The current->reclaim_state will be dereferenced in set_mm_walk(), so >> calling set_mm_walk() before set_task_reclaim_state(current, >> &sc.reclaim_state) will cause panic: >> >> [ 1861.154916] BUG: kernel NULL pointer dereference, address: >> 0000000000000008 > > Thanks. > > Apparently I shot myself in the foot by one of the nits between v11 and v12. > >>> + kvfree(buf); >>> + return -ENOMEM; >>> + } >>> + >>> + set_task_reclaim_state(current, &sc.reclaim_state); >>> + flags = memalloc_noreclaim_save(); >>> + blk_start_plug(&plug); >>> + >>> + next = buf; >>> + next[len] = '\0'; >>> + >>> + while ((cur = strsep(&next, ",;\n"))) { >>> + int n; >>> + int end; >>> + char cmd; >>> + unsigned int memcg_id; >>> + unsigned int nid; >>> + unsigned long seq; >>> + unsigned int swappiness = -1; >>> + unsigned long opt = -1; >>> + >>> + cur = skip_spaces(cur); >>> + if (!*cur) >>> + continue; >>> + >>> + n = sscanf(cur, "%c %u %u %lu %n %u %n %lu %n", &cmd, &memcg_id, &nid, >>> + &seq, &end, &swappiness, &end, &opt, &end); >>> + if (n < 4 || cur[end]) { >>> + err = -EINVAL; >>> + break; >>> + } >>> + >>> + err = run_cmd(cmd, memcg_id, nid, seq, &sc, swappiness, opt); >>> + if (err) >>> + break; >>> + } >>> + >>> + blk_finish_plug(&plug); >>> + memalloc_noreclaim_restore(flags); >>> + set_task_reclaim_state(current, NULL); >>> + >>> + clear_mm_walk(); >> >> Ditto, we can't call clear_mm_walk() after >> set_task_reclaim_state(current, NULL). >> >> Maybe it can be modified as follows: >> >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index 2422edc786eb..552e6ae5243e 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -5569,12 +5569,12 @@ static ssize_t lru_gen_seq_write(struct file >> *file, const char __user *src, >> return -EFAULT; >> } >> >> + set_task_reclaim_state(current, &sc.reclaim_state); >> if (!set_mm_walk(NULL)) { >> kvfree(buf); >> return -ENOMEM; >> } >> >> - set_task_reclaim_state(current, &sc.reclaim_state); > > We need a `goto` because otherwise we leave a dangling Yes, right. With this: Reviewed-by: Qi Zheng > `current->reclaim_state`. (I swear I had one.) (I believe :)) -- Thanks, Qi