From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 689FEC5475B for ; Fri, 1 Mar 2024 12:12:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD5B26B0072; Fri, 1 Mar 2024 07:12:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D86886B0074; Fri, 1 Mar 2024 07:12:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4E4A6B007E; Fri, 1 Mar 2024 07:12:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B37446B0072 for ; Fri, 1 Mar 2024 07:12:10 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5FD70141380 for ; Fri, 1 Mar 2024 12:12:10 +0000 (UTC) X-FDA: 81848357220.29.F6B00BF Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf13.hostedemail.com (Postfix) with ESMTP id 4A4362001C for ; Fri, 1 Mar 2024 12:12:07 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IrYw+K7f; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709295128; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kCE5yE+EOG4EtzTQPZh5soFZgiqWRPt2t+i5neN6wP8=; b=7K5PqrF6X28L7rDUzVXJnW+oepQvEkGDJf3OwI/AoHgWuF+IZ9VCuH3FsdzOUlJqwMQEvO TBlBpcKhV0NEOOWFsR8EJ3dl0LImPp/U+zuRu0W6AGLPStqpjm0VC6We6p+qy+A4JhPgh0 0m9BWoqijlY649N2OxCZsfUhgRPGLHY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IrYw+K7f; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709295128; a=rsa-sha256; cv=none; b=h1q1tIYY9/x4DI9eWiOVKGB3t/K7JsWGaa5nlhvYbyYJFsG/xJ4BVf6/EXS1sicoVGjjJ3 VIsQMTDWvhFm0QKYIEnt80Vu44g2CG4OwGnmgjZB5aGL/V40B97co7JhtGchpufWq6e/Au Zni4k28FoUdPBFFm1aZjwWKc5+PX/w8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A8929CE1F4E; Fri, 1 Mar 2024 12:12:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CEA8C433F1; Fri, 1 Mar 2024 12:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709295122; bh=WfddGTTxOxrioIY8/wcsdzeHOCxjcPKVGeQVl66RUsA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IrYw+K7fnHTaJUP4LWmas0DizEtD7fbGrk+TcYhHHi6hHTegtRNZRntjBYRvUF+2L c5NCYfNPwJUqkK4tklnaR3Asg7YCy4R/+9YshVAf/BcDC2MLGPo3Q6vFJk/5uhPcAH HljkJCAJ0FbRO/jHKYH5txVgtuBlw1uJj6cMDKCdJVswWMjZ/s8fWVh1Df/DWLUtkY wbn/V2cx/s/f29t057+sjQfev9+HTXkdWKkO713vfG8ZLT3LxDuTU/BLgE6zmYRq9g BiUr/6p8pX7H0G+DLp0fyoxNQCo0IqRR0ZZgthEoUWKBul3Eqaa2i8VBfixYbR7rZG vyL2A7sU/tmbw== Date: Fri, 1 Mar 2024 12:11:56 +0000 From: Mark Brown To: Ryan Roberts Cc: Aishwarya TCV , Zi Yan , "Pankaj Raghav (Samsung)" , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , David Hildenbrand , Yang Shi , Yu Zhao , "Kirill A . Shutemov" , Michal =?iso-8859-1?Q?Koutn=FD?= , Roman Gushchin , Zach O'Keefe , Hugh Dickins , Luis Chamberlain , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order. Message-ID: <2d5f9cd5-a2c2-453e-aa52-a84a86107d1f@sirena.org.uk> References: <20240226205534.1603748-1-zi.yan@sent.com> <20240226205534.1603748-9-zi.yan@sent.com> <082e48c8-71b7-4937-a5da-7a37b4be16ba@arm.com> <0dab0c69-2eac-4e65-9efe-e0b037499abc@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ghaC36SALgS50dQQ" Content-Disposition: inline In-Reply-To: <0dab0c69-2eac-4e65-9efe-e0b037499abc@arm.com> X-Cookie: Schizophrenia beats being alone. X-Rspamd-Queue-Id: 4A4362001C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: rw86dzdwf7bgei4oi7jzzjqg976a753w X-HE-Tag: 1709295127-390596 X-HE-Meta: U2FsdGVkX1/LgsW9K3WMuLcwHWEHlEHpEZtkba2hpL77Mn8N0NFS3Gq9kSQRLlcWf5C+EuUlUKR3+P/TMc0XIScU+YCbf5kxFSd626zc+S0r4z0MJoTS1jG4NWS2YXw3ob9eYylH3OUKNemWwPdgOeDRslVT2nTUW0DC8Qi5/VI0f/3wrGaY0sPB3Lo87G2qndrl+rPz7cCETDINn/v5u/Cn9k3gEyFrukMoab39StqnxBbDQkl4dtmrIIkL1AjlH0UYUE0LwIhyt+Lu735LPJ4WRgT3b8e6VtzFCeYNcLBZHCxVi6S77NGP0UMz/9eLnGHOPAKWQ6fUelZnONaaH0KdLkaVvhKJpo3SZo7FFwWVen8/kTQ92Y080gyE2kqItFIUXcge+nBhucMzqqzIoLm3YQUgGpXeZCgXVcHkf3teWgg7V20P/cELOq38SLPQoaYDjk6MM0vdL1phwW7vt1uz+bFp6MSJmiZxQwqklrm7taRNpaCg786BJtSwqTE0Cwo3D2DKiYvNgbHcsATi5nOQR5B+Pla1MjIZESEgyV4+VYg7QX+lVmOaOcE/b60M4O0P/wMeAmRHqx9mcDXp5zFGigPqq51ySMtu2Xsx+1l9LXKqB9Cop47av4HSuYwdG8lqtsN5JkhzwNFwVsRhmFH0V+kee008VMZlpbWj2OLjPAp+B76/k47n0+QeyVq31EL9iI3UphduRnoh25UKjQwthYOnLC5oJOzPjrzsNXpQPa9l5lWpxyR1GjIXSUs/zqBpomE5Lh5iF8yyknRcYqoG2FfvRGx3dfDqW/6EAoXFo4uJLN0h/iQS7AJbiODMyCrYCxrE2yTBJYrJ0HhpcOp9/nbqD+0RatrE9wloFEOowKlL+wQE7wU2XLEWY/Byk4Rp5WAqUNqiRWrrYjYO2cbd/Jmg6UAe2w6nQ3EmsGkLmcDSGoOeMu1/5lGRzHJsZtX+Ibnd90sMKpI+kA1 vaBYj4DN vi6gkMq0PyGACQyww8Y1mvgl4xZ6RFT1VgYKp45i1VuAwCyC8qgxEAujGdlEc2eAashfyfP75G3s4i7awXx5k+m30T7phS2KZkGdbsgH7gUvc2x3HiKPvkaCEdbguGif0wTEG79We6LpgEHh6F3BuSM3yV5KSW2RkK1vQNVvtJuuVZlhN9RF+cS8lSL1jYp/lLQueX6NVT00bxJ2PdiU/zF7CpoB3WKSoQls8igs8NsW2ZfJggHGg9etstlDwLR8jHEaljQMpWb83WOInM0O1mZjzRvTkcAFiaiXULMtGy7NYu5cCGJ/a3jSb2ZPHtXTt3ofWVh+IEcW3WkU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --ghaC36SALgS50dQQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 01, 2024 at 10:33:15AM +0000, Ryan Roberts wrote: > - In create_pagecache_thp_and_fd() you do *fd = open(testfile, O_CREAT ...); > where testfile is /mnt/thp_fs/testfile. So if /mnt/thp_fs doesn't exist, > then the open will fail I think? I'm pretty sure that's what's happening on > our CI. Suggest the test needs to setup this dir itself. Is thp_fs a mounted > fs or just a dir? If the latter can you just mktemp()? Mounting on /mnt would also be a bit of an issue, that's something people are relatively likely to have used for something so could be disruptive. If the test is going to do a new mount it's probably better to do something like make a temporary directory then mount on top of that. --ghaC36SALgS50dQQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXhxgsACgkQJNaLcl1U h9CNLgf9HnhxProx3fA8CTE/KbjX2kFnC4nKYaXEmu4hIqNDt7YEDJ3tb98zw/Sj bTFxhX7W1MPl3iqo8ylB7H8Lkx87AgriD1Z1Dx7ejr4VuFG7wY+yee81LuIL9p9K YCRKeb8PXzdPitkpVupwFmf3HxNLkpOnPYnZz3e5J6UNthFxxBHkcDKXxNGxa3v2 JE4LuVmQ+tSw442i4gNHrcmIuaSIIdlcGX5GcNFRGvIpR+UshuCxz3nW3E++9Yoa 3V+ueMu756haaNJActL1liljR0Q6JMp934EuvNJ+o6XWl48aGkuXQ4dUabvm7Qn1 LwbKuFeIM2JiK9dS6EWSVyiPTPvS1w== =Rx7H -----END PGP SIGNATURE----- --ghaC36SALgS50dQQ--