From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85CD8C27C65 for ; Mon, 10 Jun 2024 14:14:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01F686B008A; Mon, 10 Jun 2024 10:14:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEA796B008C; Mon, 10 Jun 2024 10:14:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D641C6B0092; Mon, 10 Jun 2024 10:14:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B779C6B008A for ; Mon, 10 Jun 2024 10:14:40 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1FFCEA0FF3 for ; Mon, 10 Jun 2024 14:14:40 +0000 (UTC) X-FDA: 82215174720.24.083831F Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf12.hostedemail.com (Postfix) with ESMTP id E30B840010 for ; Mon, 10 Jun 2024 14:14:37 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="XIlyhNW/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718028878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=otgxqPSAJXSRGAj15fYyDevd0a/nXgqK0lL4xZTmNjM=; b=iKAa3vTvrNZ7zxTL9lOkaejGLyzbbrY1fr6mYfeZhT5oQMcnx1NybWGow2Ek+0Pezmwlp7 zJ3aiQ0SrCKOxeHzCZCpMlPOcpbtQd7sMJwiQcLw4O/nlGpM3yE1CLcxApJuBqxCis8q9N TT/TEvxQARpQWBqU1HBB3PWL+mUL6Tw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="XIlyhNW/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718028878; a=rsa-sha256; cv=none; b=eFbXr99iGLzwi6fFdX2VhgR/9wYBQXD+Z/10kIVWHKRN6sYOWHgTn6tZk/oSOJpFNeVGZn DtjzpXicKO3y1fIGeTt/5Y5WZBAhNi2D11dftcv6lFQ7/ffLqRmG+/mLVU1tBjc64V97dR mraIBmeOpIs7ViQGV33lJc90XpOlXxs= Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52c9034860dso404437e87.2 for ; Mon, 10 Jun 2024 07:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718028876; x=1718633676; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=otgxqPSAJXSRGAj15fYyDevd0a/nXgqK0lL4xZTmNjM=; b=XIlyhNW/+T+ZhucRWy0j/rsSDC293k6B3+gxIpNOc+HncM50BngHg/sYmYrPPWMvFg BK+jsz0SPRptpVPimYTs8pUP9R0mJq92rurpyBWszgB0+4yglgX2hHojuxDpN7OKlLHv RkU9D95GKpwms2OJGzD+kX3flxfalNq7G70VDX5uAD48CkYrQhmHidY+yaqLUOiPBLnC GupzojjTQNSsh65hWf0m7Ui34Z+aJdElg01J09CAi5L+x50M486YNExhrTQMtEZoYBDE 49XB2GbLQA+6gaDJdpboRQA2RZbo6SK6X4Fs0e8hR0I2WT2DkOUWVW67dhnf9bpB+iZ+ B88g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718028876; x=1718633676; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=otgxqPSAJXSRGAj15fYyDevd0a/nXgqK0lL4xZTmNjM=; b=oepAhRJvQbsg0oKCGbNpVDznvMjgXZdH9xWWQOeuxgJOx6/F/3yrtlJ78YZ0loRbRs bPJGSvoL8xvG5LTtUhleuhv1IsS8j36rnX1EarMHfhskf9V22778kqUFSnDPpRLDrweU DsEDarulNRvKrIqFxdF3pDhH3E1PhNaDMtrHwJ7PT+vue97vrF+3jg6l3edpyPjbGapL qrd3RqioztiCWCx+VOi4DkU0r/e6Pb8aXV1XxuvgILb1gcEyoOE/T2WJCiQF4CFIUTOV K621UFb9hwa/HEKdaaTju9v/i481bt6UoKJaTyJ0t9yCdINcBEpqLDWULhiJbj/DJ8SN mMvw== X-Forwarded-Encrypted: i=1; AJvYcCXd3gKWn9WB4VGin8KI7u95YWMBIoZREaC0gOlUBHCTrqP7PYfa2WOmOBbdQVs0LITKr75j0VnIhjbapwl2XZbK0pk= X-Gm-Message-State: AOJu0YwPml/U8IszoMGhL0PyjvpGHStCuYz3HZiCmpmRA8mraoAlmGos d6T+EqC7yNFXVUGZURdf1t6qxgjQ1VMS2ydISd/9qhiLIEgH68B2 X-Google-Smtp-Source: AGHT+IGgbfdPUdapCE4c6qvjFTT17cbQeOyfvRh2FapDiAmnGcnDYYFEqEcHG2m+PPHIPzPo2C9z1w== X-Received: by 2002:a05:6512:b1c:b0:52c:80fb:ee76 with SMTP id 2adb3069b0e04-52c80fbef32mr5558127e87.58.1718028875838; Mon, 10 Jun 2024 07:14:35 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:eb:d0d0:c7fd:c82c? ([2620:10d:c092:500::7:493]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f0e450681sm308036466b.139.2024.06.10.07.14.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jun 2024 07:14:35 -0700 (PDT) Message-ID: <2d52b1a5-4c44-4cea-bccf-57972ca79f04@gmail.com> Date: Mon, 10 Jun 2024 15:14:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] mm: store zero pages to be swapped out in a bitmap To: Matthew Wilcox , hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com Cc: akpm@linux-foundation.org, david@redhat.com, ying.huang@intel.com, hughd@google.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com References: <20240610121820.328876-1-usamaarif642@gmail.com> <20240610121820.328876-2-usamaarif642@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E30B840010 X-Stat-Signature: ix1re99ahsgpf4b16bsqgjrxc5sszd1t X-HE-Tag: 1718028877-715490 X-HE-Meta: U2FsdGVkX18S9ijatVzVwQz1pUkPC44IhOwT/VDl4AxgBq/h+Y+eYVQoQvOoHhE36KWXatsbgzxwGG254FgTFoj8AxEajPFUYvq1LOogJJht1+OVdTTYI0OOr87E0D5vdIgkseJMLMIXhArfw7ZA3kTtwRRBXRY0uhhETKOMIYocsfuGySgBgjivgJJ77PoFWhC4MDnETOELjsjwttY74NWAtjV3RM82sX/V4cif335doOdKcQyOV9oFVRYtVkCD1DQ8GxoXuB9kAc8mzUJDeigk3bwVHIQsiFDTWTlmpStizY/9QFU44IsAjNUyKw97udd+kDIy9biR2KYrajHl5LYq2xvvT0z3+keBpUu6/5c1C3PgXLAba6X5a8P5u6o6s5Qp3l0cccR6rDf0xfZBoyeJD5Fix4Cxcfv6kFszHlep9KmvU5vIjCFMYSvwckBJ3cdEZjmJkA4pylYAysfjC7FD7ctnEj7ykfprH2IXMaQDgkVkwZXw2/eFpafp2B6HNB1FXbNmTdeiiB5Im0UzCEZ8/LHlxTq6Otfs/P+7SNkslRBPJJS6Japg5ZTZqu+iRwYN/VUyK8ZiFRs8D6OkFqNBZPaPHFnhQiJjm9XjCS1DOnOiHhtMqtLqrwVU/wTJvadKA6YuwjUZHGbB6vzQ30InJS3UuiCPUybuzVRIwUS+A3A86O0tB1HDqhfPKVMD4W1HolWfxybIupXzL7q5htnLkwL4hHUqI9+FOvwRG8o2oBMTMeRNGiIT/G6ndD7MfSXsVrhgw4ChGt44L7YRXwYVuc9KvbwIgSAJIcODsHK4Q9X+rNnStw07cr0qzemiIbYgrulFuwivTUSuX89PkMMPjRhaiNknWAHKWYCR8NGC6YorV+ruAIermSTTdT6QqPV8QUNw/6R8PH3bHlaGtq3waZgfKh01gZj+Dnz+SnLXYxTbnl39+vn6pHgOf/7Xbz55Y22M4MyVAaBLabv ja2YLoaA uZcQ/53sCDO91WJNSMCCX3CmXEoM6hdI5IgeMgjpGh+gl9UxxQLvtCFUp927aogjpB4tqCVh2UY//+8Kzxb2gYG8Iou9bACLn6O135V6oBcGiFuzYB/lXVa4eRdcP/7litcX2NhOiC5LIQpoEkqcFveMq62/Tm7F95txvdKqRAnEfGu2HIys/PScQgg/U5KCcsz/pAxJfNRsf0WP7Hw/QVMSwEcqun4/xG7FSLfwm8ZK3EYY5MhV1zB3F5vPcNvhtPPWVyjBQ0j/cNukvmebwOFY0Wz7HRV+fEC3UXtP9ktYszOgsZF6CrGiGih0Du26+cLXvl9/XuZfAsnVSCWntSUbMvbJ2PN0/T3zkci7g1wqw7pl91RnmbBZyQJCASv/kEjZwdSopD/WdSRiaQJmmIzt1RsZhaGeI2XWdb6/RkCy0cms25eWPJ5zcImhpcOGCctLKhOxq+66ayplnLVSNY/sFViq+gH1ZqTo5KzoJMRLGyv6eXQOAzZ9eu8PYiazzt0NGhPyd3kBJsHF8w9fgGVM1YpytX/SOad/K X-Bogosity: Ham, tests=bogofilter, spamicity=0.010394, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/06/2024 15:06, Matthew Wilcox wrote: > On Mon, Jun 10, 2024 at 02:56:09PM +0100, Usama Arif wrote: >> I am guessing what you are suggesting is just do this? >> >>     if (is_folio_zero_filled(folio)) { >>         swap_zeromap_folio_set(folio); >>         folio_unlock(folio); >>         return 0; >>     } > Right. Thanks! Will change to this in the next revision. >> If we have zswap enabled, the zero filled pages (infact any page that is >> compressed), will be saved in zswap_entry and NR_WRITTEN will be wrongly >> incremented. So the behaviour for NR_WRITTEN does not change in this patch >> when encountering zero pages with zswap enabled (even if its wrong). > We should fiz zswap too. > Will send the below diff as a separate patch for zswap: diff --git a/mm/page_io.c b/mm/page_io.c index 2cac1e11fb85..82796b9f08c7 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -281,9 +281,7 @@ int swap_writepage(struct page *page, struct writeback_control *wbc) } swap_zeromap_folio_clear(folio); if (zswap_store(folio)) { - folio_start_writeback(folio); folio_unlock(folio); - folio_end_writeback(folio); return 0; }