From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8854C2D0CD for ; Thu, 15 May 2025 14:57:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 723A06B009D; Thu, 15 May 2025 10:57:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AB7F6B009F; Thu, 15 May 2025 10:57:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5732A6B00A0; Thu, 15 May 2025 10:57:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 353096B009D for ; Thu, 15 May 2025 10:57:14 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 564E112012D for ; Thu, 15 May 2025 14:57:15 +0000 (UTC) X-FDA: 83445445230.30.6EB6059 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf28.hostedemail.com (Postfix) with ESMTP id EA46DC0003 for ; Thu, 15 May 2025 14:57:12 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CvVx4kFR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rxlkYI3r; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CvVx4kFR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rxlkYI3r; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747321033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=275R20YMq0CMl3mWxLHSxXzp2q9navMzLEtYmOMEG1k=; b=50IV73dsCmr7vQQZIhcPC8WY2JwiVm70b6j+bf62HF0UaPeGCVwFJyan6vnaS2d1XuWlGe rrmP5k5r/yiCsUTyx+u92/tYOQJxT9wGlTLO3Q7tCwFwgIklLGPBtmX2KlzhDUMZ9sog90 Kig2fH905D5YfGMCOaXJDBVVIeN2yUo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CvVx4kFR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rxlkYI3r; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CvVx4kFR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rxlkYI3r; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747321033; a=rsa-sha256; cv=none; b=f2nUZd3MmT6NbkaKjT+DXhSMT8euZjsv008JKqvuXf0qfTYl6caKpUIJVXqEPIUqvsuJLg N7qMfQFL6GD0msGD2rWdh3dmmN3auWnPOciC3PpeB7bFYgFRgerUFukusJKKeJyRPan/Ul 8XMo52wHqg6ajw73PtkO+YSl9U61qfg= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 36B35211D5; Thu, 15 May 2025 14:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747321031; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=275R20YMq0CMl3mWxLHSxXzp2q9navMzLEtYmOMEG1k=; b=CvVx4kFRIVHJBnwzffrXPD2IfV0JTCgFMMcYSzyBXMXx9qT+yYnWs2nc5z0szrXgturl0P Um1/tmg4APcIW+7f1QeKUN8Fx/aJNui8oUdaQp9LDJX0Wzvh7+TU3zmf7LG8/fRncAXGLK SH8FyWGIA6B1T8l8xhCTatyh/eBJSh0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747321031; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=275R20YMq0CMl3mWxLHSxXzp2q9navMzLEtYmOMEG1k=; b=rxlkYI3rlhrl4Bj6OZGwHlXSH7Fr5OXZtpvdr2NbixnFSFyu0a3WLgtaEV2LgQdp7k1mfQ KeQB7K8Rdzr4/xAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747321031; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=275R20YMq0CMl3mWxLHSxXzp2q9navMzLEtYmOMEG1k=; b=CvVx4kFRIVHJBnwzffrXPD2IfV0JTCgFMMcYSzyBXMXx9qT+yYnWs2nc5z0szrXgturl0P Um1/tmg4APcIW+7f1QeKUN8Fx/aJNui8oUdaQp9LDJX0Wzvh7+TU3zmf7LG8/fRncAXGLK SH8FyWGIA6B1T8l8xhCTatyh/eBJSh0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747321031; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=275R20YMq0CMl3mWxLHSxXzp2q9navMzLEtYmOMEG1k=; b=rxlkYI3rlhrl4Bj6OZGwHlXSH7Fr5OXZtpvdr2NbixnFSFyu0a3WLgtaEV2LgQdp7k1mfQ KeQB7K8Rdzr4/xAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0F748139D0; Thu, 15 May 2025 14:57:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yWrcAscAJmgHPAAAD6G6ig (envelope-from ); Thu, 15 May 2025 14:57:11 +0000 Message-ID: <2d517f89-3bb4-4de2-8c14-8bb1e4235c7a@suse.cz> Date: Thu, 15 May 2025 16:57:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/7] memcg: memcg_rstat_updated re-entrant safe against irqs Content-Language: en-US To: Shakeel Butt , Lorenzo Stoakes Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Alexei Starovoitov , Sebastian Andrzej Siewior , Harry Yoo , Yosry Ahmed , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team References: <20250514184158.3471331-1-shakeel.butt@linux.dev> <20250514184158.3471331-2-shakeel.butt@linux.dev> <22f69e6e-7908-4e92-96ca-5c70d535c439@lucifer.local> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Stat-Signature: 9gespu5o9f9x6hsw34xp9gdxbcd9xq9s X-Rspamd-Queue-Id: EA46DC0003 X-Rspam-User: X-HE-Tag: 1747321032-639922 X-HE-Meta: U2FsdGVkX19WekFZTIsiJx0z/sILRZ3yusQ6GIne97VM+QtOz4s3OhpN08pDll4POiCp27tQbk8+1fnFahgIEsa1aMn9m5obLpyhi8UDQAmeMc4cJJRHKYaETdm2bpLMStus1X7v/jA0OB3k+sgKvPz4h56LZdrL5hFOYh1UVtrtLaCjubC3ycHBcvqCeTUvK3mlZ/D8fjgbApUs7NVzVJjnghe8x0fENTrkBsbb6bGkPM+9yJ8/dA3Zu3+UUjlVIm8DnM2PTKNe4p0Uwdp3y+xaib5tsb1KW3J1m3fIyK4TDLYuZPogPLF4/z6Y7YMuBfdsSYPbLznrS7qSXVXhH/tylQGwX0Anef+qGB/f+4YOUUchRubuWnIS8Tzv/NqBuCGlOHuKW5mbWdvulThmh5SCOOB8lMcFS8sbtnZdsjNr+u5qT30YHaEPdqlW27T7gRm9IBmOAzqiECXDB/r4pA66Hx71rtaaiVcVt2L4JVKcbfJho54ejypBsN2F/7hBcI3RJIgY1h3eOnomNnhXATQnnKsBAALF0t5OpwsoTXGN/OHEaNoavzeT9tAHzoo8L4LV83zZ4OnDjpYpd4YzFjvBlAuWwVDI6nDIdmSQCMB+XfrWdnRmYJkwpo838K1VKEFz8Cdim21AlTTyN+tclz8WXt70B8/C5/pXhbzPT3YIzPr8Ima1yeSg7otYtecs3KtLyFN5LZuFjAuH3OWrrSXNKw/SF/7m0eInHlp8D36wIE9A9zExPP8jTHvnF86lLS32Nx+w/EufoFF4hMJexGFbLYPCaZtTIQbirqc1jZKwrDp2YG5s6dMXl4r2IsQa7WMOod2f1vQ6wCwMuglPfQuo11jNtd0d9OUuMdURYacHEF84k5TgrfQtEqSo94aVupDkVMnJEVla//WxFxKbC9iUUYeqahF8DMudOZk/Vf+Tf4ee0bzT4+XVYQKgBk5W6is/VY6IujCeCfU1gjz M913Cd9f 4rC3PMt0HgeIwN0xdRnKgqgMULh/vIuLy4jdTBJPi9QD4QLUz4Nqhuzoaqvt2sc4lvPN1qEXRNKWR5emvJLT5NMhyZIFTasQ8AjRBa243rDSPUGmUhprVv9z6TJvtflRIVTUGW8evW/h3193DEPzx8XNChBq2Z5ThYO0b3m52Vh1Vu2m+cf8Yw6+xqNxoYYOuafuhZG4BAOqfk3G4zHplxtTcsrhXjIKNeA/wEvrHFgFNUr310O/OwRygRtsNdTo3ICzCj6unFzZ90VU2dSfUCEfM11dStftHPCyQiZXnxHlj5QzddLoAxaskPFXgGmB7C9K8rewLKIxE/iOsGXKEgL0FnVdUQdIBZixTGPPpo1y6wq4MdFAP9v06SZKOSUn1Gvpy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/15/25 16:31, Shakeel Butt wrote: > On Thu, May 15, 2025 at 5:47 AM Lorenzo Stoakes > wrote: >> >> Shakeel - This breaks the build in mm-new for me: >> >> CC mm/pt_reclaim.o >> In file included from ./arch/x86/include/asm/rmwcc.h:5, >> from ./arch/x86/include/asm/bitops.h:18, >> from ./include/linux/bitops.h:68, >> from ./include/linux/radix-tree.h:11, >> from ./include/linux/idr.h:15, >> from ./include/linux/cgroup-defs.h:13, >> from mm/memcontrol.c:28: >> mm/memcontrol.c: In function ‘mem_cgroup_alloc’: >> ./arch/x86/include/asm/percpu.h:39:45: error: expected identifier or ‘(’ before ‘__seg_gs’ >> 39 | #define __percpu_seg_override CONCATENATE(__seg_, __percpu_seg) >> | ^~~~~~ >> ./include/linux/args.h:25:24: note: in definition of macro ‘__CONCAT’ >> 25 | #define __CONCAT(a, b) a ## b >> | ^ >> ./arch/x86/include/asm/percpu.h:39:33: note: in expansion of macro ‘CONCATENATE’ >> 39 | #define __percpu_seg_override CONCATENATE(__seg_, __percpu_seg) >> | ^~~~~~~~~~~ >> ./arch/x86/include/asm/percpu.h:93:33: note: in expansion of macro ‘__percpu_seg_override’ >> 93 | # define __percpu_qual __percpu_seg_override >> | ^~~~~~~~~~~~~~~~~~~~~ >> ././include/linux/compiler_types.h:60:25: note: in expansion of macro ‘__percpu_qual’ >> 60 | # define __percpu __percpu_qual BTF_TYPE_TAG(percpu) >> | ^~~~~~~~~~~~~ >> mm/memcontrol.c:3700:45: note: in expansion of macro ‘__percpu’ >> 3700 | struct memcg_vmstats_percpu *statc, __percpu *pstatc_pcpu; >> | ^~~~~~~~ >> mm/memcontrol.c:3731:25: error: ‘pstatc_pcpu’ undeclared (first use in this function); did you mean ‘kstat_cpu’? >> 3731 | pstatc_pcpu = parent->vmstats_percpu; >> | ^~~~~~~~~~~ >> | kstat_cpu >> mm/memcontrol.c:3731:25: note: each undeclared identifier is reported only once for each function it appears in >> >> The __percpu macro seems to be a bit screwy with comma-delimited decls, as it >> seems that putting this on its own line fixes this problem: >> > > Which compiler (and version) is this? Thanks for the fix. Hm right I see the same errors with gcc 7, 13, 14, 15 but not with clang.