From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF43FC3DA4A for ; Thu, 22 Aug 2024 08:21:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2895E6B0159; Thu, 22 Aug 2024 04:21:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2394F6B0177; Thu, 22 Aug 2024 04:21:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DB2F6B015B; Thu, 22 Aug 2024 04:21:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E1C0F80017 for ; Thu, 22 Aug 2024 04:21:51 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8760714105C for ; Thu, 22 Aug 2024 08:21:51 +0000 (UTC) X-FDA: 82479188022.19.4EE8DE4 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf12.hostedemail.com (Postfix) with ESMTP id E826D40009 for ; Thu, 22 Aug 2024 08:21:48 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of liaoyu15@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=liaoyu15@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724314819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GpCLKiJ6v/En5pgctP2AT/nkeAo3bVRqEpwWS1NGCpg=; b=X1crqRTs6FRSwfDUtT+263hvxxnfepS1RKnb1n4hk3RgTD1kFiQyqEF8TMiypjk0C6wLj/ J/erEZXjkpWqN6KZEmgc2MCuvd0onx5jd8EB/J1J/EAP7epYtDr8tpuESP8eA2TtI47SuU 68Hs+Pelbi0Z4C44htwIk4ukYq7QNKA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724314819; a=rsa-sha256; cv=none; b=AU8ZUum5roTzHpc2vttM8b/IlRnHb4klzP+gNi+By9F0z/ryXvMwsf+ZYLmHElXkxb6wVe pAHNvmphowaK9sJXnLiDlLUtSbIYbvQHNM849PcKQj+7F3HFDFC8fifScWQYnapGJxRMJV XnjvhTsKUu6iiyzBWGDjIvYim67SiIc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of liaoyu15@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=liaoyu15@huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4WqGPD3pZ2z13kGf; Thu, 22 Aug 2024 16:21:04 +0800 (CST) Received: from dggpeml500003.china.huawei.com (unknown [7.185.36.200]) by mail.maildlp.com (Postfix) with ESMTPS id A915C1800D3; Thu, 22 Aug 2024 16:21:44 +0800 (CST) Received: from [10.174.177.173] (10.174.177.173) by dggpeml500003.china.huawei.com (7.185.36.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 22 Aug 2024 16:21:44 +0800 Message-ID: <2d418463-1458-5361-86c4-a07908fc114d@huawei.com> Date: Thu, 22 Aug 2024 16:21:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH mm-unstable v2 1/3] mm/contig_alloc: support __GFP_COMP Content-Language: en-US To: Yu Zhao , Andrew Morton , Muchun Song CC: "Matthew Wilcox (Oracle)" , Zi Yan , , , Kefeng Wang References: <20240814035451.773331-1-yuzhao@google.com> <20240814035451.773331-2-yuzhao@google.com> From: Yu Liao In-Reply-To: <20240814035451.773331-2-yuzhao@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.173] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500003.china.huawei.com (7.185.36.200) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E826D40009 X-Stat-Signature: 4t48wukpj6pcey7snn4ksftnr93nhqx9 X-Rspam-User: X-HE-Tag: 1724314908-797254 X-HE-Meta: U2FsdGVkX1+IB7GDeDCE9vboFL9z/Xgk1WBJ+3jwo8jynRtCaJU+p7ji9jPNdScO1R5Gl5cxR5yeMo+hrZ+1T1rLpWL7cVLbI2LASqpwBUqJDXrdKypjW6vsi5kAC0BJAkwDuRykA06mP8GOKaVL9rroIPUL+/vo6UvqcAbzVUSnpX0JRpYVxdM+TFwcZqYbgalGxR2CakPN/PE8RX+dhhQuiasu8p5NZzO424sl78lwf+bKKWH29eGRMpqGuTYe0KgennvzjyIKAYkJ/DxA+o9uaroaS6w6wnJIbxymvu30AxYXE09CVmbQrMzGysu13xfWXXqPPz1BB63Os9+66f2dMybyoq7ML+oqAhH5NKGHRMhm4eAJ3NxAUIk1conVrqD+9e1Sw7bSFYU0UXpwVX7zg3fezmcONkqW7C1Bo1d3L5RC36U4KOCCNYSNK5FOxV6bpw0XSI8m/U/7Pv0I2jHfGpxWbZxonHan1FPn9oOd4qCOKBkvhKuFO1rxndCxP6CxLuKDxIz9dcB0dxlHfLq03wOtlz7Vw8HCU3B7jJQ9Grji7x0JFRxSWBgahZ3TUEVGMZwA+uckTk7Deo+I1oPNki3lYoCghi/cK2fH23fjCQAgPbBdP2vewvmq5P/mNdmqhGIuKrBKgbZf0oBKXdAjbdNa6IgaN6TGE6ThoV731snrUBnXwBQhFMSKUpF7tOdpY7O8/FpIUsnJq0TNTyeXtC8kXU2e/Li7NC6wz3RzveHC63Hj/Ubqs3PR9f0LDaDo5EF7DjGe3Ctjh4HaNV7OlF5EEipdg1EJad6Qsm4dOy9DJPuldnkgeDAxVn5B1ZoAfzIporGvPBQC+alACon6oJk6WlwzOq2w1HsOGUQfay1WWBSNwVQWReyTRXOWGiMuJtucKNUgUZUAd8FnFKUzgiHO03qZoT/hkpbQcXTd4jYZp2ZaOmeCLSIyQ28XZToU5SRqIjf5UsNbYqI 1hRu/cB1 LdhBbgIl8DW/D4dN1g/bpx4aQtctua7kdMIKbw3m0nWZYXMCY3cZSfOhdcCjZ7qSqXx7fSBB6Ajn2dpynFE/7SBGVjVqWQ8MKxzqaUa4P4HBpmGVlGH9CjayF62kyHYKYXjHfiZ4hTOlHXrX7TN85/6VYgGDBPsWxgfDUdmRlIVe4lEnWtklO0QYBzwe4O9cwejfY3FbVo+7i3As= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/14 11:54, Yu Zhao wrote: > Support __GFP_COMP in alloc_contig_range(). When the flag is set, upon > success the function returns a large folio prepared by > prep_new_page(), rather than a range of order-0 pages prepared by > split_free_pages() (which is renamed from split_map_pages()). > > alloc_contig_range() can be used to allocate folios larger than > MAX_PAGE_ORDER, e.g., gigantic hugeTLB folios. So on the free path, > free_one_page() needs to handle that by split_large_buddy(). > > Signed-off-by: Yu Zhao > --- > include/linux/gfp.h | 23 +++++++++ > mm/compaction.c | 41 ++-------------- > mm/page_alloc.c | 111 +++++++++++++++++++++++++++++++------------- > 3 files changed, 108 insertions(+), 67 deletions(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index f53f76e0b17e..59266df56aeb 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -446,4 +446,27 @@ extern struct page *alloc_contig_pages_noprof(unsigned long nr_pages, gfp_t gfp_ > #endif > void free_contig_range(unsigned long pfn, unsigned long nr_pages); > > +#ifdef CONFIG_CONTIG_ALLOC > +static inline struct folio *folio_alloc_gigantic_noprof(int order, gfp_t gfp, > + int nid, nodemask_t *node) > +{ > + struct page *page; > + > + if (WARN_ON(!order || !(gfp | __GFP_COMP))) It doesn't seem right, it should be !(gfp & __GFP_COMP). Best Regards, Yu