From: David Hildenbrand <david@redhat.com>
To: Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>, Huang Ying <ying.huang@intel.com>,
Minchan Kim <minchan@kernel.org>,
Wei Yang <richard.weiyang@gmail.com>
Subject: Re: [PATCH v1 1/2] mm: drop vm_total_pages
Date: Mon, 22 Jun 2020 09:03:10 +0200 [thread overview]
Message-ID: <2d388e8e-6888-85d3-3584-b20438d58d16@redhat.com> (raw)
In-Reply-To: <20200621144621.GF6571@kernel.org>
On 21.06.20 16:46, Mike Rapoport wrote:
> On Fri, Jun 19, 2020 at 03:24:09PM +0200, David Hildenbrand wrote:
>> The global variable "vm_total_pages" is a relict from older days. There
>> is only a single user that reads the variable - build_all_zonelists() -
>> and the first thing it does is updating it. Use a local variable in
>> build_all_zonelists() instead and drop the local variable.
>
> Nit: ^ global
Indeed, @Andrew, can you fix this up?
Thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-06-22 7:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 13:24 [PATCH v1 0/2] mm: vm_total_pages and build_all_zonelists() cleanup David Hildenbrand
2020-06-19 13:24 ` [PATCH v1 1/2] mm: drop vm_total_pages David Hildenbrand
2020-06-19 13:47 ` Wei Yang
2020-06-21 14:46 ` Mike Rapoport
2020-06-22 7:03 ` David Hildenbrand [this message]
2020-06-21 19:56 ` Pankaj Gupta
2020-06-23 12:59 ` Michal Hocko
2020-06-19 13:24 ` [PATCH v1 2/2] mm/page_alloc: drop nr_free_pagecache_pages() David Hildenbrand
2020-06-19 13:48 ` Wei Yang
2020-06-21 14:47 ` Mike Rapoport
2020-06-21 19:57 ` Pankaj Gupta
2020-06-23 13:02 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d388e8e-6888-85d3-3584-b20438d58d16@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=richard.weiyang@gmail.com \
--cc=rppt@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox